Re: RFR JDK-8197533 move javax.transaction.xa into its own module

[Alan Bateman]

On 28/02/2018 19:54, Lance Andersen wrote:

:


Is there any XA text from the original JTA spec that should be added 
to the module description as part of this? Another way to ask this is 
whether the JTA 1.3 drops any text dealing with the XA part.
Still waiting to see what changes are made to the PDF spec, that is 
still needing to be completed. So I think for now, we go with what we 
have and can circle back if needed.


Thanks. I checked the latest webrev (moving the package description to 
package-info.java and the langtools dot test) and it all looks good to me.


-Alan

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

[Paul Sandoz]

> On Mar 1, 2018, at 4:41 PM, Lance Andersen  wrote:
> 
> While running the JDK regression tests, I found a test that needed to be 
> updated, test/langtools/tools/jdeps/modules/DotFileTest.java, due to the 
> update to the java.sql module
> 
> The updated webrev is at 
> http://cr.openjdk.java.net/~lancea/8197533/webrev.03/ 
> 
> 

+1

Paul.

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

[Lance Andersen]

While running the JDK regression tests, I found a test that needed to be 
updated, test/langtools/tools/jdeps/modules/DotFileTest.java, due to the update 
to the java.sql module

The updated webrev is at http://cr.openjdk.java.net/~lancea/8197533/webrev.03/ 


Best
Lance
> On Mar 1, 2018, at 12:37 PM, Paul Sandoz  wrote:
> 
> +1
> 
>> On Mar 1, 2018, at 8:59 AM, Lance Andersen > > wrote:
>>> 
>>> +1, i second Joe’s request to update package-info.java while we are 
>>> opportunistically cleaning this area up.
>> 
>> Per your and Joe’s request, please see 
>> cr.openjdk.java.net/~lancea/8197533/webrev.02 
>>  which has your 
>> suggested update to use package-info.java
>> 
>> Thank you both
>> 
>> Best
>> Lance
> 

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com 

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

[Paul Sandoz]

+1

> On Mar 1, 2018, at 8:59 AM, Lance Andersen  wrote:
>> 
>> +1, i second Joe’s request to update package-info.java while we are 
>> opportunistically cleaning this area up.
> 
> Per your and Joe’s request, please see 
> cr.openjdk.java.net/~lancea/8197533/webrev.02 
>  which has your 
> suggested update to use package-info.java
> 
> Thank you both
> 
> Best
> Lance

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

[Lance Andersen]

> On Feb 28, 2018, at 8:29 PM, Paul Sandoz  wrote:
> 
> 
> 
>> On Feb 28, 2018, at 1:22 PM, Lance Andersen > > wrote:
>> 
>>> 
>>> On Feb 28, 2018, at 2:20 PM, Lance Andersen >> > wrote:
>>> 
>>> Hi Paul,
>>> 
>>> Thank you for the review.
 On Feb 28, 2018, at 1:40 PM, Paul Sandoz >>> > wrote:
 
 Compatible module refactoring in action!
 
 Looks good, one comment:
 
 test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java
 
 This is not a valid Java source file can you merge the jtreg meta data 
 into XAExceptionTests instead?
>>> 
>>> As we discussed offline, I will change the above file and Driver.java.  I 
>>> naively assumed this was OK as the change  to add Driver.java was made 
>>> after I had originally added these tests in 2015.
>> 
>> http://cr.openjdk.java.net/~lancea/8197533/webrev.01/ 
>>  has the updated tests
> 
> +1, i second Joe’s request to update package-info.java while we are 
> opportunistically cleaning this area up.

Per your and Joe’s request, please see 
cr.openjdk.java.net/~lancea/8197533/webrev.02 which has your suggested update 
to use package-info.java

Thank you both

Best
Lance
> 
> Paul.

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com 

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

[Paul Sandoz]

> On Feb 28, 2018, at 1:22 PM, Lance Andersen  wrote:
> 
>> 
>> On Feb 28, 2018, at 2:20 PM, Lance Andersen > > wrote:
>> 
>> Hi Paul,
>> 
>> Thank you for the review.
>>> On Feb 28, 2018, at 1:40 PM, Paul Sandoz >> > wrote:
>>> 
>>> Compatible module refactoring in action!
>>> 
>>> Looks good, one comment:
>>> 
>>> test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java
>>> 
>>> This is not a valid Java source file can you merge the jtreg meta data into 
>>> XAExceptionTests instead?
>> 
>> As we discussed offline, I will change the above file and Driver.java.  I 
>> naively assumed this was OK as the change  to add Driver.java was made after 
>> I had originally added these tests in 2015.
> 
> http://cr.openjdk.java.net/~lancea/8197533/webrev.01/ 
>  has the updated tests

+1, i second Joe’s request to update package-info.java while we are 
opportunistically cleaning this area up.

Paul.

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

[joe darcy]

Hi Lance,

I'd prefer if 
src/java.sql/share/classes/javax/transaction/xa/package.html was 
replaced by a package-info.java files as opposed to another package.html 
file in the new module.


Thanks,

-Joe


On 2/28/2018 1:22 PM, Lance Andersen wrote:

On Feb 28, 2018, at 2:20 PM, Lance Andersen  wrote:

Hi Paul,

Thank you for the review.

On Feb 28, 2018, at 1:40 PM, Paul Sandoz mailto:paul.san...@oracle.com>> wrote:

Compatible module refactoring in action!

Looks good, one comment:

test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java

This is not a valid Java source file can you merge the jtreg meta data into 
XAExceptionTests instead?

As we discussed offline, I will change the above file and Driver.java.  I 
naively assumed this was OK as the change  to add Driver.java was made after I 
had originally added these tests in 2015.

http://cr.openjdk.java.net/~lancea/8197533/webrev.01/ has the updated tests
Best
Lance

Best
Lance

Paul.


On Feb 28, 2018, at 10:25 AM, Lance Andersen mailto:lance.ander...@oracle.com>>> wrote:

Hi all,

This RFR request moves the javax.transaction.xa package out of the java.sql 
module and into its own module java.transaction.xa.  One of the motivators for 
this change is due to the fact JSR 907 1.3 MR indicated that the 
javax.transaction.xa package will be subsumed by Java SE.

There should be no compatibility issues with this change. Any module that 
`requires java.sql` will continue to have access to the public classes in the 
javax.transaction.xa package at both compile-time and run-time.


The CSR has been approved

The webrev can be found at: 
http://cr.openjdk.java.net/~lancea/8197533/webrev.00/

Best
Lance
 
>>
 
>> 
 
>>
 
>>Lance Andersen| Principal Member 
of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com  > >>


 

Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com 

  
   

  Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com 

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

[Magnus Ihse Bursie]

On 2018-02-28 19:25, Lance Andersen wrote:

Hi all,

This RFR request moves the javax.transaction.xa package out of the java.sql 
module and into its own module java.transaction.xa.  One of the motivators for 
this change is due to the fact JSR 907 1.3 MR indicated that the 
javax.transaction.xa package will be subsumed by Java SE.

There should be no compatibility issues with this change. Any module that 
`requires java.sql` will continue to have access to the public classes in the 
javax.transaction.xa package at both compile-time and run-time.


The CSR has been approved


The webrev can be found at: 
http://cr.openjdk.java.net/~lancea/8197533/webrev.00/

Build changes look good.

/Magnus


Best
Lance
  
   

  Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com 

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

[Lance Andersen]

> On Feb 28, 2018, at 2:20 PM, Lance Andersen  wrote:
> 
> Hi Paul,
> 
> Thank you for the review.
>> On Feb 28, 2018, at 1:40 PM, Paul Sandoz > > wrote:
>> 
>> Compatible module refactoring in action!
>> 
>> Looks good, one comment:
>> 
>> test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java
>> 
>> This is not a valid Java source file can you merge the jtreg meta data into 
>> XAExceptionTests instead?
> 
> As we discussed offline, I will change the above file and Driver.java.  I 
> naively assumed this was OK as the change  to add Driver.java was made after 
> I had originally added these tests in 2015.

http://cr.openjdk.java.net/~lancea/8197533/webrev.01/ has the updated tests
Best
Lance
> 
> Best
> Lance
>> 
>> Paul.
>> 
>>> On Feb 28, 2018, at 10:25 AM, Lance Andersen >> >> >> wrote:
>>> 
>>> Hi all,
>>> 
>>> This RFR request moves the javax.transaction.xa package out of the java.sql 
>>> module and into its own module java.transaction.xa.  One of the motivators 
>>> for this change is due to the fact JSR 907 1.3 MR indicated that the 
>>> javax.transaction.xa package will be subsumed by Java SE.
>>> 
>>> There should be no compatibility issues with this change. Any module that 
>>> `requires java.sql` will continue to have access to the public classes in 
>>> the javax.transaction.xa package at both compile-time and run-time. 
>>> 
>>> 
>>> The CSR has been approved
>>> 
>>> The webrev can be found at: 
>>> http://cr.openjdk.java.net/~lancea/8197533/webrev.00/
>>> 
>>> Best
>>> Lance
>>> >>  
>>> >> >>
>>> >>  
>>> >> >> 
>>> >>  
>>> >> >>
>>> >>  
>>> >> >>Lance Andersen| 
>>> Principal Member of Technical Staff | +1.781.442.2037
>>> Oracle Java Engineering 
>>> 1 Network Drive 
>>> Burlington, MA 01803
>>> lance.ander...@oracle.com  
>>> > 
>>> >> >> >>
> 
> 
>  
> 
> Lance Andersen| 
> Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering 
> 1 Network Drive 
> Burlington, MA 01803
> lance.ander...@oracle.com 

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com 

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

[Lance Andersen]

> On Feb 28, 2018, at 2:43 PM, Alan Bateman  wrote:
> 
> On 28/02/2018 18:25, Lance Andersen wrote:
>> Hi all,
>> 
>> This RFR request moves the javax.transaction.xa package out of the java.sql 
>> module and into its own module java.transaction.xa.  One of the motivators 
>> for this change is due to the fact JSR 907 1.3 MR indicated that the 
>> javax.transaction.xa package will be subsumed by Java SE.
>> 
>> There should be no compatibility issues with this change. Any module that 
>> `requires java.sql` will continue to have access to the public classes in 
>> the javax.transaction.xa package at both compile-time and run-time.
>> 
>> 
> I skipped the tests but everything else looks good. It is a compatible change 
> as you noted.
Thank you Alan
> 
> Is there any XA text from the original JTA spec that should be added to the 
> module description as part of this? Another way to ask this is whether the 
> JTA 1.3 drops any text dealing with the XA part.
Still waiting to see what changes are made to the PDF spec, that is still 
needing to be completed. So I think for now, we go with what we have and can 
circle back if needed.

Best
Lance
> 
> -Alan

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com 

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

[Alan Bateman]

On 28/02/2018 18:25, Lance Andersen wrote:

Hi all,

This RFR request moves the javax.transaction.xa package out of the java.sql 
module and into its own module java.transaction.xa.  One of the motivators for 
this change is due to the fact JSR 907 1.3 MR indicated that the 
javax.transaction.xa package will be subsumed by Java SE.

There should be no compatibility issues with this change. Any module that 
`requires java.sql` will continue to have access to the public classes in the 
javax.transaction.xa package at both compile-time and run-time.


I skipped the tests but everything else looks good. It is a compatible 
change as you noted.


Is there any XA text from the original JTA spec that should be added to 
the module description as part of this? Another way to ask this is 
whether the JTA 1.3 drops any text dealing with the XA part.


-Alan

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

[Lance Andersen]

Hi Paul,

Thank you for the review.
> On Feb 28, 2018, at 1:40 PM, Paul Sandoz  wrote:
> 
> Compatible module refactoring in action!
> 
> Looks good, one comment:
> 
> test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java
> 
> This is not a valid Java source file can you merge the jtreg meta data into 
> XAExceptionTests instead?

As we discussed offline, I will change the above file and Driver.java.  I 
naively assumed this was OK as the change  to add Driver.java was made after I 
had originally added these tests in 2015.

Best
Lance
> 
> Paul.
> 
>> On Feb 28, 2018, at 10:25 AM, Lance Andersen > > wrote:
>> 
>> Hi all,
>> 
>> This RFR request moves the javax.transaction.xa package out of the java.sql 
>> module and into its own module java.transaction.xa.  One of the motivators 
>> for this change is due to the fact JSR 907 1.3 MR indicated that the 
>> javax.transaction.xa package will be subsumed by Java SE.
>> 
>> There should be no compatibility issues with this change. Any module that 
>> `requires java.sql` will continue to have access to the public classes in 
>> the javax.transaction.xa package at both compile-time and run-time. 
>> 
>> 
>> The CSR has been approved
>> 
>> The webrev can be found at: 
>> http://cr.openjdk.java.net/~lancea/8197533/webrev.00/
>> 
>> Best
>> Lance
>> > >
>> > > 
>> > >
>> > >Lance Andersen| 
>> Principal Member of Technical Staff | +1.781.442.2037
>> Oracle Java Engineering 
>> 1 Network Drive 
>> Burlington, MA 01803
>> lance.ander...@oracle.com  
>> >

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com 

Re: RFR JDK-8197533 move javax.transaction.xa into its own module

[Paul Sandoz]

Compatible module refactoring in action!

Looks good, one comment:

test/jdk/javax/transaction/xa/testng/JavaSqlModuleDriver.java

This is not a valid Java source file can you merge the jtreg meta data into 
XAExceptionTests instead?

Paul.

> On Feb 28, 2018, at 10:25 AM, Lance Andersen  
> wrote:
> 
> Hi all,
> 
> This RFR request moves the javax.transaction.xa package out of the java.sql 
> module and into its own module java.transaction.xa.  One of the motivators 
> for this change is due to the fact JSR 907 1.3 MR indicated that the 
> javax.transaction.xa package will be subsumed by Java SE.
> 
> There should be no compatibility issues with this change. Any module that 
> `requires java.sql` will continue to have access to the public classes in the 
> javax.transaction.xa package at both compile-time and run-time. 
> 
> 
> The CSR has been approved
> 
> The webrev can be found at: 
> http://cr.openjdk.java.net/~lancea/8197533/webrev.00/
> 
> Best
> Lance
> 
>  
> 
> Lance Andersen| 
> Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering 
> 1 Network Drive 
> Burlington, MA 01803
> lance.ander...@oracle.com 
> 
> 
>