Re: Review Request: JDK-8164689: Retrofit jar, jlink, jmod as a ToolProvider

2016-10-12 Thread Alan Bateman 



On 12/10/2016 20:20, Mandy Chung wrote:

Updated webrev:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8164689/webrev.01

Mandy


This looks good.

-Alan

Re: Review Request: JDK-8164689: Retrofit jar, jlink, jmod as a ToolProvider

2016-10-12 Thread Mandy Chung 
Updated webrev:
   http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8164689/webrev.01

Mandy

> On Oct 12, 2016, at 9:10 AM, Mandy Chung  wrote:
> 
> 
>> On Oct 11, 2016, at 11:07 PM, Alan Bateman  wrote:
>> 
>> On 11/10/2016 19:03, Mandy Chung wrote:
>> 
>>> This patch updates jar, jlink, jmod tool to be a provider of the new tool 
>>> SPI.  Some tests are also updated to replace the use of internal APIs with 
>>> ToolProvider::findFirst to look up a tool provider.  There are more tests 
>>> that can be updated and something to be cleaned up in the future.
>>> 
>>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8164689/webrev.00/index.html
>>> 
>> This update to the tools looks good. For the tests then 
>> ToolProvider.findFirst("jar").get() will draw the attention of the optional 
>> police and might be better to use orElseThrow to supply an exception that 
>> clearly indicates that the tool cannot be found.
> 
> 
> Good suggestion.  Will change that before pushing.
> 
> Thanks
> Mandy

Re: Review Request: JDK-8164689: Retrofit jar, jlink, jmod as a ToolProvider

2016-10-12 Thread Mandy Chung 

> On Oct 11, 2016, at 11:07 PM, Alan Bateman  wrote:
> 
> On 11/10/2016 19:03, Mandy Chung wrote:
> 
>> This patch updates jar, jlink, jmod tool to be a provider of the new tool 
>> SPI.  Some tests are also updated to replace the use of internal APIs with 
>> ToolProvider::findFirst to look up a tool provider.  There are more tests 
>> that can be updated and something to be cleaned up in the future.
>> 
>> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8164689/webrev.00/index.html
>> 
> This update to the tools looks good. For the tests then 
> ToolProvider.findFirst("jar").get() will draw the attention of the optional 
> police and might be better to use orElseThrow to supply an exception that 
> clearly indicates that the tool cannot be found.


Good suggestion.  Will change that before pushing.

Thanks
Mandy

Re: Review Request: JDK-8164689: Retrofit jar, jlink, jmod as a ToolProvider

2016-10-12 Thread Alan Bateman 

On 11/10/2016 19:03, Mandy Chung wrote:


This patch updates jar, jlink, jmod tool to be a provider of the new tool SPI.  
Some tests are also updated to replace the use of internal APIs with 
ToolProvider::findFirst to look up a tool provider.  There are more tests that 
can be updated and something to be cleaned up in the future.

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8164689/webrev.00/index.html

This update to the tools looks good. For the tests then 
ToolProvider.findFirst("jar").get() will draw the attention of the 
optional police and might be better to use orElseThrow to supply an 
exception that clearly indicates that the tool cannot be found.


-Alan

Re: Review Request: JDK-8164689: Retrofit jar, jlink, jmod as a ToolProvider

2016-10-11 Thread Lance Andersen 
The changes look good Mandy

> On Oct 11, 2016, at 2:03 PM, Mandy Chung  wrote:
> 
> This patch updates jar, jlink, jmod tool to be a provider of the new tool 
> SPI.  Some tests are also updated to replace the use of internal APIs with 
> ToolProvider::findFirst to look up a tool provider.  There are more tests 
> that can be updated and something to be cleaned up in the future.
> 
> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8164689/webrev.00/index.html
> 
> thanks
> Mandy

 
  

 Lance Andersen| 
Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
lance.ander...@oracle.com