Re: Review request for 7020513 : Add com.sun.xml.internal to the package.access property in java.security

2011-08-29 Thread Florian Weimer
* Rama Pulavarthi: Just porting the fix along with tests from Open JDK 6 workspace, that's why I kept the old date. Does it need to be changed? This test was added then following the convention of other tests. I will check other tests in JDK 7 to see if it needs any update. I see that the

Re: Review request for 7020513 : Add com.sun.xml.internal to the package.access property in java.security

2011-04-26 Thread Sean Mullan
I'll defer to Kelly on the Makefile changes :) --Sean On 03/07/2011 02:39 PM, Rama Pulavarthi wrote: Thanks for the review. We had to make additional changes to run the tests. Hopefully this is the final webrev for this issue. Please review this new webrev which also has changes to

Re: Review request for 7020513 : Add com.sun.xml.internal to the package.access property in java.security

2011-03-07 Thread Rama Pulavarthi
Thanks for the review. We had to make additional changes to run the tests. Hopefully this is the final webrev for this issue. Please review this new webrev which also has changes to jdk/test/Makefile to run the tests. http://cr.openjdk.java.net/~ramap/CR7020513-open-webrev/ thanks, Rama

Re: Review request for 7020513 : Add com.sun.xml.internal to the package.access property in java.security

2011-03-07 Thread Kelly O'Hair
Looks good to me. -kto On Mar 7, 2011, at 11:39 AM, Rama Pulavarthi wrote: Thanks for the review. We had to make additional changes to run the tests. Hopefully this is the final webrev for this issue. Please review this new webrev which also has changes to jdk/test/Makefile to run the

Re: Review request for 7020513 : Add com.sun.xml.internal to the package.access property in java.security

2011-02-28 Thread Mandy Chung
Rama, Looks good to me. Are you planning to add a regression test? You had it in the webrev of an earlier version. Mandy On 02/25/11 10:12, Rama Pulavarthi wrote: Please review this updated webrev that has the patch for JDK 7 repo.

Re: Review request for 7020513 : Add com.sun.xml.internal to the package.access property in java.security

2011-02-26 Thread Alan Bateman
Rama Pulavarthi wrote: Please review this updated webrev that has the patch for JDK 7 repo. http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxws-7020513-open/webrev/ Looks good to me too. -Alan.

Re: Review request for 7020513 : Add com.sun.xml.internal to the package.access property in java.security

2011-02-25 Thread Sean Mullan
Looks good to me. --Sean On 2/25/11 1:12 PM, Rama Pulavarthi wrote: Please review this updated webrev that has the patch for JDK 7 repo. http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-jaxws-7020513-open/webrev/ For background on this issue, this is not a new one. I am trying to port the

Re: Review request for 7020513 : Add com.sun.xml.internal to the package.access property in java.security

2011-02-23 Thread Rama Pulavarthi
Hi Alan, On 2/23/11 12:44 AM, Alan Bateman wrote: Rama Pulavarthi wrote: Hi, Need reviewer for CR 7020513: Add com.sun.xml.internal to the package.access property in $JAVA_HOME/lib/security/java.security Webrev is available at

Re: Review request for 7020513 : Add com.sun.xml.internal to the package.access property in java.security

2011-02-23 Thread Alan Bateman
Rama Pulavarthi wrote: : Just porting the fix along with tests from Open JDK 6 workspace, that's why I kept the old date. Does it need to be changed? This test was added then following the convention of other tests. I will check other tests in JDK 7 to see if it needs any update. Sorry