Re: RFC: cksum --base64/-b support

2023-01-31 Thread Jim Meyering
On Tue, Jan 31, 2023 at 1:43 PM Pádraig Brady wrote: > s/accepted/supports/ in NEWS Thanks. Good catch. I prefer to use "accepts", matching the entry just below. Will push soon.

Re: RFC: cksum --base64/-b support

2023-01-31 Thread Pádraig Brady
s/accepted/supports/ in NEWS Otherwise good to push. thanks! Pádraig

Re: RFC: cksum --base64/-b support

2023-01-31 Thread Jim Meyering
On Tue, Jan 31, 2023 at 5:00 AM Pádraig Brady wrote: > On 31/01/2023 06:48, Jim Meyering wrote: > > On Mon, Jan 30, 2023 at 11:29 AM Pádraig Brady wrote: > >> ... > > > > Thanks for the speedy feedback. > > > >> "If must be followed by white space." comment has a typo > >> and also not enforced

Re: RFC: cksum --base64/-b support

2023-01-31 Thread Pádraig Brady
On 31/01/2023 06:48, Jim Meyering wrote: On Mon, Jan 30, 2023 at 11:29 AM Pádraig Brady wrote: ... Thanks for the speedy feedback. "If must be followed by white space." comment has a typo and also not enforced explicitly, so could be removed. Thanks. Removed. valid_digits() may check

Re: RFC: cksum --base64/-b support

2023-01-31 Thread Pádraig Brady
On 31/01/2023 06:07, Jim Meyering wrote: On Mon, Jan 30, 2023 at 10:17 AM Pádraig Brady wrote: BTW I noted the following possible option when I recently refactored cksum: --digest_format={int, hex, base64, binary} /* cksum output formats: int (sum, and cksum default),

Re: RFC: cksum --base64/-b support

2023-01-30 Thread Jim Meyering
On Mon, Jan 30, 2023 at 11:29 AM Pádraig Brady wrote: > ... Thanks for the speedy feedback. > "If must be followed by white space." comment has a typo > and also not enforced explicitly, so could be removed. Thanks. Removed. > valid_digits() may check beyond the end of the buffer > in the

Re: RFC: cksum --base64/-b support

2023-01-30 Thread Jim Meyering
On Mon, Jan 30, 2023 at 10:17 AM Pádraig Brady wrote: > On 29/01/2023 20:40, Jim Meyering wrote: > > Hi Pádraig! Happy new year (belatedly ;-). Hope you're well. > > > > I'd like our generated announcements to be able to include > > base64-encoded checksums without having to recommend verifying

Re: RFC: cksum --base64/-b support

2023-01-30 Thread Pádraig Brady
On 30/01/2023 17:52, Jim Meyering wrote: On Sun, Jan 29, 2023 at 1:10 PM Jim Meyering wrote: On Sun, Jan 29, 2023 at 12:40 PM Jim Meyering wrote: ... - I'm inclined to work like the openbsd cksum and accept invocations like "cksum -a sha1x" and "cksum -a sha1b". Any objection? Actually, I

Re: RFC: cksum --base64/-b support

2023-01-30 Thread Pádraig Brady
On 29/01/2023 20:40, Jim Meyering wrote: Hi Pádraig! Happy new year (belatedly ;-). Hope you're well. I'd like our generated announcements to be able to include base64-encoded checksums without having to recommend verifying them using openbsd's cksum, so... This is so the checksums are

Re: RFC: cksum --base64/-b support

2023-01-30 Thread Jim Meyering
On Sun, Jan 29, 2023 at 1:10 PM Jim Meyering wrote: > On Sun, Jan 29, 2023 at 12:40 PM Jim Meyering wrote: > ... > > - I'm inclined to work like the openbsd cksum and accept invocations > > like "cksum -a sha1x" and "cksum -a sha1b". Any objection? > > Actually, I am now **disinclined** to

Re: RFC: cksum --base64/-b support

2023-01-29 Thread Jim Meyering
On Sun, Jan 29, 2023 at 12:40 PM Jim Meyering wrote: ... > - I'm inclined to work like the openbsd cksum and accept invocations > like "cksum -a sha1x" and "cksum -a sha1b". Any objection? Actually, I am now **disinclined** to implement this part. It'd make sense only if we were able to compute