FYI,
From cab21195422804046a7f2b18de2282a46a2e8f39 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sun, 9 May 2010 12:08:21 +0200
Subject: [PATCH] tests: improve the always_defined_macros check
* cfg.mk (sc_always_defined_macros): Adjust its helpers not to depend
are from gettext version 0.18
Not surprisingly, installing gettext-0.18 and regenerating po/Makefile.in.in
solves the problem.
I've just pushed the following, in order to make that apparent earlier
in the build process:
From 0c22e841565492279dbeb63b0aa2f075a8342bde Mon Sep 17 00:00:00 2001
From: Jim
Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Mon, 17 May 2010 16:10:24 +0200
Subject: [PATCH] maint: fix the fs-magic-compare rule
* src/Makefile.am (fs-def): Sort definitions.
This is required by fs-magic-compare's use of join.
---
src/Makefile.am |2 +-
1 files changed
FYI, minor stylistic preference...
From 55db9a39a818e82324e1304e5d886aa2cf137092 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 25 May 2010 12:32:03 +0200
Subject: [PATCH] maint: remove unneeded double quotes on RHS of shell
assignments
Run this command:
git grep
From: Jim Meyering meyer...@redhat.com
* src/stat.c (alignof): Remove definition.
Instead, include alignof.h, and sort the #include directives.
And get its definition from the gnulib module by that name:
* bootstrap.conf (gnulib_modules): Add alignof.
---
bootstrap.conf |1 +
src/stat.c
From: Jim Meyering meyer...@redhat.com
E.g.,
- size_t desired_width IF_LINT (= 0);
+ size_t desired_width IF_LINT ( = 0);
Use this command:
g grep -l IF_LINT | grep '\.[ch]$' \
| xargs perl -pi -e 's/(IF_LINT \()= /$1 = /'
---
src/chmod.c|4 ++--
src/copy.c |2 +-
src
From: Jim Meyering meyer...@redhat.com
Run this command:
git ls-files | grep '\.[ch]$' \
| xargs perl -pi -e 's/for \(;;\)/while (true)/g'
...except for randint.c, which does not include stdbool.h.
In that case, use while (1).
* gl/lib/randint.c (randint_genmax): Use while (1) for infloops
I've just pushed these two:
From 155c8148ae06dcbbdfb85837e4aebe0080b71d2a Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 10 Jun 2010 23:33:17 +0200
Subject: [PATCH 1/2] build: don't let a large sparse temporary file cause make
dist to fail
* bootstrap.conf
versa.
The last two lines should probably read:
comm -3 file1 file2
Print lines in file1 not in file2, and vice versa.
Thank you.
I'll fix it like this:
From 1419af82433027b03c2d49f7a401beb485bcbe2a Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Mon
FYI,
From d27d6d371f3f7ede14b6bde79ddd45307d30fa47 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 1 Jul 2010 23:43:55 +0200
Subject: [PATCH] build: update gnulib submodule to latest; update bootstrap, too
* gnulib: Update to latest, for hash.c improvement.
* bootstrap
Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 10 Aug 2010 08:11:15 -0700
Subject: [PATCH] sort: avoid gcc warning: explicitly ignore strtold result
* src/sort.c: Include ignore-value.h.
(debug_key): Use ignore_value.
---
src/sort.c |3 ++-
1 files changed, 2 insertions
John Sonnenschein wrote:
On 09/10/10 09:16 AM, Eric Blake wrote:
On 09/10/2010 10:03 AM, John Sonnenschein wrote:
Before you get too far into it, please present your high-level
goals on this list.
Well, the features the Solaris native versions of the coreutils have are
roughly as follows:
Eric Blake wrote:
I'm seeing the following two failures on 'make check' on a
SELinux-enforcing Fedora 13 system:
Hi Eric,
Thanks for the report.
FAIL: misc/runcon-no-reorder (exit: 1)
...
-runcon: failed to create security context:
unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023:
Pádraig Brady wrote:
not all printf commands support \xhh
diff --git a/tests/misc/sort-debug-keys b/tests/misc/sort-debug-keys
index 57a52a6..4e8beff 100755
--- a/tests/misc/sort-debug-keys
+++ b/tests/misc/sort-debug-keys
@@ -275,7 +275,7 @@ printf 2.,,3\n2.4\n | sort -s -k1n --debug
Pádraig Brady wrote:
On 17/09/10 11:06, Pádraig Brady wrote:
On 17/09/10 10:34, Jim Meyering wrote:
FAIL: misc/stat-mount (exit: 1)
===
...
+ stat_mnt=/shared/home
+ test /shared = /shared/home
+ fail=1
...
Here, the failure is that I have /home bind-mounted
Eric Blake wrote:
On 09/24/2010 04:47 PM, Pádraig Brady wrote:
I was just looking at a bug reported to fedora there where this abort()s
$ LC_ALL=en_US tr '[:upper:] ' '[:lower:]'
Ouch! Thanks for reporting it here.
How many more bugs lurk in tr...
Consolation: this one is a failure to
Pádraig Brady wrote:
On 25/09/10 07:53, Jim Meyering wrote:
Eric Blake wrote:
On 09/24/2010 04:47 PM, Pádraig Brady wrote:
I was just looking at a bug reported to fedora there where this abort()s
$ LC_ALL=en_US tr '[:upper:] ' '[:lower:]'
Ouch! Thanks for reporting it here.
How many
There have been many relevant changes in gnulib,
so I've updated coreutils to use the latest.
From 724e9931043a414dfb197ea5b7a2c5d947980d74 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Wed, 29 Sep 2010 14:34:20 +0200
Subject: [PATCH] build: update gnulib submodule
Pádraig Brady wrote:
On 01/10/10 00:32, Eric Blake wrote:
* src/stat.c (epoch_time): New function.
(print_stat): Use it for %[WXYZ].
* NEWS: Document this.
* tests/touch/60-seconds: Adjust test to match.
---
It bugs me that %x has more information than %X in 'stat --format',
especially,
Eric Blake wrote:
* src/stat.c (print_stat): New %w and %W formats.
(do_stat): Include %w in verbose format.
(usage): Document them.
* doc/coreutils.texi (stat invocation): Likewise.
* NEWS: Likewise.
Suggested by Andre Osku Schmidt.
---
I've tested that this works on cygwin. On Fedora
Eric Blake wrote:
* src/stat.c (default_format): Include context when present.
* NEWS: Update blurb explaining the replacement for -Z.
---
Definitely nicer than the first attempt, but still controversial on
whether we want to do this at all. I'm 70:30 for (I use Fedora's stat
-Z regularly,
Eric Blake wrote:
* src/stat.c (main): Hoist default format computation out of loop.
(do_statfs, do_stat): Move default format generation...
(default_format): ...into new function. Allocate the result in
pieces, rather than repeating mostly-similar chunks. Allow
translation of verbose
Eric Blake wrote:
* tests/sample-test: Recommend modern idiom.
---
tests/sample-test |7 +--
1 files changed, 1 insertions(+), 6 deletions(-)
diff --git a/tests/sample-test b/tests/sample-test
index 85a61cf..85b779f 100644
--- a/tests/sample-test
+++ b/tests/sample-test
@@
Eric Blake wrote:
On 10/01/2010 02:44 PM, Jim Meyering wrote:
Eric Blake wrote:
* src/stat.c (main): Hoist default format computation out of loop.
This one should be uncontroversial, but just to be safe: OK to push?
Yes.
Thank you for the factoring.
Did you do any before/after testing
Pádraig Brady wrote:
On 01/10/10 21:41, Jim Meyering wrote:
Eric Blake wrote:
* src/stat.c (default_format): Include context when present.
This is a close call, but I think it is justified.
stat's default format should show as much information
as possible, and no one should be parsing
Eric Blake wrote:
...
+check_timestamps_updated()
+{
+ local delay=$1
I guess we're blindly assuming that coreutils testsuite is requiring a
shell that supports 'local'?
Yes. So far it hasn't been an issue.
$ git grep '^ *local' tests
tests/dd/reblock: local delay=$1
Pádraig Brady wrote:
Note the above test fits the pattern of requiring a delay to pass
and so can use the retry_delay_ functionality used elsewhere.
The advantage is that the delay is 1s rather than 2 on
1s resolution file systems like ext3.
Oh! Glad you remembered that. I should have, too.
FYI, I'll push this soon:
From deb483e6498e32a8174e0fdd9d39d53241fe5aef Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 5 Oct 2010 10:50:48 +0200
Subject: [PATCH] maint: describe coreutils' policy on copyright year number
ranges
* README: Mention coreutils' long
Eric Blake wrote:
On 10/05/2010 03:03 AM, Jim Meyering wrote:
* src/stat.c (default_format): Don't print SELinux context
when in file system (-f) mode, as the context is associated
with the file, not the file system.
Fix logic inversion, so that in terse mode, %C is included
only when
Pádraig Brady wrote:
Ok to push this for the imminent release?
Subject: [PATCH] split: fix reporting of read errors
The bug was introduced with commit 23f6d41f, 19-02-2003.
* src/split.c (bytes_split, lines_split, line_bytes_split):
Correctly check the return from full_read().
* NEWS:
coreutils didn't compile on OpenBSD 4.7:
http://thread.gmane.org/gmane.comp.parsers.bison.bugs/3418
I'll push the gnulib fix early tomorrow.
Eric Blake wrote:
On 10/01/2010 04:34 PM, Eric Blake wrote:
On 10/01/2010 09:19 AM, Eric Blake wrote:
Correct - time_t need not be integral, but do we have any proof of a
system using a floating-point time_t?
I think I'm going to write a POSIX bug requesting that time_t be
tightened to
OpenBSD has helped expose real bugs (nanosleep),
and some less-important problems (compilation failure and fdopendir).
For details, see e.g.,
http://git.savannah.gnu.org/cgit/gnulib.git/log/
From ab9d2d2d4671a00bbabad3f700045bc604683b23 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer
--version of program under test
build: fix build on Solaris 10
stat: drop %C support when printing file system details
build: complete the rename of get_date
Jim Meyering (82):
post-release administrivia
tests: clean up also upon SIGQUIT
build: enable gnulib modules
Eric Blake wrote:
On 10/10/2010 01:57 PM, Jim Meyering wrote:
Paul Eggert (24):
Paul R. Eggert (15):
Time for a mailmap file so that git will consolidate entries from a
single author spread over multiple email addresses?
Good point.
I've just added this:
From
Pádraig Brady wrote:
On 10/10/10 20:57, Jim Meyering wrote:
Here is a snapshot of the latest coreutils development sources.
Please build it and run make check on any systems you can, and
report any problems to bug-coreut...@gnu.org.
I expect to make a stable release in two or three days.
I
Pádraig Brady wrote:
On 12/10/10 02:44, Pádraig Brady wrote:
On 12/10/10 02:18, Pádraig Brady wrote:
I'll apply the attached tomorrow at some stage.
With this squashed in to replace the confusing
no space left on device error, with the
reverting to polling information.
This has the side
: Jim Meyering meyer...@redhat.com
Date: Wed, 13 Oct 2010 11:20:18 +0200
Subject: [PATCH] build: prepare to enable -Werror also for gnulib-tests/
* configure.ac (GNULIB_WARN_CFLAGS): Define new variable, for use
in gnulib-tests.
* gnulib-tests/Makefile.am: Disable specific -W___ options,
but only
This is to announce coreutils-8.6, a stable release.
It's been over five months, with 200 change-sets in coreutils
and 550 in gnulib. There have been a handful of new features
(all relatively safe, imho), several bug fixes, and numerous
minor changes in behavior. See NEWS below for a summary.
Andreas Schwab wrote:
* src/fold.c (fold_file): Advice istream, not stdin.
---
src/fold.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/fold.c b/src/fold.c
index d585856..4da834b 100644
--- a/src/fold.c
+++ b/src/fold.c
@@ -143,7 +143,7 @@ fold_file (char
Three small patches:
[PATCH 1/3] .gitignore: anchor patterns
[PATCH 2/3] maint: update bootstrap from gnulib
[PATCH 3/3] build: enable -Werror for gnulib-tests, too
From b1b23d894b1aeb03ac59a570b634f5d248268b8c Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date
Andreas Schwab wrote:
Eric Blake eblake-h+wxahxf7alqt0dzr+a...@public.gmane.org writes:
* src/stat.c (epoch_time): New function.
(print_stat): Use it for %[WXYZ].
* NEWS: Document this.
* tests/touch/60-seconds: Adjust test to match.
---
It bugs me that %x has more information than %X in
Andreas Schwab wrote:
Jim Meyering j...@meyering.net writes:
Can you point to any others?
Tramp, mkinitrd on openSUSE 11.3.
I found one, you mention two more. IMHO, that's not too bad.
And besides, with coreutils-8.6 already released, reverting the
change is no longer an option.
Andreas Schwab wrote:
Jim Meyering j...@meyering.net writes:
And besides, with coreutils-8.6 already released, reverting the
change is no longer an option.
Why? I'm pretty sure more breakage will pop up over time.
Hmm... I see what you mean.
Anyone using a distribution with coreutils-8.5
Eric Blake wrote:
On 10/21/2010 09:33 AM, Jim Meyering wrote:
Then, to get full seconds.nanoseconds, you'd use a format like %X.%:X
and if you want only milliseconds, you'd use %X.%3.3:X
Oops.
I forgot to zero-pad. Otherwise, with 100,000,000ns in the first
case or 100 in the 2nd
Jim Meyering wrote:
Jim Meyering wrote:
Eric Blake wrote:
On 10/21/2010 08:09 AM, Andreas Schwab wrote:
Eric Blakeebl...@redhat.com writes:
On 10/21/2010 03:22 AM, Andreas Schwab wrote:
Jim Meyeringj...@meyering.net writes:
And besides, with coreutils-8.6 already released
Paul Eggert wrote:
While looking into the inttostr issues circulated recently on
bug-gnulib, I was experimenting with an inttostr variant that I hope
will be nicer. In the process, I discovered a bug in du, where du
uses uninitialized storage. Here's a patch.
Good catch!
The tabs in the
Pádraig Brady wrote:
On 22/10/10 18:43, Jim Meyering wrote:
Part of reverting this change:
stat now outputs the full sub-second resolution for the atime,
mtime, and ctime values since the Epoch, when using the %X, %Y, and
%Z directives of the --format option. This matches
size.
Here's the patch I'll probably use to solve that:
From 4df6a5f89cb5abd3f48ba3fa1653a0b732165a76 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 26 Oct 2010 11:36:08 +0200
Subject: [PATCH] tests: avoid false-positive failure on btrfs
* tests/cp/reflink-perm: Don't
Erik Auerswald wrote:
Hi,
On Tue, Oct 26, 2010 at 11:39:58AM +0200, Jim Meyering wrote:
The cp/reflink-perm test fails on a btrfs file system:
echo file2 # file with data
cp --reflink=auto --preserve --attributes-only file2 empty_copy || fail=1
test -s empty_copy fail=1
Pádraig Brady wrote:
On 26/10/10 12:48, Pádraig Brady wrote:
So in summary error if any of --link, --symbolic-link,
--reflink or --attributes-only are combined.
I.E. leave the docs alone and do:
Thanks. That sounds good.
Do you feel like writing the NEWS entry, too?
diff --git a/src/cp.c
FYI, I considered skipping this as a known bug,
but hear that it should be fixed soon, so prefer
to continue to see the failure until it's resolved.
From 0960e0c83d2a79d260f2b83bb273ed13ef5bbea1 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 26 Oct 2010 16:34:51 +0200
Pádraig Brady wrote:
On 26/10/10 18:59, Jim Meyering wrote:
Jim Meyering wrote:
Jim Meyering wrote:
Pádraig Brady wrote:
On 22/10/10 18:43, Jim Meyering wrote:
Part of reverting this change:
stat now outputs the full sub-second resolution for the atime,
mtime, and ctime values
Pádraig Brady wrote:
On 27/10/10 18:27, William Plusnick wrote:
I added a way to specify the string printed after the last number in the
seq command, as suggested by a comment. I am not sure how helpful this
option is, because I personally don't use the seq command much. I also
added
Jim Meyering wrote:
...
I think I have fixed things, finally.
Here's how my latest works:
$ touch -d '2010-10-21 18:43:33.012345678' k
$ src/stat -c %3:X k
12345678
$ src/stat -c %3.3:X k
12
$ src/stat -c %03.3:X k
012
$ src/stat -c %:X k
012345678
$ src/stat -c
William Plusnick wrote:
When I was looking at seq I noticed it did not process escape character in the
separator string. This renders it nearly impossible to separate the numbers by
tabs in Bash because when you hit the tab key it tries to autofill and doesn't
add the tab in directly. A more
Pádraig Brady wrote:
On 02/11/10 16:41, Eric Blake wrote:
On 11/02/2010 09:46 AM, Андрей Передрий wrote:
Hello guys!
I found a bug in 'sleep' command.
As you can see - 'sleep' was terminated by himself after 24 days, 20 hours,
26 minutes and 33 seconds.
24*24*3600 + 20*3600 + 26*60 + 33
Gilles Espinasse wrote:
backref-multibyte-slow test fail on my imac 400
Fail with timeout 5s, pass when timeout is changed to 10s
I have no faster machine to test on ppc.
Thanks for the report.
What is the ratio of the two times when running the
latest with LC_ALL=en_US.UTF-8 / LC_ALL=C ?
For
Pádraig Brady wrote:
On 04/11/10 09:40, Jim Meyering wrote:
...
Using Perl would work...
I've wanted this sort of ability for other tests (e.g., coreutils'
tests/rm/ext3-perf), so maybe it's worth adding an option to GNU timeout:
run a reference command, measuring how long it takes, S
Gilles Espinasse wrote:
...
Patch work with the zerl/perl typo fixed
PASS: backref-multibyte-slow
Thanks. Oh, zerl was for testing, to make sure the case of missing perl
was handled properly.
Nelson H. F. Beebe wrote:
[...there appears to be a hang in make check on FreeBSD...]
PASS: misc/id-groups
SKIP: misc/md5sum
SKIP: misc/md5sum-newline
PASS: misc/md5sum-parallel
PASS: misc/mknod
Hi Nelson,
[Cc'ing the list]
Thanks for the heads up and for all the testing.
The test
Andreas Schwab wrote:
Jim Meyering j...@meyering.net writes:
Here's a better test case:
$ /bin/sh -c 'f(){ local s=$IFS; test -n $s; }; f'
[Exit 1]
And based on that, here's a patch to gnulib's tests/init.sh
that solves the problem more generally:
(but this is not enough
-ss.tar.xz
http://people.redhat.com/meyering/cu/coreutils-8.6.24-6c058.tar.xz
Changes in coreutils since 8.6.19-1369f:
Eric Blake (2):
cp, mv, touch: fix file time manipulation on Solaris 10
cp: NEWS entry for previous fix
Jim Meyering (2):
build: update gnulib to latest
Eric Blake wrote:
On 11/06/2010 08:19 AM, Jim Meyering wrote:
Andreas Schwab wrote:
Jim Meyering j...@meyering.net writes:
Here's a better test case:
$ /bin/sh -c 'f(){ local s=$IFS; test -n $s; }; f'
[Exit 1]
And based on that, here's a patch to gnulib's tests/init.sh
Andreas Schwab wrote:
Jim Meyering j...@meyering.net writes:
IMHO, the fact that VAR=$OTHER_VAL never needs quotes
should imply that `local VAR=$OTHER_VAL' also requires no quotes.
I wonder where POSIX requires or even allows that export VAR=$foo does
not perform word splitting (although
I'll push this tomorrow:
From dd45755406861fc192284d7e2b28f3c33e0433d3 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sun, 7 Nov 2010 14:23:32 +0100
Subject: [PATCH] tests: don't disqualify FreeBSD 8.1's /bin/sh just yet,
because dash-0.5.6-2.fc14.x86_64 would also
Pádraig Brady wrote:
On 08/11/10 14:33, Jim Meyering wrote:
Looks like I got very lucky here and hit a number of nanoseconds
that happened to be a multiple of 100,000:
$ for i in $(seq 1000); do touch -d '1970-01-01 18:43:33.50' 2;
t=$(stat -c %.W %.X %.Y %.Z 2); test $(echo $t
Pádraig Brady wrote:
Another bug I noticed with dash-0.5.6-2.fc11.i586
is that it doesn't redirect from symlinks correctly
for background processes.
$ dash -c tty /dev/stdin
$ dash -c tty /dev/stdin
/dev/pts/3
$ bash -c tty /dev/stdin
/dev/pts/3
$ dash -c tty $(readlink -f
This is to announce coreutils-8.7, a stable, bug-fix-only release.
It's been a month since coreutils-8.6 with 37 change-sets in coreutils
proper and 59 in gnulib. This was supposed to have been a snap release
solely to revert the stat %[XYZ] time stamp handling change introduced
in 8.6, but that
Pádraig Brady wrote:
maint: add a missed fadvise-tests module
* gl/modules/fadvise-tests: Add the module previously missed
in commit 63b5e816, 2010-07-14, fadvise: new module
* gl/tests/test-fadvise.c: Add a comment as to why we don't
check return values.
Looks
Pádraig Brady wrote:
FYI.
commit 79adacc43178916392af3dd581ded87f3aea1655
Author: Pádraig Brady p...@draigbrady.com
Date: Tue Nov 16 07:32:32 2010 +
build: add `patch` as a bootstrap dependency
* bootstrap.conf (buildreq): require `patch` as it's used
by gnulib-tool to
Pádraig Brady wrote:
On 17/11/10 21:31, Jim Meyering wrote:
FYI, here are 5 change-sets to make a few hundred (mostly automated)
changes like these:
-test $VERBOSE = yes chown --version
+print_ver_ chown
-test $VERBOSE = yes { cp --version; mv --version; }
+print_ver_ cp
FYI,
From c1b41c5c3bd9f603ac09a8cbf16a69ffc9129e4f Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Thu, 18 Nov 2010 06:29:54 +0100
Subject: [PATCH] maint: syntax-check: prevent new $VERBOSE/--version tests
* cfg.mk (sc_prohibit_verbose_version): New rule.
---
cfg.mk |6
this only on multi-core systems, with --parallel=2.
From 3b8f453a325fbd094e2605347b1d8a05efab9b0d Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sun, 28 Nov 2010 12:59:38 +0100
Subject: [PATCH] tests: add test for parallel sort -u segfault bug
* tests/misc/sort-unique-segv
17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sun, 28 Nov 2010 12:59:38 +0100
Subject: [PATCH 2/2] tests: add test for parallel sort -u segfault bug
* tests/misc/sort-unique-segv: New file.
* tests/Makefile.am (TESTS): Add it.
---
tests/Makefile.am |1 +
tests/misc
Jim Meyering wrote:
Paul Eggert wrote:
Could you please try this little patch? It should fix your
problem. I came up with this fix in my sleep (literally!
I woke up this morning and the patch was in my head), but
haven't had time to look at the code in this area to see
if it's the best fix
Paul Eggert wrote:
On 11/29/2010 08:32 PM, Chen Guo wrote:
Hi guys,
Is something up with Savannah? I just tried a git clone and got
connection time out; I cant even reach git.sv.gnu.org via ping.
There was a breakin, which led to leaking of encrypted account
passwords, some of them
Chen Guo wrote:
Hi Professor Eggert,
On Mon, Nov 29, 2010 at 11:16 AM, Paul Eggert egg...@cs.ucla.edu wrote:
(for i in $(seq 12); do read line; echo $i; sleep .1; done
cat /dev/null) fifo
(ulimit -t 1; ./sort in fifo \
|| echo killed via $(env kill -l $(expr $? - 128)))
I ran this
Paul Eggert wrote:
(I pushed this.)
This problem was observed on RHEL 5.5 x86-64 when running as a
client of a NetApp FAS2050.
* tests/cp/cp-mv-backup: Don't leave a file descriptor open to
a file in a directory that will be cleaned up with rm -rf.
Under NFS, when the rm unlinks that file,
Paul Eggert wrote:
On 11/29/2010 02:46 PM, Paul Eggert wrote:
My current guess, by the way,
is that it's not a bug that can be triggered: it's merely
useless code that is harmless and can safely be removed.
I removed it as part of the following series of cleanup
patches. These are intended
Chen Guo wrote:
...
I've attached the patch (inlined at the bottom). Here's the GDB
crash, with backtrace. I also printed node-queued in GDB, so it's
evident that its accessible.
(gdb) run --parallel 2 rec_1M /dev/null
Starting program: /data/chen/Coding/Coreutils/test/sort-mutex
Chen Guo wrote:
Hi Professor Eggert,
On Sun, Dec 5, 2010 at 11:01 PM, Paul Eggert egg...@cs.ucla.edu wrote:
On 12/05/2010 09:16 PM, Chen Guo wrote:
Before saying anything else, I should note that for mutexes, on 4
threads 20% of the time there's a segfault on a seemingly innocuous
line in
[I've retitled and Cc'd bug-coreutils so this gets its own bug number]
Chen Guo wrote:
On Tue, Dec 7, 2010 at 3:24 AM, Jim Meyering j...@meyering.net wrote:
Thanks. What does your input file look like?
I've been unable to reproduce the failure using the output of
seq 100. I've tried
Jim Meyering wrote:
...
With that, I've solved at least part of the problem.
The segfault (and other strangeness we've witnessed)
arises because each node struct is stored on the stack,
and its address ends up being used by another thread after
the thread that owns the stack in question has
Pádraig Brady wrote:
On 11/12/10 09:05, Paul Eggert wrote:
It seems to me that this code in sort.c:
unsigned long int np2 = num_processors (NPROC_CURRENT_OVERRIDABLE);
if (!nthreads || nthreads np2)
nthreads = np2;
is now obsolete. It was written assuming spin locks,
I noticed a false-positive failure when testing valgrind-wrapped tools:
From 45ff91af24f84eff331cbbc5c1a3f4a84248 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sat, 11 Dec 2010 18:44:57 +0100
Subject: [PATCH] tests: avoid FP failure when run under valgrind
* tests
Paul Eggert wrote:
On 12/12/2010 07:41 AM, Jim Meyering wrote:
That sounds good, assuming it triggers the bug reliably for you.
I was hoping to find a way to reproduce it without relying on gensort,
but won't object if you want to do that.
In my attempts to reproduce the problem, it's pretty
FYI,
From 2f2ef7369e326d7d43a91e1bef502d764517efd7 Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Tue, 14 Dec 2010 09:08:37 +0100
Subject: [PATCH] doc: tail: semi-deprecate --sleep-interval and
--max-unchanged-stats
Those options are useful only on systems that lack
Paul Eggert wrote:
I found and fixed some bugs and simplified some code
while trying (and so far, failing) to fix the hang reported at the end of
http://lists.gnu.org/archive/html/bug-coreutils/2010-12/msg00023.html.
I installed the following, and plan to look into that hang some more.
*
Paul Eggert wrote:
On 14/12/10 09:55, Jim Meyering wrote:
It'd be a shame to make everyone sleep even one second for NFS.
Well, it is marked as an _expensive_ test. :-)
On 12/14/10 02:07, Pádraig Brady wrote:
If the subprocesses were reparented to the shell,
then one could just `wait
:
=
Changes in coreutils since v8.7:
Chen Guo (3):
split: add --number to generate a particular number of files
sort: use mutexes, not spinlocks (avoid busy loop on blocked output)
sort: preallocate merge tree nodes to heap.
Jim Meyering (27):
post-release
Pádraig Brady wrote:
On 17/12/10 16:11, Pádraig Brady wrote:
I also notice more warnings and a possible
uninitialized stat buf in cp.c.
I'll have a look at these later...
That was another buglet fixed with:
commit b0cce8793c0b7a305f0f336e2f563ea941c44a92
Author: Pádraig Brady
Paul Eggert wrote:
I found this one by tracking down a bug with the latest snapshot
on Solaris. Still haven't got to the real bug yet, but this bug
was getting in the way.
Subject: [PATCH] tests: set fail=0 by default
* tests/init.sh (setup_): Set fail=0. This was the intent as per
Pádraig Brady wrote:
On 17/12/10 19:29, Assaf Gordon wrote:
...
Thanks for looking at this!
I've not looked into the memory details,
but this is another reason to restrict
the default number of threads to 8,
which we talked about previously...
commit
Pádraig Brady wrote:
Drats, I made a typo.
OK to push this?
commit 9ccc49f2a7b5daf86a0a8683c159798890ef1dcc
Author: Pádraig Brady p...@draigbrady.com
Date: Mon Dec 20 07:49:07 2010 +
maint: fix a typo in sort --parallel help message
Also fix up Chen Guo's emails
*
FYI, this pulls in Paul Eggert's ACL-vs-Solaris-8 fix
as well as some portability fixes.
From c00fb912ee1c53ef60374dba124053a4fe057acf Mon Sep 17 00:00:00 2001
From: Jim Meyering meyer...@redhat.com
Date: Sun, 19 Dec 2010 21:23:19 +0100
Subject: [PATCH] build: update gnulib: ACL-vs-Solaris 8
Eric Blake wrote:
Commit 041c9c47 traded the 'gettext' module for the lighter 'gettext-h'
module, so as to not require the latest gettext release (we only need
the latest release if we ship gettext as a dependent library, but
coreutils has long preferred to use it as an external library).
But
Jim Meyering wrote:
Given today's bug fix, I expect to release coreutils-8.9 next
week, so if you know of any other changes that would be appropriate
for a bug-fix-only release, please tell us now.
Unless I hear otherwise, I'll release coreutils-8.9 tomorrow
with the current changes:
http
In releasing coreutils-8.9, I left its gnulib submodule pointing at a
private commit that was going to be pushed, pending an ACK... Since a
slightly different commit was pushed, coreutils' submodule SHA1 was
invalid for a short interval. However, I have pushed my local commit
to the new gnulib
Eric Blake wrote:
On 01/04/2011 01:05 PM, Jim Meyering wrote:
That way, the next update of gnulib as coreutils submodule could still
be a fast-forward.
Hi Ralf,
I've done as you suggest (note that it required temporarily
disabling the hook that prohibits pushing merge commits to master
1 - 100 of 5559 matches
Mail list logo
