Re: [crossfire] [RFC 0/3] Work on keys.c and the keybinding system

2013-10-28 Thread Arvid Brodin
On 2013-10-29 00:46, Kevin Zheng wrote: > Hi Arvid, > > Thank you very much for your contributions, it's really appreciated! I'm > glad you enjoy playing Crossfire as much as you want to improve it. I'm glad to hear it! I know the patches are large; I hope they can get reviewed and ultimately acc

Re: [crossfire] [RFC 0/3] Work on keys.c and the keybinding system

2013-10-28 Thread Kevin Zheng
Hi Arvid, Thank you very much for your contributions, it's really appreciated! I'm glad you enjoy playing Crossfire as much as you want to improve it. On 10/28/2013 18:09, Arvid Brodin wrote: > I'm thinking that perhaps I should also change the flags in the keys file so > that they conform with t

[crossfire] [RFC 3/3] character-specific keybinding files

2013-10-28 Thread Arvid Brodin
As the Subject says. Also removes the weird MULTKEYS definition... Signed-off-by: Arvid Brodin --- common/client.h | 13 ++-- common/metaserver.c | 4 -- gtk-v2/src/account.c | 5 ++ gtk-v2/src/create_char.c | 4 ++ gtk-v2/src/gtk2proto.h | 1 + gtk-v2/src/keys.c

[crossfire] [RFC 0/3] Work on keys.c and the keybinding system

2013-10-28 Thread Arvid Brodin
Hi, This patch series is meant to make keybinding usage a lot more obvious - to new users especially, but hopefully also for the more experienced ones. Hopefully it also makes the keys.c file a bit more maintainable. In detail: * Coding style fixes (so that it is at least consistent in the keys.