Re: [Cryptodev-linux-devel] [PATCH] Replace INIT_COMPLETION with reinit_completion.

2014-01-22 Thread Gustavo Zacarias
On 01/21/2014 12:14 PM, Phil Sutter wrote: > Looking good so far. I just compile-tested against 3.10 and 3.13 without > problems. If you don't mind, I'll leave the patch sitting for a few more > days to allow for more discussion (if any at all). Works for me with 3.13 on ppc (caam & talitos). Rega

Re: [Cryptodev-linux-devel] [PATCH] Replace INIT_COMPLETION with reinit_completion.

2014-01-21 Thread Phil Sutter
Hi Christian, On Tue, Jan 21, 2014 at 08:26:35AM +, cristian.sto...@freescale.com wrote: > Hi Phil, > > > Wouldn't it be better to conditionally define INIT_COMPLETION to > > reinit_completion for newer kernels? Doesn't this break downwards > > compatibility? > > > > I could think of somethi

Re: [Cryptodev-linux-devel] [PATCH] Replace INIT_COMPLETION with reinit_completion.

2014-01-21 Thread cristian.sto...@freescale.com
Hi Phil, > Wouldn't it be better to conditionally define INIT_COMPLETION to > reinit_completion for newer kernels? Doesn't this break downwards > compatibility? > > I could think of something like: > > #if (LINUX_VERSION_CODE >= KERNEL_VERSION(3, 12, 0)) > # define INIT_COMPLETION(x) reinit_com

Re: [Cryptodev-linux-devel] [PATCH] Replace INIT_COMPLETION with reinit_completion.

2014-01-15 Thread Phil Sutter
On Wed, Jan 15, 2014 at 06:21:30PM +0200, Horia Geantă wrote: > On 1/15/2014 5:46 PM, Phil Sutter wrote: > > Hi, > > > > On Wed, Jan 15, 2014 at 05:22:18PM +0200, Horia Geanta wrote: > >> From: Cosmin Paraschiv > >> > >> In the 3.12 Linux kernel, the INIT_COMPLETION macro has been replaced > >> wi

Re: [Cryptodev-linux-devel] [PATCH] Replace INIT_COMPLETION with reinit_completion.

2014-01-15 Thread Horia Geantă
On 1/15/2014 5:46 PM, Phil Sutter wrote: Hi, On Wed, Jan 15, 2014 at 05:22:18PM +0200, Horia Geanta wrote: From: Cosmin Paraschiv In the 3.12 Linux kernel, the INIT_COMPLETION macro has been replaced with an inline function, reinit_completion [1][2]. We are currently using the 3.13-rc3 Linux

Re: [Cryptodev-linux-devel] [PATCH] Replace INIT_COMPLETION with reinit_completion.

2014-01-15 Thread Phil Sutter
Hi, On Wed, Jan 15, 2014 at 05:22:18PM +0200, Horia Geanta wrote: > From: Cosmin Paraschiv > > In the 3.12 Linux kernel, the INIT_COMPLETION macro has been replaced > with an inline function, reinit_completion [1][2]. We are currently > using the 3.13-rc3 Linux kernel, which leads to the followi

[Cryptodev-linux-devel] [PATCH] Replace INIT_COMPLETION with reinit_completion.

2014-01-15 Thread Horia Geanta
From: Cosmin Paraschiv In the 3.12 Linux kernel, the INIT_COMPLETION macro has been replaced with an inline function, reinit_completion [1][2]. We are currently using the 3.13-rc3 Linux kernel, which leads to the following error: cryptlib.c:220:2: error: implicit declaration of function 'INIT_CO