Re: [Cryptodev-linux-devel] [PATCH] fix dst_len for TLS mode with aead ciphers

2014-07-01 Thread Nikos Mavrogiannopoulos
On Tue, Jul 1, 2014 at 10:48 AM, cristian.sto...@freescale.com wrote: > Hi Phil, >> This means we write more data into the userspace-supplied buffer than >> requested without noticing it. Although this might be correct in regards >> of the cipher mode's requirements, we could corrupt userspace mem

Re: [Cryptodev-linux-devel] [PATCH] fix dst_len for TLS mode with aead ciphers

2014-07-01 Thread cristian.sto...@freescale.com
Hi Phil, > This means we write more data into the userspace-supplied buffer than > requested without noticing it. Although this might be correct in regards > of the cipher mode's requirements, we could corrupt userspace memory by > doing so. Correctly calculating the needed bufferspace for the req

Re: [Cryptodev-linux-devel] [PATCH] fix dst_len for TLS mode with aead ciphers

2014-06-30 Thread Phil Sutter
Hi, On Mon, Jun 23, 2014 at 06:57:25PM +0300, Cristian Stoica wrote: > - destination length is rounded to multiple of blockcipher length > before encryption This means we write more data into the userspace-supplied buffer than requested without noticing it. Although this might be correct in reg

[Cryptodev-linux-devel] [PATCH] fix dst_len for TLS mode with aead ciphers

2014-06-23 Thread Cristian Stoica
- destination length is rounded to multiple of blockcipher length before encryption Signed-off-by: Cristian Stoica --- authenc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/authenc.c b/authenc.c index a183820..774239a 100644 --- a/authenc.c +++ b/authenc.c @@