[Cryptodev-linux-devel] [PATCH] Fix ablkcipher algorithms usage in v4.8+ kernels

2016-11-17 Thread Horia Geantă
ablkcipher API is not completely removed from kernels <= v4.9. Thus it's still valid to use ablkcipher algorithms. Fix the case when implementers register ablkcipher algorithms and cryptodev casts them to skcipher without checking their type. Note: alg returned by crypto_ablkcipher_alg() is no lo

Re: [Cryptodev-linux-devel] [PATCH] Fix ablkcipher algorithms usage in v4.8+ kernels

2016-11-17 Thread Horia Geanta Neag
Forgot to Cc Michael Weiser. On 11/17/2016 10:20 AM, Horia Geantă wrote: > ablkcipher API is not completely removed from kernels <= v4.9. > Thus it's still valid to use ablkcipher algorithms. > > Fix the case when implementers register ablkcipher algorithms > and cryptodev casts them to skcipher

Re: [Cryptodev-linux-devel] [PATCH] Fix ablkcipher algorithms usage in v4.8+ kernels

2016-11-17 Thread Michael Weiser
Hi Horia, On Thu, Nov 17, 2016 at 10:18:50AM +0200, Horia Geant?? wrote: > ablkcipher API is not completely removed from kernels <= v4.9. > Thus it's still valid to use ablkcipher algorithms. I was under the impression that skcipher is just a unified API meant to give a common way of accessing s

Re: [Cryptodev-linux-devel] [PATCH] Fix ablkcipher algorithms usage in v4.8+ kernels

2016-11-17 Thread Horia Geanta Neag
On 11/17/2016 12:01 PM, Michael Weiser wrote: > Hi Horia, > > On Thu, Nov 17, 2016 at 10:18:50AM +0200, Horia Geant?? wrote: > >> ablkcipher API is not completely removed from kernels <= v4.9. >> Thus it's still valid to use ablkcipher algorithms. > > I was under the impression that skcipher is

Re: [Cryptodev-linux-devel] [PATCH] Fix ablkcipher algorithms usage in v4.8+ kernels

2016-11-17 Thread Michael Weiser
Hi Horia, On Thu, Nov 17, 2016 at 11:27:10AM +, Horia Geanta Neag wrote: > Yes, the intent is to replace (a)blkcipher with skcipher, however the > conversion is not over yet. > and a part 4 (converting existing drivers) will surely follow. > > So is your patch meant as a stop-gap measure fo