Re: [cryptography] Just how bad is OpenSSL ?

2015-01-06 Thread Jeffrey Walton
The source code is mostly written to the OpenSSL coding standards, which are seriously different from any other coding standard I've seen (it's not Linux/KR, nor GNU, nor Microsoft, nor Sun/Oracle). Nonconformance with the coding standards in later patches is very common, so it's a mishmash

Re: [cryptography] Just how bad is OpenSSL ?

2012-11-12 Thread Zack Weinberg
On Mon, Nov 12, 2012 at 2:32 AM, Jeffrey Walton noloa...@gmail.com wrote: GCC really should provide a function like SecureZeroMemory that cannot be optimized away. Its easier than educating every developer about the optimization issue and telling them to compile with -O0. The Ostrich

Re: [cryptography] Just how bad is OpenSSL ?

2012-11-05 Thread Ben Laurie
On Mon, Nov 5, 2012 at 5:07 AM, Nico Williams n...@cryptonector.com wrote: On Sun, Nov 4, 2012 at 8:42 AM, Ben Laurie b...@links.org wrote: On Sat, Nov 3, 2012 at 12:26 AM, James A. Donald jam...@echeque.com wrote: On Oct 30, 2012 7:50 AM, Ben Laurie b...@links.org wrote: The team has ruled

Re: [cryptography] Just how bad is OpenSSL ?

2012-11-05 Thread Jeremy Stanley
On 2012-11-05 09:31:08 + (+), Ben Laurie wrote: On Mon, Nov 5, 2012 at 5:07 AM, Nico Williams n...@cryptonector.com wrote: It's just git, so keep multiple clone repos. You could use an internal one as the master and push updates to the github one if you don't trust github -- use

Re: [cryptography] Just how bad is OpenSSL ?

2012-11-04 Thread Ben Laurie
On Sat, Nov 3, 2012 at 12:26 AM, James A. Donald jam...@echeque.com wrote: On Oct 30, 2012 7:50 AM, Ben Laurie b...@links.org wrote: The team has ruled out having the master at github. What is wrong with github? TBH, I wouldn't mind much, but I think the concern is that its not under our

Re: [cryptography] Just how bad is OpenSSL ?

2012-11-04 Thread Nico Williams
On Sun, Nov 4, 2012 at 8:42 AM, Ben Laurie b...@links.org wrote: On Sat, Nov 3, 2012 at 12:26 AM, James A. Donald jam...@echeque.com wrote: On Oct 30, 2012 7:50 AM, Ben Laurie b...@links.org wrote: The team has ruled out having the master at github. What is wrong with github? TBH, I

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-31 Thread Jeffrey Walton
On Fri, Oct 26, 2012 at 3:38 PM, Andy Isaacson a...@hexapodia.org wrote: On Fri, Oct 26, 2012 at 06:29:47PM +, John Case wrote: So, given what is in the stanford report and then reading this rant about openssl, I am wondering just how bad openssl is ? I've never had to implement it or

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-31 Thread Jeffrey Walton
On Tue, Oct 30, 2012 at 11:29 AM, Thierry Moreau thierry.mor...@connotech.com wrote: Solar Designer wrote: On Mon, Oct 29, 2012 at 04:06:58PM -0400, Jeffrey Walton wrote: The OpenSSL cleanse() function will likely fail on BIOs created from storage and memory mapped files when used on SSDs

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Ben Laurie
On Mon, Oct 29, 2012 at 10:34 PM, Jeffrey Walton noloa...@gmail.com wrote: On Fri, Oct 26, 2012 at 2:29 PM, John Case c...@sdf.org wrote: I was recently reading the most dangerous code in the world article at stanford: https://crypto.stanford.edu/~dabo/pubs/abstracts/ssl-client-bugs.html

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Jeffrey Walton
On Tue, Oct 30, 2012 at 5:03 AM, Ben Laurie b...@links.org wrote: On Mon, Oct 29, 2012 at 10:34 PM, Jeffrey Walton noloa...@gmail.com wrote: On Fri, Oct 26, 2012 at 2:29 PM, John Case c...@sdf.org wrote: [SNIP] Apparently you think the best way to get a secure platform is to apply pressure

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Ben Laurie
On Tue, Oct 30, 2012 at 11:09 AM, Jeffrey Walton noloa...@gmail.com wrote: On Tue, Oct 30, 2012 at 5:03 AM, Ben Laurie b...@links.org wrote: On Mon, Oct 29, 2012 at 10:34 PM, Jeffrey Walton noloa...@gmail.com wrote: On Fri, Oct 26, 2012 at 2:29 PM, John Case c...@sdf.org wrote: [SNIP]

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Ben Laurie
On Tue, Oct 30, 2012 at 11:17 AM, Peter Gutmann pgut...@cs.auckland.ac.nz wrote: Ben Laurie b...@links.org writes: Apparently you think the best way to get a secure platform is to apply pressure through pointless security standards. I think that's a bit of an extreme comment on FIPS 140. For

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Jeffrey Walton
On Tue, Oct 30, 2012 at 5:03 AM, Ben Laurie b...@links.org wrote: On Mon, Oct 29, 2012 at 10:34 PM, Jeffrey Walton noloa...@gmail.com wrote: On Fri, Oct 26, 2012 at 2:29 PM, John Case c...@sdf.org wrote: [SNIP] Apparently you think the best way to get a secure platform is to apply pressure

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Peter Gutmann
Ben Laurie b...@links.org writes: On Tue, Oct 30, 2012 at 11:17 AM, Peter Gutmann pgut...@cs.auckland.ac.nz wrote: Ben Laurie b...@links.org writes: Apparently you think the best way to get a secure platform is to apply pressure through pointless security standards. I think that's a bit of an

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Matthew Green
So: 1. What is the process by which you get OpenSSL contributors to notice a serious issue and apply a patch? 2. What are the criteria for applying a patch? Is it just 'whatever interests the devs'? It seems that publishing an exploit works, but is that necessary? 3. It's 2012 -- why the

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Ben Laurie
On Tue, Oct 30, 2012 at 2:21 PM, Matthew Green matthewdgr...@gmail.com wrote: So: 1. What is the process by which you get OpenSSL contributors to notice a serious issue and apply a patch? I wouldn't know, I haven't tried :-) In my case, just ask (me, that is, not some mailing list). If the

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Nico Williams
I strongly suggest you move to git ASAP. It's not hard, though some history can be lost in the move using off-the-shelf conversion tools. (MIT Kerberos recently moved from SVN to git, and before that, from CVS to SVN, and they seem to have done a lot of manual cleanup to avoid some losses of

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Ben Laurie
On Tue, Oct 30, 2012 at 2:31 PM, Nico Williams n...@cryptonector.com wrote: I strongly suggest you move to git ASAP. It's not hard, though some history can be lost in the move using off-the-shelf conversion tools. (MIT Kerberos recently moved from SVN to git, and before that, from CVS to SVN,

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Patrick Mylund Nielsen
I would be happy to volunteer to move everything to Github. But it really is really, really easy to do, and the maintenance required is minimal. That or git+redmine or git+JIRA would be my suggestion. On Tue, Oct 30, 2012 at 3:28 PM, Ben Laurie b...@links.org wrote: On Tue, Oct 30, 2012 at 2:21

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Ben Laurie
On Tue, Oct 30, 2012 at 2:39 PM, Patrick Mylund Nielsen cryptogra...@patrickmylund.com wrote: I would be happy to volunteer to move everything to Github. But it really is really, really easy to do, and the maintenance required is minimal. That or git+redmine or git+JIRA would be my suggestion.

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Aaron Grattafiori
Thank god... On Oct 30, 2012 7:50 AM, Ben Laurie b...@links.org wrote: On Tue, Oct 30, 2012 at 2:39 PM, Patrick Mylund Nielsen cryptogra...@patrickmylund.com wrote: I would be happy to volunteer to move everything to Github. But it really is really, really easy to do, and the maintenance

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Patrick Mylund Nielsen
Hopefully somebody's doing some kind of integrity check pre-release no matter where it's hosted... :) In either case, happy to help if it is manhours you need, and I'm sure others on this list are as well. On Tue, Oct 30, 2012 at 3:51 PM, Aaron Grattafiori aa...@digitalinfinity.net wrote:

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Thierry Moreau
Solar Designer wrote: On Tue, Oct 30, 2012 at 11:29:17AM -0400, Thierry Moreau wrote: Isn't memory-space cleanse() isolated from file system specifics except for the swap space? Normally yes, but the swap space may be in a file (rather than a disk partition), or the swap partition may be in a

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Paul Hoffman
On Oct 30, 2012, at 9:11 AM, Thierry Moreau thierry.mor...@connotech.com wrote: Then it's just a matter of the shortest route to finish: route a) secure the swap, route b) monitor software components for maximum memory usage vs physical mem plus make a memory exhaustion fault analysis.

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-30 Thread Jeffrey Walton
On Tue, Oct 30, 2012 at 12:10 PM, Paul Hoffman paul.hoff...@vpnc.org wrote: On Oct 30, 2012, at 9:11 AM, Thierry Moreau thierry.mor...@connotech.com wrote: Then it's just a matter of the shortest route to finish: route a) secure the swap, route b) monitor software components for maximum

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-29 Thread Jeffrey Walton
On Sun, Oct 28, 2012 at 3:01 PM, Solar Designer so...@openwall.com wrote: On Sat, Oct 27, 2012 at 06:47:05PM -0700, Patrick Pelletier wrote: For the most part, I would say that OpenSSL is not badly written, just badly documented. I am not a cryptography expert (just a smart, experienced

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-29 Thread Von Welch
I am wondering just how bad openssl is ? While one can find various software engineer faults, I think that main issue is not that it is bad, it is that OpenSSL is written for cryptographic experts not standard software developers. The unfortunate thing is that most of the time the latter

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-29 Thread Solar Designer
On Mon, Oct 29, 2012 at 04:06:58PM -0400, Jeffrey Walton wrote: On Sun, Oct 28, 2012 at 3:01 PM, Solar Designer so...@openwall.com wrote: The OPENSSL_cleanse() function is such that the memory is overwritten with the counter values, whereas the counter is incremented in ways dependent on

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-29 Thread Jeffrey Walton
Hi Alexander, Sorry to go offlist. On Mon, Oct 29, 2012 at 7:31 PM, Solar Designer so...@openwall.com wrote: On Mon, Oct 29, 2012 at 04:06:58PM -0400, Jeffrey Walton wrote: On Sun, Oct 28, 2012 at 3:01 PM, Solar Designer so...@openwall.com wrote: [SNIP, SNIP, SNIP] GCC uses volatile

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-28 Thread Solar Designer
On Sat, Oct 27, 2012 at 06:47:05PM -0700, Patrick Pelletier wrote: For the most part, I would say that OpenSSL is not badly written, just badly documented. I am not a cryptography expert (just a smart, experienced programmer, trying to use TLS) so I'm not in a particularly good position to

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-27 Thread Patrick Pelletier
On 10/26/12 11:29 AM, John Case wrote: So, given what is in the stanford report and then reading this rant about openssl, I am wondering just how bad openssl is ? I've never had to implement it or code with it, so I really have no idea. I think that OpenSSL is written by monkeys is a bit

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-27 Thread ianG
On 28/10/12 12:47 PM, Patrick Pelletier wrote: Just a slow sunday morning so I thought I'd dive in on one point. For the rest, nodding. The other thing that bugged me a bit was in the infamous rand(3ssl) man page: 3. The state should be very large. If the RNG is being used

Re: [cryptography] Just how bad is OpenSSL ?

2012-10-26 Thread Andy Isaacson
On Fri, Oct 26, 2012 at 06:29:47PM +, John Case wrote: So, given what is in the stanford report and then reading this rant about openssl, I am wondering just how bad openssl is ? I've never had to implement it or code with it, so I really have no idea. How long has it been understood