Re: [cryptopp-users] Crypto++ 7.0: Warning LNK4221 in project cryptlib with Visual Studio 2015
On Wednesday, July 11, 2018 at 3:24:46 AM UTC-4, Don-Umbro wrote: > > ... > Looking into the issue a little more, I figured that the corresponding > *.cpp files themselves are included elsewhere. Basically e.g. "algebra.cpp" > in fact seems to be more like a header than a source. One way to get rid of > the issue would be renaming "algebra.cpp" to something like > "algebra_impl.h". Would you view this as a useful change? Why is it a cpp > after all? > > Try: >> >> * https://github.com/weidai11/cryptopp/commit/3dcceb55f57c >> * https://github.com/weidai11/cryptopp/commit/0cee6f01f010 > > > This solution would work as well. However IMHO it looks more like a > workaround than solving the original issue, which is VisualStudio compiling > algebra.cpp because it is a cpp... > We also have to clear the warnings when using libtool on Unix and Linux. Jeff -- You received this message because you are subscribed to "Crypto++ Users". More information about Crypto++ and this group is available at http://www.cryptopp.com and http://groups.google.com/forum/#!forum/cryptopp-users. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to cryptopp-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [cryptopp-users] Crypto++ 7.0: Warning LNK4221 in project cryptlib with Visual Studio 2015
Hi Jeff, thanks for your answer. Patches are always welcomed. > > We don't bust balls over the trivial stuff like formatting. If you can > move the library forward then we are happy to evaluate it. > I'm happy to provide a patch / pull request, if I have a solution that benefits the project. However I'm not as experienced with Crypto++, cryptography and c++ in general as many of you probably are. So spamming bad / inappropriate patches onto the project might not be the best... That's why I wanted to get my understanding right and some comments first. Looking into the issue a little more, I figured that the corresponding *.cpp files themselves are included elsewhere. Basically e.g. "algebra.cpp" in fact seems to be more like a header than a source. One way to get rid of the issue would be renaming "algebra.cpp" to something like "algebra_impl.h". Would you view this as a useful change? Why is it a cpp after all? Try: > > * https://github.com/weidai11/cryptopp/commit/3dcceb55f57c > * https://github.com/weidai11/cryptopp/commit/0cee6f01f010 This solution would work as well. However IMHO it looks more like a workaround than solving the original issue, which is VisualStudio compiling algebra.cpp because it is a cpp... Jan -- You received this message because you are subscribed to "Crypto++ Users". More information about Crypto++ and this group is available at http://www.cryptopp.com and http://groups.google.com/forum/#!forum/cryptopp-users. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to cryptopp-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [cryptopp-users] Crypto++ 7.0: Warning LNK4221 in project cryptlib with Visual Studio 2015
On Tue, Jul 10, 2018 at 5:04 AM, Don-Umbro wrote: > ... > > However I'm a little irritated, because I get LNK4221 error in project > cryptlib even for the original solution cryptest which is shipped with the > code: Patches are always welcomed. We don't bust balls over the trivial stuff like formatting. If you can move the library forward then we are happy to evaluate it. >> strciphr.obj : warning LNK4221: This object file does not define any >> previously undefined public symbols, so it will not be used by any link >> operation that consumes this library [c:\cryptopp\cryptlib.vcxproj] > > I get this warnings for object files strciphr.obj, simple.obj, polynomi.obj > and algebra.obj. Try: * https://github.com/weidai11/cryptopp/commit/3dcceb55f57c * https://github.com/weidai11/cryptopp/commit/0cee6f01f010 Jeff -- You received this message because you are subscribed to "Crypto++ Users". More information about Crypto++ and this group is available at http://www.cryptopp.com and http://groups.google.com/forum/#!forum/cryptopp-users. --- You received this message because you are subscribed to the Google Groups "Crypto++ Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to cryptopp-users+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
