Re: Re: TFTP transfer is not aborted by non-zerovaluereturnedbyCURLOPT_PROGRESSFUNCTION

2011-10-03 Thread Marcin Adamski
On Sun, 2 Oct 20111 21:56 Daniel Stenberg dan...@haxx.se wrote: On Sun, 2 Oct 2011, Marcin Adamski wrote: I don't have any quick and easy way to drop my interface since I run the test on a single machine. What if I shut down the TFTP server in the midst of the transfer, would that

Re: Curl_ssl_kill_session called with --without-ssl

2011-10-03 Thread Alejandro Álvarez Ayllón
My fault. I think this should do it: diff --git a/lib/share.c b/lib/share.c index a3eae16..78da890 100644 --- a/lib/share.c +++ b/lib/share.c @@ -186,11 +186,13 @@ curl_share_cleanup(CURLSH *sh) if(share-cookies) Curl_cookie_cleanup(share-cookies); if(share-sslsession) { +#ifdef

What are consequences of late curl_multi_perform call

2011-10-03 Thread Marcin Adamski
I'm wondering what are consequences of late curl_multi_perform call. I guess that it may cause some timeouts to occur later than it should i.e. we set CURLOPT_TIMEOUT for 60s, but whole operation lasted 62s. But are there any significant consequences for ongoing transfer? Say we are downloading

Re: Closing an open connection with curl easy handle

2011-10-03 Thread Thibaut Le Guilly
Thanks for your answers I will check those. Why is curl_multi_perform() a bigger problem than calling curl_easy_perform() ? Because (unless I'm doing something wrong or misunderstood) curl_easy_perform is synchronous and will call the write callback each time the server sends notification,

Re: What are consequences of late curl_multi_perform call

2011-10-03 Thread Rich Gray
Marcin Adamski wrote: I'm wondering what are consequences of late curl_multi_perform call. I guess that it may cause some timeouts to occur later than it should i.e. we set CURLOPT_TIMEOUT for 60s, but whole operation lasted 62s. But are there any significant consequences for ongoing

Re: What are consequences of late curl_multi_perform call

2011-10-03 Thread Daniel Stenberg
On Mon, 3 Oct 2011, Marcin Adamski wrote: I'm wondering what are consequences of late curl_multi_perform call. I guess that it may cause some timeouts to occur later than it should i.e. we set CURLOPT_TIMEOUT for 60s, but whole operation lasted 62s. But are there any significant consequences

Re: What are consequences of late curl_multi_perform call

2011-10-03 Thread Daniel Stenberg
On Mon, 3 Oct 2011, Rich Gray wrote: Before version 7.20.0: If you receive CURLM_CALL_MULTI_PERFORM, this basically means that you should call curl_multi_perform again, before you select() on more actions. I'm trying to figure out what this really means. If you use a recent libcurl I

Re: What are consequences of late curl_multi_perform call

2011-10-03 Thread Rich Gray
Daniel Stenberg wrote: On Mon, 3 Oct 2011, Rich Gray wrote: Before version 7.20.0: If you receive CURLM_CALL_MULTI_PERFORM, this basically means that you should call curl_multi_perform again, before you select() on more actions. I'm trying to figure out what this really means. If you use a

[PATCH] m4: Use x in order to avoid variable 'x' set but not used

2011-10-03 Thread Dominique Leuenberger
See attached patch, fixing an issue when running a configure with -Werror -Wall and the current libcurl.m4. the fix simply introduces 'to use' x; Dominique From 0a8361df11617fe0a59687b00f020a8e9f15e83f Mon Sep 17 00:00:00 2001 From: Dominique Leuenberger dims...@opensuse.org Date: Mon, 3 Oct

RE: Connection being reused following a cancellation (HTTP)

2011-10-03 Thread Vladimir Grishchenko
Thanks! Thinking further, is there enough information available to recognize the connection as not being dirty in this case and actually leave it open? It appears that closing the connection in case when no data was sent out is somewhat pessimistic and wastes a perfectly good

Re: Curl_ssl_kill_session called with --without-ssl

2011-10-03 Thread Daniel Stenberg
On Mon, 3 Oct 2011, Alejandro Álvarez Ayllón wrote: My fault. I think this should do it: Thanks! But I took a larger scope and removed the sslsession completely from the struct when SSL isn't used and while doing that, I did the same for the cookies and I added a new return code for the

Re: [PATCH] m4: Use x in order to avoid variable 'x' set but not used

2011-10-03 Thread Daniel Stenberg
On Mon, 3 Oct 2011, Dominique Leuenberger wrote: See attached patch, fixing an issue when running a configure with -Werror -Wall and the current libcurl.m4. the fix simply introduces 'to use' x; Thanks a lot, pushed! -- / daniel.haxx.se

RE: [PATCH] smtp_mail: Added support to MAIL FROM for the optional SIZE parameter

2011-10-03 Thread Daniel Stenberg
On Fri, 30 Sep 2011, Steve Holme wrote: I see there is also the potential for another leak when from is successfully allocated but size fails. I have attached a small patch to fix this issue as well. Thanks, pushed! -- / daniel.haxx.se

Re: [PATCH] Added support for NTLM authentication to SMTP

2011-10-03 Thread Daniel Stenberg
On Sat, 1 Oct 2011, Steve Holme wrote: Please find attached three patches which ultimately add NTLM authorisation support to SMTP. This carries on the work I was involved with during July and August but unfortunately ran out of time on to complete for the v7.22.0 release. Thanks a lot! I've

RE: [PATCH] Added support for NTLM authentication to SMTP

2011-10-03 Thread Steve Holme
Hi Daniel, Please find attached three patches which ultimately add NTLM authorisation support to SMTP. This carries on the work I was involved with during July and August but unfortunately ran out of time on to complete for the v7.22.0 release. Thanks a lot! I've pushed your

Re: Curl_ssl_kill_session called with --without-ssl

2011-10-03 Thread Dan Fandrich
On Mon, Oct 03, 2011 at 10:37:05PM +0200, Daniel Stenberg wrote: But I took a larger scope and removed the sslsession completely from the struct when SSL isn't used and while doing that, I did the same for the cookies and I added a new return code for the share interface when trying to share