On 11/13/2014 05:43 PM, Daniel Stenberg wrote:
> Thanks a lot, pushed!
Looks good, thanks!
-Brad
---
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.html
On Thu, 13 Nov 2014, Brad King wrote:
Thanks. I don't have direct access, so would someone commit this, please?
Thanks a lot, pushed!
--
/ daniel.haxx.se
---
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette
On 11/11/2014 04:02 PM, Jakub Zakrzewski wrote:
>> please provide the necessary +1 when ready.
>
> The purpose is clear, so +1 from me.
Thanks. I don't have direct access, so would someone commit
this, please?
-Brad
---
List admin
> please provide the necessary +1 when ready.
Sure, from my point of view it's reverting the old, working behaviour. The
purpose is clear, so +1 from me.
> IIRC the checks were originally written that way many years
> ago to duplicate what the non-CMake buildsystem was doing
> for its checks at
On 11/11/2014 04:42 AM, Jakub Zakrzewski wrote:
>> Here is a patch series to fix it. See individual commit messages for
>> details. Basically they revert some recent changes and add comments
>> explaning why the original code worked the way it did. Whatever issues
>> caused those changes will
> Here is a patch series to fix it. See individual commit messages for
> details. Basically they revert some recent changes and add comments
> explaning why the original code worked the way it did. Whatever issues
> caused those changes will need to be resolved in another way.
Thanks for your
On 11/07/2014 01:37 PM, Steve Holme wrote:
> I'm sure Daniel will review this
Great.
>> Revert commit curl-7_39_0~160 (Cmake: Avoid cycle directory dependencies,
>> 2014-08-22) and add a comment explaining the purpose of the original code.
>
> I would recommend referencing the original commit in
On Fri, 7 Nov 2014, Brad King wrote:
> Here is a patch series to fix it.
Many thanks for your efforts on this - it is much appreciate especially as our
cmake builds have lacked in functionality for quite a while now.
I'm sure Daniel will review this along with Peter's recent changes however I
