Re: Username and password in URL stopped working with proxy

2019-08-15 Thread Mike Crowe via curl-library
On Thursday 15 August 2019 at 15:52:31 +0200, Daniel Stenberg wrote: > On Thu, 15 Aug 2019, Mike Crowe wrote: > > > If I make that change to master (and don't modify the GET lines because > > master doesn't supply the username and password to the proxy that way) > > then no Authorization header

Re: Username and password in URL stopped working with proxy

2019-08-15 Thread Daniel Stenberg via curl-library
On Thu, 15 Aug 2019, Mike Crowe wrote: If I make that change to master (and don't modify the GET lines because master doesn't supply the username and password to the proxy that way) then no Authorization header is sent, so the test fails. Right, I saw that as well. Test 168 doesn't appear

Re: Username and password in URL stopped working with proxy

2019-08-15 Thread Mike Crowe via curl-library
On Thursday 15 August 2019 at 11:15:55 +0200, Daniel Stenberg wrote: > On Thu, 15 Aug 2019, Mike Crowe wrote: > > > I'll have a dig into the unit test infrastructure to see if I can find a > > way to add a test case for this. I'd previously assumed that the use of > > a proxy would make creating

Re: Username and password in URL stopped working with proxy

2019-08-15 Thread Daniel Stenberg via curl-library
On Thu, 15 Aug 2019, Mike Crowe wrote: I'll have a dig into the unit test infrastructure to see if I can find a way to add a test case for this. I'd previously assumed that the use of a proxy would make creating a test case difficult. I believe we can reproduce this problem with a modified

Re: Username and password in URL stopped working with proxy

2019-08-15 Thread Mike Crowe via curl-library
On Thursday 15 August 2019 at 09:50:50 +0200, Daniel Stenberg wrote: > On Thu, 15 Aug 2019, Mike Crowe via curl-library wrote: > > > That seems to be using basic authentication, so there's no 401 round > > trip required to get the nonce. Please can you post the full output when > > using digest

Re: Username and password in URL stopped working with proxy

2019-08-15 Thread Daniel Stenberg via curl-library
On Thu, 15 Aug 2019, Mike Crowe via curl-library wrote: That seems to be using basic authentication, so there's no 401 round trip required to get the nonce. Please can you post the full output when using digest authentication? You didn't say that was a requirement... =) I don't have a digest

Re: Username and password in URL stopped working with proxy

2019-08-15 Thread Mike Crowe via curl-library
On Wednesday 14 August 2019 at 23:35:47 +0200, Daniel Stenberg wrote: > On Wed, 14 Aug 2019, Mike Crowe wrote: > > > If this doesn't help point at the problem, please can you post the full > > output from when you successfully ran: > > > > $ ./src/curl http://daniel:he...@www.haxx.se -x

Re: Username and password in URL stopped working with proxy

2019-08-14 Thread Daniel Stenberg via curl-library
On Wed, 14 Aug 2019, Mike Crowe wrote: If this doesn't help point at the problem, please can you post the full output from when you successfully ran: $ ./src/curl http://daniel:he...@www.haxx.se -x localhost:80 --trace-ascii - -o /dev/null It seems to work? : GET http://www.haxx.se/

Re: Username and password in URL stopped working with proxy

2019-08-14 Thread Mike Crowe via curl-library
On Sunday 04 August 2019 at 23:35:17 +0200, Daniel Stenberg via curl-library wrote: > On Sat, 3 Aug 2019, Mike Crowe wrote: > > > I've attached two logs. One from my build of master, and one from the > > Debian Stretch version of curl (7.52.1.) It looks like v7.52.1 passes > > the username and

Re: Username and password in URL stopped working with proxy

2019-08-04 Thread Daniel Stenberg via curl-library
On Sat, 3 Aug 2019, Mike Crowe wrote: I've attached two logs. One from my build of master, and one from the Debian Stretch version of curl (7.52.1.) It looks like v7.52.1 passes the username and password on to the proxy in the URL, whereas master does not: I ran cd tests && ./runtests.pl

Re: Username and password in URL stopped working with proxy

2019-08-03 Thread R C via curl-library
depending on what protocol you are using, with curl, and the device,  it might be that you have to authenticate once, with digest or so, before you start streaming, and the authentication is good for the session. Ron On 8/3/19 2:39 PM, Mike Crowe via curl-library wrote: On Saturday 03

Re: Username and password in URL stopped working with proxy

2019-08-03 Thread Mike Crowe via curl-library
On Saturday 03 August 2019 at 21:32:12 +0200, Daniel Stenberg wrote: > On Sat, 3 Aug 2019, Daniel Stenberg via curl-library wrote: > > > > curl --proxy http://proxy:3128/ --anyauth http://unittest:password@host/ > > > > And you're using curl 7.65.3 ? No, I was using the current state of master

Re: Username and password in URL stopped working with proxy

2019-08-03 Thread Daniel Stenberg via curl-library
On Sat, 3 Aug 2019, Daniel Stenberg via curl-library wrote: curl --proxy http://proxy:3128/ --anyauth http://unittest:password@host/ And you're using curl 7.65.3 ? I just tried this with git master: $ ./src/curl http://daniel:he...@www.haxx.se -x localhost:80 --trace-ascii - -o

Re: Username and password in URL stopped working with proxy

2019-08-03 Thread Daniel Stenberg via curl-library
On Fri, 2 Aug 2019, Mike Crowe via curl-library wrote: I've managed to reproduce the problem against our Squid proxy with the the curl command line tool in the current state of master: curl --proxy http://proxy:3128/ --anyauth http://unittest:password@host/ And you're using curl 7.65.3 ? --

Username and password in URL stopped working with proxy

2019-08-02 Thread Mike Crowe via curl-library
Whilst upgrading to libcurl I've discovered that one of our tests has started failing. The test checks that a URL containing both a user name and password works correctly with digest authentication through a proxy. I've managed to reproduce the problem against our Squid proxy with the the curl