Re: Windows SSPI Schannel implementation ready

2012-06-14 Thread Yang Tse
Hi Gün, > 1st autobuild with new option: > http://curl.haxx.se/dev/log.cgi?id=20120614071403-7256 Great!. I've already pushed some further Schannel polishing, so next Schannel autobuilds should come out 'cleaner'. -- -=[Yang]=- --

Re: Windows SSPI Schannel implementation ready

2012-06-14 Thread Guenter
Am 13.06.2012 20:51, schrieb Yang Tse: Daniel Stenberg wrote: I assume you meant that to be --with-winssl? That seems more like regular configure style. (It is also done more or less automatically with the use of autoconf macros.) Done. Just pushed. Great, thanks Yang! 1st autobuild with ne

Re: Windows SSPI Schannel implementation ready

2012-06-13 Thread Marc Hoersken
2012/6/13 Tim Bannister : > On 13 Jun 2012, at 16:04, Marc Hoersken wrote: > >> Actually "schannel" is not the correct identifier. It's either "Schannel" or >> "Secure Schannel". Please take a look at the MSDN >> documentation before doing such changes: >> http://msdn.microsoft.com/en-us/library/

Re: Windows SSPI Schannel implementation ready

2012-06-13 Thread Yang Tse
Steve Holme wrote: >> OTOH every half baked Windows user, and all power-users, >> knows that schannel is the 'thingy' to hack in the registry to >> modify SSL behavior. But I have no problem with calling it >> 'SSL-Windows-native'. > > Personally I find that quite offensive. I have been programmi

Re: Windows SSPI Schannel implementation ready

2012-06-13 Thread Tim Bannister
On 13 Jun 2012, at 16:04, Marc Hoersken wrote: > Actually "schannel" is not the correct identifier. It's either "Schannel" or > "Secure Schannel". Please take a look at the MSDN > documentation before doing such changes: > http://msdn.microsoft.com/en-us/library/windows/desktop/ms678421.aspx I'

Re: Windows SSPI Schannel implementation ready

2012-06-13 Thread Yang Tse
Steve Holme wrote: >> > I'm not opposed to not including the version number - this would be >> > consistent to what WinIDN displays, [...] >> >> Ok, then we have consensus then. > > On the version number yes, on the SChannel literal no as this should be SSPI > - you wouldn't list either libssl32

RE: Windows SSPI Schannel implementation ready

2012-06-13 Thread Steve Holme
Yang, > OTOH every half baked Windows user, and all power-users, > knows that schannel is the 'thingy' to hack in the registry to > modify SSL behavior. But I have no problem with calling it > 'SSL-Windows-native'. Personally I find that quite offensive. I have been programming Windows since v2.0

Re: Windows SSPI Schannel implementation ready

2012-06-13 Thread Yang Tse
Marc Hoersken wrote: >> Identifier changed from 'WinSSPI' to 'schannel' given that this is the >> actual provider of the SSL/TLS support. libcurl can still be built >> with SSPI and without SCHANNEL support. > > Actually "schannel" is not the correct identifier. It's either > "Schannel" or "Secur

Re: Windows SSPI Schannel implementation ready

2012-06-13 Thread Yang Tse
Daniel Stenberg wrote: > I assume you meant that to be --with-winssl? That seems more like regular > configure style. (It is also done more or less automatically with the use of > autoconf macros.) Done. Just pushed. -- -=[Yang]=- --

RE: Windows SSPI Schannel implementation ready

2012-06-13 Thread Steve Holme
Hi Guenter, > to shorten this never-ending discussion I did > just change the string to "SSL-Windows-native" > for 3 reasons: >[...] > 3) At least we have 2 of us agree on this (me and Marc). Three (me) - I was simply against the package name as SChannel, although Marc, Yang and I didn't have a p

Re: Windows SSPI Schannel implementation ready

2012-06-13 Thread Guenter
Am 13.06.2012 20:24, schrieb Daniel Stenberg: On Wed, 13 Jun 2012, Guenter wrote: 5) we need to teach configure to build with SSL-native; I propose: --winssl I assume you meant that to be --with-winssl? That seems more like yup, of course! sorry ... regular configure style. (It is also don

Re: Windows SSPI Schannel implementation ready

2012-06-13 Thread Daniel Stenberg
On Wed, 13 Jun 2012, Guenter wrote: 5) we need to teach configure to build with SSL-native; I propose: --winssl I assume you meant that to be --with-winssl? That seems more like regular configure style. (It is also done more or less automatically with the use of autoconf macros.) we need

Re: Windows SSPI Schannel implementation ready

2012-06-13 Thread Guenter
Folks, to shorten this never-ending discussion I did just change the string to "SSL-Windows-native" for 3 reasons: 1) this describes how SSL is supported in a way the average user understands; "schannel" is something which users might not even know about what it is at all. 2) It is conform with

RE: Windows SSPI Schannel implementation ready

2012-06-13 Thread Steve Holme
Hi Yang, > > I'm not opposed to not including the version number - this would be > > consistent to what WinIDN displays, [...] > > Ok, then we have consensus then. On the version number yes, on the SChannel literal no as this should be SSPI - you wouldn't list either libssl32 or libeay32 for Ope

Re: Windows SSPI Schannel implementation ready

2012-06-13 Thread Guenter
Hi, Am 13.06.2012 16:40, schrieb Yang Tse: One of the reasons for which I personally dislike big patches is that these usually hide changes which are not properly discussed, or discussed with such lengthy threads that no one knows finally what's going on, making it necessary to fully analyze resu

Re: Windows SSPI Schannel implementation ready

2012-06-13 Thread Marc Hoersken
Hello everyone, 2012/6/13 Yang Tse : > One of the reasons for which I personally dislike big patches is that > these usually hide changes which are not properly discussed, or > discussed with such lengthy threads that no one knows finally what's > going on, making it necessary to fully analyze res

Re: Windows SSPI Schannel implementation ready

2012-06-13 Thread Yang Tse
Steve Holme wrote: > I'm not opposed to not including the version number - this would be > consistent to what WinIDN displays, [...] Ok, then we have consensus then. > I also think, as per the discussion I started 6 weeks ago which I thought we > had decided to do, hence my work here, was that

RE: Windows SSPI Schannel implementation ready

2012-06-13 Thread Steve Holme
Hi all, > Get well soon. Thank you for the well wishes - I got a good night's sleep but am still feeling pretty crap this morning :( I'm dosed up on Ibuprofen at the moment to try and reduce the fever but I might have to nip out in a bit and grab some paracetamol based cold and flue type remedie

Re: Windows SSPI Schannel implementation ready

2012-06-12 Thread Marc Hoersken
Hi Steve, 2012/6/12 Steve Holme : > I was tucked up in bed keeping warm as I'm really not feeling too good, I > currently have a temperature yet am cold and am feeling sick at the same > time, but I saw the email come in on my phone so I thought I should respond > properly at the keyboard whilst t

Re: Windows SSPI Schannel implementation ready

2012-06-12 Thread Yang Tse
Steve Holme wrote: > I was tucked up in bed keeping warm as I'm really not feeling too good, Get well soon. > If we don't put anything in here then what will a programmer who is using > ssl_version from the result of curl_version_info() get? Aha!, real reasons for us to chew on. Although man

RE: Windows SSPI Schannel implementation ready

2012-06-12 Thread Steve Holme
Hi again, On Tue, 12 Jun 2012, Yang Tse wrote: Apologies if any of what I write sounds a little off or abrupt... it isn't my intention! I was tucked up in bed keeping warm as I'm really not feeling too good, I currently have a temperature yet am cold and am feeling sick at the same time, but I s

Re: Windows SSPI Schannel implementation ready

2012-06-12 Thread Gisle Vanem
"Marc Hoersken" wrote: I like this idea. That way Curl_schannel_version would still return something useful while avoiding the dependency on version.lib. Do you also mean that '-DWIN_USE_SSPI' also needs to drop the version.lib requirement? I mean, 'WIN_USE_SSPI' without 'USE_SCHANNEL'. I'm

Re: Windows SSPI Schannel implementation ready

2012-06-12 Thread Marc Hoersken
2012/6/12 Guenter > > well, perhaps a compromise would be if we just display "SSL-Windows-native" > like we do with WinIDN ? That would drop the new dependency to the version > lib while remaining the information that SSL is provided through a Windows > system lib rather than through an exptern

Re: Windows SSPI Schannel implementation ready

2012-06-12 Thread Yang Tse
Marc Hoersken wrote: > I do understand and support Yang's arguments, but I also understand > that we need to figure out a good way to illustrate the features > provided by SSPI or any other security provider. The fact that security.dll or secur32.dll is being used is exposed for historical reaso

Re: Windows SSPI Schannel implementation ready

2012-06-12 Thread Guenter
Hi, 1st of all: I have no strong opinion either for or against the string ... Am 12.06.2012 19:21, schrieb Steve Holme: On Tue, 12 Jun 2012, Yang Tse wrote: 1) curl displays the SSL library in its version string and as such should display something when SSL through Windows SSPI is enabled. k, bu

RE: Windows SSPI Schannel implementation ready

2012-06-12 Thread Steve Holme
Hi Yang, On Tue, 12 Jun 2012, Yang Tse wrote: > SSPI is already present in libcurl's feature list when in use, so... > > Why do we need to show the security.dll or secur32.dll > version in libcurl's version string, and additionally dress it up as > WinSSPI? There are two reasons for including W

Re: Windows SSPI Schannel implementation ready

2012-06-12 Thread Marc Hoersken
2012/6/12 Yang Tse : > SSPI is already present in libcurl's feature list when in use, so... > > Why do we need to show the security.dll or secur32.dll version in > libcurl's version string, and additionally dress it up as WinSSPI? > > These two are system libraries the same as all other system libs

Re: Windows SSPI Schannel implementation ready

2012-06-12 Thread Yang Tse
SSPI is already present in libcurl's feature list when in use, so... Why do we need to show the security.dll or secur32.dll version in libcurl's version string, and additionally dress it up as WinSSPI? These two are system libraries the same as all other system libs that might be used, such as ke

Re: Windows SSPI Schannel implementation ready

2012-06-11 Thread Marc Hoersken
Hi Guenter, 2012/6/12 Guenter : > Hi Marc, > Am 10.06.2012 22:54, schrieb Marc Hoersken: > >> with the support of Steve and Guenter, I was able to ready my Windows >> SSPI Schannel implementation. > > naa, not worth to mention me at all - I did contribute nothing but few small > commits! > Great w

Re: Windows SSPI Schannel implementation ready

2012-06-11 Thread Guenter
Hi Marc, Am 10.06.2012 22:54, schrieb Marc Hoersken: with the support of Steve and Guenter, I was able to ready my Windows SSPI Schannel implementation. naa, not worth to mention me at all - I did contribute nothing but few small commits! Great work, Marc! And thanks to Steve too who did also pu

Re: Windows SSPI Schannel implementation ready

2012-06-11 Thread Daniel Stenberg
On Tue, 12 Jun 2012, Marc Hoersken wrote: Just out of curiosity: What is the maximum line length for code lines? The lines you shortened were 80 character long, which I thought was correct. The lib/checksrc.pl script warns on >79 columns - and the script runs automatically on configure --enab

RE: Windows SSPI Schannel implementation ready

2012-06-11 Thread Steve Holme
Hi Marc, > > Nope. Merged and pushed just now. Go and try it out! > > Great! Thank you very much. The merge looks great. It's great we got this into 7.27.0 ;-) > Just out of curiosity: What is the maximum line length > for code lines? The lines you shortened were 80 > character long, which I th

Re: Windows SSPI Schannel implementation ready

2012-06-11 Thread Marc Hoersken
Hi Daniel, 2012/6/11 Daniel Stenberg : > On Mon, 11 Jun 2012, Marc Hoersken wrote: > >> Do you have anything else you want to discuss before merging the Schannel >> branch, Daniel? :-) > > > Nope. Merged and pushed just now. Go and try it out! > Great! Thank you very much. The merge looks great.

RE: Windows SSPI Schannel implementation ready

2012-06-11 Thread Daniel Stenberg
On Mon, 11 Jun 2012, Steve Holme wrote: No problem - perhaps something we can add to clean up list for a major update. Yes, there's a list of such stuff at the bottom of the TODO (section 18 and 19). Alternatively, as see SSPI is back on the features list as well... Yes, only to keep the

RE: Windows SSPI Schannel implementation ready

2012-06-11 Thread Steve Holme
Hi again, > > Just out of interest - does that feature still exist and work? How > > does an end Windows user tell curl to use the currently logged in user? > > IIRC you just use ":" as name/password, but I don't know if it still works > as unfortunately we don't test that in the test suite since

RE: Windows SSPI Schannel implementation ready

2012-06-11 Thread Daniel Stenberg
On Mon, 11 Jun 2012, Steve Holme wrote: We added SSPI in the curl output and as a feature bit once upon the time partly because libcurl built with SSPI provides certain features that libcurl without SSPI doesn't possess (I'm thinking of the ability to magically use the logged in user's usernam

Re: Windows SSPI Schannel implementation ready

2012-06-11 Thread Daniel Stenberg
On Mon, 11 Jun 2012, Marc Hoersken wrote: Do you have anything else you want to discuss before merging the Schannel branch, Daniel? :-) Nope. Merged and pushed just now. Go and try it out! -- / daniel.haxx.se --- List admin: ht

RE: Windows SSPI Schannel implementation ready

2012-06-11 Thread Steve Holme
Hi Daniel, On Mon, 11 Jun 2012, Daniel Stenberg wrote: > We added SSPI in the curl output and as a feature bit once > upon the time partly because libcurl built with SSPI provides > certain features that libcurl without SSPI doesn't possess (I'm > thinking of the ability to magically use the logg

Re: Windows SSPI Schannel implementation ready

2012-06-11 Thread Marc Hoersken
Hi Daniel, 2012/6/11 Daniel Stenberg : > On Mon, 11 Jun 2012, Steve Holme wrote: > >> We had discussed that SSPI was a library / provider of security features >> such a Security Contexts (GSS-Nego, NTLM, etc...) and now SSL and as such >> should not appear on the features list in the same way that

RE: Windows SSPI Schannel implementation ready

2012-06-11 Thread Daniel Stenberg
On Mon, 11 Jun 2012, Steve Holme wrote: We had discussed that SSPI was a library / provider of security features such a Security Contexts (GSS-Nego, NTLM, etc...) and now SSL and as such should not appear on the features list in the same way that OpenSSL or GNUTLS don't. I agree with this, g

Re: Windows SSPI Schannel implementation ready

2012-06-11 Thread Marc Hoersken
2012/6/11 Marc Hoersken : > Hi Daniel, > > 2012/6/11 Daniel Stenberg : >> On Mon, 11 Jun 2012, Marc Hoersken wrote: >> >>> Did you use the latest set of patch files? Actually that set shouldn't >>> contain CRLF newline issues anymore. If it does, please tell me the location >>> so that I can fix it

RE: Windows SSPI Schannel implementation ready

2012-06-11 Thread Steve Holme
Hi again, > Oh I missed that. So Steve, any comments? I just replied a minute or so ago... whilst Outlook was grabbing the latest messages from Hotmail ;-) S. --- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquett

Re: Windows SSPI Schannel implementation ready

2012-06-11 Thread Marc Hoersken
Hi Daniel, 2012/6/11 Daniel Stenberg : > On Mon, 11 Jun 2012, Marc Hoersken wrote: > >> Did you use the latest set of patch files? Actually that set shouldn't >> contain CRLF newline issues anymore. If it does, please tell me the location >> so that I can fix it on my branch and provide a new patc

RE: Windows SSPI Schannel implementation ready

2012-06-11 Thread Steve Holme
Hi Daniel, On Mon, 11 Jun 2012, Daniel Stenberg wrote: > A question I have is about the removal of CURL_VERSION_SSPI. > What's the gain in removing this bit? We're set to keep the API > backwards compatible so we better not remove the definition > from the header file, but won't there also be one

Re: Windows SSPI Schannel implementation ready

2012-06-11 Thread Daniel Stenberg
On Mon, 11 Jun 2012, Marc Hoersken wrote: Did you use the latest set of patch files? Actually that set shouldn't contain CRLF newline issues anymore. If it does, please tell me the location so that I can fix it on my branch and provide a new patch file. The CRLFs are in the windows makefiles,

Re: Windows SSPI Schannel implementation ready

2012-06-11 Thread Marc Hoersken
> I would to make sure that changes created due to misunderstandings or > similiar make it into the master. That sentence should read: I would like to make sure that changes created due to misunderstandings or similiar do not make it into the master. Sorry. --

Re: Windows SSPI Schannel implementation ready

2012-06-11 Thread Marc Hoersken
Hi Daniel, 2012/6/11 Daniel Stenberg : > On Mon, 11 Jun 2012, Marc Hoersken wrote: > >> Therefore I am attaching a complete new set of patches that differs >> after 38984c2775651c8fb675528b20fa8d54ba43e2c6 (patch 0022). >> Sorry for the inconvenience. >> >> Please drop the old set and use the new

Re: Windows SSPI Schannel implementation ready

2012-06-11 Thread Daniel Stenberg
On Mon, 11 Jun 2012, Marc Hoersken wrote: Therefore I am attaching a complete new set of patches that differs after 38984c2775651c8fb675528b20fa8d54ba43e2c6 (patch 0022). Sorry for the inconvenience. Please drop the old set and use the new one. Thanks for your hard work on this! I've merged t

Re: Windows SSPI Schannel implementation ready

2012-06-10 Thread Yang Tse
Hi Marc, I'll look soonish into all this. An ultra fast patch skimming shows there are line ending problems (changed from UNIX to DOS) in at least all lines of include/curl/curl.h and lib/setup.h -- -=[Yang]=- --- List admin: http:

Re: Windows SSPI Schannel implementation ready

2012-06-10 Thread Marc Hoersken
Hello again, shame on me, but I have to submit another small patch with just a single character being added: - Fixed missing pointer cast in Curl_sspi_version Best regards, Marc 0029-sspi-Fixed-missing-pointer-cast-in-Curl_sspi_version.patch Description: Binary data

Re: Windows SSPI Schannel implementation ready

2012-06-10 Thread Marc Hoersken
Hello again, sorry, but I have to submit two more patches for the mingw32 build: - sspi: Fixed incompatible parameter pointer type in Curl_sspi_version - mingw32: Fixed warning of USE_SSL being redefined And just for the record, the following things are left to be done for the Schannel implementa