Ryan Harper has proposed merging
~raharper/curtin:fix/unittest-prevent-subp-by-default into curtin:master.
Commit message:
unittest: do not allow util.subp by default
Bring over our util.subp mock from cloud-init. Rework unittest to enable subp
as needed.
Requested reviews:
curtin
Ryan Harper has proposed merging
~raharper/curtin:fix/lvm-over-multipath-partition-wipe into curtin:master.
Commit message:
lvm-over-multipath: handle lookups of multipath members
Subiquity provides a 'path' value for disks in storage config.
This triggered an edge case where curtin attempted
Ryan Harper has proposed merging
~raharper/curtin:fix/block-discover-use-mp-name into curtin:master.
Commit message:
block-discover: handle missing multipath 'path' data, use DM_NAME
Probert's multipath data (maps and paths) is not always complete.
In some systems, the paths output may
>
> I haven't run the vmtest yet because I haven't run make sync-images on this
> laptop yet and that takes about a million years. Hopefully I'll get to that
> today!
If you don't want to sync everything you can do:
CURTIN_VMTEST_IMAGE_SYNC=1 ./tools/jenkins
The proposal to merge ~raharper/curtin:fix/unittest-prevent-subp-by-default
into curtin:master has been updated.
Commit message changed to:
unittest: do not allow util.subp by default
Bring over our util.subp mock from cloud-init. Rework unittest to enable subp
as needed.
LP: #1873913
For
The proposal to merge ~raharper/curtin:fix/unittest-prevent-subp-by-default
into curtin:master has been updated.
Commit message changed to:
unittest: do not allow util.subp by default
Bring over our util.subp mock from cloud-init. Rework unittest to
enable subp as needed.
LP: #1873913
For
The proposal to merge ~raharper/curtin:fix/unittest-prevent-subp-by-default
into curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382604
--
Your team curtin developers is subscribed to
The proposal to merge ~raharper/curtin:fix/unittest-prevent-subp-by-default
into curtin:master has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382604
--
Your team curtin developers is subscribed to
Let me drop the logging bits; I replied in line; I think the per-test
enablement with a tearDown() is reasonable. Let me see if I can sub-class the
main test class and put the subp_enabled ones within that; hoping to avoid
duplicating code from one class to another when all we need is to
Fixing
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382604
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~curtin-dev
More
The proposal to merge ~raharper/curtin:fix/unittest-prevent-subp-by-default
into curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382604
--
Your team curtin developers is subscribed to
The proposal to merge ~raharper/curtin:fix/reuse-vg-partition-simple into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382505
--
Your team curtin developers is subscribed to branch
Thanks, I'll wait till CI reports success on this before merging.
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382607
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to :
wait for CI to say yes, then mark approve
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382604
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe :
Ryan Harper has proposed merging
~raharper/curtin:fix/vmtest-basic-scsi-pnum-disk into curtin:master.
Commit message:
vmtest: basic use dname to lookup disk with multiple partitions
This handles unstable scsi device names (sdc/sdd) which shuffle around
from time to time; instead look up
The proposal to merge ~raharper/curtin:fix/vmtest-basic-scsi-pnum-disk into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382607
--
Your team curtin developers is subscribed to branch
The proposal to merge ~raharper/curtin:fix/block-discover-use-mp-name into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382602
--
Your team curtin developers is subscribed to branch
The proposal to merge ~raharper/curtin:fix/unittest-prevent-subp-by-default
into curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382604
--
Your team curtin developers is subscribed to
Thanks. shlex.quote() is designed to make the string usable directly in shell,
like so:
% lxc exec x1 bash
root@x1:~# lsb_release -rd
Description:Ubuntu 16.04.6 LTS
Release:16.04
root@x1:~# python3
Python 3.5.2 (default, Apr 16 2020, 17:47:17)
[GCC 5.4.0 20160609] on linux
Type
Ryan Harper has proposed merging ~raharper/curtin:fix/udevadm-info-shlex-quote
into curtin:master.
Commit message:
udev: use shlex.quote before shlex.split to preserve shell escape chars
The udev database includes shell escape characters in the output.
Use shlex.quote on the values before
The proposal to merge ~raharper/curtin:fix/vmtest-early-rsync-error into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382705
--
Your team curtin developers is subscribed to branch
Thanks
Diff comments:
> diff --git a/curtin/udev.py b/curtin/udev.py
> index e2e3dd0..0908bc9 100644
> --- a/curtin/udev.py
> +++ b/curtin/udev.py
> @@ -4,7 +4,14 @@ import shlex
> import os
>
> from curtin import util
> -from curtin.log import logged_call
> +from curtin.log import
The proposal to merge ~raharper/curtin:fix/udevadm-info-shlex-quote into
curtin:master has been updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382993
--
Your team curtin developers is subscribed to
This unittest is not exposing the path we're seeing. I suspect there's some
python string stuff happening here, I'll likely need to dump udevadm info
--query=property --export output into a file and provide the decoded file
output into the return of the mocked subp to have it trigger what I
Heh, that's exactly what I did =)
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382993
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe :
Ryan Harper has proposed merging ~raharper/curtin:fix/udevadm-info-shlex-quote
into curtin:master.
Commit message:
udev: use shlex.quote before shlex.split to preserve shell escape chars
The udev database includes shell escape characters in the output.
Use shlex.quote on the values before
Ryan Harper has proposed merging
~raharper/curtin:fix/device-mapper-mpath-is-not-symlink into curtin:master.
Commit message:
block-meta: device mapper partitions may be block devices not links
In some cases the multipath library may create a block device which
is not a symbolic link
Review: Approve
Waiting for CI to say yes once more then we can land.
--
https://code.launchpad.net/~sil2100/curtin/+git/curtin/+merge/382768
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to :
The proposal to merge ~sil2100/curtin:default-dm_name-id into curtin:master has
been updated.
Commit message changed to:
Default to dm_name being id if empty earlier in dm_crypt_handler()
In other parts of the code, when deciding the path for dmcrypt_dev,
we default to 'id' when 'dm_name' is
Review: Approve
Thanks!
--
https://code.launchpad.net/~chad.smith/curtin/+git/curtin/+merge/382778
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe :
% ./tools/schema-validate-storage test2.cfg
Validating storage config file: test2.cfg
Failed validation on: test2.cfg
# Validation Errors #
'dm_name' is a required property in test2.cfg
{
"id": "dm_crypt-0",
"key": "ubuntu",
"preserve": false,
"type": "dm_crypt",
"volume":
The proposal to merge ~sil2100/curtin:default-dm_name-id into curtin:master has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~sil2100/curtin/+git/curtin/+merge/382768
--
Your team curtin developers is subscribed to branch curtin:master.
Diff comments:
> diff --git a/curtin/commands/block_meta.py b/curtin/commands/block_meta.py
> index 7fbd89f..5849e3d 100644
> --- a/curtin/commands/block_meta.py
> +++ b/curtin/commands/block_meta.py
> @@ -910,8 +910,12 @@ def partition_handler(info, storage_config):
> if
Ryan Harper has proposed merging ~raharper/curtin:fix/vmtest-centos-basic into
curtin:master.
Commit message:
vmtest: centos66 doesn't use dname
Handle centos66 unittest results differently due to dname
not working there.
LP: #1874100
Requested reviews:
curtin developers (curtin-dev
There's a completely different error on power now... on focal (Un related to
this change too!)
Diff comments:
> diff --git a/tests/vmtests/test_basic.py b/tests/vmtests/test_basic.py
> index bb6d3a4..b442d8b 100644
> --- a/tests/vmtests/test_basic.py
> +++ b/tests/vmtests/test_basic.py
> @@
That said, it looks like the collect script needs to use the dname support
since "sda" moved on ppc64, so let me work on that one while we're fixing this
up.
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382704
Your team curtin developers is requested to review the proposed
The proposal to merge ~raharper/curtin:fix/force-mpath-mapper-links into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382798
--
Your team curtin developers is subscribed to branch
We don't trigger this path in vmtests as our multipath setup isn't real enough
to have the variability that triggers this race between multipathd and udev
however, vmtests do still pass so we've not regressed anything with this
change.
--
This should fix daily-ppa builds, once we fixed the first set of subp leaks, we
found more.
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382717
Your team curtin developers is requested to review the proposed merge of
~raharper/curtin:fix/unittest-leak-modprobe into
The proposal to merge
~raharper/curtin:fix/block-meta-get-device-paths-skip-missing into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382718
--
Your team curtin developers is
Thanks. vmtests pass, landing.
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382718
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe :
Ryan Harper has proposed merging ~raharper/curtin:fix/vmtest-early-rsync-error
into curtin:master.
Commit message:
vmtest: rsync don't cross filesystem boundaries when copying
In some scenarios /var/lib/lxcfs is mounted with kernel bits
and rsync complains; instead we now copy using the --one
Ryan Harper has proposed merging
~raharper/curtin:fix/block-meta-get-device-paths-skip-missing into
curtin:master.
Commit message:
block-meta: skip wipe device paths if not present
Curtin extracts the devices from storage config with wipe enabled.
These devices may not exist yet (curtin
Ryan Harper has proposed merging ~raharper/curtin:fix/unittest-leak-modprobe
into curtin:master.
Commit message:
Mock out zfs_supported to prevent attempting to load kernel modules
Requested reviews:
curtin developers (curtin-dev)
For more details, see:
https://code.launchpad.net/~raharper
The proposal to merge ~raharper/curtin:fix/udevadm-info-shlex-quote into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382993
--
Your team curtin developers is subscribed to branch
Ryan Harper has proposed merging ~raharper/curtin:fix/lvm-vgscan-no-mknodes
into curtin:master.
Commit message:
lvm: don't use vgscan --mknodes
vgscan --mknodes has a bug which creates block device nodes for any
entry in dmsetup table if it doesn't exist yet. This breaks the
assumption
Ryan Harper has proposed merging ~raharper/curtin:fix/block-sfdisk-parsing into
curtin:master.
Commit message:
Fix handing of reusing msdos partitions and flags
Disks with an MSDOS partition table and one partition with the
'bootable' flag set exposed parsing error in block.sfdisk_info;
further
The proposal to merge ~raharper/curtin:fix/udevadm-info-shlex-quote into
curtin:master has been updated.
Commit message changed to:
udev: use shlex.quote when shlex.split errors on shell-escape chars
The udev database may include shell escape characters in the output.
We want to avoid using
The proposal to merge ~raharper/curtin:fix/vmtest-centos-basic into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382704
--
Your team curtin developers is subscribed to branch
grub-multi-install is affected by this as well.
** Also affects: grub2 (Ubuntu)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of curtin
developers, which is subscribed to curtin.
https://bugs.launchpad.net/bugs/1876258
Title:
Thanks. Basic and the added ones pass. Full vmtest run is pending.
Diff comments:
> diff --git a/examples/tests/reuse-msdos-partitions.yaml
> b/examples/tests/reuse-msdos-partitions.yaml
> new file mode 100644
> index 000..bc1dbf1
> --- /dev/null
> +++
curtin 19.1 release contains this feature,
f722ef6b6bffadbe0ac5c3e7b22ae77bf8ab297d
** Merge proposal linked:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/360329
** Changed in: curtin
Status: Triaged => Fix Released
--
You received this bug notification because you
I'm marking the curtin task invalid; we believe the subiquity change
should resolve this issue.
** Changed in: curtin
Status: Incomplete => Invalid
--
You received this bug notification because you are a member of curtin
developers, which is subscribed to curtin.
I believe this commit should resolve this:
https://github.com/CanonicalLtd/subiquity/commit/f9eb715108c1289eb19f48946f7216964373b91f
I'm not sure if that's been published in edge yet.
** Also affects: subiquity (Ubuntu)
Importance: Undecided
Status: New
** Changed in: subiquity
I'm marking subiquity task invalid, the changes made were in curtin.
The outstanding issue we see with this scenario is related to multipath-
tools itself. We can reopen this task if we find that subiquity needs
to do something different.
** Changed in: subiquity
Status: New => Invalid
The proposal to merge
~raharper/curtin:feature/add-unittest-multipath-part-handler into curtin:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382877
--
Your team curtin developers is
py3-flake8 runtests: commands[0] |
/jenkins/servers/server/workspace/curtin-autoland-test/nodes/metal-amd64/curtin/.tox/py3-flake8/bin/python
-m flake8 curtin tests/
curtin/block/bcache.py:322:31: E741 ambiguous variable name 'l'
curtin/block/bcache.py:323:30: E741 ambiguous variable name 'l'
Review: Needs Fixing
Thanks for getting something started. The origin of this scenario comes from
the Subiquity installer which handles writing a network configuration into the
target outside of curtin and cloud-init. In this scenario, subiquity provides
*no* network config at all to curtin,
Ryan Harper has proposed merging
~raharper/curtin:fix/block-discover-skip-invalid-wwn-serial into curtin:master.
Commit message:
block-discover: ignore invalid id_serial/id_wwn values
When obtaining unique ids for identifying a block storage
device, block-discover looks for ID_WWN and ID_SERIAL
The proposal to merge ~mwhudson/curtin:lp-1876626 into curtin:master has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/383319
--
Your team curtin developers is subscribed to branch curtin:master.
--
The proposal to merge ~mwhudson/curtin:lp-1876626 into curtin:master has been
updated.
Commit message changed to:
block.detect_multipath: ignore fake "devices" from /proc/mounts
A tmpfs can be mounted with any old junk in the "device" field and
unfortunately casper sometimes puts "/dev/shm"
Review: Approve
Thanks!
--
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/383319
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe :
The proposal to merge ~raharper/curtin:fix/block-sfdisk-parsing into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/383180
--
Your team curtin developers is subscribed to branch
The proposal to merge
~raharper/curtin:fix/block-discover-skip-invalid-wwn-serial into curtin:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/383547
--
Your team curtin developers is requested
Ryan Harper has proposed merging
~raharper/curtin:fix/makefile-drop-nosetest-command into curtin:master.
Commit message:
Makefile: make adjustments to call lint/style tools via python module
- Drop nosetest invocation
- Drop tools/run-pyflakes*
- Add pylint targets
- Add pylintopts
Thanks Chad, I'll update with some suggested changes.
Diff comments:
> diff --git a/curtin/commands/curthooks.py b/curtin/commands/curthooks.py
> index 4afe00c..f705711 100644
> --- a/curtin/commands/curthooks.py
> +++ b/curtin/commands/curthooks.py
> @@ -682,28 +683,6 @@ def setup_grub(cfg,
Spurious failure on ppc64 node; could be lab vpn related; I was having some
trouble as well. I think autolander will retry.
--
https://code.launchpad.net/~mwhudson/curtin/+git/curtin/+merge/383319
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list:
Review: Needs Fixing
Thanks for the refactor. I think we can simplify a few things. Comments
inline.
Diff comments:
> diff --git a/curtin/commands/apply_net.py b/curtin/commands/apply_net.py
> index ddc5056..8e5596b 100644
> --- a/curtin/commands/apply_net.py
> +++
Thanks Chad, I looked into git history, and it turns out that
the docs had not been updated to indicate the change in behavior
we introduced when we added support for reordering uefi menu.
The maas team added that switched to defaulting update_nvram
to True.
I'll update the docs to match the
Ryan Harper has proposed merging
~raharper/curtin:fix/partition-verify-flags-msdos-primary-types into
curtin:master.
Commit message:
verify_ptable_flag: dos primary partitions use ptable_uuid map for flag
Curtin currently special-cases verifying MSDOS 'boot', 'extended'
and 'logical' flags
Review: Needs Fixing
Thanks for updating. I've added some more inline comments.
>From your last comments:
> but I had to skip some tests that directly used the network state. However
> this is not the case for the disabled config test with a version key. Maybe
> we could always return a
Thanks, a couple more comments inline.
Diff comments:
> diff --git a/curtin/commands/curthooks.py b/curtin/commands/curthooks.py
> index 4afe00c..e0498f6 100644
> --- a/curtin/commands/curthooks.py
> +++ b/curtin/commands/curthooks.py
> @@ -1155,7 +1155,7 @@ def detect_required_packages(cfg,
>
Review: Approve
--
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/383861
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe :
Public bug reported:
In the server install discourse page, users found a config option
used to control whether curtin will re-order grub entries
https://discourse.ubuntu.com/t/please-test-autoinstalls-
for-20-04/15250/121
This is not documented.
** Affects: curtin
Importance: Undecided
Ryan Harper has proposed merging ~raharper/curtin:fix/tip-flake8 into
curtin:master.
Commit message:
Replace 'l' for 'L' to make tip flake8 happy
- Update and renaming tox environment flake8 -> tip-flake8 to reproduce
flake8 failure on 3.8.0 flake8 release.
LP: #1878236
Requested revi
> The autoland job just runs a plain 'tox' on the source tree [1], and I
> can reproduce that problem locally on my Groovy system.
Looks like tox.ini needs a tip-flake8 so we can reproduce this elsewhere.
>
> It's annoying when the autolander job runs in this kind of loop. One
> easy way to
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/383810
--
https://code.launchpad.net/~falcojr/curtin/+git/curtin/+merge/383601
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to :
Ryan Harper has proposed merging
~raharper/curtin:vmtest/enable-kernel-crashdump into curtin:master.
Commit message:
vmtest: trigger guest panic to fail fast
A number of vmtest scenarios trigger stuck or hung kernels and leave
the VM running in such state which continues to consume resources
Review: Needs Fixing
Thanks for the Merge Proposal (MP). I failed to bring up how we land changes,
so this is my fault.
1) Please move your Description into the 'Set Commit Message' box; the
autolander here won't use the description and complains when it's set at
landing time.
2) The
The proposal to merge ~raharper/curtin:fix/makefile-drop-nosetest-command into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/383563
--
Your team curtin developers is requested to review
Thanks!
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/383563
Your team curtin developers is requested to review the proposed merge of
~raharper/curtin:fix/makefile-drop-nosetest-command into curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to :
> Dan Watkins (daniel-thewatkins) wrote on 2020-05-01:
> `--json` was introduced in util-linux 2.27[0] which means it isn't present
> pre-xenial[1] or in Centos 7[2]. Is that an issue?
>
>
> [0]
> https://github.com/karelzak/util-linux/blob/master/Documentation/releases/v2.27-ReleaseNotes#L611
> Dan Watkins (daniel-thewatkins) wrote on 2020-05-04:
> Should we be raising this error in all the other places that we're using
> sfdisk_info?
For block-meta, I'll move this check to partition_verify which is the entry to
the verify partition code paths. We then pass the asserted value info
Thanks Chad, I'll update with some suggested changes.
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
The proposal to merge ~raharper/curtin:fix/block-sfdisk-parsing into
curtin:master has been updated.
Commit message changed to:
Fix handing of reusing msdos partitions and flags
Disks with an MSDOS partition table and one partition with the
'bootable' flag set exposed a parsing error in
> Dan Watkins (daniel-thewatkins) wrote on 2020-05-04:
> Why 0x and not 0X?
we .upper() the value anyhow? Either is fine.
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/383180
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list:
Diff comments:
> diff --git a/curtin/block/__init__.py b/curtin/block/__init__.py
> index a7fe22f..97596e1 100644
> --- a/curtin/block/__init__.py
> +++ b/curtin/block/__init__.py
> @@ -248,46 +248,47 @@ def _lsblock(args=None):
> return _lsblock_pairs_to_dict(out)
>
>
> -def
We do squash merge commits (for historic reasons that have to do with bazaar;
which did squash merges, but kept the original commit history "hidden"). So
the box is what's going into the commit history for this item.
w.r.t the format, yeah, no LP and single line commit is ok, just needs to be
Review: Needs Information
Thanks, one more question on the vmtests; it's not clear to me why we've got
network-disabled tests in test_network.py rather than both of those classes in
test_network_disabled.py and have the two different config versions subclass
from your main TestNetMetaDisabled
On Wed, May 20, 2020 at 1:43 PM Lucas Albuquerque Medeiros de Moura <
lucas.mo...@canonical.com> wrote:
> Wait, I think I missed something for these scenarios:
>
> network: {config: disabled}
> network: {config: disabled, version=1}
>
> We should not create the
This looks good! I think we can update one or more of our raid vmtests config
to use the extended name; and we'll likely want to add a vmtest *unittest* to
verify we find the device in /dev/md/
See examples/tests/raid5boot.yaml and
tests/vmtests/test_mdadm_bcache.py:TestRaid5bootAbs
--
For the three scenarios:
net-meta mode=disabled
network: {config: disabled}
network: {config: disabled, version=1}
We need to check that in the target system, we do not find
/etc/cloud/cloud.cfg.d/50-curtin-networking.cfg
So, let's put that unittest in its own base class and then
build each
The proposal to merge ~legovini/curtin:update-maas-streams-url into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
--
Your team curtin developers is subscribed to branch
We may need to pull and push this directly to master if the autolander is going
to fail as well.
--
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post
Review: Approve
I'm +1 on this; did we file an RT or some thing to let them know the old URL
does not get to the right place?
--
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list:
I notified in #maas about the URL breaking. I'm pushing this branch to master
so we can autoland again.
--
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/384245
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list:
Merged a fix for the streams url, marking approved to re-run the autolander
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to :
The proposal to merge ~raharper/curtin:fix/replace-grub-shell-helper into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
--
Your team curtin developers is subscribed to branch
Review: Needs Fixing
I see, unittests around vmtest results. For those tests we can mark them a
skiptests; we don't expect to verify the network config of the target machine
when it's been disabled.
This looks really good. Just a couple more small points inline.
Diff comments:
> diff
Review: Needs Fixing
> I still have to test this simulating a hung kernel, but the panic +
> no-reboot logic looks nice and solid.
I suppose should add a vmtest (not enabled by default, I think) which triggers
a panic. For curtin, we'd just run an early command like so:
echo c >
1 - 100 of 270 matches
Mail list logo
