RE: [Patch] Proxy command-line argument

2008-02-01 Thread Dave Korn
Well, after some very minor refactoring and reformatting, here's what I will commit (in twelve hours or so, unless anyone raises any issue between now and then). It builds cleanly and I tested that it works by installing a couple of packages through Tor[*] and found no problems. Thanks

Re: [Patch] Proxy command-line argument

2008-01-31 Thread Vincent Privat
Is the patch OK ? Vincent 2008/1/28, Dave Korn [EMAIL PROTECTED]: On 28 January 2008 09:45, Corinna Vinschen wrote: Is any of you setup guys going to look into this patch? Brian? Dave? Igor? I'll have a look at it after work this evening if nobody else gets to it first.

RE: [Patch] Proxy command-line argument

2008-01-31 Thread Dave Korn
On 31 January 2008 08:05, Vincent Privat wrote: Before we even get started: Thanks for your contribution! We're pretty under resourced here and every little bit really helps :) Is the patch OK ? It patched and compiles fine. I haven't had time to test it yet, but it looks fairly

Re: [Patch] Proxy command-line argument

2008-01-31 Thread Warren Young
Dave Korn wrote: + std::string proxyString(((std::string)ProxyOption).c_str()); I'm not a C++ expert, so maybe I'm missing something, but if I read that right you're taking ProxyOption (type StringOption), calling the std::string conversion operator to return a std::string, getting a const

Re: [Patch] Proxy command-line argument

2008-01-28 Thread Corinna Vinschen
On Jan 21 09:02, Vincent Privat wrote: On Mon, Jan 21, 2008 at 12:19:56AM -0500, Christopher Faylor wrote: Please provide this as an actual patch: http://en.wikipedia.org/wiki/Patch_%28Unix%29 A patch is basically just a diff -du old new. Sending the whole file makes it hard to figure

RE: [Patch] Proxy command-line argument

2008-01-28 Thread Dave Korn
On 28 January 2008 09:45, Corinna Vinschen wrote: Is any of you setup guys going to look into this patch? Brian? Dave? Igor? I'll have a look at it after work this evening if nobody else gets to it first. cheers, DaveK -- Can't think of a witty .sigline today

Re: [Patch] Proxy command-line argument

2008-01-21 Thread Vincent Privat
On Mon, Jan 21, 2008 at 12:19:56AM -0500, Christopher Faylor wrote: Please provide this as an actual patch: http://en.wikipedia.org/wiki/Patch_%28Unix%29 A patch is basically just a diff -du old new. Sending the whole file makes it hard to figure out what you've changed. If possible, a patch

[Patch] Proxy command-line argument

2008-01-20 Thread Vincent Privat
Hi, I made a small patch to setup.exe. It adds the following command line argument: -p --proxy HTTP/FTP proxy (host:port) The only modified file is net.cc, which is attached to this mail. Basically, the modifications are: - Inclusion of sstream and getopt++/StringOption.h - Addition of static

Re: [Patch] Proxy command-line argument

2008-01-20 Thread Christopher Faylor
On Mon, Jan 21, 2008 at 12:19:56AM -0500, Christopher Faylor wrote: On Mon, Jan 21, 2008 at 02:38:35AM +0100, Vincent Privat wrote: The only modified file is net.cc, which is attached to this mail. Basically, the modifications are: - Inclusion of sstream and getopt++/StringOption.h - Addition of

Re: [Patch] Proxy command-line argument

2008-01-20 Thread Christopher Faylor
On Mon, Jan 21, 2008 at 02:38:35AM +0100, Vincent Privat wrote: I made a small patch to setup.exe. It adds the following command line argument: -p --proxy HTTP/FTP proxy (host:port) Thanks! The only modified file is net.cc, which is attached to this mail. Basically, the modifications are: -