Re: Fixed patch for install.cc

2003-03-12 Thread Robert Collins
On Mon, 2003-03-10 at 09:09, Pavel Tsekov wrote: Changelog entry: 2003-03-09 Pavel Tsekov [EMAIL PROTECTED] * install.cc (do_install_thread): Use IDS_SKIP_PACKAGE instead of IDS_CORRUPT_PACKAGE when asking the user to take action if the hash verification check fails

Re: Pending setup patches (issue 6)

2003-03-10 Thread Robert Collins
On Mon, 2003-03-10 at 15:33, Robert Collins wrote: * Going back, changing the local cache dir, and going forward again does not correctly reparse inis in the new dir. Reproduction: Choose an incorrect cache dir, go back, correct it. Chooser shows all packages in Misc. Fixed

From the TODO

2003-03-10 Thread Robert Collins
* Toggling from All Default to All Install takes *way* too long. This takes under 1/10th of a second on my PC. I need a testcase, or more info. Rob -- GPG key available at: http://users.bigpond.net.au/robertc/keys.txt. signature.asc Description: This is a digitally signed message part

Re: [PATCH] Postinstall script ordering in setup - take 2

2003-03-10 Thread Robert Collins
On Mon, 2003-03-10 at 16:18, Igor Pechtchanski wrote: Sure they can. All it takes is two maintainers marking the other script as a requirement. Oh, of course you can *have* circular dependences, but you can't *honor* them. Script dependences mean that some script has to be run before

/etc/setup.conf

2003-03-10 Thread Robert Collins
Ok, a few pragmatic thoughts: * When do we parse it? It's not trivial: - if we parse on startup, and the user changes the cygwin / path during runtime, should we revert to defaults? - if we wait for the / path to be chosen, we can't store any pre- / dialog settings. - if we parse on startup, and

Re: Setup cvs HEAD build problems

2003-03-10 Thread Robert Collins
On Mon, 2003-03-10 at 15:48, Igor Pechtchanski wrote: Rob, There was a follow-up message: http://cygwin.com/ml/cygwin-apps/2002-10/msg00152.html That eliminates #1. I don't know how to fix #2 -- could have something to do with cvs checkout timestamps. I don't believe it was addressed,

starter for usersettings persistence

2003-03-10 Thread Robert Collins
I've observed that dynamic registration always seems to give folks pause, so I've added a couple of classes to setup to begin the user persistence codefest... UserSettings: Registry of UserSetting. UserSetting: A user setting. should be the entry point for the logic of the parser and

Release candidate snapshot

2003-03-10 Thread Robert Collins
Ok, I've fixed * compress_bz::error called appears in the log every time a package is installed, even if everything works. So, setup-3.324 (now 325 due to the UserSetting addition) (snapshot uploading :}) should be considered a release candidate. Pending confirmation of the correctness of the

Re: Pending setup patches (issue 2)

2003-03-10 Thread Robert Collins
On Mon, 2003-03-10 at 16:03, Igor Pechtchanski wrote: Sounds fine. I got the first part mostly done (it'll be a run script, output to file idiom). The second might take some time... I'll probably have to use mktemp() or something similar. Just use the postinstall.log you where planning to

Re: [Approval?] Revert whitespace-only 20000401 change tosetup/zlib

2003-03-10 Thread Robert Collins
On Mon, 2003-03-10 at 21:30, Max Bowsher wrote: On 2401, there was a commit to setup/zlib, log message Eliminate \r in line endings. I hypothesize that the repository files might have been d2u-ed at some point, because there are *no* \r's in any revision. This change also stripped

Re: [Approval?] Revert whitespace-only 20000401 change tosetup/zlib

2003-03-10 Thread Robert Collins
On Mon, 2003-03-10 at 22:04, Max Bowsher wrote: NB: I have verified this will NOT introduce \r characters into the files. MM, it would be easier for you to use patch -l :]. 1) patch won't be involved in the process at all Huh? Then I've misunderstood. 2) I think gratuitous

Re: [Approval?] Revert whitespace-only 20000401 change tosetup/zlib

2003-03-10 Thread Robert Collins
On Tue, 2003-03-11 at 03:36, Max Bowsher wrote: Robert Collins wrote: On Mon, 2003-03-10 at 22:04, Max Bowsher wrote: NB: I have verified this will NOT introduce \r characters into the files. MM, it would be easier for you to use patch -l :]. 1) patch won't be involved

Re: From the TODO

2003-03-10 Thread Robert Collins
On Tue, 2003-03-11 at 02:28, Max Bowsher wrote: Robert Collins wrote: * Toggling from All Default to All Install takes *way* too long. This takes under 1/10th of a second on my PC. I need a testcase, or more info. I can no longer reproduce. Suggest deleting from TODO

Re: Setup cvs HEAD build problems

2003-03-10 Thread Robert Collins
On Tue, 2003-03-11 at 03:37, Max Bowsher wrote: Ok, well I'm going to practice delegation here: Max - when you look at zlib, can you ensure that the timestamps on zlib's autotool files are correctly ordered? Delegation accepted, but I think it's potentially more complicated than that.

Re: /etc/setup/setup.cfg ?

2003-03-10 Thread Robert Collins
On Tue, 2003-03-11 at 03:54, Max Bowsher wrote: Either we disallow comments, or we keep the order, IMO. ^^^ My vote. Ok, we are starting down a rabbit hole. Whomever puts the time in can decide whether it's user editable or not. I've already listed the

Re: /etc/setup/setup.cfg ?

2003-03-10 Thread Robert Collins
On Tue, 2003-03-11 at 07:39, Robert Collins wrote: I'll add another incentive: I'll accept 'progress' patches, that refactor the code to use the emerging framework, as long as the current *behaviour* doesn't change. (i.e. we still use last-mirror etc). The first patch that starts to use

Re: From the TODO

2003-03-10 Thread Robert Collins
On Tue, 2003-03-11 at 07:50, Christopher Faylor wrote: Yep, please move to done. (I'm assuming that until the cvsadmin commands you requests, I shouldn't commit stuff?) Ok. I've made this crucial change. For the record, I don't want to get involved whenever people screw up their commit

Re: when is next release of setup.exe

2003-03-09 Thread Robert Collins
On Sun, 2003-03-09 at 22:12, Max Bowsher wrote: linda w (cyg) wrote: I tried it with eliminating the argument...seems to run... Now I'm worried...why'd it work?cause I happen to have all the right libraries in place and a generic new-user wouldn't have them? No, because that

Re: /etc/setup/setup.cfg ?

2003-03-09 Thread Robert Collins
On Mon, 2003-03-10 at 07:08, Michael A Chase wrote: On Sun, 9 Mar 2003 16:38:57 - Max Bowsher [EMAIL PROTECTED] wrote: Igor Pechtchanski wrote: There have been bits of persistent state that people wanted to store for setup. I'm proposing an Xdefaults-style setup.cfg in /etc/setup.

Re: /etc/setup/setup.cfg ?

2003-03-09 Thread Robert Collins
On Mon, 2003-03-10 at 07:58, Christopher Faylor wrote: On Mon, Mar 10, 2003 at 07:49:27AM +1100, Robert Collins wrote: Also, I'd prefer /etc/setup.rc rather that /etc/setup/setup.cfg. Wouldn't /etc/setuprc be somewhat more consistent with existing unix practices? Sure. I'm happy

Re: Pending setup patches (issue 4)

2003-03-09 Thread Robert Collins
On Mon, 2003-03-10 at 05:59, Elfyn McBratney wrote: Do you think that a fixed set of colours is OK, or do I need to make them customizable? Erm.. I think fixed is fine for now and perhaps fixed could be a TODO? No. Colour is one of those areas where bad choices make it all-but-impossible

Re: Pending setup patches (issue 4)

2003-03-09 Thread Robert Collins
On Mon, 2003-03-10 at 02:57, Igor Pechtchanski wrote: On Sun, 9 Mar 2003, Max Bowsher wrote: I like this feature too. However, the colors definitely have to be configurable. I could fix it, but then how do I submit the changes? A patch to a patch? :-| Or do I regenerate your patch from

Re: --disabled-shared = hang?

2003-03-09 Thread Robert Collins
On Mon, 2003-03-10 at 05:23, Max Bowsher wrote: linda w (cyg) wrote: Dangitthought I sent this out again checking whether stripping libraries is possible... yes checking dynamic linker characteristics... Win32 ld.exe Without the arg it went though, did make

Re: --disabled-shared = hang?

2003-03-09 Thread Robert Collins
On Mon, 2003-03-10 at 11:05, Christopher Faylor wrote: On Mon, Mar 10, 2003 at 08:53:06AM +1100, Robert Collins wrote: Does it hang in the setup configure, the libgetopt++ configure, or some other configure? (There's not enough context given so far to tell). It's not hanging for me at all

RE: --disabled-shared = hang?

2003-03-09 Thread Robert Collins
On Mon, 2003-03-10 at 12:42, linda w (cyg) wrote: Problem magically went away. Perhaps, technically, something should have cleaned up something somewhere, but I wouldn't worry about it. Just an oddity Ah well. *shrug*. Rob signature.asc Description: This is a digitally signed

Re: /etc/setup/setup.cfg ?

2003-03-09 Thread Robert Collins
On Mon, 2003-03-10 at 13:11, Elfyn McBratney wrote: How about [/etc/]setup.conf ? it follows the (other) unix convention of configuration file naming. Thank you. That works for everyone I think. Rob -- GPG key available at: http://users.bigpond.net.au/robertc/keys.txt. signature.asc

Re: Setup cvs HEAD build problems

2003-03-09 Thread Robert Collins
Igor, have we address points 1 2 below? I don't recall... Rob On Fri, 2002-10-18 at 14:08, Igor Pechtchanski wrote: Hi, Just checked setup out from cvs (:pserver:[EMAIL PROTECTED]:/cvs/cygwin-apps) and tried to build. I created a new directory, from there ran $(SETUP_SOURCE)/configure with

Re: [PATCH] Postinstall script ordering in setup - take 2

2003-03-09 Thread Robert Collins
On Wed, 2003-03-05 at 11:41, Igor Pechtchanski wrote: On 5 Mar 2003, Robert Collins wrote: On Wed, [EMAIL PROTECTED]:19, Igor Pechtchanski wrote: On 5 Mar 2003, Robert Collins wrote: Using the packages as dependencies we can build the same topological tree based on the packages

Re: Pending setup patches (issue 2)

2003-03-09 Thread Robert Collins
On Wed, 2003-03-05 at 11:52, Igor Pechtchanski wrote: On 5 Mar 2003, Robert Collins wrote: Other than that, please expand to address all scripts. Rob Rob, There is a design issue here that I'd like to address before I work more on this. I recall your comment that this should be tied

Re: Pending setup patches (issue 6)

2003-03-09 Thread Robert Collins
On Mon, 2003-03-10 at 02:16, Max Bowsher wrote: Patches held to allow feedback: ~~~ * Remove autotool-generated files from CVS Will happen on Thurs 13th March if no objections received by then. I'll do this one (assuming no objections)... gives me some

Re: I think I've GOT IT! The Cannot open (null) for readingbug!!!

2003-03-08 Thread Robert Collins
On Sun, 2003-03-09 at 07:41, Max Bowsher wrote: I traced it to this curious condition: pkg.desired.sourcePackage() == false pkg.desired.sourcePackage().picked() == true How? Well, it turns out that the defaultversion placeholder object used, amongst other circumstances, when a

Re: He wrote, then she wrote, ... (was RE: when is next release ofsetup.exe)

2003-03-08 Thread Robert Collins
On Sun, 2003-03-09 at 11:17, Christopher Faylor wrote: So, for you to get snapshot access, ask Chris for a) scp upload access b) write access to the setup-snapshots directory. Don't ask Chris. Go to http://sourceware.org/ and fill out the form referenced on that page. List [EMAIL

Re: ChangeLog README changes?

2003-03-08 Thread Robert Collins
On Sun, 2003-03-09 at 13:42, Max Bowsher wrote: Robert: Should I write ChangeLog entries for README changes? I was thinking no, but then I noticed you did, today. Up to you. I thought importing the list of bugs was worthy. Rob -- GPG key available at:

Re: [setup TODO] Proposed reshuffle of items

2003-03-08 Thread Robert Collins
On Sun, 2003-03-09 at 13:58, Max Bowsher wrote: Here is the contents of the setup TODO, and some comments on how I think the items should be dealt with. * Mirrors list orer is snafued. It's the same order as in the release (2.249.2.5) setup. Therefore I propose deleting this item, and add

Re: Preliminary colour-coding patch (was: Pending setup patches (issue 2))

2003-03-08 Thread Cygwin \(Robert Collins\)
=== - Original Message - From: Max Bowsher [EMAIL PROTECTED] I had anticipated some change in the design though (http://sources.redhat.com/ml/cygwin-apps/2003-01/msg00362.html) I was anticipating the need to customize the colours. Re-designing would be premature until that has been

Re: Setup Bug Collation

2003-03-08 Thread Cygwin \(Robert Collins\)
I've merged this into the README. Thanks Max, Rob === - Original Message - From: Max Bowsher [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Thursday, December 12, 2002 6:06 AM Subject: Setup Bug Collation The new setup snapshot 2.303 has been out a while now, and there have been a

Re: Removing concat.cc/h

2003-03-08 Thread Cygwin \(Robert Collins\)
=== - Original Message - From: Max Bowsher [EMAIL PROTECTED] What is policy for setup? Should we regenerate Makefile.in (and aclocal.m4, and any other relevent files) with the current Cygwin release of automake, since we are changing it at all, or would you prefer to keep it at the

Re: Pending setup patches (issue 3)

2003-03-08 Thread Cygwin \(Robert Collins\)
=== - Original Message - From: Max Bowsher [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, March 05, 2003 12:25 PM Subject: Pending setup patches (issue 3) Updated: * Remove concat.* In http://sources.redhat.com/ml/cygwin-apps/2003-02/msg00022.html Applied. Rob

Re: Pending setup patches (Re: [PATCH] Re: Removing concat.cc/h)

2003-03-08 Thread Cygwin \(Robert Collins\)
=== - Original Message - From: Max Bowsher [EMAIL PROTECTED] * Igor's error message patch http://sources.redhat.com/ml/cygwin-apps/2003-02/msg00017.html Commited. I still suspect we need a = rather than == - but we'll see :}. Rob

Re: Pending setup patches (Re: [PATCH] Re: Removing concat.cc/h)

2003-03-08 Thread Cygwin \(Robert Collins\)
=== - Original Message - From: Max Bowsher [EMAIL PROTECTED] * Pavel's patch for Exceptions freeing their messages too early http://sources.redhat.com/ml/cygwin-apps/2003-02/msg00176.html Applied. Rob

Re: Pending setup patches (Re: [PATCH] Re: Removing concat.cc/h)

2003-03-08 Thread Cygwin \(Robert Collins\)
=== - Original Message - From: Max Bowsher [EMAIL PROTECTED] * Pavel's Do not uninstall if upgrade package fails md5 patch http://sources.redhat.com/ml/cygwin-apps/2003-02/msg00178.html Pavel, This patch was missing IDS_CRC_ERROR definitions, even though it used it. Tsk! I've

queue semi-flushed

2003-03-08 Thread Cygwin \(Robert Collins\)
Well, I've reviewed / applied the bulk of the queue. There is a new snapshot of HEAD being uploaded as I type. To get this released we need to work through the bugs in README. Given the number of features already added to HEAD, I consider new feature patchs lowest priority, and patches solving

Re: I think I've GOT IT! The Cannot open (null) for readingbug!!!

2003-03-08 Thread Cygwin \(Robert Collins\)
=== - Original Message - From: Max Bowsher [EMAIL PROTECTED] To: Robert Collins [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Sent: Sunday, March 09, 2003 10:08 AM Subject: Re: I think I've GOT IT! The Cannot open (null) for readingbug!!! Robert Collins wrote: On Sun, 2003-03-09 at 07:41

Re: He wrote, then she wrote, ... (was RE: when is next release of setup.exe)

2003-03-08 Thread Cygwin \(Robert Collins\)
=== - Original Message - From: linda w (cyg) [EMAIL PROTECTED] I didn't know it was in reference to the CVS...I just tried current released source for current released setup with current released tools -- which I realize (now) was completely naive of me. :-/ Naive, yes. Foolish no.

Re: when is next release of setup.exe

2003-03-08 Thread Cygwin \(Robert Collins\)
=== - Original Message - From: vijay kiran kamuju [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Saturday, March 08, 2003 6:00 PM Subject: when is next release of setup.exe hi, when is it going to be the next release of the the setup.exe with all the CURRENT PATCHES, i need it asap.

Re: LPRng was Re: Pending packages status

2003-03-08 Thread Cygwin \(Robert Collins\)
Max Bowsher wrote: IMO, a simple bootstrap.sh containing the appropriate autotool commands would be better. A source release for a binary package isn't supposed to require autotools. IIRC, this is GNU standards mandated; if not it certainly is autoconf mandated. The configure script

Re: He wrote, then she wrote, ... (was RE: when is next release of setup.exe)

2003-03-08 Thread Cygwin \(Robert Collins\)
=== - Original Message - From: Max Bowsher [EMAIL PROTECTED] To: Cygwin (Robert Collins) [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Sunday, March 09, 2003 10:56 AM Subject: Re: He wrote, then she wrote, ... (was RE: when is next release of setup.exe) Cygwin (Robert Collins) wrote

Re: He wrote, then she wrote, ... (was RE: when is next release of setup.exe)

2003-03-08 Thread Cygwin \(Robert Collins\)
=== - Original Message - From: Max Bowsher [EMAIL PROTECTED] To: Cygwin (Robert Collins) [EMAIL PROTECTED]; [EMAIL PROTECTED] Sent: Sunday, March 09, 2003 10:56 AM Subject: Re: He wrote, then she wrote, ... (was RE: when is next release of setup.exe) Cygwin (Robert Collins) wrote

Re: Pending setup patches (Re: [PATCH] Re: Removing concat.cc/h)

2003-03-08 Thread Cygwin \(Robert Collins\)
=== - Original Message - From: Igor Pechtchanski [EMAIL PROTECTED] I still suspect we need a = rather than == - but we'll see :}. Rob Only if files is traversed in order of decreasing minlevel. Otherwise we'd have to traverse the whole set before we can find the right log file.

Re: Pending packages status

2003-03-07 Thread Robert Collins
On Sat, 2003-03-08 at 06:44, Max Bowsher wrote: IIRC, setup works exclusively by curr/prev/test and doesn't parse versions at all. And upset may not order -0.* correctly, but it doesn't choke. I have a package whose release is 0.max currently in my local upset tree. It parses the package

Re: [PATCH] Re: proxy setup help

2003-03-07 Thread Robert Collins
On Sat, 2003-03-08 at 07:50, Max Bowsher wrote: Should do it. Except it doesn't work - the OK button is still disabled. Ah:[. Would you like me to also remove the check on *passwd here: static void check_if_enable_ok (HWND h) { int e = 0; if (*user *passwd) Well, that should

Re: [PATCH] Re: proxy setup help

2003-03-07 Thread Robert Collins
On Sat, 2003-03-08 at 09:07, Max Bowsher wrote: It's more kludgy. You're changing the behaviour of a low level tool in a way that produces scattered changes, rather than isolating the needed changes and addressing those. I prefer to see it as fixing a low level tool, but nevermind, I

Re: Proposal: Remove autotool-generated files from setup CVS

2003-03-06 Thread Robert Collins
On Thu, 2003-03-06 at 20:52, Marcel Telka wrote: $0.02: What about one `autoreconf` call instead of twiddling with autoconf/automake/autoheader/auto... call order? Blurk. If you're comfortable with autoreconf, just run it directly. Bootstrap exists to do the right thing for us. Rob --

Re: Pending packages status

2003-03-06 Thread Robert Collins
On Thu, 2003-03-06 at 22:00, Pavel Tsekov wrote: On Thu, 6 Mar 2003, Daniel Bößwetter wrote: Pavel Tsekov wrote: No. You should not touch this number until the first release of your package is out. Please, rename the package files. As you wish. I changed all occurences back

Re: Proposal: Remove autotool-generated files from setup CVS

2003-03-05 Thread Robert Collins
On Thu, 2003-03-06 at 07:05, Max Bowsher wrote: I propose removing autotool-generated files from setup CVS. I am ok with this. I'm not going to participate in a flamefest like that occuring when I introduced libgetopt++ w/o generated files. So... if no-one speaks up against this in the next

RE: Setup: LogFile::exit

2003-03-04 Thread Robert Collins
On Tue, 2003-03-04 at 19:10, Gary R. Van Sickle wrote: How about just replace it with a flush() member? As long as you track down *all* the exit points and ensure they call it. Safer IMO to a) fix static object destructors or b) exit via the log object. Rob -- GPG key available at:

Re: [PATCH] Postinstall script ordering in setup

2003-03-04 Thread Robert Collins
On Wed, 2003-03-05 at 01:58, Igor Pechtchanski wrote: Rob, Thanks for the review. Comments below... This does too much. When a method does more than one thing... split it up. This does it by calling 3 functions. It's a 7-line function. :-D I guess my eagerness to make the changelog

Re: Cygwin setup crashes

2003-03-04 Thread Robert Collins
On Wed, 2003-03-05 at 06:05, Max Bowsher wrote: Pavel Tsekov wrote: On Tue, 4 Mar 2003, Pavel Tsekov wrote: Now i see something really interesting. The patch the I wanted to be backported to 200206, seems to be applied incorrectly to HEAD. I think this is the real cause of the

Re: [PATCH] Postinstall script ordering in setup - take 2

2003-03-04 Thread Robert Collins
On Wed, 2003-03-05 at 05:37, Christopher Faylor wrote: Of course, maybe it's only because I don't have to change upset, but still... Just wait for the first X doesn't install correctly when Y isn't installed, and I checked, and Y-install.sh is in the list for the X-instal script resulting from

Re: [PATCH] Postinstall script ordering in setup - take 2

2003-03-04 Thread Robert Collins
On Wed, 2003-03-05 at 05:52, Max Bowsher wrote: I'm thinking about passwd-grp.sh mainly. No. Package authors have enough info to describe their requirements such that setup will DoTheRightThing. Rob -- GPG key available at: http://users.bigpond.net.au/robertc/keys.txt. signature.asc

Re: Pending setup patches (issue 2)

2003-03-04 Thread Robert Collins
On Wed, 2003-03-05 at 07:41, Max Bowsher wrote: How about http://cygwin.com/ml/cygwin-apps/2002-10/msg00129.html ? This is pretty old, but I can regenerate it against the current CVS if people think it's a good idea. This is also a where-do-we-go-from-here patch... Sounds like a

Re: Pending setup patches (issue 2)

2003-03-04 Thread Robert Collins
On Wed, 2003-03-05 at 07:41, Max Bowsher wrote: * Patch I forwarded from Brian Keener, for adding extra views http://sources.redhat.com/ml/cygwin-apps/2003-01/msg00346.html Ok, reviewed again to refresh my memory. Brian, Why do you change the scroll bar behaviour? Thats orthogonal to the

Re: Pending setup patches (issue 2)

2003-03-04 Thread Robert Collins
On Wed, 2003-03-05 at 08:58, Robert Collins wrote: Other than that, please expand to address all postinstall scripts. s/postinstall// :}. Rob -- GPG key available at: http://users.bigpond.net.au/robertc/keys.txt. signature.asc Description: This is a digitally signed message part

Re: [PATCH] Postinstall script ordering in setup

2003-03-03 Thread Robert Collins
On Tue, 2003-03-04 at 15:36, Igor Pechtchanski wrote: Hi, This patch adds a dependence tracking mechanism to postinstall scripts. The idea is essentially the one described in http://cygwin.com/ml/cygwin-apps/2003-03/msg00022.html. This patch is very preliminary, and not tested much beyond

Re: Setup: LogFile::exit

2003-03-01 Thread Robert Collins
On Sun, 2003-03-02 at 13:30, Gary R. Van Sickle wrote: Rob, LogFile::exit() actually exit()s Setup, i.e. main() never returns under any circumstances. This doesn't seem like a good thing to me; it's not at all clear to me why a logging object should as a matter of course be responsible for

Re: A new version of setup very soon?

2003-02-28 Thread Robert Collins
On Fri, 2003-02-28 at 15:20, Christopher Faylor wrote: I would really appreciate it if we could release a new version of setup.exe with (at least) Pierre Humblet's ntsec changes soon. I think it is becoming very clear that Pierre's ntsec changes are required if we want sane behavior for

Re: ntsec patch for setup

2003-02-28 Thread Robert Collins
On Fri, 2003-02-28 at 22:44, Pavel Tsekov wrote: Here is the same patch modified to be applied on main.cc from setup-200207 branch. This looks reasonable. Pavel, if you have write access, please commit to the setup-200207 branch, otherwise, Max - if you have time could you? Failing that, I'll

Re: ntsec patch for setup

2003-02-28 Thread Robert Collins
On Sat, 2003-03-01 at 01:32, Max Bowsher wrote: I can commit ASAP, once this issue is talked out, but I think it might be wise to use 200206 for an interim release now, unless Robert is very sure 200207 is OK. 200206. I wasn't thinking for a sec there. Rob -- GPG key available at:

Re: ntsec patch for setup

2003-02-28 Thread Robert Collins
On Sat, 2003-03-01 at 05:23, Max Bowsher wrote: Robert Collins wrote: On Fri, 2003-02-28 at 22:44, Pavel Tsekov wrote: Here is the same patch modified to be applied on main.cc from setup-200207 branch. This looks reasonable. Pavel, if you have write access, please commit to the setup

Re: [PATCH] setup-200206: Do not create/etc/postinstall/passwd-grp.bat

2003-02-28 Thread Robert Collins
On Sat, 2003-03-01 at 02:45, Pavel Tsekov wrote: From the ChangeLog entry for version 2.34 of desktop.cc: * desktop.cc (etc_profile): Remove. (make_etc_profile): Remove. (uexists): Remove. (make_passwd_group): Remove. (do_desktop_setup): Don't call

Re: ntsec patch for setup

2003-02-28 Thread Robert Collins
On Sat, 2003-03-01 at 02:54, Max Bowsher wrote: I've built setup from 200206 with ntsec patch as backported by Pavel. I ran into other problems: 1) I had to merge these fixes, which enable building of setup with gcc-2. cvs upd -kk -j2.22 -j2.23 Makefile.am cvs upd -kk -j2.84 -j2.85

Re: ntsec patch for setup

2003-02-28 Thread Robert Collins
On Sat, 2003-03-01 at 03:41, Pavel Tsekov wrote: On Fri, 28 Feb 2003, Pavel Tsekov wrote: 2) gcc2 (not g++2) chokes on some lines in /usr/include/mingw/string.h. I had to patch as below, adding prototypes before the functions declared inline. There are also some complaints about

Re: ntsec patch for setup

2003-02-28 Thread Robert Collins
On Tue, 2003-01-21 at 14:00, Pierre A. Humblet wrote: At 10:24 PM 1/19/2003 -, Max Bowsher wrote: I'd suggest something like this: if (isusers) { nsid = usid; log(LOG_TIMESTAMP) Changing gid to Users endLog; } else if (isadmins) nsid = asid; log(LOG_TIMESTAMP)

Re: [PATCH] Re: Removing concat.cc/h

2003-02-25 Thread Robert Collins
this a couple of hours ago, but it didn't appear in the web archive, so I'm resending it. If the original does get through, apologies for the duplicate. On 2 Feb 2003, Robert Collins wrote: On Sun, [EMAIL PROTECTED]:37, Igor Pechtchanski wrote: [snip] Incidentally

Re: Difftools?

2003-02-08 Thread Robert Collins
On Sun, 2003-02-09 at 00:33, Max Bowsher wrote: Robert mentioned difftools, but I deleted the mail, thinking I would be able to find them with Google. No luck, so - Where can I find them? Patchutils sorry :[. The tool in question in splitdiff IIRC. Been a while since I've had to fiddle this

Re: new libxml2 / libxslt packages?

2003-02-07 Thread Robert Collins
On Sat, 2003-02-08 at 14:42, Alex Lancaster wrote: RC == Robert Collins writes: RC I hope to do a update-and-test run shortly. Updating these RC packages tends to be a little painful, or I'd do it more often :}. I feel your pain from trying to compile them from source myself

Re: new libxml2 / libxslt packages?

2003-02-07 Thread Robert Collins
On Sat, 2003-02-08 at 15:09, Alex Lancaster wrote: RC Check the changelog :]. Yes, I'm on the libx* lists, and routinely RC feed some patches back after each cygwin release. Mea culpa. I should have checked the ChangeLog before I suggested that... :-{ I actually did download the source w/

Re: base-files-mketc.sh

2003-02-03 Thread Robert Collins
On Tue, 2003-02-04 at 05:26, Igor Pechtchanski wrote: True, but doesn't mean we can't do it on initial install, at least. We could also pop up a warning box... This actually gives merit to the idea of the Advanced button, since most users probably will not go there. 'Advanced' buttons are

Re: [PATCH] Re: [setup] Inaccurate message: See /setup.log.full

2003-02-01 Thread Robert Collins
On Sun, 2003-02-02 at 07:37, Igor Pechtchanski wrote: Yes, it does recompile everything when resource.h is modified, but that only happens once. A necessary evil... Even so... resource.h urrghh. Sorry about the (null) bit. Should be fixed now. I also took your suggestion regarding log

Re: [PATCH] Re: [setup] Inaccurate message: See /setup.log.full

2003-02-01 Thread Robert Collins
On Sun, 2003-02-02 at 08:22, Max Bowsher wrote: Robert Collins wrote: getFileName doesn't take a minlevel, it takes an exactLevel - your parameter name is misleading, or you've got the logic in the loop wrong :}. Or, you could say that it gets the file whose minlevel is what you request

Re: setup: Colour code package trust levels

2003-01-31 Thread Robert Collins
On Sat, 2003-02-01 at 10:33, Max Bowsher wrote: Below is a patch which adds colour coding to the package picker. Should I conditionalize it on a boolean command line option, or do we need to be able to specify which colours to use, as opposed to whether to use colours? Deisgn wise, we

Re: [ITP] rebase

2003-01-29 Thread Robert Collins
On Thu, 2003-01-30 at 08:02, Jason Tishler wrote: Actually, I need it for proper Cygwin setup.exe operation anyway. IIRC there's an abstracted version in setup.exe you can leverage. Cheers, Rob -- GPG key available at: http://users.bigpond.net.au/robertc/keys.txt. signature.asc

Re: [ITP] rebase

2003-01-25 Thread Robert Collins
On Sat, 2003-01-25 at 22:56, Max Bowsher wrote: I hope that using the term non-persistent does not delay the voting process... Definitely not. I vote pro regardless of what name we choose. I second this. In fact, IMO this vote should really be a formality - this is core infrastructure

Re: [ITP] rebase

2003-01-25 Thread Robert Collins
On Sun, 2003-01-26 at 01:14, Max Bowsher wrote: Should this rebase maybe be a Cygwin, not MinGW version? (So that we can use POSIX paths with it?) No - you need to be able to rebase cygwin1.dll too. Rob -- GPG key available at: http://users.bigpond.net.au/robertc/keys.txt. signature.asc

Re: [ITP] rebase

2003-01-25 Thread Robert Collins
On Sun, 2003-01-26 at 14:47, Jason Tishler wrote: On Sat, Jan 25, 2003 at 11:01:45PM +1100, Robert Collins wrote: I second this. In fact, IMO this vote should really be a formality - this is core infrastructure after all. I wrestled with the category and ended up with Admin. Should

Re: new libxml2 / libxslt packages?

2003-01-24 Thread Robert Collins
On Sat, 2003-01-25 at 00:11, Nicholas Wourms wrote: [EMAIL PROTECTED] wrote: I was wondering whether there were plans to release new versions of libxml2 and libxslt. The versions that are part of Cygnus now are all rather old (by almost a year in the case of libxslt). ... I'm sure

RE: Mirrors list options

2003-01-23 Thread Robert Collins
On Fri, 2003-01-24 at 00:13, Roth, Kevin P. wrote: Another issue here is for those of us behind a corporate (or other restrictive) firewall that may not even permit UDP pings out the door. In this setup we usually have to use HTTP downloads through a proxy server. You might like to see my

Re: Mirrors list options

2003-01-23 Thread Robert Collins
On Fri, 2003-01-24 at 07:26, Max Bowsher wrote: Robert Collins wrote: Explore the command line options. There's currently no way to do that short of grepping the source code. I know. Still, this is a list for developers and maintainers - it's hardly a large barrier given the presumed skills

Re: Setup.exe: When to release? (Must-fix bugs)

2003-01-23 Thread Robert Collins
On Fri, 2003-01-24 at 10:45, Max Bowsher wrote: I think we desperately need to make a setup release, Why the urgency? Rob -- GPG key available at: http://users.bigpond.net.au/robertc/keys.txt. signature.asc Description: This is a digitally signed message part

Re: [setup] Inaccurate message: See /setup.log.full

2003-01-23 Thread Robert Collins
On Fri, 2003-01-24 at 10:51, Igor Pechtchanski wrote: and then cygpath transformation functions are used to transform its result to a Windows filename, #3 seems pretty doable... Or even more simply: Get a list of all the log files that exist and their levels, so we tell the user: see these

Re: [setup] Inaccurate message: See /setup.log.full

2003-01-23 Thread Robert Collins
On Fri, 2003-01-24 at 11:04, Igor Pechtchanski wrote: With all due respect, what you're proposing is not really simpler (although it is more complete). I was thinking more in terms of a minimal patch. What you propose will need a change in the dialog routine, won't it? At least it will if

Re: Setup.exe: When to release? (Must-fix bugs)

2003-01-23 Thread Robert Collins
On Fri, 2003-01-24 at 11:08, Max Bowsher wrote: Robert Collins wrote: On Fri, 2003-01-24 at 10:45, Max Bowsher wrote: I think we desperately need to make a setup release, Why the urgency? Because we've got lots of tweaks and little improvements here and there that it would be nice

RE: Mirrors list order is snafued - What is the order supposedto be?

2003-01-22 Thread Robert Collins
On Thu, 2003-01-23 at 16:00, Gary R. Van Sickle wrote: I think we should in any case be moving towards hiding from the average and uninterested user behind an advanced button or something, and doing an automated server-picking based on ping and even-server-load-distribution considerations.

Re: Mirrors list order is snafued - What is the order supposedto be?

2003-01-21 Thread Robert Collins
On Wed, 2003-01-22 at 05:55, Max Bowsher wrote: Nevertheless, wouldn't you agree that the treeview I proposed above would be an improvement over the current listview? No. There are several facets to resolve in the design... 1) Where do custom mirrors go? 2) What if all the mirrors in region

Re: Mirrors list order is snafued - What is the order supposedto be?

2003-01-20 Thread Robert Collins
On Mon, 2003-01-20 at 19:59, Lapo Luchini wrote: Robert Collins wrote: But: even after that is done, I think we should reexamine the sorting concept, and perhaps sort by the sources.redhat.com order (for us-site speed), or perhaps user mirrors then official, etc. I guess the best

Re: [setup PATCH] Remove pointless, worrying log message

2003-01-19 Thread Robert Collins
On Mon, 2003-01-20 at 02:25, Max Bowsher wrote: Code calls compress_bz::error() to ask *whether* an error has occurred. It is silly and scare-mongering to print compress_bz::error called to the log in this case. Ok to commit? No. We really need to implement the error checking - thats why

Re: [setup PATCH] Add Keep Button (and leave Prev button, for now)

2003-01-19 Thread Robert Collins
On Mon, 2003-01-20 at 05:03, Max Bowsher wrote: OK, my previous Keep button patch fizzled, because I was trying to remove the Prev button at the same time. So this adds Keep, whilst leaving Prev alone. OK to apply? Yes. PS: Something else to think about: Does anyone edit the setup

Re: [setup PATCH] Remove pointless, worrying log message

2003-01-19 Thread Robert Collins
On Mon, 2003-01-20 at 07:34, Max Bowsher wrote: How about this?: Robert and I promise to annoy each other into fixing the lack of error checking, and I change the log to a FIXME for now. How about this: If the error checking isn't implemented when we go to release the next setup.exe, *then*

Re: ntsec patch for setup

2003-01-19 Thread Robert Collins
On Sat, 2003-01-11 at 14:36, Pierre A. Humblet wrote: This is the patch mentioned in the previous e-mail. I seems to work fine on NT and an early version was tested on 2000 (there are differences). I'll be looking at this shortly - I am for it in principal. Rob -- GPG key available at:

Re: Setup proposal: Maintainer Features #define and AC_ARG_ENABLE

2003-01-15 Thread Robert Collins
On Thu, 2003-01-16 at 03:59, Max Bowsher wrote: Sorry to be so long in replying. Please check this in. Rob -- GPG key available at: http://users.bigpond.net.au/robertc/keys.txt. signature.asc Description: This is a digitally signed message part

<    1   2   3   4   5   6   7   8   9   10   >