Re: Ghostscript 7.05 test version ready for review, upload
Uploaded. Dario Alcocer wrote: On Mon, Jul 08, 2002 at 04:17:41PM -0400, Charles Wilson wrote: Erm, you realize that the setup.hints are supposed to be *separate* files, right? Oops, no I didn't realize this. I've split the setup.hint into three separate ones: gs-setup.hint, gs-base-setup.hint, and gs-x11-setup.hint. [snip] For ghostscript-x and ghostscript-base, you don't need a 'curr:' line -- there is no version 6.51-4 of those packages. OK, fixed. [snip] Also, you need to add a line to the ghostscript-x11 and ghostscript-base setup.hints: external-source: ghostscript OK, also fixed. I rebuilt the source package, and uploaded three new hint files, and updated the md5sum file. Please take a look when you have some time. I really appreciate you taking the time to review the package.
Re: Ghostscript 7.05 test version ready for review, upload
On Sun, Jul 07, 2002 at 02:12:39PM -0400, Charles Wilson wrote: - setup files: #1) @ ghostscript requires: cygwin libpng2 zlib ghostscript-base version: 7.05-1 You don't specify the version in setup.hint. You either a) don't include any version info at all; upset will figure it out b) specify using curr: prev: and test: key words... e.g. curr: 6.52-1 test: 7.05-1 Thanks, I've corrected the setup.hint file appropriately. requires: libpng2?? REALLY? Are you sure it isn't libpng12? Yes, you are correct, fixed the hint file, both for native and X11. #2) @ ghostscript-x11 requires: cygwin cygwin-xfree86 libpng2 zlib ghostscript-base version: 7.05-1 Also, the correct require: for xfree is 'XFree86-base'. there is no 'cygwin-xfree86' package. Fixed. #3) @ ghostscript-base category: Graphics requires: cygwin version: 7.05-1 Ditto version:. Also, this package probably doesn't directly require cygwin. It's just docs, right? Yes, just docs. I removed the requires: line. packages: -(nonx)- contains: usr/bin/* -x- contains: usr/X11R6/bin/* There are no postinstall scripts, no symlinks. I assume, then, that the -x- version was compiled so that it automatically looked outside of its own -prefix (e.g. not under /usr/X11R6/, but instead under /usr/share/ghostscript) for its runtime files. This is fine by me. Yes, this is correct; /usr/share/ghostscript stores run-time files, and this path is compiled into both native and X11 versions. However, the man pages are not under share -- yet are shared. (Not complaining, just pointing it out). I assume this was done because of the difficulties involved with changing the cygwin standard -- we'd need a new 'man' package, or everybody'd have to muck with MANPATH, etc etc. This seems like a sensible way to go, for now. Yes, I just left the manual pages in $(prefix)/man for now. I'll have to remember to change this to /usr/share/man after the 'man' package is changed. I assume we don't have to tell the package maintainer, since they're probably already aware of this. (BTW, I don't know who the 'man' maintainer is...) (Although, I've never seen localized man pages separated out that way -- is that normal?) Well, to be honest, I've never dealt with localized manual pages before, so I can't say. -src- package: is a 'method 1' package (http://www.cygwin.com/setup.html). (not complaining, just pointing it out). To make it a more compliant 'method 1' source package, I moved setup.hint into CYGWIN-PATCHES, and I renamed and moved the patch out of CYGWIN-PATCHES. BTW, refresh me on the jpeg problem? Why can't gs use the official cygwin library? Here are the comments from unix-gcc.mak, Ghostscript 6.x: # Choose whether to use a shared version of the IJG JPEG library (-ljpeg). # DON'T DO THIS. If you do, the resulting executable will not be able to # read some PostScript files containing JPEG data, because Adobe chose to # define PostScript's JPEG capabilities in a way that is slightly # incompatible with the JPEG standard. Note also that if you set SHARE_JPEG # to 1, you must still have the library header files available to compile # Ghostscript. See doc/Make.htm for more information. In summary, the packages look good -- but the setup.hints need some work. :-) OK, details mentioned above are fixed now. Please take a look again when you have the chance. (The files that changed are setup.hint, md5sum, and the source package.) -- Dario Alcocer -- Sr. Software Developer, Helix Digital Inc. [EMAIL PROTECTED] -- http://www.helixdigital.com
Re: Ghostscript 7.05 test version ready for review, upload
Dario Alcocer wrote: BTW, refresh me on the jpeg problem? Why can't gs use the official cygwin library? Here are the comments from unix-gcc.mak, Ghostscript 6.x: # Choose whether to use a shared version of the IJG JPEG library (-ljpeg). # DON'T DO THIS. If you do, the resulting executable will not be able to # read some PostScript files containing JPEG data, because Adobe chose to # define PostScript's JPEG capabilities in a way that is slightly # incompatible with the JPEG standard. Note also that if you set SHARE_JPEG # to 1, you must still have the library header files available to compile # Ghostscript. See doc/Make.htm for more information. Oh yeah, now I remember. grumble grumble Adobe grumble bastards grumble... In summary, the packages look good -- but the setup.hints need some work. :-) OK, details mentioned above are fixed now. Please take a look again when you have the chance. (The files that changed are setup.hint, md5sum, and the source package.) Erm, you realize that the setup.hints are supposed to be *separate* files, right? one for each package... eventually, on sourceware we'll have: /release/ghostscript: -src tarball binary tarball setup.hint (1) /release/ghostscript/ghostscript-x11/ binary tarball for -x11- version setup.hint (2) /release/ghostscript/ghostscript-base/ binary tarball for -base- package setup.hint (3) Where (1) contains the fragment that applies to the non-X ghostscript pacakge, (2) contains the fragment that applies to the -X ghostscript package, and (3) ... Now, it doesn't really matter HOW that information is stored inside the -src archive (at least, presently). If you want it to be all in one file, that's fine -- but you'll need to split it up into separate files *on your website* before whoever uploads it to sourceware will touch it. g -- other comments -- For ghostscript-x and ghostscript-base, you don't need a 'curr:' line -- there is no version 6.51-4 of those packages. And, since you've explicitly marked 'test:' versions, upset will NOT autoassign them to 'current'. Also, you need to add a line to the ghostscript-x11 and ghostscript-base setup.hints: external-source: ghostscript --Chuck
Re: Ghostscript 7.05 test version ready for review, upload
On Mon, Jul 08, 2002 at 04:17:41PM -0400, Charles Wilson wrote: Erm, you realize that the setup.hints are supposed to be *separate* files, right? Oops, no I didn't realize this. I've split the setup.hint into three separate ones: gs-setup.hint, gs-base-setup.hint, and gs-x11-setup.hint. [snip] For ghostscript-x and ghostscript-base, you don't need a 'curr:' line -- there is no version 6.51-4 of those packages. OK, fixed. [snip] Also, you need to add a line to the ghostscript-x11 and ghostscript-base setup.hints: external-source: ghostscript OK, also fixed. I rebuilt the source package, and uploaded three new hint files, and updated the md5sum file. Please take a look when you have some time. I really appreciate you taking the time to review the package. -- Dario Alcocer -- Sr. Software Developer, Helix Digital Inc. [EMAIL PROTECTED] -- http://www.helixdigital.com
Re: Ghostscript 7.05 test version ready for review, upload
- setup files: #1) ghostscript requires: cygwin libpng2 zlib ghostscript-base version: 7.05-1 You don't specify the version in setup.hint. You either a) don't include any version info at all; upset will figure it out b) specify using curr: prev: and test: key words... e.g. curr: 6.52-1 test: 7.05-1 requires: libpng2?? REALLY? Are you sure it isn't libpng12? (you could temporarily list both libpng2 and libpng12, since it's probable that 6.52-1 needs libpng2 but 7.05-1 needs libpng12) #2) ghostscript-x11 requires: cygwin cygwin-xfree86 libpng2 zlib ghostscript-base version: 7.05-1 ditto version:. Ditto libpng2 -- except here I'm SURE you don't need libpng2 -- you want libpng12 (and not both; there is no gs-x11-6.52-1) Also, the correct require: for xfree is 'XFree86-base'. there is no 'cygwin-xfree86' package. #3) ghostscript-base category: Graphics requires: cygwin version: 7.05-1 Ditto version:. Also, this package probably doesn't directly require cygwin. It's just docs, right? - packages: -base- contains: usr/doc/Cygwin/ghostscript-7.05.README usr/doc/ghostscript-7.05/* usr/man/de/man1/* usr/man/man1/* usr/share/ghostscript/7.05/* usr/share/ghostscript/fonts/* -(nonx)- contains: usr/bin/* -x- contains: usr/X11R6/bin/* There are no postinstall scripts, no symlinks. I assume, then, that the -x- version was compiled so that it automatically looked outside of its own -prefix (e.g. not under /usr/X11R6/, but instead under /usr/share/ghostscript) for its runtime files. This is fine by me. However, the man pages are not under share -- yet are shared. (Not complaining, just pointing it out). I assume this was done because of the difficulties involved with changing the cygwin standard -- we'd need a new 'man' package, or everybody'd have to muck with MANPATH, etc etc. This seems like a sensible way to go, for now. (Although, I've never seen localized man pages separated out that way -- is that normal?) -src- package: is a 'method 1' package (http://www.cygwin.com/setup.html). (not complaining, just pointing it out). BTW, refresh me on the jpeg problem? Why can't gs use the official cygwin library? In summary, the packages look good -- but the setup.hints need some work. :-) --Chuck
