Re: [Patch]: Last path.cc

2004-05-04 Thread Christopher Faylor
On Sat, Apr 10, 2004 at 11:37:07PM -0400, Pierre A. Humblet wrote: 2004-04-11 Pierre Humblet [EMAIL PROTECTED] * path.cc (normalize_win32_path): Detect components with only dots. Remove a final . if it follows '\\'. (slash_unc_prefix_p): Remove redundant tests.

Re: [Patch]: chdir

2004-05-04 Thread Christopher Faylor
On Tue, May 04, 2004 at 08:03:59PM -0400, Pierre A. Humblet wrote: Here is a simple patch that simplifies chdir processing and avoids calling normalized_posix_path multiple times. If it doesn't break anything it will simplify removing trailing dots and spaces, as discussed earlier today. If it

Re: [Patch]: chdir

2004-05-04 Thread Christopher Faylor
On Tue, May 04, 2004 at 08:20:03PM -0400, Christopher Faylor wrote: On Tue, May 04, 2004 at 08:03:59PM -0400, Pierre A. Humblet wrote: Here is a simple patch that simplifies chdir processing and avoids calling normalized_posix_path multiple times. If it doesn't break anything it will simplify

Re: Copyright assignment received for Chris Faylor

2004-04-29 Thread Christopher Faylor
On Thu, Apr 29, 2004 at 06:55:53PM -0400, Sergey Okhapkin wrote: Corinna Vinschen wrote: Red Hat received the copyright assignment for Chris Faylor and the yay of his new employer. So patch right away, Chris! Hmm... I remember the day when I got similar message from Geof Noer... Welcome to

Re: Recent changes in pthread_create

2004-04-21 Thread Christopher Faylor
On Wed, Apr 21, 2004 at 09:18:11AM +0200, Thomas Pfaff wrote: i am not so happy with the recent changes to pthread_create and pthread::init_wrapper. Is it at all possible for you not to apprise me of your emotional state regarding any changes I make? If you have a technical problem then present

Re: Recent changes in pthread_create

2004-04-21 Thread Christopher Faylor
On Wed, Apr 21, 2004 at 09:18:11AM +0200, Thomas Pfaff wrote: Date: Thu, 18 Apr 2002 12:11:26 +0200 [...] 2. The InterlockedIncrement (MT_INTERFACE-threadcount) in __pthread_create is misplaced. If the newly created thread terminates fast enough the threadcount will be decremented before it

Re: Recent changes in pthread_create

2004-04-21 Thread Christopher Faylor
On Wed, Apr 21, 2004 at 10:44:57AM -0400, Christopher Faylor wrote: On Wed, Apr 21, 2004 at 09:18:11AM +0200, Thomas Pfaff wrote: Date: Thu, 18 Apr 2002 12:11:26 +0200 [...] 2. The InterlockedIncrement (MT_INTERFACE-threadcount) in __pthread_create is misplaced. If the newly created thread

Re: wingdi.h (ENUMLOGFONTEXDV[AW]): breaks cygwin (fwd)

2004-04-20 Thread Christopher Faylor
On Tue, Apr 20, 2004 at 09:52:32AM -0500, Brian Ford wrote: I sent this to mingw-patches yesterday, but it got stuck waiting on moderator approval because I am not subscribed. As such, I thought I'd forward it here as well. I stumbled across this while generating a snapshot today and checked in

Re: [Patch]: 3 or more initial slashes

2004-04-20 Thread Christopher Faylor
On Tue, Apr 20, 2004 at 01:38:01PM -0400, Pierre A. Humblet wrote: POSIX specifies that three ore more slashes at the beginning of a pathname are equivalent to a single one. This patch implements that feature. Only Posix paths are affected, Windows paths are left alone. Also, Posix paths are

Re: [Patch]: Last path.cc

2004-04-13 Thread Christopher Faylor
On Tue, Apr 13, 2004 at 10:49:13PM +0200, Corinna Vinschen wrote: Oh, one problem left. Currently fhandler_disk_file::fchmod calls chmod_device which is pretty ugly. Chris, do you have an idea how to do that in a cleaner way? It sounds like the same thing as required by fhandler_base::fstat_fs.

Re: [Patch]: st_size for symlinks

2004-04-13 Thread Christopher Faylor
On Tue, Apr 13, 2004 at 10:16:32PM -0400, Pierre A. Humblet wrote: This patch sets st_size correctly for symlinks. Please check in. Thanks. cgf

Re: [Patch]: path.cc

2004-04-12 Thread Christopher Faylor
On Mon, Apr 12, 2004 at 07:06:45PM -0400, Pierre A. Humblet wrote: This fixes the /proc bug reported on the list. Please check in. Thanks, cgf

Re: [Patch]: path.cc

2004-04-10 Thread Christopher Faylor
On Fri, Apr 09, 2004 at 11:19:57PM -0400, Pierre A. Humblet wrote: I am somewhat concerned that the update of fsinfo isn't thread safe. I don't know how the overhead of making it thread safe compares with the overhead of the old method (not caching the fs_info). Corinna, this is a problem that I

Re: [Patch]: Last path.cc

2004-04-10 Thread Christopher Faylor
On Sat, Apr 10, 2004 at 11:37:07PM -0400, Pierre A. Humblet wrote: This should take care of the issues I listed yesterday evening. I simply don't understand the logic in normalize_win32_path well enough to touch it intelligently. So I removed the final . in the dumbest way possible Why do we

Re: [Patch]: dtable.cc

2004-04-10 Thread Christopher Faylor
On Sat, Apr 10, 2004 at 11:42:39PM -0400, Pierre A. Humblet wrote: Here is a minor fix in dtable.cc. Thanks. Applied. My next fix is to remove the normalized_path from path_conv, and the attendant malloc and path_conv destructor. Please, don't bother. I don't want to do this. I want to have

Re: [PATCH] thread self handling revised

2004-04-09 Thread Christopher Faylor
On Thu, Apr 01, 2004 at 11:58:45AM +0200, Thomas Pfaff wrote: Rethinking the changes to pthread::init_mainthread i came to the conclusion that this stuff can be made simpler and cleaner. The changes to init_maintread are reverted, the thread self pointer for an unknown thread is now set in

Re: [Patch]: path.cc

2004-04-04 Thread Christopher Faylor
On Sun, Apr 04, 2004 at 09:57:56AM -0400, Pierre A. Humblet wrote: At 11:01 PM 4/3/2004 -0500, Christopher Faylor wrote: On Sat, Apr 03, 2004 at 09:49:40PM -0500, Pierre A. Humblet wrote: Also, there is a problem in execution: snip I believe that this is due to your removal of the normalize

Re: [Patch]: path.cc

2004-04-03 Thread Christopher Faylor
On Sat, Apr 03, 2004 at 09:49:40PM -0500, Pierre A. Humblet wrote: This patch removes old cruft from and streamlines the mainline of path_conv::check (avoiding a bunch of strlen, strcpy and the like). It also removes trailing / in win32 paths. Pierre, this patch didn't compile. I had to declare

Re: [Dr.Volker.Zell@oracle.com: Re: uxterm from xterm-185-3 and xfontsel crashing when running under cygserver support]

2004-03-30 Thread Christopher Faylor
On Tue, Mar 30, 2004 at 02:42:20PM +0200, Thomas Pfaff wrote: 1. The thread which is started by the service control manager must be initiallized, for example in the first get_tls_self_pointer call. Chris has made some changes to TLS, i do not know if _my_tls can be used for a thread that is

Re: [Dr.Volker.Zell@oracle.com: Re: uxterm from xterm-185-3 and xfontsel crashing when running under cygserver support]

2004-03-30 Thread Christopher Faylor
On Tue, Mar 30, 2004 at 03:55:14PM +0200, Corinna Vinschen wrote: On Mar 30 15:34, Thomas Pfaff wrote: Regardless whether a process is started from a cygwin app or not it will always start at mainCRTStartup. When it is started by the SCM however the service_main thread is created by the

Re: [Dr.Volker.Zell@oracle.com: Re: uxterm from xterm-185-3 and xfontsel crashing when running under cygserver support]

2004-03-30 Thread Christopher Faylor
On Tue, Mar 30, 2004 at 05:33:07PM +0200, Corinna Vinschen wrote: On Mar 30 16:39, Thomas Pfaff wrote: Corinna Vinschen wrote: Do you have an appropriate patch? 2004-03-30 Thomas Pfaff [EMAIL PROTECTED] * thread.h (pthread::init_mainthread): Add parameter forked. Set forked default

Re: [RFA]: Thread safe stdio again

2004-03-26 Thread Christopher Faylor
On Fri, Mar 26, 2004 at 01:50:08AM -0500, Christopher Faylor wrote: On Sun, Mar 14, 2004 at 08:28:02PM +0100, Thomas Pfaff wrote: This time i am using the non portable mutex initializers, therefore moving __sinit is no longer needed. And i added calls to newlibs __fp_lock_all and __fp_unlock_all

Re: [RFA]: Thread safe stdio again

2004-03-25 Thread Christopher Faylor
On Sun, Mar 14, 2004 at 08:28:02PM +0100, Thomas Pfaff wrote: This time i am using the non portable mutex initializers, therefore moving __sinit is no longer needed. And i added calls to newlibs __fp_lock_all and __fp_unlock_all at fork. 2004-03-14 Thomas Pfaff [EMAIL PROTECTED] *

Re: [Patch]: Win95

2004-03-22 Thread Christopher Faylor
On Mon, Mar 22, 2004 at 09:36:36AM -0500, Pierre A. Humblet wrote: This fixes gnuchess on Win95. There is still a compiler warning, will look at it tonight. Tested on ME, 95 and NT4.0 2004-03-22 Pierre Humblet [EMAIL PROTECTED] * init.cc (munge_threadfunc): Handle all instances of

Re: [Patch]: Win95

2004-03-22 Thread Christopher Faylor
On Mon, Mar 22, 2004 at 02:57:36PM -0500, Pierre A. Humblet wrote: Christopher Faylor wrote: On Mon, Mar 22, 2004 at 09:36:36AM -0500, Pierre A. Humblet wrote: This fixes gnuchess on Win95. There is still a compiler warning, will look at it tonight. Tested on ME, 95 and NT4.0 2004-03-22

Re: [Patch]: rmdir

2004-03-14 Thread Christopher Faylor
On Sun, Mar 14, 2004 at 10:46:06AM -0500, Pierre A. Humblet wrote: 2004-03-14 Pierre Humblet [EMAIL PROTECTED] * dir.cc (rmdir): Construct real_dir with flag PC_FULL. Use a loop instead of recursion to handle the current directory. Looks good. Please apply. Thanks, cgf

Re: [Patch] src/winsup/mingw/include/process.h __STRICT_ANSI__

2004-03-12 Thread Christopher Faylor
On Thu, Mar 11, 2004 at 07:23:37PM -0500, Brian Keener wrote: I notice when trying to compile the #endif got left behind. Sure you found it by now. 2004-03-11 Brian Keener [EMAIL PROTECTED] * include/process.h: Remove the #endif associated with removal of __STRICT_ANSI__

Re: [Patch] Signal mask handling

2004-03-11 Thread Christopher Faylor
On Thu, Mar 11, 2004 at 09:04:05PM -0500, Pierre A. Humblet wrote: At 08:43 PM 3/11/2004 -0500, you wrote: On Thu, Mar 11, 2004 at 07:36:41PM -0500, Pierre A. Humblet wrote: There was a problem: pause() calls handle_sigsuspend(), which overwrites the oldmask set by _cygtls::interrupt_setup. It's

Re: [Patch] Signal mask handling

2004-03-11 Thread Christopher Faylor
On Thu, Mar 11, 2004 at 09:04:05PM -0500, Pierre A. Humblet wrote: 2004-02-11 Pierre Humblet [EMAIL PROTECTED] * cygtls.h (_cygtls::newmask): Delete member. (_cygtls::newmask): New member. * gendef (_sigdelayed): Replace the call to set_process_mask by a call

Re: [Patch] Signal mask handling

2004-03-10 Thread Christopher Faylor
On Wed, Mar 10, 2004 at 11:26:19PM -0500, Pierre A. Humblet wrote: 2004-02-11 Pierre Humblet [EMAIL PROTECTED] * gendef (_sigdelayed): Replace the call to set_process_mask by a call to set_process_mask_delta. * exceptions.cc (_cygtls::interrupt_setup): Set oldmask

Re: sigproc.cc (proc_subproc): make -j hang

2004-03-08 Thread Christopher Faylor
On Mon, Mar 08, 2004 at 03:05:12PM -0600, Brian Ford wrote: While trying to analyze my own strace example of a make -j hang ala this ugly thread: http://www.cygwin.com/ml/cygwin/2004-03/msg00376.html My last strace output from the hung make process was: 69 1576822 [proc] make 6724

Re: FW: Final patch for audio recording with /dev/dsp

2004-03-03 Thread Christopher Faylor
On Wed, Mar 03, 2004 at 10:55:43AM +0100, Corinna Vinschen wrote: [Sorry for the delay, I didn't realize that my mail to cygwin-patches didn't come through] Hi Gerd, thanks for the patch, but regardless of the content, it's not acceptable for a few stylistic reasons: - All sentences end in a

Assignment received from Gerd Spalink

2004-02-18 Thread Christopher Faylor
We've received an assignment from Gerd Spalink so any patch submissions are now ok. Gerd, please resubmit patches against current CVS. Thanks, cgf

Re: [PATCH] Thread safe stdio

2004-02-11 Thread Christopher Faylor
On Wed, Feb 11, 2004 at 11:08:57AM +0100, Thomas Pfaff wrote: The __sinit call must be done after malloc is initialized, otherwise the mutex creation will fail. I am not comfortable with this part of the patch. I moved the __sinit call where I did for a reason. It needed to be called earlier

Re: DEBUGGING guards in winsup/cygwin/exceptions.cc are missing

2004-02-08 Thread Christopher Faylor
On Sun, Feb 08, 2004 at 08:46:23PM -0500, Volker Quetschke wrote: When compiling the cygwin dll from cvs, without --enable-debugging the build fails in winsup/cygwin/exceptions.cc because console_printf has no prototype defined without DEBUGGING set. Thanks for the heads up. I will check in a

Re: [PATCH]: 2. Thread safe stdio update

2004-02-06 Thread Christopher Faylor
On Fri, Jan 23, 2004 at 12:03:09PM +0100, Thomas Pfaff wrote: Corinna Vinschen wrote: On Jan 22 21:48, Thomas Pfaff wrote: This is an update of my previous patch. It adds support for newlibs __LOCK_INIT macro. Thomas 2004-01-22 Thomas Pfaff [EMAIL PROTECTED] * include/sys/_types.h: New

Re: [Patch]: heap_chunk_size

2004-02-03 Thread Christopher Faylor
On Mon, Feb 02, 2004 at 08:22:01PM -0500, Pierre A. Humblet wrote: Here is a no brainer patch that eliminates the use of heap_chunk in the cygwin shared. That removes a source of DOS attack and it's another step towards the demise of the cygwin shared. This isn't a no-brainer. This value is

Re: [Patch]: ciresrv.parent

2004-02-02 Thread Christopher Faylor
On Mon, Feb 02, 2004 at 09:47:35AM -0500, Pierre A. Humblet wrote: Do you want to apply the patch now, or I do it this evening? I applied it. I also got rid of all of the now-obsolete arguments/parameters to fixup_after_exec. cgf

Re: [Patch]: ciresrv.parent

2004-02-02 Thread Christopher Faylor
On Mon, Feb 02, 2004 at 04:04:05PM -0500, Christopher Faylor wrote: On Mon, Feb 02, 2004 at 09:47:35AM -0500, Pierre A. Humblet wrote: Do you want to apply the patch now, or I do it this evening? I applied it. I also got rid of all of the now-obsolete arguments/parameters to fixup_after_exec

Re: [Patch]: ciresrv.parent

2004-02-01 Thread Christopher Faylor
On Sat, Jan 31, 2004 at 02:18:48PM -0500, Pierre A. Humblet wrote: Fortunately it is never used in the case of spawn: all handles are inherited, or the parent does the work (sockets). The one placed the handle is actually used is in fhandler_socket::fixup_after_exec. I'd like Corinna's

Re: patch for audio recording with /dev/dsp

2004-01-29 Thread Christopher Faylor
On Thu, Jan 29, 2004 at 12:07:26PM +0100, Corinna Vinschen wrote: We just have no feedback from the person who's collecting the papers so far. For that reason we have to wait, yet. Actually, I believe we do have the individual form. I had asked for the employer's signature also since we don't

Re: [Patch]: secret event

2004-01-23 Thread Christopher Faylor
On Fri, Jan 23, 2004 at 10:59:52AM +0100, Corinna Vinschen wrote: On Jan 22 18:33, Pierre A. Humblet wrote: 2004-01-22 Pierre Humblet [EMAIL PROTECTED] * fhandler_socket.cc (fhandler_socket::create_secret_event): Avoid creating multiple handles. Always allow event inheritance but

Re: Fix write deadlock with streaming serial devices

2004-01-23 Thread Christopher Faylor
On Thu, Jan 22, 2004 at 05:07:38PM -0600, Brian Ford wrote: 2004-01-22 Brian Ford [EMAIL PROTECTED] * fhandler_serial.cc (fhandler_serial::raw_write): Prevent a deadlock when the input buffer overflows. (fhandler_serial::raw_read): Correct to print the actual error

Re: [Patch]: secret event

2004-01-23 Thread Christopher Faylor
On Fri, Jan 23, 2004 at 11:04:05AM -0500, Pierre A. Humblet wrote: Christopher Faylor wrote: I agree, with one nit. Was there a reason for getting rid of the handle protection in this patch? We are apparently stumbling over a problem with handle corruption in the current CVS so removing

Re: lstat symbolic link size

2004-01-07 Thread Christopher Faylor
On Wed, Jan 07, 2004 at 11:33:18AM -0600, Brian Ford wrote: On Mon, 5 Jan 2004, Christopher Faylor wrote: On Mon, Jan 05, 2004 at 08:38:24PM -0500, Christopher Faylor wrote: On Tue, Jan 06, 2004 at 09:30:26AM +0800, peter garrone wrote: lstat returns an incorrect symbolic link size, with size

Re: termios.cc: Restore setting of EBADF appropriately throughout

2003-12-12 Thread Christopher Faylor
On Fri, Dec 12, 2003 at 01:14:32PM -0600, Brian Ford wrote: I noticed this while digging through other serial port problems. It appears to have been lost in version 1.16, although there did not appear to be a reason for the loss in that change. Please let me know if it was intentional for some

Re: [Patch]: Fixing the PROCESS_DUP_HANDLE security hole (part 1).

2003-12-10 Thread Christopher Faylor
On Wed, Dec 10, 2003 at 10:28:53PM -0500, Christopher Faylor wrote: On Wed, Dec 10, 2003 at 09:54:30PM -0500, Pierre A. Humblet wrote: At 12:08 AM 12/9/2003 -0500, Christopher Faylor wrote: I'll work on that tomorrow. OK, it works, but I found a few odd things. I haven't checked in any changes

Re: patch for audio recording with /dev/dsp

2003-12-09 Thread Christopher Faylor
On Tue, Dec 09, 2003 at 06:54:02PM -0500, Nicholas Wourms wrote: Gerd Spalink wrote: Hi, This patch changes the device /dev/dsp so that audio recording works. I have tested it with cp /dev/dsp test.wav (stop by hitting ctrl-C) and subsequent playback with cp test.wav /dev/dsp I also

Re: [Patch]: Fixing the PROCESS_DUP_HANDLE security hole (part 1).

2003-12-08 Thread Christopher Faylor
On Mon, Dec 08, 2003 at 10:10:10PM -0500, Pierre A. Humblet wrote: Either myself-set_ctty should be smarter, or fhandler_tty_slave::dup could see if it's about the ctty and simply copy it. I stared at the set_ctty code a long time trying to understand why it went out of its way to do the ctty

Re: patch for audio recording with /dev/dsp

2003-12-07 Thread Christopher Faylor
On Mon, Dec 08, 2003 at 03:37:19AM +0100, Gerd Spalink wrote: Hi, This patch changes the device /dev/dsp so that audio recording works. I have tested it with cp /dev/dsp test.wav (stop by hitting ctrl-C) and subsequent playback with cp test.wav /dev/dsp I also tested successfully with

Re: [Patch]: Create Global Privilege

2003-12-01 Thread Christopher Faylor
On Mon, Dec 01, 2003 at 12:18:05PM +0100, Corinna Vinschen wrote: On Sun, Nov 30, 2003 at 12:07:22AM +0100, Corinna Vinschen wrote: On Wed, Nov 26, 2003 at 10:45:57AM -0500, Pierre A. Humblet wrote: At 03:32 PM 11/26/2003 +0100, Corinna Vinschen wrote: Imagine a sshd service is running on the

Re: [Patch]: Create Global Privilege

2003-12-01 Thread Christopher Faylor
On Mon, Dec 01, 2003 at 10:55:46PM -0500, Pierre A. Humblet wrote: Corinna Vinschen wrote: On Sun, Nov 30, 2003 at 12:07:22AM +0100, Corinna Vinschen wrote: On Wed, Nov 26, 2003 at 10:45:57AM -0500, Pierre A. Humblet wrote: At 03:32 PM 11/26/2003 +0100, Corinna Vinschen wrote: Imagine a sshd

Re: [Patch]: Create Global Privilege

2003-12-01 Thread Christopher Faylor
On Mon, Dec 01, 2003 at 10:55:46PM -0500, Pierre A. Humblet wrote: Below is another small patch to lookup pinfo's in the global name space when possible. Btw, applied. Thanks. cgf

Re: [PATCH]: Add flock syscall emulation

2003-11-29 Thread Christopher Faylor
On Sun, Nov 30, 2003 at 12:01:04AM +0100, Corinna Vinschen wrote: On Thu, Nov 27, 2003 at 02:51:10PM -0500, Nicholas Wourms wrote: Hi All, Here is a patch to add the flock() syscall to Cygwin. I've noticed that some Applied with changes. I've run indent on flock.c since its formatting was

Re: [PATCH]: Add flock syscall emulation

2003-11-28 Thread Christopher Faylor
On Fri, Nov 28, 2003 at 08:12:27AM -0500, Nicholas Wourms wrote: cgf wrote: On Thu, Nov 27, 2003 at 02:51:10PM -0500, Nicholas Wourms wrote: And, the employee was...? Your reasoning may be correct but it isn't possible to know for sure without details. Chris, Ooops, sorry about that! I meant

Re: [PATCH]: Add flock syscall emulation

2003-11-27 Thread Christopher Faylor
On Thu, Nov 27, 2003 at 02:51:10PM -0500, Nicholas Wourms wrote: I decided to port this particular version of flock emulation from a patch written by a Red Hat employee for use in Red Hat's IMAPd RPM. I tried contacting the individual listed in the spec's ChangeLog, but got no response. IANAL,

Re: [Patch]: Create Global Privilege

2003-11-25 Thread Christopher Faylor
On Tue, Nov 25, 2003 at 09:13:12PM -0500, Christopher Faylor wrote: Other than that minor point, this looks ok. Sorry. On rereading this this sounded rather lukewarm. I'm very happy that you are fixing this problem. I should probably let Corinna have the final word on this, though. Thanks

Re: [Patch]: Create Global Privilege

2003-11-25 Thread Christopher Faylor
On Tue, Nov 25, 2003 at 10:12:19PM -0500, Pierre A. Humblet wrote: At 09:47 PM 11/25/2003 -0500, you wrote: On Tue, Nov 25, 2003 at 09:13:12PM -0500, Christopher Faylor wrote: Other than that minor point, this looks ok. Sorry. On rereading this this sounded rather lukewarm. I'm very happy

Re: For masochists: the leap o faith

2003-11-20 Thread Christopher Faylor
On Fri, Nov 21, 2003 at 07:43:09AM +1100, Robert Collins wrote: On Sat, 2003-11-15 at 09:07, Christopher Faylor wrote: This problem is fixed in the gcc cvs trunk. I've asked Danny and Gerrit about backporting the fix to 3.3.2. It should be trivial to do so. Any word on this? I backported

Re: The increased path length changes

2003-11-15 Thread Christopher Faylor
On Sun, Nov 16, 2003 at 07:36:21AM +1100, Robert Collins wrote: ...Ron claims said assignment is in place... I have no record of an assignment so if there is an assignment, it predates me. I don't see any changes in the ChangeLog which would indicate the need for an assignment prior to this

Re: The increased path length changes

2003-11-15 Thread Christopher Faylor
On Sun, Nov 16, 2003 at 09:11:34AM +1100, Robert Collins wrote: On Sun, 2003-11-16 at 08:46, Christopher Faylor wrote: On Sun, Nov 16, 2003 at 07:36:21AM +1100, Robert Collins wrote: ...Ron claims said assignment is in place... I have no record of an assignment so if there is an assignment

Re: thunk createDirectory and createFile calls

2003-11-14 Thread Christopher Faylor
On Fri, Nov 14, 2003 at 08:41:21PM +1100, Robert Collins wrote: Rename CreateFile to cygwin_create_file throughout. ^^ Rename CreateDirectory to cygwin_create_directory throughout.

Re: thunking, the next step

2003-11-14 Thread Christopher Faylor
On Fri, Nov 14, 2003 at 11:02:11PM +1100, Robert Collins wrote: Ok, I've now integrated and generalised Ron's unicode support mini-patch. So, here tis a version that, well the changelog explains the overview, and io.h the detail. Overhead wise, this is reasonably low: 1 strlen() per IO call

Re: thunking, the next step

2003-11-14 Thread Christopher Faylor
On Sat, Nov 15, 2003 at 04:52:43AM +1100, Robert Collins wrote: On Sat, 2003-11-15 at 02:57, Christopher Faylor wrote: On Fri, Nov 14, 2003 at 11:02:11PM +1100, Robert Collins wrote: Ok, I've now integrated and generalised Ron's unicode support mini-patch. So, here tis a version that, well

Re: dtable.cc (build_fh_pc): serial port handling

2003-11-14 Thread Christopher Faylor
On Fri, Nov 14, 2003 at 02:41:06PM -0600, Brian Ford wrote: However, it certainly looked like an obvious and logical bug fix. It's only logical and obvious if you assume that the com file device handling is the same as other devices. I needed to reaquaint myself with whether that was true or

Re: For masochists: the leap o faith

2003-11-14 Thread Christopher Faylor
On Sat, Nov 15, 2003 at 09:48:46AM +1100, Robert Collins wrote: Christopher Faylor wrote: It is fairly unusual for PATH_MAX to be many times greater than what is support by pathconf. And yet: http://www.opengroup.org/onlinepubs/007908799/xsh/fpathconf.html Yes, I've already (obviously?) been

Re: dtable.cc (build_fh_pc): serial port handling

2003-11-13 Thread Christopher Faylor
On Wed, Nov 12, 2003 at 01:24:21PM -0600, Brian Ford wrote: 2003-11-12 Brian Ford [EMAIL PROTECTED] * dtable.cc (build_fh_pc): Use DEV_SERIAL_MAJOR to catch all serial ports. Remove redundant FH_CYGDRIVE case since it is handled by DEV_CYGDRIVE_MAJOR. FYI, this is the

Re: Small patch for the FAQ

2003-11-13 Thread Christopher Faylor
On Thu, Nov 13, 2003 at 10:46:51PM +, David Starks-Browning wrote: When I started over as FAQ maintainer (sheesh -- *years* ago?) I was told that Changelog entries were not necessary for documentation, as long as the cvs commit messages were informative. (Perhaps this was only intended for

Re: [PATCH] stdio initialization

2003-11-10 Thread Christopher Faylor
On Mon, Nov 10, 2003 at 03:03:06PM +0100, Thomas Pfaff wrote: Christopher Faylor wrote: On Mon, Nov 10, 2003 at 12:23:35PM +0100, Thomas Pfaff wrote: Attached patch fixes the memory leak reported by Arash Partow by initializing stdio during startup and setting __sdidinit from thread local clib

Re: [PATCH] stdio initialization

2003-11-10 Thread Christopher Faylor
On Mon, Nov 10, 2003 at 10:09:52AM -0500, Christopher Faylor wrote: On Mon, Nov 10, 2003 at 03:03:06PM +0100, Thomas Pfaff wrote: Christopher Faylor wrote: On Mon, Nov 10, 2003 at 12:23:35PM +0100, Thomas Pfaff wrote: Attached patch fixes the memory leak reported by Arash Partow by initializing

Re: [Patch]: Fixing the PROCESS_DUP_HANDLE security hole (part 1).

2003-11-06 Thread Christopher Faylor
On Wed, Nov 05, 2003 at 08:02:01PM -0500, Pierre A. Humblet wrote: Ping? This has been pending for a while. See also http://cygwin.com/ml/cygwin-patches/2003-q4/msg3.html I haven't forgotten about it. Unfortunately, in quick scans, the implementation gives me heartburn. That doesn't mean

Re: fhandler_tty_slave::ioctl (FIONBIO) return status

2003-10-23 Thread Christopher Faylor
On Thu, Oct 23, 2003 at 05:14:47PM -0500, Brian Ford wrote: I don't really understand the code here in depth, but could someone explain to me why the attached trivial patch would'nt fix a minor bug? Thanks. 2003-10-23 Brian Ford [EMAIL PROTECTED] * fhandler_tty.c

Re: [Patch]: Ncurses frame drawing

2003-10-14 Thread Christopher Faylor
On Tue, Oct 14, 2003 at 04:55:07PM +0200, Corinna Vinschen wrote: On Tue, Oct 14, 2003 at 10:24:47AM -0400, Christopher Faylor wrote: On Tue, Oct 14, 2003 at 01:29:37PM +0200, Micha Nelissen wrote: Corinna Vinschen wrote: This patch is a nice idea but it's not quite correct. You can't rely

Re: [Patch]: shared.cc debug info.

2003-10-06 Thread Christopher Faylor
On Mon, Oct 06, 2003 at 09:26:12PM -0400, Pierre A. Humblet wrote: Here is a pretty simple patch.. Ok to include. BTW, are there more questions about [Patch]: Fixing the PROCESS_DUP_HANDLE security hole (part 1). from last week? Yes, actually. I am still puzzling over all of the extra logic

Re: New program: cygtweak

2003-09-30 Thread Christopher Faylor
On Tue, Sep 30, 2003 at 02:16:09PM +0200, Corinna Vinschen wrote: On Sat, Sep 27, 2003 at 12:42:50PM -0400, Igor Pechtchanski wrote: The only thing I didn't test were the rules in the Makefile, so if someone could please double-check them, it'd be great. Index: winsup/utils/Makefile.in

Re: New program: cygtweak

2003-09-30 Thread Christopher Faylor
On Tue, Sep 30, 2003 at 11:02:39AM -0400, Igor Pechtchanski wrote: On Tue, 30 Sep 2003, Corinna Vinschen wrote: Wouldn't it be sufficient to add $(srcdir)/cygprogctl to PROGS and to drop the copy rule? The script only needs installing and that should work then. I just remembered why I did it

Re: New program: cygtweak

2003-09-30 Thread Christopher Faylor
On Tue, Sep 30, 2003 at 11:29:29AM -0400, Igor Pechtchanski wrote: On Tue, 30 Sep 2003, Christopher Faylor wrote: On Tue, Sep 30, 2003 at 11:02:39AM -0400, Igor Pechtchanski wrote: On Tue, 30 Sep 2003, Corinna Vinschen wrote: Wouldn't it be sufficient to add $(srcdir)/cygprogctl to PROGS

Re: New program: cygtweak

2003-09-30 Thread Christopher Faylor
On Tue, Sep 30, 2003 at 11:49:44AM -0400, Igor Pechtchanski wrote: On Tue, 30 Sep 2003, Christopher Faylor wrote: On Tue, Sep 30, 2003 at 11:29:29AM -0400, Igor Pechtchanski wrote: On Tue, 30 Sep 2003, Christopher Faylor wrote: On Tue, Sep 30, 2003 at 11:02:39AM -0400, Igor Pechtchanski

Re: New program: cygtweak

2003-09-30 Thread Christopher Faylor
On Tue, Sep 30, 2003 at 12:40:58PM -0400, Igor Pechtchanski wrote: Close enough. So, are we jump-starting the car, or replacing the battery? ;-) I'm just hoping for someone to come up with a creative name for the car. cgf

Re: New program: cygtweak

2003-09-30 Thread Christopher Faylor
On Tue, Sep 30, 2003 at 01:20:44PM -0400, Igor Pechtchanski wrote: On Tue, 30 Sep 2003, Christopher Faylor wrote: On Tue, Sep 30, 2003 at 12:40:58PM -0400, Igor Pechtchanski wrote: Close enough. So, are we jump-starting the car, or replacing the battery? ;-) I'm just hoping for someone

Re: [Patch]: Fixing the PROCESS_DUP_HANDLE security hole (part 1).

2003-09-29 Thread Christopher Faylor
On Mon, Sep 29, 2003 at 09:55:25PM -0400, Pierre A. Humblet wrote: Here is a patch that allows to open master ttys without giving full access to the process, at least for access to the ctty. It works by snooping the ctty pipe handles and duplicating them on the cygheap, for use by future opens

Re: Turning pinfo security on

2003-09-26 Thread Christopher Faylor
On Fri, Sep 26, 2003 at 10:17:00PM -0400, Pierre A. Humblet wrote: Following Chris' new signal handling approach and the previous patch Giving access to pinfo after seteuid and exec, we can now turn pinfo security on. It's just a matter of removing the FILE_MAP_WRITE permission for Everybody, and

Re: [PATCH] Add support for ioctl TIOCLINUX, function 6 (get key modifiers) on a TTY

2003-09-26 Thread Christopher Faylor
On Fri, Aug 01, 2003 at 02:57:05AM +0200, Pavel Tsekov wrote: 2003-08-01 Pavel Tsekov [EMAIL PROTECTED] * fhandler_console.c (fhandler_console::read): Record the state of the SHIFT, CTRL and ALT keys at the time of the last keyboard input event. (fhandler_console::ioctl):

Re: Turning pinfo security on

2003-09-26 Thread Christopher Faylor
On Fri, Sep 26, 2003 at 10:36:05PM -0400, Pierre A. Humblet wrote: BTW, now that your sigpacket includes the sending pid, the commune stuff could be simplified and avoid calling winpids. It knows whom to talk to (but it must still double check for security). Yeah. That's one of the reasons I

Re: setmetamode

2003-09-26 Thread Christopher Faylor
On Tue, Aug 12, 2003 at 04:47:31PM +0200, Corinna Vinschen wrote: On Mon, Jul 28, 2003 at 09:39:53AM +0900, Kazuhiro Fujieda wrote: On Fri, 18 Jul 2003 19:10:54 +0200 Corinna Vinschen [EMAIL PROTECTED] said: Umm. I can't find any reason why it doesn't work. I'd like to confirm whether

Re: New program: cygtweak

2003-09-26 Thread Christopher Faylor
On Fri, Aug 16, 2002 at 03:42:21PM -0400, Igor Pechtchanski wrote: I've tried submitting this twice before, and had gotten no reaction. I'm trying to find out what the proper procedure is and which list should this be sent to. I'd also like to discuss the appropriate name for this little app, as

Re: Implementation of sched_rr_get_interval for NT systems.

2003-09-26 Thread Christopher Faylor
[cleaning out my cygwin-patches backlog] On Thu, Feb 06, 2003 at 01:16:17PM +0100, Vaclav Haisman wrote: 2003-02-06 Vaclav Haisman [EMAIL PROTECTED] * Makefile.in: Add libusr32.a to DLL_IMPORTS. * wincap.h (wincaps::is_server): New flag. (wincapc::version): Change type to

Re: {Patch]: Giving access to pinfo after seteuid and exec

2003-09-25 Thread Christopher Faylor
On Thu, Sep 25, 2003 at 09:47:48PM -0400, Pierre A. Humblet wrote: This patch sets the _pinfo acl in order to allow access after seteuid and exec. While looking at spawn.cc I also noticed oddities in pinfo related error handling, and reworked them. I also restored impersonation in case of

Re: {Patch]: Giving access to pinfo after seteuid and exec

2003-09-25 Thread Christopher Faylor
On Thu, Sep 25, 2003 at 10:17:22PM -0400, Christopher Faylor wrote: I was looking at the above today. Don't you have to reimpersonate regardless of whether the CreateProcess succeeded? Nevermind. That's exactly what you're doing. I'm always briefly 10% more brilliant after I hit 'y' to send

Re: {Patch]: Giving access to pinfo after seteuid and exec

2003-09-25 Thread Christopher Faylor
On Thu, Sep 25, 2003 at 10:17:22PM -0400, Christopher Faylor wrote: I'll check in the rest of the spawn.cc stuff with some modifications. I see I missed some cases with the addition of _P_SYSTEM. I'm sorry. Long day. I'm checking in the non-acl related stuff. I'll leave the rest for Corinna's

Re: {Patch]: Giving access to pinfo after seteuid and exec

2003-09-25 Thread Christopher Faylor
On Thu, Sep 25, 2003 at 10:56:41PM -0400, Pierre A. Humblet wrote: At 10:23 PM 9/25/2003 -0400, you wrote: On Thu, Sep 25, 2003 at 10:17:22PM -0400, Christopher Faylor wrote: I'll check in the rest of the spawn.cc stuff with some modifications. I see I missed some cases with the addition

Re: Fixing the delete queue security

2003-09-24 Thread Christopher Faylor
On Mon, Sep 15, 2003 at 09:18:08PM -0400, Pierre A. Humblet wrote: 2003-09-15 Pierre Humblet [EMAIL PROTECTED] * shared_info.h (class user_info): New. (cygwin_user_h): New. (user_shared): New. (enum shared_locations): Replace SH_MOUNT_TABLE by SH_USER_SHARED;

Re: Fixing the delete queue security

2003-09-24 Thread Christopher Faylor
On Wed, Sep 24, 2003 at 08:43:55PM -0400, Christopher Faylor wrote: Please check in. You'll have to accommodate the new layout after my checkin but it should apply with only minor problems. I just built cygwin with these changes and noticed the warnings due to MOUNT_MAGIC changing. I should

Re: O_NONBLOCK for pipes

2003-09-20 Thread Christopher Faylor
On Sat, Sep 20, 2003 at 01:13:53PM +0400, Artem Khodush wrote: I have straightforward patch, containing about 20 lines of new code, which implements O_NONBLOCK fcntl for pipes using SetNamedPipeHandleState NT API call. Two questions before I send it: Will it be considered trivial, so that

Re: gethostid and GetDiskFreeSpaceEx on NT4

2003-09-16 Thread Christopher Faylor
On Tue, Sep 16, 2003 at 02:58:54PM -0500, Brian Ford wrote: The attached patch fixes the Cygwin testsuite failure I mentioned here: http://www.cygwin.com/ml/cygwin-developers/2003-09/msg00019.html 2003-09-16 Brian Ford [EMAIL PROTECTED] * syscalls.cc (gethostid): GetDiskFreeSpaceEx call

Re: Fixing a security hole in pinfo.

2003-09-13 Thread Christopher Faylor
On Thu, Sep 11, 2003 at 12:15:45AM -0400, Christopher Faylor wrote: On Thu, Sep 11, 2003 at 12:05:42AM -0400, Pierre A. Humblet wrote: 2003-09-11 Pierre Humblet [EMAIL PROTECTED] * include/sys/cygwin.h: Rename PID_UNUSED to PID_MAP_RW. * pinfo.cc (pinfo_init): Initialize myself

Re: Part 2 of Fixing a security hole in pinfo.

2003-09-13 Thread Christopher Faylor
On Sat, Sep 13, 2003 at 10:07:42PM -0400, Pierre A. Humblet wrote: This is the second and final part of the pinfo security patch. Looks like a Corinna yea or nay on this one. I am going to be checking in *all* of my stuff soon, including the long promised device reorg that I started back in

[PATCH] pthread patch - Thomas Pfaff, please note

2003-09-12 Thread Christopher Faylor
information not present in the calling threads reent structure. I hope it makes sense. If there is some better way to do this, please feel free to check it in. This looked right to me, though. cgf 2003-09-12 Christopher Faylor [EMAIL PROTECTED] * thread.cc (MTinterface

Re: Fixing a security hole in pinfo.

2003-09-10 Thread Christopher Faylor
On Thu, Sep 11, 2003 at 12:05:42AM -0400, Pierre A. Humblet wrote: The flag PID_MAP_RW is added in the few pinfo constructors that need to be write into _pinfo if it exists. [snip] diff -u -p -r1.166 exceptions.cc --- exceptions.cc 10 Sep 2003 17:26:12 - 1.166 +++ exceptions.cc

Re: setfragment patch for sound device

2003-09-10 Thread Christopher Faylor
On Thu, Sep 11, 2003 at 12:29:12PM +0800, peter garrone wrote: The following patch to the /dev/dsp sound device does the following: - implements SNDCTL_DSP_SETFRAGMENT, allowing smaller sound buffers to be used. - trivially implements SNDCTL_DSP_CHANNELS. - opens and closes the class device

<    2   3   4   5   6   7   8   9   10   >