On Sun, Nov 17, 2002 at 10:42:55PM -0500, Pierre A. Humblet wrote:
At 06:56 PM 11/15/2002 +0100, Corinna Vinschen wrote:
On Fri, Nov 15, 2002 at 12:29:44PM -0500, Pierre A. Humblet wrote:
Alternatively I could add it, but add a check for group
sid is SYSTEM, and then skip the step. That
At 06:56 PM 11/15/2002 +0100, Corinna Vinschen wrote:
On Fri, Nov 15, 2002 at 12:29:44PM -0500, Pierre A. Humblet wrote:
Alternatively I could add it, but add a check for group
sid is SYSTEM, and then skip the step. That would be very easy
to do, and to remove later when ssh is ready.
I like
On Thu, Nov 14, 2002 at 10:04:54PM -0500, Pierre A. Humblet wrote:
Great! Here are my patches. I think they are as we agreed on.
Pierre
Sorry, I still have some problems:
}
}
*attribute = ~(S_IRWXU | S_IRWXG | S_IRWXO | S_ISVTX | S_ISGID | S_ISUID);
+ if (owner_sid
Corinna Vinschen wrote:
Sorry, I still have some problems:
Me too!
Looking for the modes. Before that change:
drwxr-xr-x2 SYSTEM SYSTEM 0 Jul 7 11:39 /var/empty
With that patch:
drwxrwxr-x2 SYSTEM SYSTEM 0 Jul 7 11:39 /var/empty
I'm not
On Fri, Nov 15, 2002 at 10:24:36AM -0500, Pierre A. Humblet wrote:
Corinna Vinschen wrote:
chgrp 544 or 513 /var/empty
but that only works for default /etc/group files.
544 is still the best solution, IMHO. Let's take the long term view.
Yep. But as far as I'm concerned we should
On Fri, Nov 15, 2002 at 12:29:44PM -0500, Pierre A. Humblet wrote:
Corinna Vinschen wrote:
Ok. I'm really sorry that I'm making your live that hard but I assume
you know that I'm just trying to find something as a best solution (if
that's at all possible).
Sure, and it's reciprocal.
Like I said
On Fri, Nov 15, 2002 at 12:29:44PM -0500, Pierre A. Humblet wrote:
Corinna Vinschen wrote:
Yep. But as far as I'm concerned we should drop that part of your
patch until I could update ssh.
What about putting it in with #if 0 ?
It will then be easier to turn it on when ssh is ready.
On Wed, Nov 13, 2002 at 12:32:31PM -0500, Pierre A. Humblet wrote:
Corinna Vinschen wrote:
It doesn't add any overhead which isn't already there.
If already is before the patch, it scans the group file instead of scanning
the token groups. If already is after the patch, it scans the group
On Thu, Nov 14, 2002 at 09:30:01AM -0500, Pierre A. Humblet wrote:
Corinna Vinschen wrote:
Isn't the impersonation token automatically read by OpenProcessToken()
when an impersonation took place?
I don't think so.
I just had another look into MSDN and AFAICS, we would have to call
On Thu, Nov 14, 2002 at 06:23:23PM +0100, Corinna Vinschen wrote:
On Thu, Nov 14, 2002 at 12:03:24PM -0500, Pierre A. Humblet wrote:
If you are emulated, you already have the token in the cygheap-user.
There is no need to open the thread, see how it's done e.g.in setegid.
Good point.
On Tue, Nov 12, 2002 at 02:43:51PM -0500, Pierre A. Humblet wrote:
It's just a flaw in is_grp_member() but it's still needed to get the
information about the group membership. is_grp_member() shouldn't check
the current token if the uid isn't myself-uid but otherwise it's ok.
That's the
Corinna Vinschen wrote:
On Tue, Nov 12, 2002 at 02:43:51PM -0500, Pierre A. Humblet wrote:
It's just a flaw in is_grp_member() but it's still needed to get the
information about the group membership. is_grp_member() shouldn't check
the current token if the uid isn't myself-uid but
On Wed, Nov 13, 2002 at 11:18:33AM -0500, Pierre A. Humblet wrote:
Corinna Vinschen wrote:
I think I found an easy (not necessaily fast) solution which doesn't
involve calling the PDC. Basically we do already depend on /etc/group
heavily so we can do this here, too, IMHO:
Yes, that
Oops, there is an error in our examples.
The Everyone permission should propagate.
Here is the correct output.
Pierre A. Humblet wrote:
Corinna Vinschen wrote:
On Wed, Nov 13, 2002 at 11:18:33AM -0500, Pierre A. Humblet wrote:
Corinna Vinschen wrote:
I think I found an easy (not
On Wed, Nov 13, 2002 at 10:35:09PM -0500, Pierre A. Humblet wrote:
At 05:50 PM 11/13/2002 +0100, Corinna Vinschen wrote:
The above ls -l example shows the result if we don't use is_grp_member().
We already had a lot of problems due to this some time ago. I won't return
to the old state. I, for
Corinna Vinschen wrote:
Hi Pierre,
On Wed, 06 Nov 2002 11:28:30 -0500, Pierre A. Humblet wrote:
Note that is_grp_member is expensive: a passwd scan + getting the token
groups in a malloc'ed structure. I am wondering if the effort is
justified, considering that it is useless when the
Hello Corinna,
The patch below includes the uid == gid patch (now obsolete) I sent
before you left and more recent changes that make Cygwin more robust
against incomplete /etc/passwd and /etc/group files.
The discussion below covers the main changes but doesn't go into
details about simple bug
17 matches
Mail list logo
