Re: [PATCH] fhandler_proc.cc(format_proc_cpuinfo): fix issues, add fields, flags

2019-10-06 Thread Ken Brown
On 10/6/2019 12:23 PM, Brian Inglis wrote: > On 2019-10-06 08:31, Ken Brown wrote: >> On 10/5/2019 5:42 PM, Brian Inglis wrote: >>> On 2019-10-05 15:06, Ken Brown wrote: On 10/4/2019 6:44 AM, Brian Inglis wrote: > fix cache size return code handling and make AMD/Intel code common; >

Re: [PATCH] fhandler_proc.cc(format_proc_cpuinfo): fix issues, add fields, flags

2019-10-06 Thread Brian Inglis
On 2019-10-06 08:31, Ken Brown wrote: > On 10/5/2019 5:42 PM, Brian Inglis wrote: >> On 2019-10-05 15:06, Ken Brown wrote: >>> On 10/4/2019 6:44 AM, Brian Inglis wrote: fix cache size return code handling and make AMD/Intel code common; fix cpuid level count as number of non-zero leafs

Re: [PATCH] fhandler_proc.cc(format_proc_cpuinfo): fix issues, add fields, flags

2019-10-06 Thread Ken Brown
On 10/5/2019 5:42 PM, Brian Inglis wrote: > On 2019-10-05 15:06, Ken Brown wrote: >> On 10/4/2019 6:44 AM, Brian Inglis wrote: >>> fix cache size return code handling and make AMD/Intel code common; >>> fix cpuid level count as number of non-zero leafs excluding sub-leafs; >>> fix AMD physical

Re: [PATCH] fhandler_proc.cc(format_proc_cpuinfo): fix issues, add fields, flags

2019-10-06 Thread ASSI
Brian Inglis writes: >> It would be easier to review if you would split it up into smaller patches, >> each >> doing one thing, to the extent that this makes sense. For example, the >> simplification achieved by using the ftcprint macro could be done in a >> single >> patch that's separate

Re: [PATCH] fhandler_proc.cc(format_proc_cpuinfo): fix issues, add fields, flags

2019-10-05 Thread Brian Inglis
On 2019-10-05 15:06, Ken Brown wrote: > On 10/4/2019 6:44 AM, Brian Inglis wrote: >> fix cache size return code handling and make AMD/Intel code common; >> fix cpuid level count as number of non-zero leafs excluding sub-leafs; >> fix AMD physical cores count to be documented nc + 1; >> round cpu

Re: [PATCH] fhandler_proc.cc(format_proc_cpuinfo): fix issues, add fields, flags

2019-10-05 Thread Ken Brown
Hi Brian, On 10/4/2019 6:44 AM, Brian Inglis wrote: > fix cache size return code handling and make AMD/Intel code common; > fix cpuid level count as number of non-zero leafs excluding sub-leafs; > fix AMD physical cores count to be documented nc + 1; > round cpu MHz to correct Windows and match

Re: [PATCH] fhandler_proc.cc(format_proc_cpuinfo): fix issues, add fields, flags

2019-10-05 Thread Brian Inglis
On 2019-10-05 00:30, ASSI wrote: > Brian Inglis writes: >> For informal comparison, attached are Cygwin, WSL, and test release cpuinfo >> output, with diffs against the test release output, and the Windows registry >> CentralProcessor dump (be careful not to double click on Windows systems!) > The

Re: [PATCH] fhandler_proc.cc(format_proc_cpuinfo): fix issues, add fields, flags

2019-10-05 Thread ASSI
Brian Inglis writes: > For informal comparison, attached are Cygwin, WSL, and test release cpuinfo > output, with diffs against the test release output, and the Windows registry > CentralProcessor dump (be careful not to double click on Windows > systems!) The easiest way to prevent that problem