Re: Problem with winsup/cinstall compilation

2002-01-12 Thread Corinna Vinschen
://cygwin.com/contrib.html I have read this and I see many what not to do statements relating changelog. I think it would be easier and faster to read if some true examples are included at this page. :-) Isn't the ChangeLog file itself *the* example? Corinna -- Corinna Vinschen

Re: cygpath patch

2002-01-16 Thread Corinna Vinschen
is also malformed. The first line (date, name, mail address) is splitted into two lines, the following lines are missing the indentation (one tab). Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL

Re: Cygpath patch resend

2002-01-17 Thread Corinna Vinschen
. Anyway, thanks for the patch. I'm too busy to check it today, though. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: Cygpath patch resend

2002-01-17 Thread Corinna Vinschen
cygpath section for ADPWS options. Please compare carefully *all* details. Anyway, thanks for the patch. I'm too busy to check it today, though. Got some spare time. Patch applied (with changed ChangeLog). Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin

Re: connect patch

2002-02-07 Thread Corinna Vinschen
(sun-sun_path, sock-get_sun_path (), +*namelen - sizeof *sun + sizeof sun-sun_path - 1); + *namelen = sizeof *sun - sizeof sun-sun_path + strlen (sun-sun_path) + 1; res = 0; -- Corinna Vinschen Please, send mails regarding

Re: [Fwd: src/winsup/cygwin ChangeLog child_info.h cyghe ...]

2002-02-10 Thread Corinna Vinschen
On Sun, Feb 10, 2002 at 11:55:01AM -0500, Earnie Boyd wrote: I hate to complain but, the ChangeLog isn't in proper format. Earnie, you *did* check that I fixed that already 12 minutes later, didn't you? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin

Re: Terminal input processing fix

2002-02-25 Thread Corinna Vinschen
are defined in some appropriate header files, e.g. sys/termios.h? I'm looking forward, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Big checkin to allow 64bit file access

2002-02-25 Thread Corinna Vinschen
for new applications (actually, all functions using fpos_t). Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: Big checkin to allow 64bit file access

2002-02-25 Thread Corinna Vinschen
Btw., this introduces two new datatypes, defined by SUSv2 but not yet defined in newlib, blkcnt_t and blksize_t, both used in struct stat. I added the definition of these types to cygwin/include/cygwin/types.h not to trouble newlib for now. Corinna

Re: Terminal input processing fix

2002-03-01 Thread Corinna Vinschen
/termios.h and adapt my code to use it? Yeah, that's what I'm asking for. I think it has always at least a minor advantage to have our implementation in Cygwin modelled on something already existing. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin

Re: [PATCH] Use ftruncate64 directly to not lose upper 32 bits

2002-03-04 Thread Corinna Vinschen
On Mon, Mar 04, 2002 at 01:10:29PM +0800, Dmitry Timoshkov wrote: Hello. 2002-03-04 Dmitry Timoshkov [EMAIL PROTECTED] * syscalls.cc (truncate64): Use ftruncate64 directly to not lose upper 32 bits. Thanks, applied. Corinna -- Corinna Vinschen Please, send mails

Re: Terminal input processing fix (update)

2002-03-05 Thread Corinna Vinschen
On Mon, Mar 04, 2002 at 07:13:11PM +0100, Christian LESTRADE wrote: Here a new version of my input processing patch. Applied. I've just changed your ChangeLog entry slightly. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developer

Re: get_lsa_srv_inf() NT Domain Patch

2002-04-18 Thread Corinna Vinschen
On Wed, Apr 17, 2002 at 11:39:37AM -0400, Jason Tishler wrote: The attached patch prevents extraneous backslashes from being prepended to the logon server name. See the following for more details: Applied, thanks! Corinna -- Corinna Vinschen Please, send mails regarding

Re: SSH -R problem

2002-04-30 Thread Corinna Vinschen
the close(). Fortunately sockets are usually ...why cant we keep that, i. e. If the socket is non blocking then make it blocking set linger to On, as done currently ? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developer

Re: SSH -R problem

2002-04-30 Thread Corinna Vinschen
On Tue, Apr 30, 2002 at 07:32:23AM -0400, Pierre A. Humblet wrote: At 10:32 AM 4/30/2002 +0200, Corinna Vinschen wrote: Of course we are then exposed to the issue that Cygwin was trying to fix by setting linger to On, i.e. the case of a process exiting just after the close(). Fortunately

Re: SSH -R problem

2002-05-02 Thread Corinna Vinschen
On Tue, Apr 30, 2002 at 10:12:08AM -0400, Pierre A. Humblet wrote: Corinna Vinschen wrote: That makes sense... but doesn't that again break something else? What it might break is the case for which linger was added in the first place, i.e. processes terminating and Windows flushing

Re: Security patches

2002-05-13 Thread Corinna Vinschen
On Thu, May 09, 2002 at 08:46:55PM -0400, Pierre A. Humblet wrote: At 04:23 PM 5/8/2002 +0200, Corinna Vinschen wrote: You can retrieve the value of `orig_psid' by calling the method `orig_sid()' now. Doing just that. Thanks, applied. Corinna -- Corinna Vinschen Please

Re: set_errno() fixes

2002-05-17 Thread Corinna Vinschen
. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: lsa handle in security.cc

2002-05-21 Thread Corinna Vinschen
INVALID_HANDLE_VALUE uniformly, instead of NULL. The converse would probably work as well, not sure which is better. Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red

Re: getfacl help/version patch

2002-05-21 Thread Corinna Vinschen
please send another diff? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: [PATCH] cygpath.cc

2002-05-21 Thread Corinna Vinschen
not *that* obvious for the user that s/he has to use `cygpath -w -l ...'. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: [PATCH] cygpath.cc

2002-05-22 Thread Corinna Vinschen
. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: getfacl help/version patch

2002-05-22 Thread Corinna Vinschen
sorry that this comes so late, I haven't seen that yesterday. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: getfacl help/version patch

2002-05-23 Thread Corinna Vinschen
On Wed, May 22, 2002 at 10:57:00AM -0700, Joshua Daniel Franklin wrote: --- Corinna Vinschen [EMAIL PROTECTED] wrote: On Tue, May 21, 2002 at 05:23:22PM -0500, Joshua Daniel Franklin wrote: On Mon, May 20, 2002 at 05:33:01PM -0500, Joshua Daniel Franklin wrote: Here is a patch

Re: Patches to seteuid() etc...

2002-05-24 Thread Corinna Vinschen
On Wed, May 22, 2002 at 11:52:16PM -0400, Pierre A. Humblet wrote: Hello Corinna, Here are the patches to seteuid etc.. discussed recently. I've applied the create_token patch so far. I'd like to have another look into the seteuid/setegid patch first. Thanks, Corinna -- Corinna Vinschen

Re: [PATCH] improve performance of stat() operations (e.g. ls -lR )

2002-05-27 Thread Corinna Vinschen
into account here? We could perhaps speedup stat() for FAT/FAT32 since the hard link count is always 1 for files then. We could completely skip the open() call if the file isn't already open (as in fstat(2)). The FS info is already available from path_conv::check(). Corinna -- Corinna Vinschen

Re: lsa string translation in security.cc, on NT.

2002-05-27 Thread Corinna Vinschen
of the already existing lsa2wchar function so I took the freedom to change it accordingly. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: Patches to seteuid() etc...

2002-05-27 Thread Corinna Vinschen
into the seteuid/setegid patch first. Everything applied now. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: [PATCH] improve performance of stat() operations (e.g. ls -lR )

2002-05-27 Thread Corinna Vinschen
On Mon, May 27, 2002 at 01:43:54PM -0400, Chris Faylor wrote: In the process of researching this, I discovered that NT has a mechanism for determining a filename from an open handle so I'm trying to work that into dtable.cc. Interesting. Could you provide some link? MSDN or so? Corinna

Re: ps help, version patch

2002-05-28 Thread Corinna Vinschen
)? I've fixed it. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: passwd help/version patch

2002-05-29 Thread Corinna Vinschen
that the user Administrator might be renamed to root in /etc/passwd. Do you think you could add something appropriate? Or perhaps change passwd to take the Cygwin name and convert it to the windows name??? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin

[PATCH] Changing from __uid16_t to __uid32_t

2002-05-29 Thread Corinna Vinschen
uid/gid functions. AFAIK, there are no uid/gid related function calls but probably calls to lseek and such. If anybody wants to take a stab on this, I'd be very glad. Just reporting suspect functions in newlib would already be helpful. Corinna -- Corinna Vinschen Please, send

Re: passwd help/version patch

2002-05-30 Thread Corinna Vinschen
On Wed, May 29, 2002 at 05:26:30PM -0700, Joshua Daniel Franklin wrote: --- Corinna Vinschen [EMAIL PROTECTED] wrote: Or perhaps change passwd to take the Cygwin name and convert it to the windows name??? Corinna Maybe I'm missing something, but there doesn't seem to be any Win32

Re: Cleanup of ntdll.h

2002-05-30 Thread Corinna Vinschen
On Thu, May 30, 2002 at 06:04:19PM +1000, Robert Collins wrote: [mailto:[EMAIL PROTECTED]] On Behalf Of Corinna Vinschen I changed that now so that all functions are called with Nt prefix. This is incorrect. BOTH definitions should exist. NtXXX are kernel mode calls, ZwXXX are user mode

Re: Patch to add missing ANSI_STRING typedef to ntdef.h

2002-05-30 Thread Corinna Vinschen
On Thu, May 30, 2002 at 02:12:15AM +0100, Chris January wrote: This patch adds typedefs for ANSI_STRING, PANSI_STRING, OEM_STRING and POEM_STRING to ntdef.h Apologies, I did not attach the patch... :-) I've applied it. Corinna -- Corinna Vinschen Please, send mails

Re: Cleanup of ntdll.h

2002-05-30 Thread Corinna Vinschen
called them NtXXX since that the name of the function is sort of self explaining. IMHO. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: getgrgid() and setegid()

2002-06-03 Thread Corinna Vinschen
On Sun, Jun 02, 2002 at 07:40:17PM -0400, Pierre A. Humblet wrote: 2002-05-30 Pierre Humblet [EMAIL PROTECTED] syscalls.cc (setegid32): Verify the correctness of the gid of the group returned by getgrgid32. Applied. Thanks, Corinna -- Corinna Vinschen

Re: passwd help/version patch

2002-06-03 Thread Corinna Vinschen
point couldn't be found. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: Name aliasing in security.cc

2002-06-05 Thread Corinna Vinschen
(and this is in retrospect the reason you investigated in changing the security stuff). Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: [PATCH] minor pthread fixes

2002-06-05 Thread Corinna Vinschen
below 10 changed lines is treated as nonsignificant. There's no hard rule, though. Basically, if a change is not only fixing a bug but introduces new functionality, it's a significant patch, even if it's changing less than 10 lines. Corinna -- Corinna Vinschen Please, send mails

Re: Name aliasing in security.cc

2002-06-06 Thread Corinna Vinschen
it with something similar. I will remove it later if you apply them. By the way, your ChangeLog entry is missing * passwd.cc :) :) :) Thanks, I've fixed that. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto

Re: Patch for sub-second resolution in stat(2)

2002-06-06 Thread Corinna Vinschen
by a leading TAB, the ChangeLog entry would be correct. ;-) Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: regtool support for remote registry

2002-06-06 Thread Corinna Vinschen
. Shouldn't we add a word that this is possible, too? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: Patch for sub-second resolution in stat(2)

2002-06-06 Thread Corinna Vinschen
On Thu, Jun 06, 2002 at 02:25:33PM +0100, Conrad Scott wrote: Corinna Vinschen [EMAIL PROTECTED] wrote: If you now substitute the leading space by a leading TAB, the ChangeLog entry would be correct. ;-) Corinna But I can't convince Outlook Express to insert tab characters

Re: regtool support for remote registry

2002-06-07 Thread Corinna Vinschen
:/machine/software/microsoft/... CV In this context I see for the first time, that the usage doesn't CV say anything about using forward slashes. Shouldn't we add a word CV that this is possible, too? No probs. This should support both formats. Thanks! Applied. Corinna -- Corinna Vinschen

Re: sem_getvalue patch

2002-06-07 Thread Corinna Vinschen
(guess why I know that ;-)) Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: passwd edited /etc/passwd patch

2002-06-13 Thread Corinna Vinschen
*) user); Thanks for the patch but, hmm, I think I'd prefer to look always for the Cygwin username first. It's unlikely and probably just an academic case but you could have the Cygwin username user_a for the windows user user_b and vice versa. Corinna -- Corinna Vinschen Please

Re: passwd edited /etc/passwd patch

2002-06-14 Thread Corinna Vinschen
On Thu, Jun 13, 2002 at 09:04:11PM -0700, Joshua Daniel Franklin wrote: --- Corinna Vinschen [EMAIL PROTECTED] wrote: On Tue, Jun 11, 2002 at 08:18:15PM -0500, Joshua Daniel Franklin wrote: + /* Try getting a Win32 username in case the user edited /etc/passwd */ + if (ret

Re: Patch to calls.texinfo

2002-06-14 Thread Corinna Vinschen
, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: Reorganizing internal_getlogin()

2002-06-14 Thread Corinna Vinschen
going to apply Chris' changes and some of yours. I don't know exactly which of your changes Chris want to apply. Anyway, we have to work from a new state then. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developer

Re: Windows username in get_group_sidlist

2002-06-24 Thread Corinna Vinschen
it can't happen currently), delete that if you wish. Your patch looks good but I can't apply it. patch(1) doesn't like it, probably due to ricocheting whitespaces. Could you resend it, please? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developer

Re: Windows username in get_group_sidlist

2002-06-24 Thread Corinna Vinschen
On Mon, Jun 24, 2002 at 09:02:26AM -0400, Chris Faylor wrote: patch -l seemed to get most of the way there. That's exactly the option I constantly forget. I even called `man patch' and overlooked it. Sigh. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin

Re: Windows username in get_group_sidlist

2002-06-25 Thread Corinna Vinschen
-- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: Patch to pass file descriptors

2002-06-28 Thread Corinna Vinschen
for the receiver. What do you think? I'm actually very interested in getting that working so I'd appreciate if we could work together on this. Thanks in advance, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developer

Re: [PATCH] fhandler_tty doecho change

2002-09-24 Thread Corinna Vinschen
a ChangeLog entry. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: export fseeko() and ftello() patch

2002-11-07 Thread Corinna Vinschen
The attached patch exports newlib's fseeko() and ftello(). Besides Applied, thanks. Note, though, that this isn't the ultimate solution. In the long run we must write our own entry points for 32 bit as well as 64 bit off_t. The problem is that newlib is still not changed to support both

Re: New ioctls for hard disks

2002-11-07 Thread Corinna Vinschen
On Thu, 24 Oct 2002 02:36:24 +0100, Chris January wrote: This patch implements some new ioctls for hard disks. This means you can run fdisk under Cygwin. Nice patch! Applied. Caution, broad hint follows: Are you planning to maintain a fdisk port to Cygwin? Corinna

Re: SIOCGIFCONF patch

2002-11-10 Thread Corinna Vinschen
entry. It's the other way around according to the doc excerpt which you did friendly send to me. So, I actually would like to ask you to take this part out. As soon as you send the tweaked patch, I'll check it in. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding

Re: patch 3: sshd

2002-11-12 Thread Corinna Vinschen
the shell anyway. The user then finds herself running as SYSTEM. Thanks, I'm going to apply a patch. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:cygwin;cygwin.com Red Hat, Inc.

Re: ntsec patch 1: uid==gid, chmod, alloc_sd, is_grp_member

2002-11-13 Thread Corinna Vinschen
this order, the remaining unrelated deny ACEs are positioned after the owner ACE. That's all and that's correct, AFAICS. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:cygwin;cygwin.com Red Hat, Inc.

Re: ntsec patch 1: uid==gid, chmod, alloc_sd, is_grp_member

2002-11-13 Thread Corinna Vinschen
On Wed, Nov 13, 2002 at 11:18:33AM -0500, Pierre A. Humblet wrote: Corinna Vinschen wrote: I think I found an easy (not necessaily fast) solution which doesn't involve calling the PDC. Basically we do already depend on /etc/group heavily so we can do this here, too, IMHO: Yes

Re: ntsec patch 1: uid==gid, chmod, alloc_sd, is_grp_member

2002-11-14 Thread Corinna Vinschen
On Wed, Nov 13, 2002 at 12:32:31PM -0500, Pierre A. Humblet wrote: Corinna Vinschen wrote: It doesn't add any overhead which isn't already there. If already is before the patch, it scans the group file instead of scanning the token groups. If already is after the patch, it scans the group

Re: ntsec patch 1: uid==gid, chmod, alloc_sd, is_grp_member

2002-11-14 Thread Corinna Vinschen
On Thu, Nov 14, 2002 at 09:30:01AM -0500, Pierre A. Humblet wrote: Corinna Vinschen wrote: Isn't the impersonation token automatically read by OpenProcessToken() when an impersonation took place? I don't think so. I just had another look into MSDN and AFAICS, we would have to call

Re: ntsec patch 1: uid==gid, chmod, alloc_sd, is_grp_member

2002-11-14 Thread Corinna Vinschen
. Write a new routine scanning the /etc/group file until you find the gid. Then scan the members of that group to see if the uid is in it. That's it (well, there will be mutex too, against threads rereading /etc/group). Also a good point. I'm going to rewrite is_grp_member(). Corinna -- Corinna

Re: ntsec patch 1: uid==gid, chmod, alloc_sd, is_grp_member

2002-11-14 Thread Corinna Vinschen
On Thu, Nov 14, 2002 at 06:23:23PM +0100, Corinna Vinschen wrote: On Thu, Nov 14, 2002 at 12:03:24PM -0500, Pierre A. Humblet wrote: If you are emulated, you already have the token in the cygheap-user. There is no need to open the thread, see how it's done e.g.in setegid. Good point

Re: ntsec patch 1: uid==gid, chmod, alloc_sd, is_grp_member

2002-11-15 Thread Corinna Vinschen
. So far, only the group_deny could possibly but unlikely be placed after the owner_allow... Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:cygwin;cygwin.com Red Hat, Inc.

Re: ntsec patch 1: uid==gid, chmod, alloc_sd, is_grp_member

2002-11-15 Thread Corinna Vinschen
after the user allow ACEs since it's very likely that the unrelated ACE has some bit set which is also set in the users ACE. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:cygwin;cygwin.com Red Hat, Inc.

Re: ntsec patch 1: uid==gid, chmod, alloc_sd, is_grp_member

2002-11-15 Thread Corinna Vinschen
On Fri, Nov 15, 2002 at 10:24:36AM -0500, Pierre A. Humblet wrote: Corinna Vinschen wrote: chgrp 544 or 513 /var/empty but that only works for default /etc/group files. 544 is still the best solution, IMHO. Let's take the long term view. Yep. But as far as I'm concerned we should

Re: ntsec patch 1: uid==gid, chmod, alloc_sd, is_grp_member

2002-11-15 Thread Corinna Vinschen
On Fri, Nov 15, 2002 at 12:29:44PM -0500, Pierre A. Humblet wrote: Corinna Vinschen wrote: Yep. But as far as I'm concerned we should drop that part of your patch until I could update ssh. What about putting it in with #if 0 ? It will then be easier to turn it on when ssh is ready

Re: ntsec patch 1: uid==gid, chmod, alloc_sd, is_grp_member

2002-11-20 Thread Corinna Vinschen
On Sun, Nov 17, 2002 at 10:42:55PM -0500, Pierre A. Humblet wrote: At 06:56 PM 11/15/2002 +0100, Corinna Vinschen wrote: On Fri, Nov 15, 2002 at 12:29:44PM -0500, Pierre A. Humblet wrote: Alternatively I could add it, but add a check for group sid is SYSTEM, and then skip the step

Re: ntsec patch #4: passwd and group

2002-11-20 Thread Corinna Vinschen
-user.name (), gr-gr_mem[idx])) - return TRUE; - return FALSE; - } -return FALSE; - } + if ((pw = getpwuid32 (uid))) Same here. Somehow it's a step in the wrong direction... Corinna -- Corinna Vinschen Please, send mails regarding

Re: ntsec patch #4: passwd and group

2002-11-20 Thread Corinna Vinschen
On Wed, Nov 20, 2002 at 10:04:53AM -0500, Pierre A. Humblet wrote: Corinna Vinschen wrote: Ahem, I thought we agreed that we don't call external functions from inside Cygwin? Never mind, there are still some of them which we have to eliminate, anyway. I didn't know about that policy

Re: ntsec patch #4: passwd and group

2002-11-20 Thread Corinna Vinschen
, sure. Somehow I was already fixed on the static buffer track. Applied with changes. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: More passwd/group patches

2002-11-22 Thread Corinna Vinschen
please resend your mail with patch #2? It allows me to follow up simply. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: More passwd/group patches

2002-11-24 Thread Corinna Vinschen
)) + { + lacl[pos].a_type = DEF_CLASS_OBJ; + lacl[pos].a_perm = lacl[dgpos].a_perm; Same here, shouldn't the DEF_CLASS_OBJ entry have rwx, too? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL

Re: More passwd/group patches

2002-11-24 Thread Corinna Vinschen
to ask you if you want me to make the necessary changes to comply with Solaris first and then to send a revised patch, or if you want to incorporate these changes into your patch, too? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developer

Re: More passwd/group patches

2002-11-24 Thread Corinna Vinschen
On Sun, Nov 24, 2002 at 05:08:05PM +0100, Corinna Vinschen wrote: - ...except for in the CLASS_OBJ entry. The default setting on that machine for all my files is 0x1ff and, frankly, I have no idea how to explain that setting. Interesting enough, the Solaris getfacl as well as my

Re: More passwd/group patches

2002-11-24 Thread Corinna Vinschen
On Sun, Nov 24, 2002 at 11:28:17AM -0500, Pierre A. Humblet wrote: At 05:08 PM 11/24/2002 +0100, Corinna Vinschen wrote: The appropriate changes to sec_acl.cc would collide with your patch so I'd like to ask you if you want me to make the necessary changes to comply with Solaris first

Re: More passwd/group patches

2002-11-24 Thread Corinna Vinschen
On Sun, Nov 24, 2002 at 05:12:42PM +0100, Corinna Vinschen wrote: On Sun, Nov 24, 2002 at 05:08:05PM +0100, Corinna Vinschen wrote: - ...except for in the CLASS_OBJ entry. The default setting on that machine for all my files is 0x1ff and, frankly, I have no idea how to explain

Re: More passwd/group patches

2002-11-24 Thread Corinna Vinschen
On Sun, Nov 24, 2002 at 11:28:17AM -0500, Pierre A. Humblet wrote: At 05:08 PM 11/24/2002 +0100, Corinna Vinschen wrote: The appropriate changes to sec_acl.cc would collide with your patch so I'd like to ask you if you want me to make the necessary changes to comply with Solaris first

Re: Internal get{pw,gr}XX calls

2002-11-28 Thread Corinna Vinschen
-uid, gr-gr_gid)) + break; + continue; } break; case GROUP_OBJ: The same without internal_getgrent(), cool! Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developer

Re: Internal get{pw,gr}XX calls

2002-11-29 Thread Corinna Vinschen
Hi Pierre, On Fri, Nov 29, 2002 at 12:59:37AM -0500, Pierre A. Humblet wrote: would run the code of operator pwdgrp_state (). It calls etc_changed () and WaitForSingleObject (), which is completely useless in the context of internal calls that don't reread the files. Ah, ok. I understand

Re: Internal get{pw,gr}XX calls

2002-11-29 Thread Corinna Vinschen
On Fri, Nov 29, 2002 at 06:45:01PM +0100, Corinna Vinschen wrote: That means: If the id string is invalid or empty (stp == src) or the character after the number is not a colon (*stp != ':'), set src to the end of the string (*src == '\0'), else set src to the next character after Reviewing

Re: PATCH: Implementation of functions in netdb.h

2002-12-04 Thread Corinna Vinschen
to avoid clashes with the application using strtok() as well. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: Internal get{pw,gr}XX calls

2002-12-10 Thread Corinna Vinschen
a link to this info? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: Internal get{pw,gr}XX calls

2002-12-10 Thread Corinna Vinschen
. (getgrent32): Ditto. (internal_getgrent): Ditto. I've applied the initial patch plus this one. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: [patch] netdb.cc to use strtok_r

2002-12-10 Thread Corinna Vinschen
inside of this functions is completely encapsulated. So I think we should drop the 'N.B.' comment now entirely. Comment? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: Internal get{pw,gr}XX calls

2002-12-10 Thread Corinna Vinschen
to tell which function you're talking about and I was off track somehow by talking about getpwXXX functionality. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: Small security patches

2002-12-13 Thread Corinna Vinschen
void init(); inline operator const PSID () { return psid; } inline const PSID operator= (cygsid nsid) Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: [patch] netdb.cc to use strtok_r

2002-12-14 Thread Corinna Vinschen
On Tue, Dec 10, 2002 at 02:30:02PM +0100, Corinna Vinschen wrote: So I think we should drop the 'N.B.' comment now entirely. Comment? No comment, so I removed the comment. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developer

Re: Small security patches

2002-12-14 Thread Corinna Vinschen
. Thanks Pierre, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: {get,set}facl.c (part of ntsec, inheritance and sec_acl)

2002-12-15 Thread Corinna Vinschen
. Thanks, applied, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: [PATCH] to_slave pipe is full fix

2002-12-16 Thread Corinna Vinschen
. * fhandler_tty.cc (fhandler_pty_master::accept_input): Return 0 and restore readahead buffer when tty slave pipe is full. did you perhaps forgot to attach the patch? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developer

Re: security.cc and sec_acl.cc (ntsec, inheritance and sec_acl)

2002-12-16 Thread Corinna Vinschen
Hi Pierre, On Mon, Dec 16, 2002 at 10:31:16AM -0500, Pierre A. Humblet wrote: I have a question: there is code in setacl (new line 139) to merge non-default ACE's with previous default ACEs. As the acl was sorted, I don't see how that code can ever be exercised. Should we try to merge

Re: security.cc and sec_acl.cc (ntsec, inheritance and sec_acl)

2002-12-16 Thread Corinna Vinschen
). It won't never merge a user with the creator_owner entry. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: setfacl

2003-01-10 Thread Corinna Vinschen
On Thu, Jan 09, 2003 at 11:18:26PM -0500, Pierre A. Humblet wrote: 2003/01/09 Pierre Humblet [EMAIL PROTECTED] * setfacl (usage): Remove double : for mask and other. Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin

Re: [PATCH] export asprintf and friends

2003-01-10 Thread Corinna Vinschen
: bump CYGWIN_VERSION_API_MINOR Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: ntsec: inheritance, sec_acl and chown

2003-01-12 Thread Corinna Vinschen
psd. Finally applied. Good work, IMHO! Let's test this a week before releasing 1.3.19, ok? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: NT 4.0 fixup_mmaps_after_fork() patch

2003-01-16 Thread Corinna Vinschen
! Details? Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

Re: etc_changed, passwd group.

2003-01-17 Thread Corinna Vinschen
. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Developermailto:[EMAIL PROTECTED] Red Hat, Inc.

  1   2   3   4   5   6   7   8   9   10   >