Re: [PATCH 1/1] Cygwin: don't allow getpgrp() to fail

2019-07-24 Thread Ken Brown
On 7/24/2019 11:04 AM, Ken Brown wrote: > But I still think getpgrp() should be changed I've decided not to pursue this. I don't think it's very important, and I don't know how it might affect applications. Ken

Re: [PATCH 1/1] Cygwin: don't allow getpgrp() to fail

2019-07-24 Thread Corinna Vinschen
On Jul 24 15:04, Ken Brown wrote: > On 7/23/2019 3:16 PM, Corinna Vinschen wrote: > > On Jul 23 19:07, Jon Turney wrote: > >> On 23/07/2019 17:54, Corinna Vinschen wrote: > >>> Hi Ken, > >>> > >>> On Jul 23 16:12, Ken Brown wrote: > According to POSIX, "The getpgrp() function shall always be

Re: [PATCH 1/1] Cygwin: don't allow getpgrp() to fail

2019-07-24 Thread Ken Brown
On 7/23/2019 3:16 PM, Corinna Vinschen wrote: > On Jul 23 19:07, Jon Turney wrote: >> On 23/07/2019 17:54, Corinna Vinschen wrote: >>> Hi Ken, >>> >>> On Jul 23 16:12, Ken Brown wrote: According to POSIX, "The getpgrp() function shall always be successful and no return value is reserved

Re: [PATCH 1/1] Cygwin: don't allow getpgrp() to fail

2019-07-23 Thread Corinna Vinschen
On Jul 23 19:07, Jon Turney wrote: > On 23/07/2019 17:54, Corinna Vinschen wrote: > > Hi Ken, > > > > On Jul 23 16:12, Ken Brown wrote: > > > According to POSIX, "The getpgrp() function shall always be successful > > > and no return value is reserved to indicate an error." Cygwin's > > >

Re: [PATCH 1/1] Cygwin: don't allow getpgrp() to fail

2019-07-23 Thread Jon Turney
On 23/07/2019 17:54, Corinna Vinschen wrote: Hi Ken, On Jul 23 16:12, Ken Brown wrote: According to POSIX, "The getpgrp() function shall always be successful and no return value is reserved to indicate an error." Cygwin's getpgrp() is defined in terms of getpgid(), which is allowed to fail.

Re: [PATCH 1/1] Cygwin: don't allow getpgrp() to fail

2019-07-23 Thread Corinna Vinschen
On Jul 23 18:59, Corinna Vinschen wrote: > On Jul 23 18:54, Corinna Vinschen wrote: > > Hi Ken, > > > > On Jul 23 16:12, Ken Brown wrote: > > > According to POSIX, "The getpgrp() function shall always be successful > > > and no return value is reserved to indicate an error." Cygwin's > > >

Re: [PATCH 1/1] Cygwin: don't allow getpgrp() to fail

2019-07-23 Thread Corinna Vinschen
On Jul 23 18:54, Corinna Vinschen wrote: > Hi Ken, > > On Jul 23 16:12, Ken Brown wrote: > > According to POSIX, "The getpgrp() function shall always be successful > > and no return value is reserved to indicate an error." Cygwin's > > getpgrp() is defined in terms of getpgid(), which is allowed

Re: [PATCH 1/1] Cygwin: don't allow getpgrp() to fail

2019-07-23 Thread Corinna Vinschen
Hi Ken, On Jul 23 16:12, Ken Brown wrote: > According to POSIX, "The getpgrp() function shall always be successful > and no return value is reserved to indicate an error." Cygwin's > getpgrp() is defined in terms of getpgid(), which is allowed to fail. But it shouldn't fail for the current