Re: [PATCH] Cygwin: fegetenv() in winsup/cygwin/fenv.cc should not disable exceptions!

2018-08-05 Thread Houder
On 2018-08-03 14:00, Houder wrote: On 2018-08-03 12:39, Corinna Vinschen wrote: On Aug 3 11:27, Houder wrote: On 2018-08-03 09:36, Corinna Vinschen wrote: [snip] > In terms of x86_64, do we have to change the fenv stuff completely > to use only SSE opcodes? Does that make sense at all?

Re: [PATCH] Cygwin: fegetenv() in winsup/cygwin/fenv.cc should not disable exceptions!

2018-08-03 Thread Corinna Vinschen
On Aug 3 14:00, Houder wrote: > On 2018-08-03 12:39, Corinna Vinschen wrote: > > On Aug 3 11:27, Houder wrote: > > > On 2018-08-03 09:36, Corinna Vinschen wrote: > [snip] > > > > > In terms of x86_64, do we have to change the fenv stuff completely > > > > to use only SSE opcodes? Does that

Re: [PATCH] Cygwin: fegetenv() in winsup/cygwin/fenv.cc should not disable exceptions!

2018-08-03 Thread Houder
On 2018-08-03 14:00, Houder wrote: [snip] As far as I tell, it is neither the machine nor "fenv" that devices to switch from x87 FPU to SSE ... s/devices/decides/ Sorry.

Re: [PATCH] Cygwin: fegetenv() in winsup/cygwin/fenv.cc should not disable exceptions!

2018-08-03 Thread Houder
On 2018-08-03 12:39, Corinna Vinschen wrote: On Aug 3 11:27, Houder wrote: On 2018-08-03 09:36, Corinna Vinschen wrote: [snip] > In terms of x86_64, do we have to change the fenv stuff completely > to use only SSE opcodes? Does that make sense at all? Ho! I have to disappoint you here! I

Re: [PATCH] Cygwin: fegetenv() in winsup/cygwin/fenv.cc should not disable exceptions!

2018-08-03 Thread Corinna Vinschen
On Aug 3 11:27, Houder wrote: > On 2018-08-03 09:36, Corinna Vinschen wrote: > > Hi J.H., > > > > Pushed with tweaks. The string in __asm__ statements works a > > Bah! Must be the heat! I did a compare (sdiff), but missed it. You > are correct: the '\n' is required. > > > bit different and I

Re: [PATCH] Cygwin: fegetenv() in winsup/cygwin/fenv.cc should not disable exceptions!

2018-08-03 Thread Houder
On 2018-08-03 11:27, Houder wrote: I discovered a difference in behaviour between the x87 FPU and SSE. When an exception is masked, a "default action" is carried out when an exception occurs. At the same time the associated status flag is set. (the manual speaks about a "reasonable" default

Re: [PATCH] Cygwin: fegetenv() in winsup/cygwin/fenv.cc should not disable exceptions!

2018-08-03 Thread Houder
On 2018-08-03 09:36, Corinna Vinschen wrote: Hi J.H., Pushed with tweaks. The string in __asm__ statements works a Bah! Must be the heat! I did a compare (sdiff), but missed it. You are correct: the '\n' is required. bit different and I made a slight change to the commit message. No

Re: [PATCH] Cygwin: fegetenv() in winsup/cygwin/fenv.cc should not disable exceptions!

2018-08-03 Thread Corinna Vinschen
Hi J.H., On Aug 3 01:45, J.H. van de Water wrote: > fegetenv() in winsup/cygwin/fenv.cc > > fnstenv MUST be followed by fldenv in fegetenv(), as the former disables all > exceptions in the x87 FPU, which is not appropriate here (fegetenv() ). > fldenv after fnstenv should reload the x87 FPU w/