Re: [darktable-dev] Feature request: preserve luminosity option in channel mixer

2015-11-27 Thread Tobias Ellinghaus
Am Donnerstag, 26. November 2015, 22:48:26 schrieb Caio S. Souza: > Hello! Hi. > I'm almost done implementing this feature, but I have two questions. > 1) I had to add one entry to the struct dt_iop_channelmixer_params_t > to store where the correction must be applied. Should I increment the >

Re: [darktable-dev] Feature request: preserve luminosity option in channel mixer

2015-11-26 Thread Caio S. Souza
Hello! I'm almost done implementing this feature, but I have two questions. 1) I had to add one entry to the struct dt_iop_channelmixer_params_t to store where the correction must be applied. Should I increment the version in the DT_MODULE_INTROSPECTION macro? 2) The final outputs of red, green,

[darktable-dev] Feature request: preserve luminosity option in channel mixer

2015-11-22 Thread Caio S. Souza
Hello, To preserve luminosity when using the Channel Mixer module one must be careful in choosing values for the red, green and blue sliders such that their sum equals 1. If we need to change the sliders values a lot (e.g. when experimenting with their importance on a black and white conversion),

Re: [darktable-dev] Feature request: preserve luminosity option in channel mixer

2015-11-22 Thread Moritz Moeller
On 22/11/15 23:44, Caio S. Souza wrote: I took a look at this module's source code and identified the pieces that must be changed (including the opencl kernel). If you agree this feature is a good idea, I may help implementing it. What do you think? +1 .mm