Re: [darktable-dev] Lens correction with FF lenses used on APS-C

[sturmflut]

Hi,

Am 24.02.19 um 13:32 schrieb Florian W:

> 1 This reasoning is mixing description of digital features with analog
> ones . A lens quality and specs is not defined by MP resolution (rather
> by like purity of the glass, glass curvature homogeneity, CoC, TCA, and
> so on).

You are right, things work a bit differently on the optics side before
the sensor. Hence my use of "oversimplyfing it a bit". But the
resolution of an optical system can still be measured (see e.g. Optical
transer function [1]), and you can specify how much contrast you expect
to see in details and what level of details you expect to still be visible.

It's hard to make exact quantitative statements like "this lens has an
optical transfer function which gives enough contrast for x line pairs
per millimeter, and that would be enough for an x megapixel sensor of
this and this size". Especially because glass quality even differs
within the same manufacturing batch. But for example with my blurry
70-300 it's easy to judge that it would probably be sharp enough for a
12 to 16 megapixel sensor, but nothing better.


> 2 Some of the lenses we're talking about were developed and (partially)
> targeted to FF cameras having a sensor with less MP than a current APS-C
> (for example in Canon, the 6D is a 2012 FF with 20MP).
> 
> If the reasoning is valid, a lens released at times of FF with 24MP or
> higher wouldn't be a good match to the previous cameras with less MP.
> Which doesn't seems to be the case.
>
> What I mean by this is that at some point, to ensure a lens will perform
> well on FF cameras that will be released the following decade, one can
> assume that the optical manufacturing quality is probably one order of
> magnitude above the quality required to fit the current camera sensor
> capabilities. Maybe explaining why you can see problems in older lenses.
I'm not saying that I see a general problem with older lenses, and I
already noted that your prime lenses probably won't cause much of problem.

There's simply a very, very wide range of lenses out there, and the
pricing, engineering and manufacturing decisions can lead to extremely
different optical properties. There are some prime lenses from the 1980s
which are still extremely sharp on today's sensors, but primes are easy.
Most have just seven or eight glass elements.

My Nikon 24-70/2.8 on the other hand has 20 lens elements in 16 groups.
The older Canon 70-200/2.8 has 23 lenses in 19 groups. Even the Nikon
16-35/4 has 17 lens elements. Obviously it is much harder to keep the
optical resolution at the same level when light has to pass through that
many pieces of glass and the lens still has to be affordable. So there
are FF lenses out there which will give good results on APS-C bodies,
but not all will. And you can easily end up getting worse image quality
with a FF lens on an APS-C body when you expected a better one because
the FF lens was more expensive and is supposed to be better.

Also manufacturers don't generally design lenses so thewy will work
perfectly with cameras released a decade later. They will design the
current top model so it has enough room to still be good on the next
model, but they still want you to buy the new "sharper than ever" lens
every five years.

cheers,
Simon










[1] https://en.wikipedia.org/wiki/Optical_transfer_function
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction with FF lenses used on APS-C

[parafin]

dxomark.com website seems to have relevant numbers, see for example
Nikon lens mentioned by Sturm Flut:
https://www.dxomark.com/Lenses/Nikon/AF-S-Nikkor-24-70mm-f-2.8G-ED-mounted-on-Nikon-D750__975
https://www.dxomark.com/Lenses/Nikon/AF-S-Nikkor-24-70mm-f-2.8G-ED-mounted-on-Nikon-D7100__865

Interestingly enough on D810 number is higher than on D750 even though
sensor's physical dimensions are the same, probably due to the absence
of optical low-pass filter:
https://www.dxomark.com/Lenses/Nikon/AF-S-Nikkor-24-70mm-f-2.8G-ED-mounted-on-Nikon-D810__963


On Sun, 24 Feb 2019 13:32:54 +0100
Florian W  wrote:

> Thanks for the details Simon.
> 
> I also thought about it a bit and had a reasoning similar to yours, that
> basically something designed for a specific acquisition chain will probably
> perform worse on an acquisition chain farther from its spec.
> 
> However thinking about it more deeply, 2 things are still boggling my mind.
> 
> 1 This reasoning is mixing description of digital features with analog ones
> . A lens quality and specs is not defined by MP resolution (rather by like
> purity of the glass, glass curvature homogeneity, CoC, TCA, and so on).
> 
> 2 Some of the lenses we're talking about were developed and (partially)
> targeted to FF cameras having a sensor with less MP than a current APS-C
> (for example in Canon, the 6D is a 2012 FF with 20MP).
> 
> If the reasoning is valid, a lens released at times of FF with 24MP or
> higher wouldn't be a good match to the previous cameras with less MP. Which
> doesn't seems to be the case.
> 
> What I mean by this is that at some point, to ensure a lens will perform
> well on FF cameras that will be released the following decade, one can
> assume that the optical manufacturing quality is probably one order of
> magnitude above the quality required to fit the current camera sensor
> capabilities. Maybe explaining why you can see problems in older lenses.
> 
> Please feel free to point any mistake in this reasoning.
> 
> Maybe are we lucky enough that someone working in the optical lenses or
> cameras industry is part of this mailing list and provide us some insights
> about it :)
> 
> Florian Wernert
> Software engineer INSA
> In-training Neuroscience researcher
> https://www.linkedin.com/in/wernertflorian
> 
> 
> 
> Le sam. 23 févr. 2019 à 18:12, Sturm Flut  a
> écrit :
> 
> > Hi,
> >
> > Am 23.02.19 um 16:34 schrieb Florian W:  
> > > Thanks for your answers guys.
> > >
> > > Simon, I'm curious to know why to you it's not the best idea ?  
> >
> > (oversimplifying it a bit)
> >
> > Full-frame lenses are designed to deliver their full sharpness across
> > the whole full-frame image circle. If I put a full-frame lens on my
> > APS-C D7100, I am basically expecting it to deliver 24 megapixels within
> > the smaller APS-C image circle the sensor is cropping out. That means I
> > expect the lens to deliver about 24*2,25 = 54 megapixels over the whole
> > full-frame image circle. Which not that many standard lenses will do.
> >
> > If put my standard 24-70/2.8 on a Nikon D850 and (let's say) it only
> > delivers 40 megapixels of actual resolution instead of the ~46 the
> > sensor wants, that's not going to be a catastrophe. If I put it on a
> > camera with a lower resolution sensor, e.g. the 24 megapixel sensor in
> > the D750, there is zero problem. But if I put the same lens on the
> > D7100, the cropped area will only get around 40 / 2,25 = 17 megapixels.
> > That's suddenly 30% less than what the sensor needs. And not every lens
> > will even deliver these 40 megapixels. Good APS-C and especially
> > Micro-Four-Thirds lenses are expensive and hard to make because they
> > have to be very sharp within the smaller image circle.
> >
> > Prime lenses are usually sharper to begin with, so with your 50/1.8 and
> > 28/2.8 it might not be that much of an issue. But I can clearly see the
> > problem with my 24-70/2.8, and especially with the good old 70-300/4.5-5.6.
> >
> > cheers,
> > Simon
> >  
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
> 
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction with FF lenses used on APS-C

[Florian W]

Thanks for the details Simon.

I also thought about it a bit and had a reasoning similar to yours, that
basically something designed for a specific acquisition chain will probably
perform worse on an acquisition chain farther from its spec.

However thinking about it more deeply, 2 things are still boggling my mind.

1 This reasoning is mixing description of digital features with analog ones
. A lens quality and specs is not defined by MP resolution (rather by like
purity of the glass, glass curvature homogeneity, CoC, TCA, and so on).

2 Some of the lenses we're talking about were developed and (partially)
targeted to FF cameras having a sensor with less MP than a current APS-C
(for example in Canon, the 6D is a 2012 FF with 20MP).

If the reasoning is valid, a lens released at times of FF with 24MP or
higher wouldn't be a good match to the previous cameras with less MP. Which
doesn't seems to be the case.

What I mean by this is that at some point, to ensure a lens will perform
well on FF cameras that will be released the following decade, one can
assume that the optical manufacturing quality is probably one order of
magnitude above the quality required to fit the current camera sensor
capabilities. Maybe explaining why you can see problems in older lenses.

Please feel free to point any mistake in this reasoning.

Maybe are we lucky enough that someone working in the optical lenses or
cameras industry is part of this mailing list and provide us some insights
about it :)

Florian Wernert
Software engineer INSA
In-training Neuroscience researcher
https://www.linkedin.com/in/wernertflorian



Le sam. 23 févr. 2019 à 18:12, Sturm Flut  a
écrit :

> Hi,
>
> Am 23.02.19 um 16:34 schrieb Florian W:
> > Thanks for your answers guys.
> >
> > Simon, I'm curious to know why to you it's not the best idea ?
>
> (oversimplifying it a bit)
>
> Full-frame lenses are designed to deliver their full sharpness across
> the whole full-frame image circle. If I put a full-frame lens on my
> APS-C D7100, I am basically expecting it to deliver 24 megapixels within
> the smaller APS-C image circle the sensor is cropping out. That means I
> expect the lens to deliver about 24*2,25 = 54 megapixels over the whole
> full-frame image circle. Which not that many standard lenses will do.
>
> If put my standard 24-70/2.8 on a Nikon D850 and (let's say) it only
> delivers 40 megapixels of actual resolution instead of the ~46 the
> sensor wants, that's not going to be a catastrophe. If I put it on a
> camera with a lower resolution sensor, e.g. the 24 megapixel sensor in
> the D750, there is zero problem. But if I put the same lens on the
> D7100, the cropped area will only get around 40 / 2,25 = 17 megapixels.
> That's suddenly 30% less than what the sensor needs. And not every lens
> will even deliver these 40 megapixels. Good APS-C and especially
> Micro-Four-Thirds lenses are expensive and hard to make because they
> have to be very sharp within the smaller image circle.
>
> Prime lenses are usually sharper to begin with, so with your 50/1.8 and
> 28/2.8 it might not be that much of an issue. But I can clearly see the
> problem with my 24-70/2.8, and especially with the good old 70-300/4.5-5.6.
>
> cheers,
> Simon
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction with FF lenses used on APS-C

[Jean-Luc Coulon (f5ibh)]

In the database (in liblensfun-data package, file slr-canon.xml for Canon),
you will find the various bodies / lenses.
For each lens, there is a comment like:
 
This allows you to know how the lens was calibrated.

J-L

Le sam. 23 févr. 2019 à 19:31, David Vincent-Jones  a
écrit :

> On my system the camera and correct lens is found by default  which is
> what I want!
>
> David
> On 2019-02-23 9:12 a.m., Sturm Flut wrote:
>
> Hi,
>
> Am 23.02.19 um 16:34 schrieb Florian W:
>
> Thanks for your answers guys.
>
> Simon, I'm curious to know why to you it's not the best idea ?
>
> (oversimplifying it a bit)
>
> Full-frame lenses are designed to deliver their full sharpness across
> the whole full-frame image circle. If I put a full-frame lens on my
> APS-C D7100, I am basically expecting it to deliver 24 megapixels within
> the smaller APS-C image circle the sensor is cropping out. That means I
> expect the lens to deliver about 24*2,25 = 54 megapixels over the whole
> full-frame image circle. Which not that many standard lenses will do.
>
> If put my standard 24-70/2.8 on a Nikon D850 and (let's say) it only
> delivers 40 megapixels of actual resolution instead of the ~46 the
> sensor wants, that's not going to be a catastrophe. If I put it on a
> camera with a lower resolution sensor, e.g. the 24 megapixel sensor in
> the D750, there is zero problem. But if I put the same lens on the
> D7100, the cropped area will only get around 40 / 2,25 = 17 megapixels.
> That's suddenly 30% less than what the sensor needs. And not every lens
> will even deliver these 40 megapixels. Good APS-C and especially
> Micro-Four-Thirds lenses are expensive and hard to make because they
> have to be very sharp within the smaller image circle.
>
> Prime lenses are usually sharper to begin with, so with your 50/1.8 and
> 28/2.8 it might not be that much of an issue. But I can clearly see the
> problem with my 24-70/2.8, and especially with the good old 70-300/4.5-5.6.
>
> cheers,
> Simon
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
>
>
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction with FF lenses used on APS-C

[David Vincent-Jones]

On my system the camera and correct lens is found by default  which 
is what I want!


David

On 2019-02-23 9:12 a.m., Sturm Flut wrote:

Hi,

Am 23.02.19 um 16:34 schrieb Florian W:

Thanks for your answers guys.

Simon, I'm curious to know why to you it's not the best idea ?

(oversimplifying it a bit)

Full-frame lenses are designed to deliver their full sharpness across
the whole full-frame image circle. If I put a full-frame lens on my
APS-C D7100, I am basically expecting it to deliver 24 megapixels within
the smaller APS-C image circle the sensor is cropping out. That means I
expect the lens to deliver about 24*2,25 = 54 megapixels over the whole
full-frame image circle. Which not that many standard lenses will do.

If put my standard 24-70/2.8 on a Nikon D850 and (let's say) it only
delivers 40 megapixels of actual resolution instead of the ~46 the
sensor wants, that's not going to be a catastrophe. If I put it on a
camera with a lower resolution sensor, e.g. the 24 megapixel sensor in
the D750, there is zero problem. But if I put the same lens on the
D7100, the cropped area will only get around 40 / 2,25 = 17 megapixels.
That's suddenly 30% less than what the sensor needs. And not every lens
will even deliver these 40 megapixels. Good APS-C and especially
Micro-Four-Thirds lenses are expensive and hard to make because they
have to be very sharp within the smaller image circle.

Prime lenses are usually sharper to begin with, so with your 50/1.8 and
28/2.8 it might not be that much of an issue. But I can clearly see the
problem with my 24-70/2.8, and especially with the good old 70-300/4.5-5.6.

cheers,
Simon
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org



___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction with FF lenses used on APS-C

[Sturm Flut]

Hi,

Am 23.02.19 um 16:34 schrieb Florian W:
> Thanks for your answers guys.
> 
> Simon, I'm curious to know why to you it's not the best idea ?

(oversimplifying it a bit)

Full-frame lenses are designed to deliver their full sharpness across
the whole full-frame image circle. If I put a full-frame lens on my
APS-C D7100, I am basically expecting it to deliver 24 megapixels within
the smaller APS-C image circle the sensor is cropping out. That means I
expect the lens to deliver about 24*2,25 = 54 megapixels over the whole
full-frame image circle. Which not that many standard lenses will do.

If put my standard 24-70/2.8 on a Nikon D850 and (let's say) it only
delivers 40 megapixels of actual resolution instead of the ~46 the
sensor wants, that's not going to be a catastrophe. If I put it on a
camera with a lower resolution sensor, e.g. the 24 megapixel sensor in
the D750, there is zero problem. But if I put the same lens on the
D7100, the cropped area will only get around 40 / 2,25 = 17 megapixels.
That's suddenly 30% less than what the sensor needs. And not every lens
will even deliver these 40 megapixels. Good APS-C and especially
Micro-Four-Thirds lenses are expensive and hard to make because they
have to be very sharp within the smaller image circle.

Prime lenses are usually sharper to begin with, so with your 50/1.8 and
28/2.8 it might not be that much of an issue. But I can clearly see the
problem with my 24-70/2.8, and especially with the good old 70-300/4.5-5.6.

cheers,
Simon
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction with FF lenses used on APS-C

[Florian W]

Thanks for your answers guys.

Simon, I'm curious to know why to you it's not the best idea ?


Le sam. 23 févr. 2019 16:19, Sturm Flut  a écrit :

> Hi,
>
> it does, as long as lensfun can find the lens in its database. I've been
> using full-frame-only lenses on both my Nikon D750 (full-frame) and
> D7100 (APS-C) for years.
>
> (It's not the best idea, though, so I'm about to replace the D7100 with
> a second full-frame body).
>
> cheers,
> Simon
>
>
>
> Am 23.02.19 um 14:42 schrieb Florian W:
> > Hi,
> > I happen to use on my Canon 750D (APC-C) 2 lenses designed for full
> > frame (Canon EF 50mm f/1.8 STM and Canon EF 28mm f/2.8 IS USM)
> > I wondered if the lens correction module takes into account that the
> > camera is full frame or APS-C to apply the proper correction ?
> >
> > Can someone tell me ?
> > Thanks
> >
> >
> ___
> > darktable developer mailing list to unsubscribe send a mail to
> > darktable-dev+unsubscr...@lists.darktable.org
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction with FF lenses used on APS-C

[Sturm Flut]

Hi,

it does, as long as lensfun can find the lens in its database. I've been
using full-frame-only lenses on both my Nikon D750 (full-frame) and
D7100 (APS-C) for years.

(It's not the best idea, though, so I'm about to replace the D7100 with
a second full-frame body).

cheers,
Simon



Am 23.02.19 um 14:42 schrieb Florian W:
> Hi,
> I happen to use on my Canon 750D (APC-C) 2 lenses designed for full
> frame (Canon EF 50mm f/1.8 STM and Canon EF 28mm f/2.8 IS USM)
> I wondered if the lens correction module takes into account that the
> camera is full frame or APS-C to apply the proper correction ?
> 
> Can someone tell me ?
> Thanks
> 
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction with FF lenses used on APS-C

[Timur Irikovich Davletshin]

I believe it does. Changing body type (full-frame instead of aps-c)
changes geometry. Body type description is nothing more than just a
file in /usr/share/lensfun/version_1 with cropfactor parameter being
the only meaningful information used for geometry calculaton.

Timur.

On Sat, 2019-02-23 at 14:42 +0100, Florian W wrote:
> Hi,
> I happen to use on my Canon 750D (APC-C) 2 lenses designed for full
> frame (Canon EF 50mm f/1.8 STM and Canon EF 28mm f/2.8 IS USM) 
> I wondered if the lens correction module takes into account that the
> camera is full frame or APS-C to apply the proper correction ?
> 
> Can someone tell me ?
> Thanks
> 
> _
> __ darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org 
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction -- move image center feature?

[johannes hanika]

heya,

i had one or two shots in the past where i missed this feature, too
(have an 8mm peleng fisheye). in my case it was mainly about
straightening horizon lines or similar. i ended up doing these in
hugin and forgot about it. other than that i think this is a very
reasonable feature request.

to do it the clean way however, i think this should be part of the
lensfun library (or else we would probably end up duplicating all the
undistortion code.. because you want to shift center in
spherical/angular domain, right?).

cheers,
 jo

On Sat, Dec 29, 2018 at 8:31 PM Moritz Moeller  wrote:
>
> I recently started using very shot fisheye lenses (12-14mm) for event
> photography. The idea is that you will never catch the right
> angle/composition/moment all together at a wedding/party etc.
>
> Afterwards, you undistort the images and crop to the region with the
> best composition, to obtain a FOV more like 35mm or 50mm.
>
> The problem is that you also want to shift the image around in the
> distorted space before undistorting & cropping. Not after.
>
> Basically change the center, before undistorting so you don't get the
> extreme proportional changes at the edges of the image (which may,
> because of the region you crop to, end up much closer to the center
> afterwards).
>
> Would it make sense/be possible to add a horizontal/vertical shift to
> the lens undistort module for this?
> If so, I'd create a feature request in the tracker with some example RAWs.
>
>
> Beers,
>
> .mm
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
>
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens Correction

[Maurizio Paglia]

Just for the records - as regards OpenSuse Leap problem is solved using
darktable and lensfun from offical repos or 'graphics' repo (NOT
graphics/darktable).
Here below the complete bug issue
https://bugzilla.opensuse.org/show_bug.cgi?id=1090686

Enjoy
Maurizio

2018-04-24 23:06 GMT+02:00 Patrick Shanahan :

> * Maurizio Paglia  [04-24-18 16:29]:
> > Is it a stable build?
> >
> > Il mar 24 apr 2018, 20:06 Patrick Shanahan  ha
> scritto:
> >
> > > * Maurizio Paglia  [04-24-18 13:55]:
> > > > @ Frank
> > > > Tested your solution but still does not work.
> > > > Seems the only possibility is to downgrade lensfun from 0.3.2 to
> 0.3.1
> > > > I already opened a bug issue with Leap developers that already asked
> for
> > > > more information.
> > > >
> > > > I will post further issue on the mailing list.
> > > > Thank you for your kind effort.
> > > >
> > > > Maurizio
> > > >
> > > > 2018-04-24 19:23 GMT+02:00 Frank Huebner :
> > > >
> > > > > Germano Massullo  writes:
> > > > >
> > > > > > Il 23/04/2018 18:28, Maurizio Paglia ha scritto:
> > > > > >> Well, downgraded lensfun from 0.3.2 to 0.3.1 and now all works!
> > > > > > You probably should tell darktable maintainer to rebuild
> darktable
> > > > > > against new lensfun version
> > > > >
> > > > >
> > > > > I guess I had the same problem - asked for help here but could not
> get
> > > > > it. I figured out a workaround (opensuse leap, darktable 2.4.2,
> lensfun
> > > > > 0.3.2):
> > > > >
> > > > > Install lensfun-tools
> > > > >
> > > > > run lensfun-update-data as normal user
> > > > >
> > > > > In my case lensfun-update-data saved the lensfun calibration data
> in
> > > > > ~/.local/share/lensfun/updates/version_1
> > > > >
> > > > > Then I copied all *.xml files from
> > > > > ~/.local/share/lensfun/updates/version_1 to ~/.local/share/lensfun
> > > > >
> > > > > After this, darktable recognized my camera and lenses again.
> > > > >
> > > > > Hope this helps!
> > > > >
> > > > > 
> > > > > ___
> > > > > darktable developer mailing list
> > > > > to unsubscribe send a mail to darktable-dev+unsubscribe@
> > > > > lists.darktable.org
> > > > >
> > > > >
> > > >
> > > >
> > > 
> ___
> > > > darktable developer mailing list
> > > > to unsubscribe send a mail to
> > > darktable-dev+unsubscr...@lists.darktable.org
> > >
> > > why don't you just get darix' build?  it just works!
> > >
> > > https://download.opensuse.org/repositories/graphics:/
> darktable:/master/openSUSE_Leap_15.0/x86_64/darktable-2.
> 5.0~git333.1f26b4f44-lp150.209.1.x86_64.rpm
> > >
> > > the url is long and a one liner
> > > the dt version is master from git and frequently updated
> > >
> > > you could also add his site as a repo and keep the latest installed:
> > >   [graphics_darktable_master]
> > >   name=Darktable-Org Master snapshots (openSUSE_Leap_15.0)
> > >   type=rpm-md
> > >   baseurl=
> > > http://download.opensuse.org/repositories/graphics:/
> darktable:/master/openSUSE_Leap_15.0/
> > >   gpgcheck=1
> > >   gpgkey=
> > > http://download.opensuse.org/repositories/graphics:/
> darktable:/master/openSUSE_Leap_15.0/repodata/repomd.xml.key
> > >   enabled=1
> > >
> > > I have been using his builds for several years now with few problems
> that
> > > are quickly resolved when they happen.
> > >
> > > --
> > > (paka)Patrick Shanahan   Plainfield, Indiana, USA
> @ptilopteri
> > > http://en.opensuse.orgopenSUSE Community Member
> facebook/ptilopteri
> > > Registered Linux User #207535@
> http://linuxcounter.net
> > > Photos: http://wahoo.no-ip.org/piwigo   paka @ IRCnet
> freenode
> > > 
> ___
> > > darktable developer mailing list
> > > to unsubscribe send a mail to
> > > darktable-dev+unsubscr...@lists.darktable.org
> > >
> > >
> >
> > 
> ___
> > darktable developer mailing list
> > to unsubscribe send a mail to darktable-dev+unsubscribe@
> lists.darktable.org
>
> the one I use is a development build but it has been stable for me.  darix
> also provides a stable build, but you can find the repo setup for youself.
> and I wonder why you worry about a "stable" build, you are running Leap 15
> which has not been released yet.  what is the difference?
>
> I have been running the development build for production use for quite a
> few years now, on Tumbleweed, with no downtime.
>
> --
> (paka)Patrick Shanahan   Plainfield, Indiana, USA  @ptilopteri
> http://en.opensuse.orgopenSUSE Community Memberfacebook/ptilopteri
> Registered Linux User #207535@ http://linuxcounter.net
> Photos: 

Re: [darktable-dev] Lens Correction

[Patrick Shanahan]

* Maurizio Paglia  [04-24-18 16:29]:
> Is it a stable build?
> 
> Il mar 24 apr 2018, 20:06 Patrick Shanahan  ha scritto:
> 
> > * Maurizio Paglia  [04-24-18 13:55]:
> > > @ Frank
> > > Tested your solution but still does not work.
> > > Seems the only possibility is to downgrade lensfun from 0.3.2 to 0.3.1
> > > I already opened a bug issue with Leap developers that already asked for
> > > more information.
> > >
> > > I will post further issue on the mailing list.
> > > Thank you for your kind effort.
> > >
> > > Maurizio
> > >
> > > 2018-04-24 19:23 GMT+02:00 Frank Huebner :
> > >
> > > > Germano Massullo  writes:
> > > >
> > > > > Il 23/04/2018 18:28, Maurizio Paglia ha scritto:
> > > > >> Well, downgraded lensfun from 0.3.2 to 0.3.1 and now all works!
> > > > > You probably should tell darktable maintainer to rebuild darktable
> > > > > against new lensfun version
> > > >
> > > >
> > > > I guess I had the same problem - asked for help here but could not get
> > > > it. I figured out a workaround (opensuse leap, darktable 2.4.2, lensfun
> > > > 0.3.2):
> > > >
> > > > Install lensfun-tools
> > > >
> > > > run lensfun-update-data as normal user
> > > >
> > > > In my case lensfun-update-data saved the lensfun calibration data in
> > > > ~/.local/share/lensfun/updates/version_1
> > > >
> > > > Then I copied all *.xml files from
> > > > ~/.local/share/lensfun/updates/version_1 to ~/.local/share/lensfun
> > > >
> > > > After this, darktable recognized my camera and lenses again.
> > > >
> > > > Hope this helps!
> > > >
> > > > 
> > > > ___
> > > > darktable developer mailing list
> > > > to unsubscribe send a mail to darktable-dev+unsubscribe@
> > > > lists.darktable.org
> > > >
> > > >
> > >
> > >
> > ___
> > > darktable developer mailing list
> > > to unsubscribe send a mail to
> > darktable-dev+unsubscr...@lists.darktable.org
> >
> > why don't you just get darix' build?  it just works!
> >
> > https://download.opensuse.org/repositories/graphics:/darktable:/master/openSUSE_Leap_15.0/x86_64/darktable-2.5.0~git333.1f26b4f44-lp150.209.1.x86_64.rpm
> >
> > the url is long and a one liner
> > the dt version is master from git and frequently updated
> >
> > you could also add his site as a repo and keep the latest installed:
> >   [graphics_darktable_master]
> >   name=Darktable-Org Master snapshots (openSUSE_Leap_15.0)
> >   type=rpm-md
> >   baseurl=
> > http://download.opensuse.org/repositories/graphics:/darktable:/master/openSUSE_Leap_15.0/
> >   gpgcheck=1
> >   gpgkey=
> > http://download.opensuse.org/repositories/graphics:/darktable:/master/openSUSE_Leap_15.0/repodata/repomd.xml.key
> >   enabled=1
> >
> > I have been using his builds for several years now with few problems that
> > are quickly resolved when they happen.
> >
> > --
> > (paka)Patrick Shanahan   Plainfield, Indiana, USA  @ptilopteri
> > http://en.opensuse.orgopenSUSE Community Memberfacebook/ptilopteri
> > Registered Linux User #207535@ http://linuxcounter.net
> > Photos: http://wahoo.no-ip.org/piwigo   paka @ IRCnet freenode
> > ___
> > darktable developer mailing list
> > to unsubscribe send a mail to
> > darktable-dev+unsubscr...@lists.darktable.org
> >
> >
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

the one I use is a development build but it has been stable for me.  darix
also provides a stable build, but you can find the repo setup for youself. 
and I wonder why you worry about a "stable" build, you are running Leap 15
which has not been released yet.  what is the difference?

I have been running the development build for production use for quite a
few years now, on Tumbleweed, with no downtime.

-- 
(paka)Patrick Shanahan   Plainfield, Indiana, USA  @ptilopteri
http://en.opensuse.orgopenSUSE Community Memberfacebook/ptilopteri
Registered Linux User #207535@ http://linuxcounter.net
Photos: http://wahoo.no-ip.org/piwigo   paka @ IRCnet freenode
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens Correction

[Maurizio Paglia]

Is it a stable build?

Il mar 24 apr 2018, 20:06 Patrick Shanahan  ha scritto:

> * Maurizio Paglia  [04-24-18 13:55]:
> > @ Frank
> > Tested your solution but still does not work.
> > Seems the only possibility is to downgrade lensfun from 0.3.2 to 0.3.1
> > I already opened a bug issue with Leap developers that already asked for
> > more information.
> >
> > I will post further issue on the mailing list.
> > Thank you for your kind effort.
> >
> > Maurizio
> >
> > 2018-04-24 19:23 GMT+02:00 Frank Huebner :
> >
> > > Germano Massullo  writes:
> > >
> > > > Il 23/04/2018 18:28, Maurizio Paglia ha scritto:
> > > >> Well, downgraded lensfun from 0.3.2 to 0.3.1 and now all works!
> > > > You probably should tell darktable maintainer to rebuild darktable
> > > > against new lensfun version
> > >
> > >
> > > I guess I had the same problem - asked for help here but could not get
> > > it. I figured out a workaround (opensuse leap, darktable 2.4.2, lensfun
> > > 0.3.2):
> > >
> > > Install lensfun-tools
> > >
> > > run lensfun-update-data as normal user
> > >
> > > In my case lensfun-update-data saved the lensfun calibration data in
> > > ~/.local/share/lensfun/updates/version_1
> > >
> > > Then I copied all *.xml files from
> > > ~/.local/share/lensfun/updates/version_1 to ~/.local/share/lensfun
> > >
> > > After this, darktable recognized my camera and lenses again.
> > >
> > > Hope this helps!
> > >
> > > 
> > > ___
> > > darktable developer mailing list
> > > to unsubscribe send a mail to darktable-dev+unsubscribe@
> > > lists.darktable.org
> > >
> > >
> >
> >
> ___
> > darktable developer mailing list
> > to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>
> why don't you just get darix' build?  it just works!
>
> https://download.opensuse.org/repositories/graphics:/darktable:/master/openSUSE_Leap_15.0/x86_64/darktable-2.5.0~git333.1f26b4f44-lp150.209.1.x86_64.rpm
>
> the url is long and a one liner
> the dt version is master from git and frequently updated
>
> you could also add his site as a repo and keep the latest installed:
>   [graphics_darktable_master]
>   name=Darktable-Org Master snapshots (openSUSE_Leap_15.0)
>   type=rpm-md
>   baseurl=
> http://download.opensuse.org/repositories/graphics:/darktable:/master/openSUSE_Leap_15.0/
>   gpgcheck=1
>   gpgkey=
> http://download.opensuse.org/repositories/graphics:/darktable:/master/openSUSE_Leap_15.0/repodata/repomd.xml.key
>   enabled=1
>
> I have been using his builds for several years now with few problems that
> are quickly resolved when they happen.
>
> --
> (paka)Patrick Shanahan   Plainfield, Indiana, USA  @ptilopteri
> http://en.opensuse.orgopenSUSE Community Memberfacebook/ptilopteri
> Registered Linux User #207535@ http://linuxcounter.net
> Photos: http://wahoo.no-ip.org/piwigo   paka @ IRCnet freenode
> ___
> darktable developer mailing list
> to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens Correction

[Maurizio Paglia]

@ Frank
Tested your solution but still does not work.
Seems the only possibility is to downgrade lensfun from 0.3.2 to 0.3.1
I already opened a bug issue with Leap developers that already asked for
more information.

I will post further issue on the mailing list.
Thank you for your kind effort.

Maurizio

2018-04-24 19:23 GMT+02:00 Frank Huebner :

> Germano Massullo  writes:
>
> > Il 23/04/2018 18:28, Maurizio Paglia ha scritto:
> >> Well, downgraded lensfun from 0.3.2 to 0.3.1 and now all works!
> > You probably should tell darktable maintainer to rebuild darktable
> > against new lensfun version
>
>
> I guess I had the same problem - asked for help here but could not get
> it. I figured out a workaround (opensuse leap, darktable 2.4.2, lensfun
> 0.3.2):
>
> Install lensfun-tools
>
> run lensfun-update-data as normal user
>
> In my case lensfun-update-data saved the lensfun calibration data in
> ~/.local/share/lensfun/updates/version_1
>
> Then I copied all *.xml files from
> ~/.local/share/lensfun/updates/version_1 to ~/.local/share/lensfun
>
> After this, darktable recognized my camera and lenses again.
>
> Hope this helps!
>
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscribe@
> lists.darktable.org
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens Correction

[Frank Huebner]

Germano Massullo  writes:

> Il 23/04/2018 18:28, Maurizio Paglia ha scritto:
>> Well, downgraded lensfun from 0.3.2 to 0.3.1 and now all works!
> You probably should tell darktable maintainer to rebuild darktable
> against new lensfun version


I guess I had the same problem - asked for help here but could not get
it. I figured out a workaround (opensuse leap, darktable 2.4.2, lensfun
0.3.2):

Install lensfun-tools

run lensfun-update-data as normal user

In my case lensfun-update-data saved the lensfun calibration data in
~/.local/share/lensfun/updates/version_1

Then I copied all *.xml files from
~/.local/share/lensfun/updates/version_1 to ~/.local/share/lensfun

After this, darktable recognized my camera and lenses again.

Hope this helps!

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens Correction

[Germano Massullo]

Il 23/04/2018 18:28, Maurizio Paglia ha scritto:
> Well, downgraded lensfun from 0.3.2 to 0.3.1 and now all works!
You probably should tell darktable maintainer to rebuild darktable
against new lensfun version
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens Correction

[Maurizio Paglia]

Well, downgraded lensfun from 0.3.2 to 0.3.1 and now all works!

Maurizio

2018-04-23 17:23 GMT+02:00 Maurizio Paglia :

> OpenSuse Leap
>
> 2018-04-23 17:00 GMT+02:00 Germano Massullo :
>
>> Il 23/04/2018 16:46, Maurizio Paglia ha scritto:
>> > I do not compile dt from sources but install my distribution RPMs
>>
>> Fedora?
>> 
>> ___
>> darktable developer mailing list
>> to unsubscribe send a mail to darktable-dev+unsubscribe@list
>> s.darktable.org
>>
>>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens Correction

[Maurizio Paglia]

OpenSuse Leap

2018-04-23 17:00 GMT+02:00 Germano Massullo :

> Il 23/04/2018 16:46, Maurizio Paglia ha scritto:
> > I do not compile dt from sources but install my distribution RPMs
>
> Fedora?
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscribe@
> lists.darktable.org
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens Correction

[Germano Massullo]

Il 23/04/2018 16:46, Maurizio Paglia ha scritto:
> I do not compile dt from sources but install my distribution RPMs

Fedora?
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens Correction

[Maurizio Paglia]

Thanks to all!

@ Mark Feit - I noticed too that Camera and Lens are duly identified in the
image data (lighttable)
I do not compile dt from sources but install my distribution RPMs
This evening I will try to downgrade lensfun to those recommended by my
package manager and will let you know.

Maurizio

2018-04-23 14:43 GMT+02:00 Mark Feit :

> On 04/23/2018 03:26 AM, sturmflut wrote:
>
>> Could it maybe be possible that the lensfun database got corrupted on
>> some systems?
>>
>
> It's not just some systems and it's not a database problem.  I've had this
> problem for a long time and, figuring it was pilot error, never got around
> to digging around to find the cause.
>
> The DT I run (2.4.1 on Linux; I will be upgrading later this spring when I
> get a lull in shooting) is built from the sources against the lensfun
> installed on the system, which I update (binaries and data) before
> building.  That leaves no chance of a version mismatch.
>
> DT correctly identifies the body and lens in the image information box.
> The Lens Correction tool correctly recognizes my bodies (SLR and
> point-and-shoot) but fails to recognize any of the lenses I use regularly:
>
> Nikkor AF 18-35mm f/3.5-4.5D IF-ED
> Nikkor AF-S 28-300mm f/3.5-5.6G ED VR
> Nikkor AF 35-70mm f/2.8D
> Nikkor AF 50mm f/1.4D
> Nikkor AF-S 70-200mm f/2.8G VR IF-ED
>
> I've checked the XML files that make up the Lensfun database, and all are
> in there.  I also have and use a 28-105 which is not in the database and,
> as expected, isn't found and behaves the same way.
>
> One other thing I've noticed is that the list of choices available when
> trying to select a lens manually is a subset of what's in the database.
> The brands with a compatible mount show up (so I get Nikon, Tamron and
> Samyang but not Canon or Olympus), but the list of lenses is incomplete
> despite being in the XML.  Whether this is a problem in Lensfun or DT
> remains to be seen, but I'd be hard-pressed to believe that a Lensfun
> failure to recognize common lenses like the 70-200 or the 50 f/1.4 would
> have been left to fester for very long.
>
> An image that illustrates the problem on my system can be downloaded from
> https://s3.wasabisys.com/darktable/lensfun.nef.
>
> --Mark
>
>
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscribe@list
> s.darktable.org
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens Correction

[sturmflut]

Dear list,

I don't know much about lensfun, but I can confirm that in my setup
(lensfun 0.3.2-6 package as supplied by Arch Linux, darktable built
manually from the current darktable-2.4.x branch) the lens correction
module actually fails to select the right settings for this picture
(Nikon AF-S VR Zoom-Nikkor 70-200mm f/2.8G IF-ED on a Nikon D750).

I quickly hacked a couple of printf()'s into src/iop/lens.c and it looks
like lf_db_find_lenses_hd() is called with the right arguments, but
fails to return a result.

I've noticed two things.

First: lenstool recognizes this lens as an APS-C lens, but as far as I
can tell it is a full-frame lens?

$ lenstool -L "Nikon AF-S VR Zoom-Nikkor 70-200mm f/2.8G IF-ED"

Matching lens found in the database:
  Nikon / Nikkor AF-S 70-200mm f/2.8G VR IF-ED
|- Crop factor: 1,528
|- Aspect ratio: 1,5
|- Focal: 70-200mm
|- Min-Aperture: f/2,8
|- Center: 0,0
|- Compatible mounts: Nikon F AF,
|- Calibration data: tca, vign, dist,

Second: The other lenses Mark mentioned also seem to be marked as APS-C
lenses in the lensfun database, but actually seem to be full frame
lenses. There are only a few APS-C lenses listed in the drop down, e.g.
the Nikon AF-S DX Nikkor 35mm f/1.8G, but that's because this lens
actually has two entries in the Nikon database (one for crop factor
1,528 and one for crop factor 1).

Does this maybe point to the root cause?

cheers,
Simon


On 23.04.2018 14:43, Mark Feit wrote:
> On 04/23/2018 03:26 AM, sturmflut wrote:
>> Could it maybe be possible that the lensfun database got corrupted on
>> some systems?
> 
> It's not just some systems and it's not a database problem.  I've had
> this problem for a long time and, figuring it was pilot error, never got
> around to digging around to find the cause.
> 
> The DT I run (2.4.1 on Linux; I will be upgrading later this spring when
> I get a lull in shooting) is built from the sources against the lensfun
> installed on the system, which I update (binaries and data) before
> building.  That leaves no chance of a version mismatch.
> 
> DT correctly identifies the body and lens in the image information box. 
> The Lens Correction tool correctly recognizes my bodies (SLR and
> point-and-shoot) but fails to recognize any of the lenses I use regularly:
> 
> Nikkor AF 18-35mm f/3.5-4.5D IF-ED
> Nikkor AF-S 28-300mm f/3.5-5.6G ED VR
> Nikkor AF 35-70mm f/2.8D
> Nikkor AF 50mm f/1.4D
> Nikkor AF-S 70-200mm f/2.8G VR IF-ED
> 
> I've checked the XML files that make up the Lensfun database, and all
> are in there.  I also have and use a 28-105 which is not in the database
> and, as expected, isn't found and behaves the same way.
> 
> One other thing I've noticed is that the list of choices available when
> trying to select a lens manually is a subset of what's in the database. 
> The brands with a compatible mount show up (so I get Nikon, Tamron and
> Samyang but not Canon or Olympus), but the list of lenses is incomplete
> despite being in the XML.  Whether this is a problem in Lensfun or DT
> remains to be seen, but I'd be hard-pressed to believe that a Lensfun
> failure to recognize common lenses like the 70-200 or the 50 f/1.4 would
> have been left to fester for very long.
> 
> An image that illustrates the problem on my system can be downloaded
> from https://s3.wasabisys.com/darktable/lensfun.nef.
> 
> --Mark
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
> 
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens Correction

[Mark Feit]

On 04/23/2018 03:26 AM, sturmflut wrote:

Could it maybe be possible that the lensfun database got corrupted on
some systems?


It's not just some systems and it's not a database problem.  I've had 
this problem for a long time and, figuring it was pilot error, never got 
around to digging around to find the cause.


The DT I run (2.4.1 on Linux; I will be upgrading later this spring when 
I get a lull in shooting) is built from the sources against the lensfun 
installed on the system, which I update (binaries and data) before 
building.  That leaves no chance of a version mismatch.


DT correctly identifies the body and lens in the image information box.  
The Lens Correction tool correctly recognizes my bodies (SLR and 
point-and-shoot) but fails to recognize any of the lenses I use regularly:


Nikkor AF 18-35mm f/3.5-4.5D IF-ED
Nikkor AF-S 28-300mm f/3.5-5.6G ED VR
Nikkor AF 35-70mm f/2.8D
Nikkor AF 50mm f/1.4D
Nikkor AF-S 70-200mm f/2.8G VR IF-ED

I've checked the XML files that make up the Lensfun database, and all 
are in there.  I also have and use a 28-105 which is not in the database 
and, as expected, isn't found and behaves the same way.


One other thing I've noticed is that the list of choices available when 
trying to select a lens manually is a subset of what's in the database.  
The brands with a compatible mount show up (so I get Nikon, Tamron and 
Samyang but not Canon or Olympus), but the list of lenses is incomplete 
despite being in the XML.  Whether this is a problem in Lensfun or DT 
remains to be seen, but I'd be hard-pressed to believe that a Lensfun 
failure to recognize common lenses like the 70-200 or the 50 f/1.4 would 
have been left to fester for very long.


An image that illustrates the problem on my system can be downloaded 
from https://s3.wasabisys.com/darktable/lensfun.nef.


--Mark

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens Correction

[sturmflut]

Dear list,

for what it's worth:

I ran into a similar problem yesterday. Suddenly my Nikon 70-200/2.8 VR
II lens was missing from the lens correction module while my D750 and
other Nikon lenses were available. I remembered I had run
"lensfun-update-data" last week and it had failed because one of the
download URLs (http://wilson.bronger.org/lensfun-db/versions.json) was
down. Running lensfun-update-data again fixed the issue.

Could it maybe be possible that the lensfun database got corrupted on
some systems?

cheers,
Simon



On 23.04.2018 09:02, Maurizio Paglia wrote:
> Found this on pixls.us 
> https://discuss.pixls.us/t/lens-correction-module-camera-lens-not-found/2242
> 
> @ Daudi Amani - please give it a try.
> I am at work now so cannot carry on any sort of tests. I will try as
> soon at home
> 
> Maurizio
> 
> 2018-04-23 6:20 GMT+02:00 Daudi Amani  >:
> 
> That's what I've been trying to tell people; I have the same
> problem. No seems to understand.
> 
> On Sun, Apr 22, 2018 at 1:16 AM Maurizio Paglia  > wrote:
> 
> Hi,
> my module 'lens correction' works no more.
> I cannot see ANY camera brand in the combo list, it is empty...
> Also images previously developed have the module activated but
> with NO
> correction.
> 
> Thank you,
> 
> Maurizio
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
> 
> 
> 
> 
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens Correction

[Maurizio Paglia]

Found this on pixls.us
https://discuss.pixls.us/t/lens-correction-module-camera-lens-not-found/2242

@ Daudi Amani - please give it a try.
I am at work now so cannot carry on any sort of tests. I will try as soon
at home

Maurizio

2018-04-23 6:20 GMT+02:00 Daudi Amani :

> That's what I've been trying to tell people; I have the same problem. No
> seems to understand.
>
> On Sun, Apr 22, 2018 at 1:16 AM Maurizio Paglia 
> wrote:
>
>> Hi,
>> my module 'lens correction' works no more.
>> I cannot see ANY camera brand in the combo list, it is empty...
>> Also images previously developed have the module activated but with NO
>> correction.
>>
>> Thank you,
>>
>> Maurizio
>> 
>> ___
>> darktable developer mailing list
>> to unsubscribe send a mail to darktable-dev+unsubscribe@
>> lists.darktable.org
>>
>>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens Correction

[Daudi Amani]

That's what I've been trying to tell people; I have the same problem. No
seems to understand.

On Sun, Apr 22, 2018 at 1:16 AM Maurizio Paglia  wrote:

> Hi,
> my module 'lens correction' works no more.
> I cannot see ANY camera brand in the combo list, it is empty...
> Also images previously developed have the module activated but with NO
> correction.
>
> Thank you,
>
> Maurizio
> ___
> darktable developer mailing list
> to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] lens correction / Fujifilm X-T2

[M.Bungert]

Thanks for advise 

sudo lensfun-update-data

did the job

Regards,
Marcus
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] lens correction / Fujifilm X-T2

[Roman Lebedev]

On Mon, Aug 7, 2017 at 9:19 AM, Marcus Bungert  wrote:
> I just got my new gear, moving from D600 to Fujifilm X-T2.
>
> I'm wondering that the X-T2 is not recognized by "lens correction" but the
> lense.
> The camera is listed as supported
> (http://www.darktable.org/resources/camera-support/)
>
> A manual selection is not possible, the camera is not listed in the menu.
>
> Is this a known issue or do I have to install something else to get support
> for lens correction?
>
> I use always the actual darktable-git version from Arch User Repository, but
> it is the same with official release 2.2.5
Lens support is lensfun's problem.
http://lensfun.sourceforge.net/lenslist/

> Regards,
> Marcus
>
> ___
> darktable developer mailing list to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction based on EXIF data on Sony cameras

[Kelvie Wong]

On Sat, 8 Apr 2017 at 11:50 Kelvie Wong  wrote:

> I'm still investigating if TCA correcions are baked in even if they are
> turned off in-camera; a preliminary test shows a difference of only about
> +/- 0.0001, not sure that's significant or not (see attached diff;
> generated using tca_correct with raws with CA correction on auto, to CA
> correction off).
>

Forgot to attach the diff, here it is for the SEL2470GM.

- tca_correct values with CA compensation set to Auto
+ tca_correct values with CA compensation set to Off
-- 

-- 
Kelvie Wong

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.orgdiff --git a/data/db/mil-sony.xml b/data/db/mil-sony.xml
index 75fce80..abd2a5b 100644
--- a/data/db/mil-sony.xml
+++ b/data/db/mil-sony.xml
@@ -1280,22 +1280,21 @@
 
 
 
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
 
 
 

Re: [darktable-dev] Lens correction based on EXIF data on Sony cameras

[Kelvie Wong]

Thanks, Matthias.


On Sat, 8 Apr 2017 at 05:03 Matthias Andree  wrote:


1. If the assessments of your references are true that TCA
(LateralChromaticAberration) are always baked into the ARW then the
lensfun data will have been measured with TCA pre-corrected by the
camera and lensfun data will only compensate for the difference between
the in-camera precorrection and hugin's (lensfun's) idea of how much TCA
should be compensated.


I'm still investigating if TCA correcions are baked in even if they are
turned off in-camera; a preliminary test shows a difference of only about
+/- 0.0001, not sure that's significant or not (see attached diff;
generated using tca_correct with raws with CA correction on auto, to CA
correction off).

I think in either case I still needed to de-fringe or manually adjust the
CA parameters to remove all the CA.


I think as a workaround for the time being the only way I have is to
alter the lens names (add "VignPreComp" to the name, or similar) and
manually choose them, to go along with datasets that compensate for the
delta between the in-camera pre-compensated vignetting, and the full
compensation. This can then be re-written properly once lensfun exposes
a way to choose from alternate data sets for the same lens.


Yeah, we'd have to do this for all the lenses right? I guess we could
script that.

Another point of research is if the camera-compensated delta is constant
for all lens / focal length / aperture, I would be delighted if it were,
but not surprised if it wasn't.

Kelvie
-- 

-- 
Kelvie Wong

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction based on EXIF data on Sony cameras

[Matthias Andree]

Greetings,

I have created a related ticket with the lensfun project:

https://sourceforge.net/p/lensfun/bugs/78/


This really only matters for VignettingCorrection:

1. If the assessments of your references are true that TCA
(LateralChromaticAberration) are always baked into the ARW then the
lensfun data will have been measured with TCA pre-corrected by the
camera and lensfun data will only compensate for the difference between
the in-camera precorrection and hugin's (lensfun's) idea of how much TCA
should be compensated.

2. Distortion is never baked into the ARW, so the lensfun corrections
can safely be applied to undistort images.

3. I have some images where shading compensation was on in-camera and
then applying the full correction in darktable based on lensfun data
would lead to over-correction. The workaround is either to fake a
smaller aperture setting in the lensfun module, or to turn vignetting
compensation off for now, which is a nuisance.


What needs to happen on darktable's end, code-wise, to:
1. expose the 0x2011 EXIF tag contents to lensfun to assist it in
picking the right of two alternate correction sets?
2. until the day that lensfun supports this (see ticket URL above),
automatically flip the switch for vignetting compensation to "off" in
the lens correction IOP?

I'm willing to help with code on both lensfun's and darktable's end, and
am proposing a Git feature branch tracking the development branches.
I've been programming C for 25+ years and to some limited extent C++ w/
STL, and Python 3 for a few years, too.


I think as a workaround for the time being the only way I have is to
alter the lens names (add "VignPreComp" to the name, or similar) and
manually choose them, to go along with datasets that compensate for the
delta between the in-camera pre-compensated vignetting, and the full
compensation. This can then be re-written properly once lensfun exposes
a way to choose from alternate data sets for the same lens.

Cheers,
Matthias

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction based on EXIF data on Sony cameras

[Kelvie Wong]

On the plus side, distortion is not, and CA is relatively easy to correct.

Vignetting is hard to manually correct with the current darktable modules,
however, without doing some type of stacking of vignette modules or
exposure with circular masks.

I have a theory that with the corrections on, the vignetting will still be
under corrected by a constant amount (independent of lens), but I'd need to
do more tests.

On Fri, Apr 7, 2017, 01:09 Matthias Andree,  wrote:

> Am 07.04.2017 um 09:38 schrieb Heiko Bauke:
> > Hi,
> >
> > Am 05.04.2017 um 07:33 schrieb Kelvie Wong:
> >> I just realized that on my Sony a7R II (and this probably applies to all
> >> of the cameras in this series, probably even the NEX), if you have
> >> certain camera settings, some lens corrections are baked into the ARW
> >> files (Sony's raw format) -- that is the bit values appear to change,
> >> not just the metadata.
> >
> > just for the record: This seems to be a common feature of Sony
> > cameras. If I understand the settings menu correctly, also the Sony
> > Alpha 6300 can apply in-camera vignetting correction to raw files.
> > This feature is turned on, when default factory settings are applied.
> > The pictures, which have been utilized to generate lens correction
> > data in liblensfun, have actually been taken with Sony Alpha cameras.
> > Thus, it would be interesting to know, if liblensfun data is based on
> > raw raw files or on raw files with in-camera vignetting correction.
>
> The lensfun profiling instructions tell people to switch those
> corrections off, but it might be necessary to re-profile everything
> paying heed to the settings; there may have to be two settings for each.
> I will recheck the images I've used for my profile parts in the lensfun
> database.
>
> OTOH, some people expect "RAW" images to be free of all preprocessing.
>
> And, finally, if the camera always bakes a certain correction into the
> raw images regardless of settings (or because it won't permit you to
> switch a certain correction "off") then of course the lensfun data will
> have been produced based on pre-processed RAW.
> ___
> darktable developer mailing list
> to unsubscribe send a mail to
> darktable-dev+unsubscr...@lists.darktable.org
>
> --

-- 
Kelvie Wong

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction based on EXIF data on Sony cameras

[Matthias Andree]

Am 07.04.2017 um 09:38 schrieb Heiko Bauke:
> Hi,
>
> Am 05.04.2017 um 07:33 schrieb Kelvie Wong:
>> I just realized that on my Sony a7R II (and this probably applies to all
>> of the cameras in this series, probably even the NEX), if you have
>> certain camera settings, some lens corrections are baked into the ARW
>> files (Sony's raw format) -- that is the bit values appear to change,
>> not just the metadata.
>
> just for the record: This seems to be a common feature of Sony
> cameras. If I understand the settings menu correctly, also the Sony
> Alpha 6300 can apply in-camera vignetting correction to raw files. 
> This feature is turned on, when default factory settings are applied. 
> The pictures, which have been utilized to generate lens correction
> data in liblensfun, have actually been taken with Sony Alpha cameras. 
> Thus, it would be interesting to know, if liblensfun data is based on
> raw raw files or on raw files with in-camera vignetting correction. 

The lensfun profiling instructions tell people to switch those
corrections off, but it might be necessary to re-profile everything
paying heed to the settings; there may have to be two settings for each.
I will recheck the images I've used for my profile parts in the lensfun
database.

OTOH, some people expect "RAW" images to be free of all preprocessing.

And, finally, if the camera always bakes a certain correction into the
raw images regardless of settings (or because it won't permit you to
switch a certain correction "off") then of course the lensfun data will
have been produced based on pre-processed RAW.
___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction

[François Tissandier]

Oops. let's finish it this time :

http://www.darktable.org/2013/07/have-your-lens-calibrated/
http://wilson.bronger.org/lens_calibration_tutorial/

Then it can be added to Darktable.

On Thu, Dec 15, 2016 at 6:04 AM, François Tissandier <
francois.tissand...@gmail.com> wrote:

> Salut Marc
>
> I think you need to gather the info for lensfun :
>
>
> On Thu, Dec 15, 2016 at 12:30 AM, Marc Mascré  wrote:
>
>> Hi all,
>>
>> I got the sigma 18-35 f/1.8 lens.
>> In the lens correction module, my lens is not detected and it seems that
>> it did not exist.
>>
>> I would like to help by giving you all informations you need to add it.
>> But I have no idea what and how to do.
>>
>> So, if someone can help me, I will be very happy to participate.
>>
>> Thanks a lot for this excellent software
>>
>> Marc
>>
>> 
>> ___
>> darktable developer mailing list
>> to unsubscribe send a mail to darktable-dev+unsubscribe@list
>> s.darktable.org
>>
>>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction

[François Tissandier]

Salut Marc

I think you need to gather the info for lensfun :


On Thu, Dec 15, 2016 at 12:30 AM, Marc Mascré  wrote:

> Hi all,
>
> I got the sigma 18-35 f/1.8 lens.
> In the lens correction module, my lens is not detected and it seems that
> it did not exist.
>
> I would like to help by giving you all informations you need to add it.
> But I have no idea what and how to do.
>
> So, if someone can help me, I will be very happy to participate.
>
> Thanks a lot for this excellent software
>
> Marc
>
> 
> ___
> darktable developer mailing list
> to unsubscribe send a mail to darktable-dev+unsubscribe@list
> s.darktable.org
>
>

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org

Re: [darktable-dev] Lens correction

[Marco Sala]

Hello,

Marc Mascré  wrote:
> I would like to help by giving you all informations you need to add it. 
> But I have no idea what and how to do.

DT uses LensFun for lens correction. I think you should turn the 
question to the developers team of LensFun. Please read here:

http://lensfun.sourceforge.net/lenslist

and here: 
http://wilson.bronger.org/calibration

and here: 
http://wilson.bronger.org/lens_calibration_tutorial

Best,

-- 
  Marco Sala

___
darktable developer mailing list
to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org