Re: DASH regression

2010-07-05 Thread Herbert Xu
Brian Koropoff wrote: > Hello, >I encountered a regression in DASH from git while attempting to get > it working on Solaris. I got it to build and run, but my scripts were > mysteriously failing. I tracked it down to a logic bug in setvareq() > that caused it to assign through the wrong poin

Re: dash regression against klibc

2008-05-02 Thread Herbert Xu
On Sat, May 03, 2008 at 01:16:56AM -0500, Dan McGee wrote: > > That change makes it work fine here. Thanks for looking into all of this. OK this is what I've committed. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor

Re: dash regression against klibc

2008-05-02 Thread Dan McGee
On Sat, May 3, 2008 at 1:13 AM, Herbert Xu <[EMAIL PROTECTED]> wrote: > On Fri, May 02, 2008 at 11:06:23PM -0700, H. Peter Anvin wrote: > > > > _GNU_SOURCE is defined by the application, not by the library. > > Yes, however the macro AC_GNU_SOURCE is supposed to define it > only for glibc. Hav

Re: dash regression against klibc

2008-05-02 Thread Herbert Xu
On Fri, May 02, 2008 at 11:06:23PM -0700, H. Peter Anvin wrote: > > _GNU_SOURCE is defined by the application, not by the library. Yes, however the macro AC_GNU_SOURCE is supposed to define it only for glibc. Having seen the actual code though it seems that the automake documentation is misleadi

Re: dash regression against klibc

2008-05-02 Thread H. Peter Anvin
Herbert Xu wrote: On Fri, May 02, 2008 at 08:08:34PM -0500, Dan McGee wrote: So the post-patch version of dash is acting identical to the prepatch version. I'm not convinced this is a dash problem- it could very well be an upstream klibc issue, and I will try to look into this possibility as wel

Re: dash regression against klibc

2008-05-02 Thread Herbert Xu
On Fri, May 02, 2008 at 08:08:34PM -0500, Dan McGee wrote: > > So the post-patch version of dash is acting identical to the prepatch > version. I'm not convinced this is a dash problem- it could very well > be an upstream klibc issue, and I will try to look into this > possibility as well. Could y

Re: dash regression against klibc

2008-05-02 Thread Dan McGee
On Fri, May 2, 2008 at 1:23 AM, Herbert Xu <[EMAIL PROTECTED]> wrote: > On Fri, May 02, 2008 at 01:25:30PM +0800, Herbert Xu wrote: > > > > I suspect the problem is klibc's getcwd implementation but this > > should confirm it for us. > > Actually klibc's getcwd is just fine as it is. It's dash