Re: Mac OS X support patch
On Fri, Jul 11, 2008 at 09:20:24PM +, Mark Mentovai wrote:
> Hi, Herbert and friends. I've created a small patch that allows dash
> to be built on Mac OS X. I'm contributing it here with the hope that
> it's suitable for inclusion in dash.
Sorry for the late response but please CC me next time on patches.
> The changes in this patch are:
>
> - __attribute__((__alias__())) is not supported, add an autoconf check
Applied with the exraise changed to abort and formatting fixes.
> - open64 is not present although the stat64 family is, separate the
> autoconf checks
Applied.
> - A syntax error had slipped into a non-glibc codepath
Already fixed.
> - mkbuiltins had a nonportable mktemp invocation for the case where
> tempfile is not availalble
Already fixed.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~}
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Mac OS X support patch
Herbert Xu wrote: > Mark Mentovai <[EMAIL PROTECTED]> wrote: >> >> autoconf provides AC_SYS_LARGEFILE for this, but I don't think it >> should be part of this patch. Does dash have a bug tracker where this >> can be filed? > > Please use the Debian BTS for this. See http://bugs.debian.org/. Great, filed as http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=490831 . If there are no objections to the patch in the original message, can it be committed? Mark -- To unsubscribe from this list: send the line "unsubscribe dash" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Mac OS X support patch
Mark Mentovai <[EMAIL PROTECTED]> wrote:
>
> autoconf provides AC_SYS_LARGEFILE for this, but I don't think it
> should be part of this patch. Does dash have a bug tracker where this
> can be filed?
Please use the Debian BTS for this. See http://bugs.debian.org/.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Mac OS X support patch
On Sat, Jul 12, 2008 at 06:26:11PM -0700, H. Peter Anvin wrote:
>
> I'm not sure that that makes sense, however. Unless you're hauling a
> *lot* of off_t's around the code, the incremental complexity is hardly
> worth it.
Either way it's pretty insignificant. Yes the decrease in code
size isn't great but then the increase in complexity isn't large
either. FWIW the decreases all come from stat on directories
and scripts.
> FWIW, klibc doesn't even implement the LFS64 APIs, nor does it implement
> the legacy 32-bit off_t mode in any way.
That's already handled by autoconf.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Mac OS X support patch
Herbert Xu wrote: H. Peter Anvin <[EMAIL PROTECTED]> wrote: Mark Mentovai wrote: - open64 is not present although the stat64 family is, separate the autoconf checks This seems like the Wrong Thing anyway; the right thing should be to add whatever option (like -D_FILE_OFFSET_BITS=64 on Linux) to do *everything* using the full-sized offsets. Actually there is a reason for this. Not all open(2) calls in dash need large file support. For example, doing it on a shell script or /dev/null makes no sense. Only those dealing with user files (redirections) need large file support. So that's we need to differentiate between open(2) calls on user files as opposed to those for dash itself. I'm not sure that that makes sense, however. Unless you're hauling a *lot* of off_t's around the code, the incremental complexity is hardly worth it. The *only* reason for the legacy 32-bit off_t mode is because it is an ABI change, it is necessary to prevent application/library interface breakage. FWIW, klibc doesn't even implement the LFS64 APIs, nor does it implement the legacy 32-bit off_t mode in any way. -hpa -- To unsubscribe from this list: send the line "unsubscribe dash" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Mac OS X support patch
H. Peter Anvin <[EMAIL PROTECTED]> wrote:
> Mark Mentovai wrote:
>> - open64 is not present although the stat64 family is, separate the
>> autoconf checks
>
> This seems like the Wrong Thing anyway; the right thing should be to add
> whatever option (like -D_FILE_OFFSET_BITS=64 on Linux) to do
> *everything* using the full-sized offsets.
Actually there is a reason for this. Not all open(2) calls in
dash need large file support. For example, doing it on a shell
script or /dev/null makes no sense. Only those dealing with user
files (redirections) need large file support.
So that's we need to differentiate between open(2) calls on user
files as opposed to those for dash itself.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Mac OS X support patch
H. Peter Anvin wrote: > Mark Mentovai wrote: >> - open64 is not present although the stat64 family is, separate the >> autoconf checks > > This seems like the Wrong Thing anyway; the right thing should be to add > whatever option (like -D_FILE_OFFSET_BITS=64 on Linux) to do *everything* > using the full-sized offsets. autoconf provides AC_SYS_LARGEFILE for this, but I don't think it should be part of this patch. Does dash have a bug tracker where this can be filed? Mark -- To unsubscribe from this list: send the line "unsubscribe dash" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Mac OS X support patch
Mark Mentovai wrote: - open64 is not present although the stat64 family is, separate the autoconf checks This seems like the Wrong Thing anyway; the right thing should be to add whatever option (like -D_FILE_OFFSET_BITS=64 on Linux) to do *everything* using the full-sized offsets. -hpa -- To unsubscribe from this list: send the line "unsubscribe dash" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
