Re: dash tested against ash testsuite: 17 failures

2018-03-21 Thread Herbert Xu
On Thu, Mar 08, 2018 at 08:37:11AM +0100, Harald van Dijk wrote: > > parser: use pgetc_eatbnl() in more places. > > dash has a pgetc_eatbnl function in parser.c which skips any > backslash-newline combinations. It's not used everywhere it could be. There > is also some duplicated backslash-newlin

Re: dash tested against ash testsuite: 17 failures

2018-03-07 Thread Harald van Dijk
On 3/8/18 7:30 AM, Herbert Xu wrote: Could you please resend these patches as two separate emails please? Patchwork cannot handle two patches in one email: https://patchwork.kernel.org/patch/10264661/ Ah, didn't realise that. I'll keep that in mind for future mails. Actually, I'll wit

Re: dash tested against ash testsuite: 17 failures

2018-03-07 Thread Herbert Xu
On Wed, Mar 07, 2018 at 07:19:56PM +0100, Harald van Dijk wrote: > On 3/7/18 7:51 AM, Herbert Xu wrote: > >On Wed, Mar 07, 2018 at 07:49:16AM +0100, Harald van Dijk wrote: > >> > >>This was wrong in the original patch, but I'm not seeing it in the updated > >>patch that you replied to. When parsing

Re: dash tested against ash testsuite: 17 failures

2018-03-07 Thread Harald van Dijk
On 3/7/18 7:51 AM, Herbert Xu wrote: On Wed, Mar 07, 2018 at 07:49:16AM +0100, Harald van Dijk wrote: This was wrong in the original patch, but I'm not seeing it in the updated patch that you replied to. When parsing a heredoc where part of delimiter is quoted, syntax==SQSYNTAX. Since the calls

Re: dash tested against ash testsuite: 17 failures

2018-03-06 Thread Herbert Xu
On Wed, Mar 07, 2018 at 07:49:16AM +0100, Harald van Dijk wrote: > > This was wrong in the original patch, but I'm not seeing it in the updated > patch that you replied to. When parsing a heredoc where part of delimiter is > quoted, syntax==SQSYNTAX. Since the calls to pgetc_eatbnl() are conditiona

Re: dash tested against ash testsuite: 17 failures

2018-03-06 Thread Harald van Dijk
On 3/7/18 7:18 AM, Herbert Xu wrote: On Wed, Mar 07, 2018 at 01:36:08AM +0100, Harald van Dijk wrote: I'm fine with the concept. However, your patch also breaks here- document parsing when the delimiter is a single backslash. cat << "\" \ If you can fix these two problems it

Re: dash tested against ash testsuite: 17 failures

2018-03-06 Thread Herbert Xu
On Wed, Mar 07, 2018 at 01:36:08AM +0100, Harald van Dijk wrote: > > Oh, indeed, thanks. > > There's another problem: when there is no following command (as in the above > example), things break. A shorter reproducer that has failed for years is > > $ dash -c 'alias x= > x' > dash: 2: Synta

Re: dash tested against ash testsuite: 17 failures

2018-03-06 Thread Harald van Dijk
On 3/6/18 9:45 AM, Herbert Xu wrote: On Wed, Oct 12, 2016 at 07:24:26PM +0200, Harald van Dijk wrote: I would have expected another exception to be in alias expansions that end in a backslash. Shells are not entirely in agreement there, but most appear to treat this the regular way, meaning

Re: dash tested against ash testsuite: 17 failures

2018-03-06 Thread Martijn Dekker
Op 06-03-18 om 08:45 schreef Herbert Xu: > However, your patch also breaks here- > document parsing when the delimiter is a single backslash. > > cat << "\" > \ That is supposed to break. "\" is not a correctly quoted backslash. Try '\' or "\\" or \\ - M. -- To unsubscribe from this

Re: dash tested against ash testsuite: 17 failures

2018-03-06 Thread Herbert Xu
On Wed, Oct 12, 2016 at 07:24:26PM +0200, Harald van Dijk wrote: > > > I would have expected another exception to be in alias expansions that > > end in a backslash. Shells are not entirely in agreement there, but most > > appear to treat this the regular way, meaning > > > > dash -c 'alias bs=\\

Re: dash tested against ash testsuite: 17 failures

2016-10-12 Thread Harald van Dijk
On 10/10/16 22:20, Harald van Dijk wrote: On 08/10/16 21:42, Martijn Dekker wrote: Op 01-10-16 om 19:17 schreef Denys Vlasenko: ash-vars/var_unbackslash.tests ITYM ash-vars/var_unbackslash1.tests echo Forty two:$\ (\ (\ 42\ )\ ) dash says: Syntax error: Missing '

Re: dash tested against ash testsuite: 17 failures

2016-10-10 Thread Harald van Dijk
On 10-10-16 23:51, Jilles Tjoelker wrote: On Sat, Oct 08, 2016 at 09:42:12PM +0200, Martijn Dekker wrote: Op 01-10-16 om 19:17 schreef Denys Vlasenko: ash-vars/var_unbackslash.tests ITYM ash-vars/var_unbackslash1.tests echo Forty two:$\ (\ (\ 42\ )\ ) dash says

Re: dash tested against ash testsuite: 17 failures

2016-10-10 Thread Jilles Tjoelker
On Sat, Oct 08, 2016 at 09:42:12PM +0200, Martijn Dekker wrote: > Op 01-10-16 om 19:17 schreef Denys Vlasenko: > > ash-glob/glob2.tests: > > Evidently, dash supports \f -> ^L escape. > > This test uses \f as invalid backslash escape, > > hence differences. > The test uses the "echo" bu

Re: dash tested against ash testsuite: 17 failures

2016-10-10 Thread Harald van Dijk
On 08/10/16 21:42, Martijn Dekker wrote: Op 01-10-16 om 19:17 schreef Denys Vlasenko: ash-vars/var_unbackslash.tests ITYM ash-vars/var_unbackslash1.tests echo Forty two:$\ (\ (\ 42\ )\ ) dash says: Syntax error: Missing '))' Yes, but it's not clear to me that it

Re: dash tested against ash testsuite: 17 failures

2016-10-08 Thread Martijn Dekker
Op 01-10-16 om 19:17 schreef Denys Vlasenko: > ash-glob/glob2.tests: > Evidently, dash supports \f -> ^L escape. > This test uses \f as invalid backslash escape, > hence differences. The test uses the "echo" builtin, which is very very unportable and explicitly not standardised by POSI