Re: DateTime::Event::Sunrise Beta number 3

2003-03-26 Thread John Peacock
Hill, Ronald wrote: No, it is not CVS. This is the way it was in the Astro::Sunrise module I can't remember where I got it from. $VERSION = (qw$Revision: 0.01 $)[1]; Thanks John!! I have changed the module to use this syntax Except that if you are not using CVS, there is no reason to do it at a

RE: DateTime::Event::Sunrise Beta number 3

2003-03-26 Thread Hill, Ronald
> > Dave Rolsky wrote: > > > > $VERSION = qw($Revision: 0.01 $) [1]; > > > > That's not CVS, is it? If it is, please don't use it's > revision numbers > > directly (this is discussed in the dev docs I wrote). No, it is not CVS. This is the way it was in the Astro::Sunrise module I can't rem

Re: DateTime::Event::Sunrise Beta number 3

2003-03-26 Thread John Peacock
Dave Rolsky wrote: $VERSION = qw($Revision: 0.01 $) [1]; That's not CVS, is it? If it is, please don't use it's revision numbers directly (this is discussed in the dev docs I wrote). And even if Dave hadn't prohibited that mode of operation, the above code is not backwards compatible to 5.005_

Re: DateTime::Event::Sunrise Beta number 3

2003-03-25 Thread Dave Rolsky
On Tue, 25 Mar 2003, Hill, Ronald wrote: > my $sunrise = DateTime::Event::Sunrise ->new( > Longitude =>'-118' , >Latitude => '33', > ); For consistency with other DateTime modules, it'd be good if the parameter names were lower case. A couple others nits:

DateTime::Event::Sunrise Beta number 3

2003-03-25 Thread Hill, Ronald
Hi All, I have just completed the third beta for the Sunrise module. I have added a set method (no documentation yet)I used the set API from Rick's easter module (Thanks Rick!!)Here is the perl script I used to test: #!/usr/bin/perl use strict; use warnings; use DateTime; use DateTime::Event::Sun