[PATCH] This patch fix a bug in the register indexing for GPIOs numbers 31

2011-01-25 Thread Hirosh Dabui
to get the relevant hardware registers of tnetv107x to control the GPIOs. In the structure tnetv107x_gpio_regs: struct tnetv107x_gpio_regs { u32 idver; u32 data_in[3]; u32 data_out[3]; u32 direction[3]; u32 enable[3]; }; The GPIO hardware

Re: [alsa-devel] [PATCH] davinci: da8xx/omap-l1xx: match codec_name with i2c ids

2011-01-25 Thread Liam Girdwood
On Mon, 2011-01-24 at 15:09 -0800, Kevin Hilman wrote: Kevin Hilman khil...@ti.com writes: Liam Girdwood l...@slimlogic.co.uk writes: On Fri, 2011-01-21 at 19:54 +0530, Rajashekhara, Sudhakar wrote: The codec_name entry for da8xx evm in sound/soc/davinci/davinci-evm.c is not matching

Re: [alsa-devel] [PATCH] davinci: da8xx/omap-l1xx: match codec_name with i2c ids

2011-01-25 Thread Mark Brown
On Tue, Jan 25, 2011 at 10:59:05AM +, Liam Girdwood wrote: On Mon, 2011-01-24 at 15:09 -0800, Kevin Hilman wrote: On second thought, these should probably merge for .38-rc3. If you're OK with it, I can merge this and the platform fix together for .38-rc3. Yes please :) I applied it

Re: [PATCH] This patch fix a bug in the register indexing for GPIOs numbers 31

2011-01-25 Thread Kevin Hilman
Hi Hirosh, Hirosh Dabui hirosh.da...@snom.com writes: to get the relevant hardware registers of tnetv107x to control the GPIOs. Your patch/changelog is still messed up. You're missing a good subject/shortlog and the first line of the changelog has become the subject/shortlog. Kevin In the

Re: [alsa-devel] [PATCH] davinci: da8xx/omap-l1xx: match codec_name with i2c ids

2011-01-25 Thread Kevin Hilman
Mark Brown broo...@opensource.wolfsonmicro.com writes: On Tue, Jan 25, 2011 at 10:59:05AM +, Liam Girdwood wrote: On Mon, 2011-01-24 at 15:09 -0800, Kevin Hilman wrote: On second thought, these should probably merge for .38-rc3. If you're OK with it, I can merge this and the platform

[PATCH] davinci: tnetv107x: fix register indexing for GPIOs numbers 31

2011-01-25 Thread Hirosh Dabui
This patch fix a bug in the register indexing for GPIOs numbers 31 to get the relevant hardware registers of tnetv107x to control the GPIOs. In the structure tnetv107x_gpio_regs: struct tnetv107x_gpio_regs { u32 idver; u32 data_in[3]; u32

RE: [PATCH] davinci: tnetv107x: fix register indexing for GPIOs numbers 31

2011-01-25 Thread Jon Povey
davinci-linux-open-source-boun...@linux.davincidsp.com wrote: The bug implied the use of macros to access the relevant hardware register e.g. the driver code used the macro like this: 'gpio_reg_clear_bit(reg-data_out, gpio)' But it has to be used like this: 'gpio_reg_clear_bit(reg-data_out,

RE: [PATCH] davinci: tnetv107x: fix register indexing for GPIOs numbers 31

2011-01-25 Thread Jon Povey
Hirosh Dabui wrote: On 01/26/2011 07:14 AM, Jon Povey wrote: davinci-linux-open-source-boun...@linux.davincidsp.com wrote: The bug implied the use of macros to access the relevant hardware register e.g. the driver code used the macro like this: 'gpio_reg_clear_bit(reg-data_out, gpio)' But