RE: [PATCH 1/7] VPFE capture driver for DM355 and DM6446

2009-05-13 Thread Karicheri, Muralidharan
-linux-open-source@linux.davincidsp.com Subject: Re: [PATCH 1/7] VPFE capture driver for DM355 and DM6446 Hi, On Thursday 07 May 2009 17:06:02 Karicheri, Muralidharan wrote: Laurent, I need to re-visit following comments as I found something different after going through the videobuf-core.c

RE: [PATCH 1/7] VPFE capture driver for DM355 and DM6446

2009-05-07 Thread Karicheri, Muralidharan
Laurent, I need to re-visit following comments as I found something different after going through the videobuf-core.c [snip] +static void vpfe_videobuf_queue(struct videobuf_queue *vq, +struct videobuf_buffer *vb) +{ +/* Get the file handle object and

Re: [PATCH 1/7] VPFE capture driver for DM355 and DM6446

2009-05-06 Thread Laurent Pinchart
Hi, On Tuesday 05 May 2009 18:46:04 Karicheri, Muralidharan wrote: Laurent, See my response below. I think we are closing in on most of the comments. Good news :-) [snip] Can I assume, after STREAMOFF, to successfully start streaming again, application needs to call a) REQBUF

RE: [PATCH 1/7] VPFE capture driver for DM355 and DM6446

2009-05-06 Thread Karicheri, Muralidharan
Laurent, In practice most applications will QBUF before STREAMON. You can fix the QBUF- after-STREAMON case later (please add a comment to the code) but you should already make sure the driver will not crash if QBUF hasn't been called before STREAMON. As a general rule, non-implemented functions

Re: [PATCH 1/7] VPFE capture driver for DM355 and DM6446

2009-05-05 Thread Laurent Pinchart
Hi, On Saturday 02 May 2009 00:18:46 Karicheri, Muralidharan wrote: Laurent, Thanks once again for your support. Please see below my response with [MK] prefix. If some more outstanding issues are to be discussed, will it be possible to talk to you over phone? Sure. Contact me by private

RE: [PATCH 1/7] VPFE capture driver for DM355 and DM6446

2009-05-05 Thread Karicheri, Muralidharan
Laurent, See my response below. I think we are closing in on most of the comments. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 Phone : 301-515-3736 email: m-kariche...@ti.com +static int debug; +static char *ch0_decoder = TVP514X; +static

RE: [PATCH 1/7] VPFE capture driver for DM355 and DM6446

2009-05-01 Thread Karicheri, Muralidharan
Laurent, Thanks once again for your support. Please see below my response with [MK] prefix. If some more outstanding issues are to be discussed, will it be possible to talk to you over phone? Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 Phone :

Re: [PATCH 1/7] VPFE capture driver for DM355 and DM6446

2009-03-18 Thread Hans Verkuil
On Wednesday 18 March 2009 22:47:51 Laurent Pinchart wrote: Hi Murali, here's my (humble) review of your VPFE capture driver. Before I start, I'd like to thank you for your work on this v4l driver and contribution to the Linux kernel. Excellent review, Laurent! Chaithrika, please note that

RE: [PATCH 1/7] VPFE capture driver for DM355 and DM6446

2009-03-16 Thread Karicheri, Muralidharan
for PSP Video team (May contain non-TIers) Subject: Re: [PATCH 1/7] VPFE capture driver for DM355 and DM6446 Hi Murali, On Friday 13 March 2009 22:15:31 m-kariche...@ti.com wrote: This patch is for the vpfe capture driver for DM355 DM6446 from Texas instruments. VPFE stands for Video

Re: [PATCH 1/7] VPFE capture driver for DM355 and DM6446

2009-03-15 Thread Laurent Pinchart
Hi Murali, On Friday 13 March 2009 22:15:31 m-kariche...@ti.com wrote: This patch is for the vpfe capture driver for DM355 DM6446 from Texas instruments. VPFE stands for Video Processing Front End which is the basic IP on DMxxx family for video capture and processing. vpfe capture driver is