On 8 Mar 2010, at 17:26, Miguel Aguilar miguel.agui...@ridgerun.com
wrote:
Please don't top post.
What is the status of this patch series?, I'm still missing the
change pointed below for third patch.
It's waiting for someone to post a version with that change made.
Mark Brown wrote
On Wed, Mar 10, 2010 at 02:48:33PM +0530, Chaithrika U S wrote:
On TI DM6467 EVM, S/PDIF DIT codec fails to open as it is unable to install
hardware params. This dummy codec has no set_fmt and set_sysclk
implementations
and calls from the application to these functions cause errors. This
On Tue, Mar 09, 2010 at 11:35:18AM -0600, miguel.agui...@ridgerun.com wrote:
From: Miguel Aguilar miguel.agui...@ridgerun.com
Currently the DM365 is the only SoC that includes this Voice Codec.
This looks OK to me but could you please resend the full series rather
than just this one patch?
On 12 Mar 2010, at 08:01, Liam Girdwood l...@slimlogic.co.uk wrote:
On Thu, 2010-03-11 at 09:32 -0600, miguel.agui...@ridgerun.com wrote:
From: Miguel Aguilar miguel.agui...@ridgerun.com
This is the MFD driver for the DaVinci Voice codec, it has two
clients:
* Voice codec interface
*
On Fri, Mar 12, 2010 at 08:13:25AM +, Mark Brown wrote:
On 12 Mar 2010, at 08:01, Liam Girdwood l...@slimlogic.co.uk wrote:
On Thu, 2010-03-11 at 09:32 -0600, miguel.agui...@ridgerun.com wrote:
This is the MFD driver for the DaVinci Voice codec, it has two
clients:
* Voice codec
On Fri, Mar 26, 2010 at 02:11:28PM -0600, Todd Fischer wrote:
Other sub-drivers for the TPS6507x chip will need to use register
definition so move it out of the source file and into a header file.
This
diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index
On Fri, Mar 26, 2010 at 02:11:29PM -0600, Todd Fischer wrote:
Need mfd structure that can hold pointers to sub-driver initialization
and run time data.
Please provide a more verbose changelog. What needs this structure?
/**
+ * tps_board points to pmic related constants
+ *
On Fri, Mar 26, 2010 at 02:11:30PM -0600, Todd Fischer wrote:
MFD driver for TPS6507x family of multi-function chips.
This patch should also be updating the regulator driver to work in terms
of this new MFD driver - otherwise after applying it you'll have two
incompatible drivers for the same
the output voltage is being used for.
Signed-off-by: Todd Fischer todd.fisc...@ridgerun.com
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http
On Fri, Apr 02, 2010 at 03:37:32PM -0600, Todd Fischer wrote:
Move from using tps or tsp6507x to tps6057x_pmic in a consistent manner.
Signed-off-by: Todd Fischer todd.fisc...@ridgerun.com
Acked-by: Mark Brown broo...@opensource.wolfsonicro.com
On Fri, Apr 02, 2010 at 03:37:33PM -0600, Todd Fischer wrote:
Add MFD driver for TPS6507x family of multi-function chips. Move TPS6507x
regulator driver from being stand-alone driver to using the MFD TPS6507x
driver.
Signed-off-by: Todd Fischer todd.fisc...@ridgerun.com
One issue...
On Mon, Apr 05, 2010 at 08:23:55PM -0600, Todd Fischer wrote:
This is the third posting of the TPS6507x driver set. I have
resolved the concurrent access issue identified by Mark Brown.
Instead of using a mutex, I used the i2c_transfer() as done in
the similar routine in the wm8400-core.c
On Fri, Jun 11, 2010 at 07:24:51PM +0530, Sudhakar Rajashekhara wrote:
On DA830/OMAP-L137 and DA850/OMAP-L138 SoCs, the McASP peripheral
has FIFO support. This FIFO provides additional data buffering. It
also provides tolerance to variation in host/DMA controller response
times. More details
On 23 Jun 2010, at 15:33, Raffaele Recalcati wrote:
From: Raffaele Recalcati raffaele.recalc...@bticino.it
Added audio playback support with [frame sync master - clock master]
mode
and with [frame sync master - clock slave].
Clock slave can be important when the external
On Mon, Jun 28, 2010 at 08:44:46AM +0200, Raffaele Recalcati wrote:
From: Raffaele Recalcati raffaele.recalc...@bticino.it
It's still very hard to understand what this patch is supposed to do.
As previously mentioned this would probably be a lot clearer if you
split this into multiple patches,
On Fri, Jul 02, 2010 at 07:12:27PM +0200, Raffaele Recalcati wrote:
+ * This define works when both clock and FS are output for the cpu
+ * and makes clock more accurate (FS is not symmetrical and the
+ * clock is very fast.
As I've said before please say which clock you are
On Fri, Jul 02, 2010 at 07:12:25PM +0200, Raffaele Recalcati wrote:
From: Raffaele Recalcati raffaele.recalc...@bticino.it
Added two clocking options for dm365 McBSP peripheral when used
with I2S timings, that are SND_SOC_DAIFMT_CBS_CFS (the cpu generates
You've not sent any of these
On Mon, Jul 05, 2010 at 07:05:43AM +0200, raffaele.recalc...@bticino.it wrote:
-Mark Brown broo...@opensource.wolfsonmicro.com ha scritto: -
Per: Raffaele Recalcati lamiapost...@gmail.com
You might want to look at your MUA configuration - it's started mangling
things so extra line
On Wed, Jun 30, 2010 at 10:17:40AM +0200, Raffaele Recalcati wrote:
2010/6/28 Mark Brown broo...@opensource.wolfsonmicro.com
It's still very hard to understand what this patch is supposed to do.
As previously mentioned this would probably be a lot clearer if you
split this into multiple
On Wed, Jun 30, 2010 at 03:47:57PM +0200, Raffaele Recalcati wrote:
+ /* To be used when cpu gets clock from external pin */
+ int clk_input_pin;
+
As previously indicated please say how to use this.
+ default:
+ printk(KERN_ERR %s:bad
On Wed, Jun 30, 2010 at 03:47:58PM +0200, Raffaele Recalcati wrote:
From: Raffaele Recalcati raffaele.recalc...@bticino.it
i2s_fast_clock switch can be used to have a better approximate
Oh, and please look at the CC list for these posts. You're CCing *very*
widely and at least one
On Wed, Jun 30, 2010 at 03:47:58PM +0200, Raffaele Recalcati wrote:
+ /*
+ * This define works when both clock and FS are output for the cpu
+ * and makes clock very fast (FS is not symmetrical, but sampling
+ * frequency is better approximated
+ */
+ bool
On Tue, Jul 06, 2010 at 05:00:24PM +0530, Sudhakar Rajashekhara wrote:
Acked-by: Liam Girdwood l...@slimlogic.co.uk
Acked-by: Sudhakar Rajashekhara sudhakar@ti.com
Applied all, thanks.
___
Davinci-linux-open-source mailing list
On Tue, Jul 06, 2010 at 11:35:28AM -0700, Troy Kisky wrote:
Indeed, your algorithm may produce more accurate results for the specific rate
that you tested for. However, that seems more luck than anything. How do you
know that a frame size of 33 will always give more accurate results than a
On Mon, Jul 12, 2010 at 04:04:46PM +0530, Sekhar Nori wrote:
+
+ /* Does DCDC high or the low register defines output voltage? */
+ bool defdcdc_high;
This should probably be defdcdc_default or something. Presumably the
line can also be wired to a GPIO and changed at runtime
}_HIGH register to read and change voltage levels.
Signed-off-by: Sekhar Nori nsek...@ti.com
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http
depending on
how the board is wired.
Signed-off-by: Anuj Aggarwal anuj.aggar...@ti.com
Signed-off-by: Sekhar Nori nsek...@ti.com
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source
On Thu, Jul 15, 2010 at 08:09:04AM +0200, davide.bonfa...@bticino.it wrote:
Per: Raffaele Recalcati lamiapost...@gmail.com
Da: Mark Brown broo...@opensource.wolfsonmicro.com
Data: 14/07/2010 16.44
You might want to look at your MUA configuration here - it's sending
stuff with broken line
On Wed, Jul 14, 2010 at 04:28:10PM +0200, Raffaele Recalcati wrote:
From: Davide Bonfanti davide.bonfa...@bticino.it
Since DM365 has the same DMA event for McBSP and Voicecodec this two
peripherals cannot be used at the same time.
Please try to format your patches as documented in
On Fri, Jul 16, 2010 at 04:46:57PM +0200, Raffaele Recalcati wrote:
If soc_pcm_ops is statically allocated, more than one call to soc_new_pcm
cause operations overwrite. The problem is overcome usyng dynamic
allocation.
As I said previously you're looking for Liam's
On Fri, Jul 16, 2010 at 05:25:19PM +0200, Raffaele Recalcati wrote:
For us it is better to have also more feedback from you about the other two
patches.
So the next patchset we'll submit shall be more complete.
Sure - those are bigger and take longer to read, should get to them by
the end of
On Thu, Jul 15, 2010 at 05:44:19PM +0530, Sekhar Nori wrote:
This patch has been tested on DM644x and OMAP-L138 EVMs.
Signed-off-by: Sekhar Nori nsek...@ti.com
This patch applies to latest of Linus's tree.
...so it doesn't apply against my for-2.6.36 branch (and obviously
there's crossover
On Mon, Jul 19, 2010 at 12:31:16PM +0530, Sekhar Nori wrote:
Currently the EDMA queue to be used by for servicing ASP through
internal RAM is fixed to EDMAQ_0 and that to service internal RAM
from external RAM is fixed to EDMAQ_1.
Applied, thanks.
It's ASoC, BTW.
On Fri, Jul 16, 2010 at 04:46:58PM +0200, Raffaele Recalcati wrote:
From: Davide Bonfanti davide.bonfa...@bticino.it
This driver implements a pcm interface without the use of a DMA but with
a copy_from_user.
There's a buffer in the driver that is filled with davinci_pcm_copy.
On Sun, Oct 03, 2010 at 04:44:19PM -0500, mar...@ti.com wrote:
From: Troy Kisky troy.ki...@boundarydevices.com
Since only 4 mainline ASoC codecs support the trigger
callback, we cannot rely upon them stopping the frame clock
if they are master and must assume it is running even if the
sound
On Thu, Oct 14, 2010 at 02:38:49PM -0400, Cyril Chemparathy wrote:
TPS6524X provides three step-down converters and two general-purpose LDO
voltage regulators. This device is interfaced using SPI.
Signed-off-by: Cyril Chemparathy cy...@ti.com
This looks mostly good but...
+static int
On Thu, Oct 14, 2010 at 02:38:50PM -0400, Cyril Chemparathy wrote:
+ {
+ .num_consumer_supplies = ARRAY_SIZE(usb_consumers),
+ .consumer_supplies = usb_consumers,
+ .constraints= {
+ .name = USB,
+
On Mon, Oct 18, 2010 at 03:25:16PM -0400, Cyril Chemparathy wrote:
TPS6524X provides three step-down converters and two general-purpose LDO
voltage regulators. This device is interfaced using SPI.
Signed-off-by: Cyril Chemparathy cy...@ti.com
Acked-by: Mark Brown broo
On Tue, Oct 19, 2010 at 01:06:21PM -0500, vm.ro...@gmail.com wrote:
From: Victor Rodriguez victor.rodrig...@sasken.com
This patch adds ASoC support for the Hawkboard-L138 system
Signed-off-by: Victor Rodriguez victor.rodrig...@sasken.com
Acked-by: Mark Brown broo
On Thu, Oct 28, 2010 at 02:01:27PM -0500, Victor Rodriguez wrote:
On Thu, Oct 21, 2010 at 5:28 PM, Mark Brown
Please do remember to CC maintainers on patches so they see them.
Hi Mark I am going to resend this series of patches because of one
small coding stile problem, is this ok for you
On Fri, Oct 29, 2010 at 10:10:39AM -0500, vm.ro...@gmail.com wrote:
From: Victor Rodriguez victor.rodrig...@sasken.com
This patch adds ASoC support for the Hawkboard-L138 system
Signed-off-by: Victor Rodriguez victor.rodrig...@sasken.com
Acked-by: Mark Brown broo
On Fri, Nov 12, 2010 at 08:23:20AM -0800, Kevin Hilman wrote:
Mark, I assume you're OK with me merging this ASoC change via the
davinci tree?
Yes.
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
On Tue, Nov 16, 2010 at 01:45:54PM -0700, Grant Likely wrote:
On Tue, Nov 16, 2010 at 11:34:09AM +, Mark Brown wrote:
You did also say you were going to write helpers to make this easier - I
do fear that we're going to end up with far too much boiler plate code
in machine drivers if we
On Tue, Nov 16, 2010 at 07:17:18PM -0500, Cyril Chemparathy wrote:
The ability to wait on multiple devices may come handy. In this
This is essential for any helpers, otherwise we can't cope easily with
mixes of GPIO and power or with regulators from multiple chips (like an
extra DCDC, for
On Wed, Nov 17, 2010 at 09:11:30AM -0700, Grant Likely wrote:
To start, I'm not a fan of matching by name. It's fragile because it
makes assumptions about how devices will be names when they actually
appear (ie. Sometimes .id is dynamically assigned). Ideally I'd
prefer to have direct
On Tue, Nov 16, 2010 at 12:47:04AM -0700, Grant Likely wrote:
On Tue, Nov 16, 2010 at 12:22 AM, Grant Likely
Instead, it is now incumbent on the board support code to ensure that
any device that depends on another device (including i2c or spi
regulators) will defer registration until the
On Tue, Nov 16, 2010 at 12:27:09PM +, Chris Paulson-Ellis wrote:
Multi-component commit f0fba2ad broke a few things which this patch should
fix. Tested on the DM355 EVM. I've been as careful as I can, but it would be
good if those with access to other Davinci boards could test.
Applied on
On Sun, Nov 21, 2010 at 02:31:38PM -0700, Grant Likely wrote:
On Sun, Nov 21, 2010 at 1:02 PM, Ryan Mallon r...@bluewatersys.com wrote:
Currently the code will allow you to install
several peripherals at once, which will lead to odd behaviour at
runtime. Maybe a better approach would be to
On Tue, Dec 07, 2010 at 09:51:56AM -0500, Cyril Chemparathy wrote:
+static int set_voltage(struct regulator_dev *rdev, int min_uV, int max_uV)
+{
Updates in the regulator tree mean that this will no longer build in
-next. Given the difficulty that this series seems to be having
perhaps it
On Tue, Dec 07, 2010 at 12:04:11PM -0500, Cyril Chemparathy wrote:
TPS6524X provides three step-down converters and two general-purpose LDO
voltage regulators. This device is interfaced using SPI.
Signed-off-by: Cyril Chemparathy cy...@ti.com
Acked-by: Mark Brown broo
On Tue, Dec 07, 2010 at 12:20:14PM -0500, Cyril Chemparathy wrote:
On 12/07/2010 12:15 PM, Mark Brown wrote:
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com
Is this to be merged via the davinci tree?
Liam would need to merge it, or it'd need to wait until the regulator
tree change
On Fri, Dec 10, 2010 at 04:19:48PM -0800, Kevin Hilman wrote:
[PATCH v7 08/12] gpio: add ti-ssp gpio driver
David Brownell? (MAINTAINERS isn't clear here)
It's mostly abandoned at the minute. Andrew Morton has been taking
patches. Grant Likely said he might take it over so sending stuff his
On Tue, Jan 18, 2011 at 10:04:08AM -0800, Kevin Hilman wrote:
Rajashekhara, Sudhakar sudhakar@ti.com writes:
On DA850/OMAP-L138/AM18x, AIC3x codec is at 0x18 slave address.
But in sound/soc/davinci/davinci-evm.c file, struct snd_soc_dai_link
has the wrong AIC3x codec slave address.
On Tue, Jan 25, 2011 at 10:59:05AM +, Liam Girdwood wrote:
On Mon, 2011-01-24 at 15:09 -0800, Kevin Hilman wrote:
On second thought, these should probably merge for .38-rc3.
If you're OK with it, I can merge this and the platform fix together for
.38-rc3.
Yes please :)
I applied it
On Thu, Jan 27, 2011 at 07:17:43PM +0530, Manjunathappa, Prakash wrote:
This patch fixes the Kernel panic issue on accessing davinci_vc in
cq93vc_probe function. struct davinci_vc is part of platform device's
private driver data(codec-dev-p-driver_data) and this is populated
by DaVinci Voice
On Wed, Feb 02, 2011 at 09:43:51PM +0530, Nori, Sekhar wrote:
To automate copying the right folks on each patch, please use:
git-send-email --to davinci list --cc-cmd=scripts/get_maintainer.pl [...]
Please don't use get_maintainer.pl directly like this - you need to
apply some thought and
On Thu, Feb 03, 2011 at 04:42:25PM +0530, Vaibhav Bedia wrote:
McASP1 is used on the DA830/OMAP-L137 platform for the codec.
This is different from the DA850/OMAP-L138 platform which uses McASP0.
This is fixed by adding a new snd_soc_dai_link struct.
Applied, thanks.
On Wed, Feb 09, 2011 at 09:53:46PM +, Liam Girdwood wrote:
On Wed, 2011-02-09 at 18:39 +0530, Vaibhav Bedia wrote:
This patch modifies the Davinci i2s and mcasp drivers
to make use of the resource_size() helper function for readability.
Signed-off-by: Vaibhav Bedia
On Fri, Mar 18, 2011 at 05:29:39PM +0530, Nori, Sekhar wrote:
PRUSS as an IP is not really tied to the DA8xx SoC architecture.
So, can you please name the files ti-pruss* or even just pruss if
MFD folks are okay with it?
This...
+EXPORT_SYMBOL(pruss_get_clk_freq);
This looks strange. Why
On Tue, Mar 22, 2011 at 03:05:07PM +0530, Nori, Sekhar wrote:
On Fri, Mar 18, 2011 at 18:09:17, Mark Brown wrote:
...unfortunately conflicts with this - currently all clock API
implementations are unique to the platform and there's no way of adding
clocks that works over multiple platforms
On Thu, Apr 21, 2011 at 02:19:01PM -0400, Ben Gardiner wrote:
The current check for the number of tdm-slots specified by platform data is
always true (x = 2 || x = 32); therefore the else branch that warns of an
incorrect number of slots can never be taken.
Applied all of these. Please always
On Fri, May 13, 2011 at 04:25:56PM +0530, Subhasish Ghosh wrote:
Instead, maybe you can simply call platform_device_register
at that stage to create the children and not use MFD at all.
Samuel, can you comment on this as well? Do you still see pruss
as an MFD driver when the uses are
On Sat, May 14, 2011 at 10:33:53PM +0200, Arnd Bergmann wrote:
I guess drivers/mfd would be a better place than drivers/misc, but it might
not
need to be an mfd driver in the sense that it registers mfd cells.
Yes, it might be more sensible to just open code. OTOH mfd_cell is
marginally
On Wed, May 18, 2011 at 09:43:13PM +0200, Rafael J. Wysocki wrote:
On Wednesday, May 18, 2011, mark gross wrote:
I need to get more details on this but I assume its a state where the
meta data of the file system is committed to the emmc before lights go
off such that when power is
On Wed, May 18, 2011 at 09:27:45AM -0400, Ben Gardiner wrote:
The davinci-i2s driver copies the platform data for playback and capture
sram sizes which is in turn used by davinci-pcm to allocate ping-pong
buffers.
Copy also the platform data in davinci-mcasp probe.
Signed-off-by: Ben
On Wed, May 18, 2011 at 09:27:46AM -0400, Ben Gardiner wrote:
The davinci-mcasp driver will copy the platform data specified sram sizes and
eventq's.
Set the event queues and sram sizes for da850. 8K SRAM buffers are selected
because it is the minimum that resulted in the same period size
On Tue, May 24, 2011 at 02:50:14PM -0400, Ben Gardiner wrote:
This patchset is a collection of changes for the davinci-pcm driver that were
accumulated during previous forays into the davinci-mcasp and davinci-pcm
drivers [1].
Applied all, thanks.
On Wed, May 25, 2011 at 09:27:22AM -0400, Ben Gardiner wrote:
In the previous commit 'ASoC: davinci-pcm: convert to BATCH mode', the phase
offset of 2 was mentioned in the commit message but not well commented in the
source.
Applied, thanks.
___
On Wed, Jul 20, 2011 at 05:36:04PM +0530, Rajashekhara, Sudhakar wrote:
According to DM365 voice codec data sheet at [1], before starting
recording or playback, ADC/DAC modules should follow a reset and
enable cycle. Writing a 1 to the ADC/DAC bit in the register resets
the module and clearing
On Wed, Jul 20, 2011 at 05:37:18PM +0530, Rajashekhara, Sudhakar wrote:
In davinci_vcif_trigger() function, a break() statement was missing
causing the davinci_vcif_stop() function to be called as a fallback
after calling davinci_vcif_start().
Applied, thanks.
On Fri, Aug 26, 2011 at 12:02:44PM -0400, Ben Gardiner wrote:
Although the McASP supports sign-extending samples in RX or TX [1]; the
davinci-mcasp driver does not touch the {R,X}PBIT or {R,X}PAD field of the
{R,X}FMT registers meaning that the McASP will serialize the bytes it is given
On Fri, Sep 09, 2011 at 05:06:05PM -0400, Ben Gardiner wrote:
The ambiguously named variable 'link' is used as a temporary throughout
davinci-pcm -- its presence makes grepping (and groking) the code
difficult.
Applied, thanks.
___
On Fri, Sep 30, 2011 at 05:23:02PM -0400, Ben Gardiner wrote:
The CPU DAIs available to the davinci-pcm driver have the capability of
detecting and reporting errors.
Add callbacks to the struct davinci_pcm_dma_params passed to davinci-pcm
from the CPU DAI.
This looks like something we should
On Mon, Oct 03, 2011 at 10:05:45PM -0400, Ben Gardiner wrote:
From your other email I see now that the intended behaviour can be
accomplished entirely in the application. Returning _POS_XRUN should
be sufficient here in ASoC.
OK, great - I was worried this might get complicated but if the
On Wed, Jan 04, 2012 at 12:47:49PM +0530, Manjunath Hadli wrote:
remove unnecessary inclusion of machine specific header
file mach/dm365.h from cq93vc.c voice codec driver
which comes in the way of platform code consolidation.
*Always* CC maintainers on patches. If you send me a copy directly
On Tue, Jan 10, 2012 at 04:57:43PM +0530, Manjunath Hadli wrote:
remove unnecessary inclusion of machine specific header
file mach/dm365.h from cq93vc.c voice codec driver
which comes in the way of platform code consolidation.
Applied but please do try to use a subject line appropriate for the
On Wed, Feb 08, 2012 at 12:41:14PM +, Hadli, Manjunath wrote:
On Wed, Jan 11, 2012 at 00:17:41, Mark Brown wrote:
Fix your mailer, not only is it not word wrapping within paragraphs it's
adding such problems to quoted text.
Applied but please do try to use a subject line appropriate
On Tue, Jun 26, 2012 at 11:33:43AM +0530, Hebbar, Gururaja wrote:
In sound/soc/codecs/tlv320aic3x.c
data = snd_soc_read(codec, AIC3X_PLL_PROGA_REG);
snd_soc_write(codec, AIC3X_PLL_PROGA_REG,
data | (pll_p PLLP_SHIFT));
In the above code, pll-p value
On Tue, Jun 26, 2012 at 07:25:11PM +0530, Hebbar, Gururaja wrote:
In sound/soc/codecs/tlv320aic3x.c
data = snd_soc_read(codec, AIC3X_PLL_PROGA_REG);
snd_soc_write(codec, AIC3X_PLL_PROGA_REG,
data | (pll_p PLLP_SHIFT));
Applied, thanks.
signature.asc
On Wed, Jul 04, 2012 at 02:17:48PM +, Hebbar, Gururaja wrote:
On Wed, Jul 04, 2012 at 19:31:18, Mark Brown wrote:
If these are totally different boards they should have different machine
IDs set so machine_is_() should identify. If that isn't there then you
need to do something custom
On Thu, Jul 05, 2012 at 08:32:16AM +, Arnd Bergmann wrote:
On Thursday 05 July 2012, Vaibhav Hiremath wrote:
Does machine ID still gets set? May be I am missing something...
No, it doesn't.
This is a *really* unfortunate decision, BTW - it means that if your
bootloader has a device tree
On Wed, Aug 08, 2012 at 08:40:30PM +0530, Hebbar, Gururaja wrote:
Defines or parameters from mach/mux.h isn't used anywhere. Hence
remove the header include.
Applied all, thanks.
___
Davinci-linux-open-source mailing list
On Tue, Aug 14, 2012 at 06:12:03PM +0530, Hebbar, Gururaja wrote:
Device tree support for Davinci/OMAP2+ pcm driver.
This looks like it's a device which maps a shared DMA controller in the
SoC core into ASoC rather than actual hardware. Such devices are
usually instantiated automatically from
On Tue, Aug 14, 2012 at 06:12:01PM +0530, Hebbar, Gururaja wrote:
Davinci McASP header driver are shared by few OMAP platforms (like
TI81xx, AM335x). Splitting asp header into Davinci platform specific
header and Audio specific header helps to share them across platforms.
This doesn't apply
On Tue, Aug 14, 2012 at 06:12:02PM +0530, Hebbar, Gururaja wrote:
+- op-mode : I2S/DIT ops mode.
This would normally be part of the machine binding since it needs to be
applied to both ends of the link. When adding it could you come up with
a generic binding for this in terms of the current
On Tue, Aug 14, 2012 at 06:12:04PM +0530, Hebbar, Gururaja wrote:
+- ti,codec-clock : The Codec Clock from the board
I think this is the clock rate? Please specify it more specifically.
+CODEC DAI Name, true if evm_aic3x_init is required, else false,
+evm ops required, evm_ops or
On Tue, Aug 14, 2012 at 06:12:05PM +0530, Hebbar, Gururaja wrote:
+- gpio-reset - int - gpio pin number used for codec reset
This should be a standard DT GPIO reference by phandle like:
gpio = gpio1 16 0;
There's quite a few examples in tree.
Otherwise this looks good.
On Wed, Aug 22, 2012 at 01:50:09PM +, Hebbar, Gururaja wrote:
From your for-3.7 branch, I could only find such implementation in Tegra
Platform.
Most Freescale platforms implements this through a device/driver method.
Exception being sound/soc/mxs/mxs-pcm.c
So should I follow tegra
On Mon, Aug 27, 2012 at 06:56:44PM +0530, Hebbar, Gururaja wrote:
Device tree support for tlv320aic3x CODEC driver.
Applied, thanks.
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
On Mon, Aug 27, 2012 at 06:56:42PM +0530, Hebbar, Gururaja wrote:
+- sram-size-playback : size of sram to be allocated during playback
+- sram-size-capture : size of sram to be allocated during capture
These smell like runtime/policy configuration rather than fixed
properties of the device so
On Mon, Aug 27, 2012 at 06:56:39PM +0530, Hebbar, Gururaja wrote:
Same as the commit 518de86 (ASoC: tegra: register 'platform' from DAIs,
get rid of pdev). It makes davinci-pcm not a platform_driver but helper
to register platform, so that the platform_device for davinci-pcm can
be saved
On Mon, Aug 27, 2012 at 06:56:41PM +0530, Hebbar, Gururaja wrote:
Davinci McASP header driver are shared by few OMAP platforms (like
TI81xx, AM335x). Splitting asp header into Davinci platform specific
header and Audio specific header helps to share them across platforms.
Applied, thanks.
On Mon, Aug 27, 2012 at 06:56:40PM +0530, Hebbar, Gururaja wrote:
Since davinci-pcm is no more a platform_driver but helper to register
platform pcm driver, remove davinci-pcm device registration
Applied, thanks.
___
Davinci-linux-open-source mailing
On Mon, Aug 27, 2012 at 06:56:42PM +0530, Hebbar, Gururaja wrote:
Add device tree probe for McASP driver.
Applied, thanks.
___
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
On Mon, Aug 27, 2012 at 06:56:43PM +0530, Hebbar, Gururaja wrote:
Device tree support for tlv320aic3x CODEC driver
Not really for the CODEC - this is a machine driver.
+- dai-data : A list of DAI data used by SOC code to register
+ DAI, Codecs platform.
+
On Fri, Aug 31, 2012 at 08:55:39AM +, Hebbar, Gururaja wrote:
Gentle Ping. Any updates about this version or can it be pulled into the tree.
On Thu, Aug 30, 2012 at 09:29:55, Hebbar, Gururaja wrote:
Please don't do this:
- Never top post.
- If the patch genuinely has been forgotten
On Fri, Aug 31, 2012 at 06:20:57PM +0530, Hebbar, Gururaja wrote:
+ if (dev-version == MCASP_VERSION_3) {
+ mcasp_clr_bits(dev-base + MCASP_VER3_RFIFOCTL,
FIFO_ENABLE);
-
On Fri, Aug 31, 2012 at 06:20:59PM +0530, Hebbar, Gururaja wrote:
Fix typo caused by recent commit (cf53756 - ASoC: davinci: davinci-pcm
does not need to be a plaform_driver)
Applied, thanks.
___
Davinci-linux-open-source mailing list
On Mon, Sep 03, 2012 at 06:57:22AM +, Hebbar, Gururaja wrote:
Ok I will update this. Since 3/3 is already accepted I don’t see any reviews
for 2/3, I will only resend this patch (1/3). Is it ok?
Yes.
___
Davinci-linux-open-source mailing list
On Mon, Sep 03, 2012 at 01:40:40PM +0530, Hebbar, Gururaja wrote:
The OMAP2+ variant of McASP is different from Davinci variant w.r.to
some register offset.
Applied, thanks.
___
Davinci-linux-open-source mailing list
1 - 100 of 162 matches
Mail list logo