| Eddie can suggest whatever he likes and I welcome it. That doesn't
| mean it will get included though as it depends on coders. You don't
| like his approach which is fine - it means that you won't code it. I
| like the sounds of it but very time constrained so probably won't
| unless it
On 11/28/06, Gerrit Renker [EMAIL PROTECTED] wrote:
Quoting Eddie Kohler:
| Gerrit:
|
| I am able to read code. When I look at the existing Linux code and patches
| for CCID 3, I see a lot of corner cases designed to handle the
| TFRC_SSTATE_NO_FBACK state.
|
| That state may not need to
Quoting Arnaldo Carvalho de Melo:
| most things merged, except for the packet size and
| TRFC equation patches, that I thought a day or two would be nice for
| further discussion.
I have tidied up what remained and uploaded the up-to-date remaining patches on
to
[DCCP]: Use `unsigned' for packet lengths
This patch implements a suggestion by Ian McDonald and
1) avoids tests against negative packet lengths by using unsigned (u32)
for packet payload lengths in the CCID send_packet()/packet_sent() routines
2) removes an now unnecessary test with
[CCID 3]: Remove small typo
This removes a small typo introduced by an earlier patch.
= It is sent as RFC since it would be a much better idea to
revise this so that the nofeedback timer expires after
max(4*R, 2 * s/X)
instead of after
max(t_rto, 2 *
On 11/29/06, Gerrit Renker [EMAIL PROTECTED] wrote:
[CCID 3]: Remove small typo
Acked-by: Ian McDonald [EMAIL PROTECTED]
--
Ian McDonald
Web: http://wand.net.nz/~iam4
Blog: http://imcdnzl.blogspot.com
WAND Network Research Group
Department of Computer Science
University of Waikato
New Zealand
Patch 1: Removes a typo in setting the nofeedback timer.
== Question: The nofeedback timer is currently set to time out after
max(t_rto, 2 * s/X) = max(max(4*R, 1 second), 2
*s/X)
This is non-standard and has been flagged in the code
On 11/29/06, Gerrit Renker [EMAIL PROTECTED] wrote:
[DCCP]: Use `unsigned' for packet lengths
I'm wondering whether this code is 64 bit safe??? I don't think it is.
Arnaldo can probably advise.
We changed int to u32 for length and I went and checked the callers
and parameters. They all
Quoting Ian McDonald:
| The code here predates me but I think the reason for it might be to do
| with RFC4342 (remember to read 3448 in conjunction with this).
|
| If the sender never receives a feedback packet from the receiver, and
| as a consequence never gets to set the allowed
Quoting Ian McDonald:
| On 11/29/06, Gerrit Renker [EMAIL PROTECTED] wrote:
| [DCCP]: Use `unsigned' for packet lengths
|
| I'm wondering whether this code is 64 bit safe??? I don't think it is.
| Arnaldo can probably advise.
|
| We changed int to u32 for length and I went and checked
On 11/29/06, Gerrit Renker [EMAIL PROTECTED] wrote:
Quoting Ian McDonald:
| The code here predates me but I think the reason for it might be to do
| with RFC4342 (remember to read 3448 in conjunction with this).
|
| If the sender never receives a feedback packet from the receiver, and
Quoting Ian McDonald:
| I think I didn't explain my point well here. You can't change to u32
| but need to be unsigned int (not u64).
Don't get this: u32 is a 32-bit unsigned value and therefore looks sufficient -
and you
are proposing `unsigned int' to have easier conversion to skb-len,
On 11/28/06, Gerrit Renker [EMAIL PROTECTED] wrote:
[DCCP]: Remove allocation of sysctl numbers
This is in response to a request sent earlier by Eric W. Biederman
and replaces all sysctl numbers for net.dccp.default with CTL_UNNUMBERED.
It has been tested to compile and to work.
On 11/28/06, Ian McDonald [EMAIL PROTECTED] wrote:
On 11/29/06, Gerrit Renker [EMAIL PROTECTED] wrote:
[CCID 3]: Remove small typo
Acked-by: Ian McDonald [EMAIL PROTECTED]
Thanks, applied.
-
To unsubscribe from this list: send the line unsubscribe dccp in
the body of a message to [EMAIL
On 11/29/06, Gerrit Renker [EMAIL PROTECTED] wrote:
Quoting Ian McDonald:
| I think I didn't explain my point well here. You can't change to u32
| but need to be unsigned int (not u64).
Don't get this: u32 is a 32-bit unsigned value and therefore looks sufficient -
and you
are proposing
This is a Re-sent after discusssion with Ian. I have renamed
the variable also, as the term got too long for the 80 columns fixed
linelength - hope `t_nfb' is ok as mnemonic for the nofeedback timeout.
--- Commit Message
[CCID 3]: Set NoFeedback
On Tue, Nov 28, 2006 at 08:25:00PM +, Gerrit Renker wrote:
This is a Re-sent after discusssion with Ian. I have renamed
the variable also, as the term got too long for the 80 columns fixed
linelength - hope `t_nfb' is ok as mnemonic for the nofeedback timeout.
Ok, I'll retract the other
On 11/29/06, Gerrit Renker [EMAIL PROTECTED] wrote:
This is a Re-sent after discusssion with Ian. I have renamed
the variable also, as the term got too long for the 80 columns fixed
linelength - hope `t_nfb' is ok as mnemonic for the nofeedback timeout.
Signed-off-by: Ian McDonald [EMAIL
On Wed, Nov 29, 2006 at 09:17:04AM +1300, Ian McDonald wrote:
On 11/29/06, Gerrit Renker [EMAIL PROTECTED] wrote:
Quoting Ian McDonald:
| I think I didn't explain my point well here. You can't change to u32
| but need to be unsigned int (not u64).
Don't get this: u32 is a 32-bit unsigned
| On 11/29/06, Gerrit Renker [EMAIL PROTECTED] wrote:
| Quoting Ian McDonald:
| | I think I didn't explain my point well here. You can't change to u32
| | but need to be unsigned int (not u64).
| Don't get this: u32 is a 32-bit unsigned value and therefore looks
sufficient - and you
|
On Tue, Nov 28, 2006 at 06:28:14PM -0200, Arnaldo Carvalho de Melo wrote:
On Tue, Nov 28, 2006 at 08:25:00PM +, Gerrit Renker wrote:
This is a Re-sent after discusssion with Ian. I have renamed
the variable also, as the term got too long for the 80 columns fixed
linelength - hope
In short: my suggestion is to keep an experimental patch for this and I would
even offer to
keep one up-to-date and online, if in return we can simplify the
socket API. Does
this sound like a more convincing argument?
Fair enough, I think we should go this way for now,
On 11/28/06, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote:
On 11/28/06, Ian McDonald [EMAIL PROTECTED] wrote:
In short: my suggestion is to keep an experimental patch for this and I
would even offer to
keep one up-to-date and online, if in return we can simplify
the socket
OK, additionally I'm replacing:
+ DCCP_WARN(sockopt(PACKET_SIZE) is deprecated: fix your app\n);
+ err = -EINVAL;
By
+ DCCP_WARN(sockopt(PACKET_SIZE) not yet supported\n);
+ err = -EINVAL;
To better reflect what we've discussed so far.
On 11/28/06, Ian McDonald [EMAIL PROTECTED] wrote:
OK, additionally I'm replacing:
+ DCCP_WARN(sockopt(PACKET_SIZE) is deprecated: fix your
app\n);
+ err = -EINVAL;
By
+ DCCP_WARN(sockopt(PACKET_SIZE) not yet supported\n);
+ err =
Quoting Ian McDonald:
|In short: my suggestion is to keep an experimental patch for this and I
would even offer to
| keep one up-to-date and online, if in return we can simplify
the socket API. Does
| this sound like a more convincing argument?
|
| Fair enough,
On 11/28/06, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote:
On 11/28/06, Ian McDonald [EMAIL PROTECTED] wrote:
OK, additionally I'm replacing:
+ DCCP_WARN(sockopt(PACKET_SIZE) is deprecated: fix your
app\n);
+ err = -EINVAL;
By
+
Quoting Eddie Kohler:
| | Would really appreciate if you could at some time have a look at the
moving-average patch. Have communicated
| | with Eddie again about it, and using MSS would at the moment be much
more complicated.
| |
| | Will look at it tomorrow (along with
This removes and cleans up unused variables and structures which have become
unnecessary following the introduction of the EWMA patch to automatically track
the CCID 3 receiver/sender packet sizes `s'.
It deprecates the PACKET_SIZE socket option by returning an error code and
printing a
Problem:
Currently, the receiver/sender packet size `s' of the TCP throughput equation
[RFC 3448, 3.1] has to be communicated manually via socket options to the
CCID3 module. This has been discussed on [EMAIL PROTECTED], see e.g.
This is in response to a request sent earlier by Eric W. Biederman
and replaces all sysctl numbers for net.dccp.default with CTL_UNNUMBERED.
It has been tested to compile and to work.
Commiter note: I've removed the use of CTL_UNNUMBERED, not setting .ctl_name
sets it to 0, that
This corrects the setting of the nofeedback timer with regard to RFC
3448 - previously it was not set to max(4*R, 2*s/X) as specified. Using
the maximum of 1 second as upper bound (as it was done before) can have
detrimental effects, especially if R is small.
Signed-off-by: Ian McDonald [EMAIL
To reflect the fact that this now is of no effect, not making apps
stop working, just be warned in the system log.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/proto.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/dccp/proto.c
This implements the larger-initial-windows feature for CCID 3, as described in
section 5 of RFC 4342. When the first feedback packet arrives, the sender can
send up to 2..4 packets per RTT, instead of just one.
The patch further
* reduces the number of timestamping calls by passing the timestamp
This patch implements a suggestion by Ian McDonald and
1) Avoids tests against negative packet lengths by using unsigned int
for packet payload lengths in the CCID send_packet()/packet_sent() routines
2) As a consequence, it removes an now unnecessary test with regard to `len
0'
in
ttcp-r: accept from localhost.ghostprotocols.net
ttcp-t: connect
ttcp-t: 256000 bytes in 22.98 real seconds = 10.88 KB/sec +++
ttcp-t: 1000 I/O calls, msec/call = 23.53, calls/sec = 43.51
ttcp-t: 0.2user 17.0sys 0:22real 75% 0i+0d 0maxrss 0+1pf 0+1000csw
ttcp-r: 256000 bytes in 23.31 real seconds
On 11/28/06, Ian McDonald [EMAIL PROTECTED] wrote:
ttcp-r: accept from localhost.ghostprotocols.net
ttcp-t: connect
ttcp-t: 256000 bytes in 22.98 real seconds = 10.88 KB/sec +++
ttcp-t: 1000 I/O calls, msec/call = 23.53, calls/sec = 43.51
ttcp-t: 0.2user 17.0sys 0:22real 75% 0i+0d 0maxrss
On 11/29/06, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote:
On 11/28/06, Ian McDonald [EMAIL PROTECTED] wrote:
ttcp-r: accept from localhost.ghostprotocols.net
ttcp-t: connect
ttcp-t: 256000 bytes in 22.98 real seconds = 10.88 KB/sec +++
ttcp-t: 1000 I/O calls, msec/call = 23.53,
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Date: Tue, 28 Nov 2006 19:57:16 -0200
Here goes today's DCCP batch, please consider pulling from
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git
Looks good, pulled, thanks a lot.
-
To unsubscribe from this list: send the
39 matches
Mail list logo
