Re: [RFC] [PATCH]: use explicit enums for CCID 3 states

2006-11-15 Thread Gerrit Renker
Hi Arnaldo | Well, I'd rather prefer a WARN_ON type, probably rate limiting the | printks, so that we can receive reports that something is fishy but | don't panic the machine. I have implemented such a macro and have changed the patch to use it. If it is acceptable, I would like to propose

Re: [RFC] [PATCH]: use explicit enums for CCID 3 states

2006-11-15 Thread Arnaldo Carvalho de Melo
On 11/15/06, Gerrit Renker [EMAIL PROTECTED] wrote: Hi Arnaldo | Well, I'd rather prefer a WARN_ON type, probably rate limiting the | printks, so that we can receive reports that something is fishy but | don't panic the machine. I have implemented such a macro and have changed the patch to

Re: [RFC] [PATCH]: use explicit enums for CCID 3 states

2006-11-15 Thread Ian McDonald
On 11/16/06, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: I think something like WARN(), counterpart to BUG() is very much in demand :) Agree. Should be trivial to implement and I had though of doing as I've done WARN_ON(1) a number of times... Yet another thing to add to my huge todo