On 10/17/05, Herbert Xu [EMAIL PROTECTED] wrote:
On Tue, Oct 18, 2005 at 11:01:40AM +1300, Ian McDonald wrote:
[c01034ee] dump_stack+0x1e/0x30
[c0319c25] ip_options_echo+0x45/0x360
[c033a866] icmp_send+0x106/0x3d0
[c0315a8c] ipv4_link_failure+0x2c/0x60
[c0338a97]
On 10/25/05, Ian McDonald [EMAIL PROTECTED] wrote:
I just tried replicating this but it didn't do the same for me. It did
run slow due to constant resyncing like you were having also. This is
a problem that we are aware of but shouldn't cause the crash.
I don't claim to understand what the
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.16.git
Best Regards,
- Arnaldo
tree 123eb3b4b48c74759e83249eebf9d5e0897ade9c
parent c31a8d1bb087e6f7b231f00dc611bd505d96d9c6
author Arnaldo Carvalho de Melo [EMAIL PROTECTED] 1133484923 -0200
On 12/11/05, Francois Romieu [EMAIL PROTECTED] wrote:
Arnaldo Carvalho de Melo [EMAIL PROTECTED] :
[...]
index 000..23058dc
--- /dev/null
+++ b/net/dccp/ipv6.c
[...]
+static void dccp_v6_ctl_send_reset(struct sk_buff *rxskb)
+{
[...]
+ skb = alloc_skb(MAX_HEADER + sizeof(struct
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.16.git
Best Regards,
- Arnaldo
tree 99f9e56a48a5a7a783875df630e84c91fd06488a
parent 793a36f474b6d9991f6c1c218041e350cda57195
author Arnaldo Carvalho de Melo [EMAIL PROTECTED] 1134430852 -0200
On 12/12/05, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote:
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.16.git
Oops, there was a bug introduced by this patch at this hunk:
@@ -870,7 +872,7 @@ static struct sock * tcp_v6_syn_recv_soc
I'm not aware of any, at the same time I think DCCP should at least
expose the info on ack vectors,so the question is: is the information
available on ack vectors enough for you (the app writers?)?
- Arnaldo
On 12/19/05, Bruce Barnett [EMAIL PROTECTED] wrote:
I've been involved with the
On 2/14/06, Andrea Bittau [EMAIL PROTECTED] wrote:
Drop sock reference count on timer expiration and reset.
There was a hybrid use of standard timers and sk_timers. This caused the
reference count of the sock to be incorrect when resetting the RTO timer. The
sock reference count should now
Carvalho de Melo [EMAIL PROTECTED] 1140438322 -0300
committer Arnaldo Carvalho de Melo [EMAIL PROTECTED] 1140438322 -0300
[DCCP] CCID: Improve CCID infrastructure
1. No need for -ccid_init nor -ccid_exit, this is what module_{init,exit}
does and anynways neither ccid2 nor ccid3 were using it.
2
On 2/20/06, Carl-Daniel Hailfinger [EMAIL PROTECTED] wrote:
Patrick McHardy schrieb:
Reuben Farrelly wrote:
Minor dependency issue:
My compile failed with this..
CC [M] net/netfilter/xt_dccp.o
In file included from net/netfilter/xt_dccp.c:15:
include/linux/dccp.h:341:2: error:
On 2/20/06, Ian McDonald [EMAIL PROTECTED] wrote:
Arnaldo, (or anybody else)
I can get it working with the extra lock but not without... Comments
inline and at the end. Help much appreciated!
Please leave the extern
Yep!
I guess we don't need this lock, but instead use bh_lock_sock,
-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Signed-off-by: Al Viro [EMAIL PROTECTED]
--
include/linux/dccp.h | 52 +++--
net/dccp/ccids/ccid3.c |6 ++---
net/dccp/dccp.h
On 2/21/06, David S. Miller [EMAIL PROTECTED] wrote:
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Date: Tue, 21 Feb 2006 21:49:14 -0300
Do you prefer? Today I talked with our git guy (Eduardo Habkost) and
changed my mind, doing things (duh!) in master and using git-fetch/
git-rebase
So that dccp_feat_clean doesn't get confused with uninitialized list_heads.
Noticed when testing with no ccid kernel modules.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ipv4.c |9 -
1 files changed, 4 insertions(+), 5 deletions
setsockopt to specify the desired CCID, etc.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
include/linux/dccp.h |9 -
1 files changed, 0 insertions(+), 9 deletions(-)
499dbc5e7f577a3a1712cee8dcb0e540082ab81d
diff --git a/include/linux/dccp.h b/include/linux/dccp.h
index
Renaming it to dccp_send_reset and moving it from the ipv4 specific code to the
core dccp code.
This fixes some bugs in IPV6 where timers would send v4 resets, etc.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/dccp.h |6 +-
net/dccp/input.c |2 +-
net
As this is used by both ipv4 and ipv6 and is not ipv4 specific.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/dccp.h |1 +
net/dccp/ipv4.c | 14 +-
net/dccp/ipv6.c |2 +-
net/dccp/proto.c | 14 ++
4 files changed, 17 insertions
Removing one more ipv6 uses ipv4 stuff case in dccp land.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/dccp.h |4 +-
net/dccp/ipv4.c | 106 +++---
net/dccp/ipv6.c |4 +-
net/dccp/proto.c | 102
is legacy, I only want ipv6 dude! direction.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/Makefile |7 +--
net/dccp/dccp.h|6 --
net/dccp/ipv4.c| 140 ++--
net/dccp/options.c |2 +
net/dccp/output.c |2
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 10 +
net/dccp/dccp.h| 49 ++---
net/dccp/input.c |7 +++---
net/dccp/output.c |2 +-
net/dccp/proto.c | 52
way for freeing the control sockets in
upcoming changesets.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/Kconfig |9 ---
net/dccp/ccids/ccid3.c |9 ---
net/dccp/dccp.h|4 +--
net/dccp/ipv4.c| 65
On 2/28/06, Ian McDonald [EMAIL PROTECTED] wrote:
Arnaldo,
Haven't seen this going in so resending...
What a coincidence, I'm testing this patch right now, and I'm afraid it has
some bug or makes it more likely that some other bug happens, the machine
soft locks with it enabled and when using
Code 5, ...
if option O is absent (Mandatory was the last byte of the option list), or
if option O equals Mandatory.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Signed-off-by: Hagen Paul Pfeifer [EMAIL PROTECTED]
---
net/dccp/options.c |7 ++-
1 files changed, 6
No changes in the logic where made.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid2.c | 76
1 files changed, 26 insertions(+), 50 deletions(-)
1c6ddda9288aba6a761b45357d119a47df165d4a
diff --git a/net/dccp
In rare circumstances 0 is returned by dccp_li_hist_calc_i_mean which leads to
a divide by zero in ccid3_hc_rx_packet_recv. Explicitly check for zero return
now. Update copyright notice at same time.
Found by Arnaldo.
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.17.git
Best Regards,
- Arnaldo
ccids/ccid2.c | 77 +
ccids/ccid3.c | 11 +-
ipv6.c| 257 +-
options.c |
No changes in the logic were made, just removing trailing whitespaces, etc.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ipv6.c | 256 ---
1 files changed, 129 insertions(+), 127 deletions
On 2/28/06, Ian McDonald [EMAIL PROTECTED] wrote:
When send_ackvec sysctl is on DCCP locks the machine. Unfortunately it
doesn't send any output to the kernel.
I'm getting below results by just stopping the syslog daemon and setting
printk log level to 9:
[EMAIL PROTECTED] ~]# service syslog
And not the silly LIMIT_NETDEBUG and silently return without inserting
the option requested.
Also drop some old debugging messages associated to option insertion.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ackvec.c | 14 +++---
net/dccp/ccid.h| 18
Merging it with its only user: dccp_v[46]_reqsk_send_ack.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ipv4.c |9 ++---
net/dccp/ipv6.c |9 ++---
2 files changed, 4 insertions(+), 14 deletions(-)
c4a14e8cbc06bc6733b5976a800cd1b669010bb7
diff --git
Em Wed, Mar 08, 2006 at 10:37:55PM -0800, David S. Miller escreveu:
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Date: Thu, 9 Mar 2006 00:08:08 -0300
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.17.git
I'll apply these by hand because
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.17.git
Best Regards,
- Arnaldo
b/drivers/infiniband/ulp/ipoib/ipoib_multicast.c |2
b/include/linux/dccp.h | 43 ---
b/include/net/inet_connection_sock.h
a265d6baa827bd6411d1c5566b9e3596fec88a91 removes dummy_socket_getpeersec,
replacing it with two new functions, but still references the removed function
in the security_fixup_ops table, fix it by doing the replacement operation in
the fixup table too.
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
drivers/infiniband/ulp/ipoib/ipoib_multicast.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
b4692710ef01c342b050947b55240424854d272e
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c
b/drivers/infiniband/ulp
*** Warning: skb_pull_rcsum [net/bridge/bridge.ko] undefined!
*** Warning: skb_pull_rcsum [net/8021q/8021q.ko] undefined!
*** Warning: skb_pull_rcsum [drivers/net/pppoe.ko] undefined!
*** Warning: skb_pull_rcsum [drivers/net/ppp_generic.ko] undefined!
Signed-off-by: Arnaldo Carvalho de Melo
David Miller wrote:
From: Ian McDonald [EMAIL PROTECTED]
Date: Sat, 10 Jun 2006 20:28:39 +1200
I have tested this and wonder whether it can be pushed upstream for
Linus for 2.6.17 if at all possible. I know Arnaldo is the maintainer
but as you are aware he is very busy with other projects
On 6/22/06, Ian McDonald [EMAIL PROTECTED] wrote:
When using the default sequence window size (100) I got the following in
my logs:
Jun 22 14:24:09 localhost kernel: [ 1492.114775] DCCP: Step 6 failed for
DATA packet, (LSWL(6279674225) = P.seqno(6279674749) =
S.SWH(6279674324)) and (P.ackno
using iperf goes from about 2.8 Mbits/sec
to 3.5. This is still far too slow but it is a step in the right direction.
Compile tested only for IPv6 but not particularly complex change.
Signed off by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED
On 7/19/06, Ian McDonald [EMAIL PROTECTED] wrote:
Resent to apply cleanly on latest tree. Bug fix - for 2.6.18
Thanks, applied.
- Arnaldo
-
To unsubscribe from this list: send the line unsubscribe dccp in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Andrea Bittau wrote:
This is an experimental patch to bridge CCID2 and existing tcp congestion
contrl
algorithms. Added support for tcp_congestion_ops in CCID2. This allows for
CCID2 to use different variants of congestion control. The default is the RFC
CCID2, named with much
On 8/24/06, Ian McDonald [EMAIL PROTECTED] wrote:
I spent all of today on USAGI's IPSEC/MIPV6 patches and related
issues, so I'll look into this tomorrow.
Thanks Ian.
Yes I saw that. Take your time as this is nowhere near as important!
Sigh, I'm still busy indeed, gave a quick look at the
On 8/28/06, Ian McDonald [EMAIL PROTECTED] wrote:
On 8/28/06, David Miller [EMAIL PROTECTED] wrote:
From: Ian McDonald [EMAIL PROTECTED]
Date: Mon, 28 Aug 2006 16:34:50 +1200
Arnaldo has pointed this one out to me in latest series of
patches. Can this go into 2.6.18 please?
It's not a
On 8/29/06, Ian McDonald [EMAIL PROTECTED] wrote:
On 8/28/06, David Miller [EMAIL PROTECTED] wrote:
From: Ian McDonald [EMAIL PROTECTED]
Date: Mon, 28 Aug 2006 16:34:50 +1200
Arnaldo has pointed this one out to me in latest series of
patches. Can this go into 2.6.18 please?
It's not a
Allow the user to choose whether or not to enable CCID2 debugging via Kconfig.
Signed-off-by: Andrea Bittau [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
--
Kconfig |8
ccid2
from _init().
Signed-off-by: Andrea Bittau [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
--
ccid2.c | 49 +++--
ccid2.h |1 +
2 files
On 9/22/06, Gerrit Renker [EMAIL PROTECTED] wrote:
Hi Arnaldo
| Gerrit, could you please use my net-2.6.19?
Of course - I didn't know it was active. I have just pulled your tree and
the patch applies without problem.
OK, going over it now.
Will use this tree now for all dccp work.
Thanks,
On 10/24/06, David Miller [EMAIL PROTECTED] wrote:
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Date: Mon, 23 Oct 2006 23:57:42 -0300
Not an oversight, its just that this one is not a plain code bugfix so
I deferred it for later, if Dave thinks this is OK even being just a
comment fix
On 10/24/06, Gerrit Renker [EMAIL PROTECTED] wrote:
It seems that I am not the only one having headaches about which patches
are applied and which not. I spent a major part yesterday trying to get
the set of patches consistent with regard to Dave's/Arnaldo's latest tree.
What I have been doing
On 11/9/06, Ian McDonald [EMAIL PROTECTED] wrote:
Although this is a relatively minor bug, I believe it would be better to
stick by the DCCP rule
that `each outgoing packet has its sequence number incremented' and will send
a patch.
Ian, I will remove this ToDo from the list, ok?
Thanks
Gerrit,
I'm going over the_whole_lot patch queue from you, many thanks
for doing this work! About 07a_putative_nested_lock_in_rcv.diff, I
haven't studied the bh_lock_sock_nested, lockdep stuff, but can't we
just use bh_lock_sock_nested in sk_receive_skb?
I'm postponing this one
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git
This is the first stab at merging the patch queue maintained
by Gerrit while I was busy, thanks Gerrit! I'll go over the other
patches RSN.
- Arnaldo
-
To unsubscribe from
This is a re-send from
http://www.mail-archive.com/dccp@vger.kernel.org/msg00553.html
It is the same patch as before, but I have built in Arnaldo's suggestions
pointed out in that posting.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED
PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
--
include/linux/dccp.h |7 +++
net/dccp/ipv4.c |9 ++---
net/dccp/ipv6.c |8 ++--
net/dccp/output.c| 14
Gerrit Renker noticed dccp_tw_deschedule and submitted a patch with a FIXME,
but as he suggests in the same patch the best thing is to just ditch this
declaration, while doing that also noticed that tcp_tw_count is as well not
defined anywhere, so ditch it too.
Signed-off-by: Arnaldo Carvalho de
-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
--
dccp.h |2 ++
ipv4.c | 48 +---
ipv6.c | 57
Fixes a typo in Kconfig, patch is by Ian McDonald and is re-sent from
http://www.mail-archive.com/dccp@vger.kernel.org/msg00579.html
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED
-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
--
dccp.h |2 ++
output.c |8 +---
2 files changed, 7 insertions(+), 3 deletions
On 11/10/06, James Morris [EMAIL PROTECTED] wrote:
The dccp ipv4 ipv6 modules cannot be unloaded, as their control sockets
each maintain a couple of module references. So, it seems like a good
idea to just remove the module exit functions completely.
Please review.
Well, I have a patch in
On 11/10/06, James Morris [EMAIL PROTECTED] wrote:
On Fri, 10 Nov 2006, James Morris wrote:
I wonder if this facility can be integrated more generally into the kernel
protocol which people are developing.
Ugh, editor screwup. That was meant to be
I wonder if this facility can be integrated
Sorts out the comments for processing steps 2,3 in section 8.5 of RFC 4340.
All comments have been updated against this document, and the reference to step
2 has been made consistent throughout the files.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo
:
* If P.CsCov is too large for the packet size, drop packet and return.
The code has been tested with applications, the latest version of tcpdump now
comes with support for partial DCCP checksums.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL
On Fri, Nov 10, 2006 at 02:52:22PM -0800, David Miller wrote:
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Date: Fri, 10 Nov 2006 20:44:54 -0200
Please consider pulling these extra csets, available at:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git
Pulled
consistent among calls but they seem to be in the
reverse order.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
--
ipv4.c |5 ++---
ipv6.c | 20
been dropped, since it is obvious from use.
Also removed a duplicate `dccp_feat_default_sequence_window' in ipv4.c.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git
Regards,
- Arnaldo
-
To unsubscribe from this list: send the line unsubscribe dccp in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
if CONFIG_IP_DCCP_DEBUG is
selected, leaving this to another cset tho. Also
shortened dccp_feat_negotiation_debug to dccp_feat_debug.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED
check #1. Therefore, when check #2 is
performed, no new work will be done. This is now detected and there is no
performance hit when doing #2.
Signed-off-by: Andrea Bittau [EMAIL PROTECTED]
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED
On 11/15/06, Gerrit Renker [EMAIL PROTECTED] wrote:
While working on the promised EWMA patch for CCID 3 packet sizes, I stumbled
over two things
and can make no sense of a bit of CCID 3 Receive code:
1) ccid3_hc_rx_sock maintains a real-timer RTT counter ccid3hcrx_rtt
which
On 11/15/06, Gerrit Renker [EMAIL PROTECTED] wrote:
Hi Arnaldo
| Well, I'd rather prefer a WARN_ON type, probably rate limiting the
| printks, so that we can receive reports that something is fishy but
| don't panic the machine.
I have implemented such a macro and have changed the patch to
On 11/15/06, Gerrit Renker [EMAIL PROTECTED] wrote:
Hi Arnaldo,
thank you for the link @-)
| The following is the revised patch with three macros added, I liked the
| DCCP_BUG_ON():
|
| will look into that barring social life that is taking me so much time
| that I should be working on
be a few, pre-defined enum names
* this necessitates addiditional checking for unexpected values
which would otherwise be caught by the compiler
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 45
On 11/16/06, Gerrit Renker [EMAIL PROTECTED] wrote:
Quoting Arnaldo Carvalho de Melo:
| On 9/22/06, Gerrit Renker [EMAIL PROTECTED] wrote:
| Quoting Eddie Kohler:
| | Why burden the application programmer to handcode an estimation of
the average each
| | time? I can not see
wrapping.
Signed-off-by: Andrea Bittau [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid2.c | 22 --
net/dccp/ccids/ccid2.h |1 +
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/net/dccp/ccids/ccid2.c b/net
Spotted by Eric Dumazet in tcp_v4_rcv().
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ipv4.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c
index 6bca719..a20eb71 100644
--- a/net/dccp/ipv4.c
+++ b/net/dccp
Spotted by Ian McDonald, tentatively fixed by Gerrit Renker:
http://www.mail-archive.com/dccp%40vger.kernel.org/msg00599.html
Rewritten not to unroll sk_receive_skb, in the common case, i.e. no lock
debugging, its optimized away.
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED
On 11/13/06, David Miller [EMAIL PROTECTED] wrote:
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
Date: Fri, 10 Nov 2006 16:32:16 -0200
On 11/10/06, James Morris [EMAIL PROTECTED] wrote:
On Fri, 10 Nov 2006, James Morris wrote:
I wonder if this facility can be integrated more
On Fri, Nov 17, 2006 at 03:56:50PM +, Gerrit Renker wrote:
This includes mostly Ian's tx_qlen patch, the promised tidy-up of the WARN/BUG
message scheme, and some trivial things.
Patch 1: This is Ian's tx_qlen updated tx_qlen patch.
I have removed the #define again (and was
Commiter note: original patch was splitted.
Signed-off-by: Andrea Bittau [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ackvec.c |1 -
net/dccp/ackvec.h |2 --
2 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/net/dccp/ackvec.c b/net
,
using, initially, up to a max of 2 ackvecs as per Andrea's original patch, then
I'll work on support for larger ackvecs, be it using a sysctl or using
setsockopt.
Signed-off-by: Andrea Bittau [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ackvec.c | 23
[EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ackvec.c | 46 --
1 files changed, 32 insertions(+), 14 deletions(-)
diff --git a/net/dccp/ackvec.c b/net/dccp/ackvec.c
index 41d34d1..bdf1bb7 100644
--- a/net/dccp
On 11/21/06, Gerrit Renker [EMAIL PROTECTED] wrote:
[CCID 3]: Fix calculation of t_ipi time of scheduled transmission
Problem:
Currently packet transmissions are not scheduled according to [RFC 3448, 4.6]
and
will, in the worst case, be sent later than necessary. If scheduled
On 11/26/06, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote:
On 11/21/06, Gerrit Renker [EMAIL PROTECTED] wrote:
[CCID 3]: Simplify control flow in the calculation of t_ipi
This patch performs a simplifying (performance) optimisation:
In each call of the inline function
On 11/21/06, Ian McDonald [EMAIL PROTECTED] wrote:
On 11/22/06, Gerrit Renker [EMAIL PROTECTED] wrote:
[CCID 3]: Simplify control flow of ccid3_hc_tx_send_packet
This makes some logically equivalent simplifications, by replacing
rc - values plus goto's with direct return statements.
On 11/24/06, Gerrit Renker [EMAIL PROTECTED] wrote:
[CCID 3]: Avoid congestion control on zero-sized data packets
This resolves an `XXX' in ccid3_hc_tx_send_packet().
The function is only called on Data and DataAck packets and
returns a negative result on zero-sized messages. This is a
On 11/24/06, Gerrit Renker [EMAIL PROTECTED] wrote:
[CCID 3]: Resolve small FIXME
This considers the case - ACK received while no packet has been sent
so far. Resolved by printing a (rate-limited) warning message.
Further removes an unnecessary BUG_ON in ccid3_hc_tx_packet_recv,
received
On 11/24/06, Gerrit Renker [EMAIL PROTECTED] wrote:
[CCID 3]: Consolidate timer resets
The specification in [RFC 3448, 4.4, step (3)] is impossible to
implement: when no feedback has been received, the value of RTT
is undefined as per [RFC 3448, 4.2]. Hence we can not set the
timeout value to
On 11/24/06, Gerrit Renker [EMAIL PROTECTED] wrote:
[CCID 3] Consistently update t_nom, t_ipi, t_delta
This patch
* consolidates updating of parameters (t_nom, t_ipi, t_delta) which
need to be updated at the same time, since they are inter-dependent
* removes two inline functions which
On 11/24/06, Gerrit Renker [EMAIL PROTECTED] wrote:
[CCID 3] Consolidate handling of t_RTO
This patch
* removes setting t_RTO in ccid3_hc_tx_init (per [RFC 3448, 4.2], t_RTO is
undefined until feedback has been received);
* makes some trivial changes (updates of comments);
* performs a
On 11/24/06, Gerrit Renker [EMAIL PROTECTED] wrote:
[NET]: Add documentation for TFRC structures
This adds documentation for the TFRC structure fields.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Thanks, applied.
- Arnaldo
-
To unsubscribe from this list: send the line unsubscribe dccp
On 11/27/06, Gerrit Renker [EMAIL PROTECTED] wrote:
Quoting Arnaldo Carvalho de Melo:
| For now I'm merging the patch changing just the commit log not to state that
the
| comment was wrong, i.e. I think its just superfluous :-)
|
| As I'm putting these csets in the 'ccid3' branch of my net
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git
A new batch will come as agreement is reached on some other csets.
Thanks a lot,
- Arnaldo
-
To unsubscribe from this list: send the line unsubscribe dccp in
the body of a
(USEC_PER_SEC / 2 , USEC_PER_SEC / (2 * HZ))
= USEC_PER_SEC / (2 * HZ)
Lastly, TFRC_INITIAL_IPI is not referenced anywhere else and can thus be
removed.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de
at the begin of this function is removed.
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 10 +++---
1 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 18 +-
1 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index df88c54..fb1a5e8 100644
--- a/net/dccp/ccids/ccid3.c
+++ b/net/dccp/ccids/ccid3.c
[EMAIL PROTECTED]
Signed-off-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index 58f7cac..6777a7f
t_ipi has not changed, the values of t_delta and t_nom also do
not change,
they depend fully on t_ipi
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Acked-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 21
On 11/27/06, Gerrit Renker [EMAIL PROTECTED] wrote:
Quoting Arnaldo Carvalho de Melo:
| On 11/27/06, Gerrit Renker [EMAIL PROTECTED] wrote:
| Quoting Eddie Kohler:
| | Hi Gerrit, Ian,
| |
| | I am not sure I am completely following this discussion, but there is
one
| | point I
that currently the nofeedback timer is set
in a non-standard way
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
Acked-by: Ian McDonald [EMAIL PROTECTED]
Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED]
---
net/dccp/ccids/ccid3.c | 29 ++---
1 files changed, 14
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git
Thanks a lot,
- Arnaldo
-
To unsubscribe from this list: send the line unsubscribe dccp in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On 11/28/06, Gerrit Renker [EMAIL PROTECTED] wrote:
Quoting Eddie Kohler:
| Gerrit:
|
| I am able to read code. When I look at the existing Linux code and patches
| for CCID 3, I see a lot of corner cases designed to handle the
| TFRC_SSTATE_NO_FBACK state.
|
| That state may not need to
1 - 100 of 422 matches
Mail list logo
