allocated on demand as necessary---cwnd may grow as it wishes. The exceptional
case of when memory is not available is not handled gracefully. Perhaps, cwnd
should be capped at that point.
Signed-off-by: Andrea Bittau <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL
would be for the
CCID to call-back (or dequeue) from DCCP when it is able to transmit traffic --
not the other way around as it currently occurs.
Signed-off-by: Andrea Bittau <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL
.
Signed-off-by: Andrea Bittau <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
--
ccid2.c | 31 +++
1 file changed, 23 insertions(+),
allocated on demand as necessary---cwnd may grow as it wishes. The exceptional
case of when memory is not available is not handled gracefully. Perhaps, cwnd
should be capped at that point.
Signed-off-by: Andrea Bittau <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL
On 9/21/06, Ian McDonald <[EMAIL PROTECTED]> wrote:
Here is my latest set of patches for DCCP.
If possible I would like these to go into 2.6.19. I have tested against
2.6.18rc5 and latest net-2.6.19 git tree of Dave M as well.
Dave - Patches 1 and 2 are trivial and just introducing constants an
On 9/22/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
[DCCP]: If an application does not want to provide a service code, that's
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Applied
Thanks,
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a messa
On Fri, Sep 22, 2006 at 02:26:44PM +1200, Ian McDonald wrote:
> With constants for CCID numbers this now uses them in some places.
>
> Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
Applied, could have been combined with the previous one tho :)
- Arnaldo
-
To unsubscribe from this list: send th
On Fri, Sep 22, 2006 at 02:25:36PM +1200, Ian McDonald wrote:
> This change introduces a constant for CCID numbers.
>
> Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
Applied
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to [EMAIL PROTECTE
On Fri, Sep 22, 2006 at 02:28:01PM +1200, Ian McDonald wrote:
> This adds DCCP probing shamelessly ripped off from TCP probes by Stephen
> Hemminger.
>
> I've put in here support for further CCID3 variables as well.
> Andrea/Arnaldo might look to extend for CCID2.
>
> Signed-off-by: Ian McDonald
On 9/14/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
Sorry kmail garbled this, clean text below.
- Gerrit
Applied, thanks
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/ma
On 9/22/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
Hi Arnaldo
| Gerrit, could you please use my net-2.6.19?
Of course - I didn't know it was active. I have just pulled your tree and
the patch applies without problem.
OK, going over it now.
Will use this tree now for all dccp work.
Thanks
On 9/22/06, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote:
On 9/22/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
> Hi Arnaldo
> | Gerrit, could you please use my net-2.6.19?
> Of course - I didn't know it was active. I have just pulled your tree and
> the patch
On 9/22/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
[DCCP]: current upper limit for option length is 128 bytes;
much less than actually possible. This patch sets a safe upper
bound on option length of 992, under worst-case assumptions.
This patches against the 2.6.19 tree by David.
Gerrit, co
om TCP probes by
Stephen
Hemminger.
I've put in here support for further CCID3 variables as well.
Andrea/Arnaldo might look to extend for CCID2.
Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL
naldo might look to extend for CCID2.
Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/Kconfig | 16
net/dccp/Makefile |2 +
net/dccp/probe.c | 198 +
ROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
Documentation/networking/dccp.txt |8 +---
include/linux/dccp.h |6 +-
net/dccp/ipv4.c |3 ---
net/dccp/proto.c | 11 +--
4 files chan
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.git
Best Regards,
- Arnaldo
Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
include/linux/dccp.h |8 +
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.git
Best Regards,
- Arnaldo
With constants for CCID numbers this now uses them in some places.
Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo &
On 9/29/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
> Coverity found what looks like a real leak in
net/dccp/ipv6.c::dccp_v6_do_rcv()
| otoh, it seems to me that opt_skb doesn't actually do anything and can be
| removed?
This is right, there is no code referencing opt_skb: compare with
net
mitter Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> 1161379450 -0300
[DCCP]: Fix Oops in DCCPv6
I think I got the cause for the Oops observed in
http://www.mail-archive.com/dccp@vger.kernel.org/msg00578.html
The problem is always with applications listening on PF_INET6 sockets. Apart
from t
On 10/23/06, Ian McDonald <[EMAIL PROTECTED]> wrote:
On 9/23/06, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote:
> On 9/14/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
> > Sorry kmail garbled this, clean text below.
> >
> > - Gerrit
>
> Applied,
On 10/23/06, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote:
On 10/23/06, Ian McDonald <[EMAIL PROTECTED]> wrote:
> On 9/23/06, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote:
> > On 9/14/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
> > >
On 10/24/06, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote:
On 10/23/06, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote:
> On 10/23/06, Ian McDonald <[EMAIL PROTECTED]> wrote:
> > On 9/23/06, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote:
> &
On 10/24/06, David Miller <[EMAIL PROTECTED]> wrote:
From: "Arnaldo Carvalho de Melo" <[EMAIL PROTECTED]>
Date: Mon, 23 Oct 2006 23:57:42 -0300
> Not an oversight, its just that this one is not a plain code bugfix so
> I deferred it for later, if Dave thinks
On 10/24/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
It seems that I am not the only one having headaches about which patches
are applied and which not. I spent a major part yesterday trying to get
the set of patches consistent with regard to Dave's/Arnaldo's latest tree.
What I have been doing
On 10/24/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
As promised earlier, this is the set of patches which I have been
keeping up-to-date; they divide into:
* patches sent to this list that have not been merged
[I claim that this is exhaustive, i.e. all other patches
On Tue, Oct 24, 2006 at 04:18:24PM -0700, David Miller wrote:
> From: "Arnaldo Carvalho de Melo" <[EMAIL PROTECTED]>
> Date: Tue, 24 Oct 2006 00:18:33 -0300
>
> > David, please consider applying,
>
> What the heck, it's purely doc/comment fixes,
On 11/9/06, Ian McDonald <[EMAIL PROTECTED]> wrote:
> Although this is a relatively minor bug, I believe it would be better to
stick by the DCCP rule
> that `each outgoing packet has its sequence number incremented' and will send
a patch.
>
> Ian, I will remove this ToDo from the list, ok?
>
>
Gerrit,
I'm going over the_whole_lot patch queue from you, many thanks
for doing this work! About 07a_putative_nested_lock_in_rcv.diff, I
haven't studied the bh_lock_sock_nested, lockdep stuff, but can't we
just use bh_lock_sock_nested in sk_receive_skb?
I'm postponing this one for
On 11/10/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
Arnaldo Carvalho de Melo wrote:
| Gerrit,
|
| I'm going over the_whole_lot patch queue from you, many thanks
| for doing this work! About 07a_putative_nested_lock_in_rcv.diff, I
| haven't studied the bh_lock_sock
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git
This is the first stab at merging the patch queue maintained
by Gerrit while I was busy, thanks Gerrit! I'll go over the other
patches RSN.
- Arnaldo
-
To unsubscribe from thi
This is a re-send from
http://www.mail-archive.com/dccp@vger.kernel.org/msg00553.html
It is the same patch as before, but I have built in Arnaldo's suggestions
pointed out in that posting.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[E
<[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
--
ipv6.c |8 ++--
1 file changed, 6 insertions(+),
er <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
--
include/linux/dccp.h |7 +++
net/dccp/ipv4.c |9 ++---
net/dccp/ipv6.c |8 ++--
net/d
simplify code somewhat.
Commiter note: fixed up a compile problem, trivial.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
--
i
Gerrit Renker noticed dccp_tw_deschedule and submitted a patch with a FIXME,
but as he suggests in the same patch the best thing is to just ditch this
declaration, while doing that also noticed that tcp_tw_count is as well not
defined anywhere, so ditch it too.
Signed-off-by: Arnaldo Carvalho de
h the particular objective of
having all request_sock_ops close(r) together for more clarity.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
-
AIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
--
ipv6.c | 385 -
1 file changed, 190 insertions(+), 1
dump the stack.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
--
dccp.h |2 ++
ipv4.c | 48 +--
Fixes a typo in Kconfig, patch is by Ian McDonald and is re-sent from
http://www.mail-archive.com/dccp@vger.kernel.org/msg00579.html
Signed-off-by: Ian McDonald <[EMAIL PROTECTED]>
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
--
dccp.h |2 ++
output.c |8 +---
2 files changed, 7 insertio
On 11/10/06, James Morris <[EMAIL PROTECTED]> wrote:
The dccp ipv4 & ipv6 modules cannot be unloaded, as their control sockets
each maintain a couple of module references. So, it seems like a good
idea to just remove the module exit functions completely.
Please review.
Well, I have a patch in
On 11/10/06, James Morris <[EMAIL PROTECTED]> wrote:
On Fri, 10 Nov 2006, James Morris wrote:
> I wonder if this facility can be integrated more generally into the kernel
> protocol which people are developing.
Ugh, editor screwup. That was meant to be
I wonder if this facility can be integra
On Fri, Nov 10, 2006 at 02:22:54PM -0800, David Miller wrote:
> From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
> Date: Fri, 10 Nov 2006 13:25:41 -0200
>
> > Please consider pulling from:
> >
> > master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6
Hi David,
Please consider pulling these extra csets, available at:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git
Regards,
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at h
renaming dccp_openreq_init to
dccp_reqsk_init to get rid of some baggage from the past, when struct
request_sock was called openreq and uninlined it, idea is not to call anything
prefixed foo_v4_ in foo_v6 code.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <
Sorts out the comments for processing steps 2,3 in section 8.5 of RFC 4340.
All comments have been updated against this document, and the reference to step
2 has been made consistent throughout the files.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho d
tem:
* If P.CsCov is too large for the packet size, drop packet and return.
The code has been tested with applications, the latest version of tcpdump now
comes with support for partial DCCP checksums.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Mel
On Fri, Nov 10, 2006 at 02:52:22PM -0800, David Miller wrote:
> From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
> Date: Fri, 10 Nov 2006 20:44:54 -0200
>
> > Please consider pulling these extra csets, available at:
> >
> > master.kernel.org:/pub/scm/lin
On 11/11/06, James Morris <[EMAIL PROTECTED]> wrote:
Btw, I couldn't find anything to test DCCPv6 with (GNU netcat somehow
lacks IPv6 support), so wrote some simple apps to do this:
http://namei.org/misc/dccp/
Thanks for the new test apps, you can find some more here:
http://linux-net.osdl.or
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git
Best Regards,
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/
(sec. 8.3)
* Closein node-CLOSING state (sec. 8.3)
I had meant to put in a check for these types too, but have left that
for later.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL
nding further Responses in
reply to retransmitted (i.e., non-initial) Requests.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
--
minisocks.c |
order?
I have made them consistent among calls but they seem to be in the
reverse order.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
--
fault' has been dropped, since it is obvious from use.
Also removed a duplicate `dccp_feat_default_sequence_window' in ipv4.c.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho
L PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
--
ipv4.c |9 ++---
ipv6.c | 28
output.c |6 +-
3 files changed, 2
of all existing DCCP sysctls.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
--
Documentation/networking/dcc
This removes 3 forward declarations by reordering 2 functions.
No code change at all.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
--
ti
On 11/13/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
This is one medium-sized patch (20k),
split into 7 piecemeal chunks.
Great work, thank you!
I have uploaded these as series `11' (1..7 map to a..f) onto
http://www.erg.abdn.ac.uk/users/gerrit/dccp/patch-backlog/
All applied and pushed to
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git
Regards,
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/major
already existing macro net_xmit_errno, saving on duplicated code.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
--
include/linux/netdev
CONFIG_IP_DCCP_DEBUG is
selected, leaving this to another cset tho. Also
shortened dccp_feat_negotiation_debug to dccp_feat_debug.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL
ff-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
--
Makefile |8
1 file chang
check #1. Therefore, when check #2 is
performed, no new work will be done. This is now "detected" and there is no
performance hit when doing #2.
Signed-off-by: Andrea Bittau <[EMAIL PROTECTED]>
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Ca
acket validation)
* removing duplicate statements
* combining declaration & initialisation
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
--
On 11/15/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
This patch tackles the following problem:
* the ccid3_hc_{t,r}x_sock define ccid3hc{t,r}x_state as `u8', but
in reality there can only be a few, pre-defined enum names
* this necessitates addiditional checking for une
On 11/15/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
While working on the promised EWMA patch for CCID 3 packet sizes, I stumbled
over two things
and can make no sense of a bit of CCID 3 Receive code:
1) ccid3_hc_rx_sock maintains a real-timer RTT counter ccid3hcrx_rtt
which
On 11/15/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
| Anyway, there are always tradeoffs, compiler gets more info, but we
| end up using more memory per socket instance, I guess we can stay like
| we are now, no? :-)
That is why I sent it as RFC in the first place: it is not broken but would
On 11/15/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
Hi Arnaldo
| Well, I'd rather prefer a WARN_ON type, probably rate limiting the
| printks, so that we can receive reports that something is fishy but
| don't panic the machine.
I have implemented such a macro and have changed the patch to
On 11/15/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
Hi Arnaldo,
thank you for the link @-)
| > The following is the revised patch with three macros added, I liked the
| > DCCP_BUG_ON():
|
| will look into that barring social life that is taking me so much time
| that I should be working o
be a few, pre-defined enum names
* this necessitates addiditional checking for unexpected values
which would otherwise be caught by the compiler
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/cci
On 9/22/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
Quoting Eddie Kohler:
| > Why burden the application programmer to handcode an estimation of the
average each
| > time? I can not see a justification for this, certainly not for CCIDs which
| > are intended to be used with (on average) fixe
On 11/16/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
Quoting Arnaldo Carvalho de Melo:
| On 9/22/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
| > Quoting Eddie Kohler:
| > | > Why burden the application programmer to handcode an estimation of
the average each
| >
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git
Best Regards,
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/
wrapping.
Signed-off-by: Andrea Bittau <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/ccids/ccid2.c | 22 --
net/dccp/ccids/ccid2.h |1 +
2 files changed, 21 insertions(+), 2 deletions(-)
diff --git a/net/dccp/cci
Spotted by Eric Dumazet in tcp_v4_rcv().
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/ipv4.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c
index 6bca719..a20eb71 100644
--- a/net/dccp/ipv4.c
+++ b/ne
Spotted by Ian McDonald, tentatively fixed by Gerrit Renker:
http://www.mail-archive.com/dccp%40vger.kernel.org/msg00599.html
Rewritten not to unroll sk_receive_skb, in the common case, i.e. no lock
debugging, its optimized away.
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTEC
On 11/16/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
Hi Arnaldo,
| Thanks, applied.
many thanks for applying this; it was sooner as expected and I think it would
be good to tidy this up and make it consistent throughout the code. Since I
initiated this,
I feel a bit obliged to improve this.
On 11/13/06, David Miller <[EMAIL PROTECTED]> wrote:
From: "Arnaldo Carvalho de Melo" <[EMAIL PROTECTED]>
Date: Fri, 10 Nov 2006 16:32:16 -0200
> On 11/10/06, James Morris <[EMAIL PROTECTED]> wrote:
> > On Fri, 10 Nov 2006, James Morris wrote:
>
On Fri, Nov 17, 2006 at 03:56:50PM +, Gerrit Renker wrote:
> This includes mostly Ian's tx_qlen patch, the promised tidy-up of the WARN/BUG
> message scheme, and some trivial things.
>
>
> Patch 1: This is Ian's tx_qlen updated tx_qlen patch.
> I have removed the #define again (and w
Hi David,
Please consider pulling from:
master.kernel.org:/pub/scm/linux/kernel/git/acme/net-2.6.20.git
This is a patch Andrea sent me long ago and that I finally
managed to review, splitting it into smaller bits and simplifying it in
the process.
Best Regards,
- Arnaldo
-
To u
Commiter note: original patch was splitted.
Signed-off-by: Andrea Bittau <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/ackvec.c |1 -
net/dccp/ackvec.h |2 --
2 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/net/dcc
per packet,
using, initially, up to a max of 2 ackvecs as per Andrea's original patch, then
I'll work on support for larger ackvecs, be it using a sysctl or using
setsockopt.
Signed-off-by: Andrea Bittau <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTE
<[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/ackvec.c | 46 --
1 files changed, 32 insertions(+), 14 deletions(-)
diff --git a/net/dccp/ackvec.c b/net/dccp/ackvec.c
index 41d34d1..bdf1bb7 1006
Now that we can stuff bigger ack vectors into options.
Signed-off-by: Andrea Bittau <[EMAIL PROTECTED]>
Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
---
net/dccp/ccids/ccid2.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/dccp/ccids/c
On 11/22/06, Ian McDonald <[EMAIL PROTECTED]> wrote:
> However, I think your point is valid and we should add a ToDo for that
section
> of code which re-adjusts the sending rate after the first feedback packet
has arrived.
>
Thanks for checking this and I agree with your conclusions.
Can
On 11/26/06, Ian McDonald <[EMAIL PROTECTED]> wrote:
On 11/26/06, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote:
> On 11/22/06, Ian McDonald <[EMAIL PROTECTED]> wrote:
> > > However, I think your point is valid and we should add a ToDo for that
section
&g
On 11/21/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
[CCID 3]: Simplify control flow in the calculation of t_ipi
This patch performs a simplifying (performance) optimisation:
In each call of the inline function ccid3_calc_new_t_ipi(), the state is
tested against TFRC_SSTATE_NO_FBACK. This i
On 11/21/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
[CCID 3]: Fix calculation of t_ipi time of scheduled transmission
Problem:
Currently packet transmissions are not scheduled according to [RFC 3448, 4.6]
and
will, in the worst case, be sent later than necessary. If scheduled
tran
On 11/26/06, Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> wrote:
On 11/21/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
> [CCID 3]: Simplify control flow in the calculation of t_ipi
>
>
> This patch performs a simplifying (performance) optimisation:
>
> In ea
On 11/21/06, Ian McDonald <[EMAIL PROTECTED]> wrote:
On 11/22/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
> [CCID 3]: Simplify control flow of ccid3_hc_tx_send_packet
>
> This makes some logically equivalent simplifications, by replacing
> rc - values plus goto's with direct return statements.
>
On 11/23/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
@@ -1022,6 +1047,9 @@ static void ccid3_hc_rx_packet_recv(stru
if (DCCP_SKB_CB(skb)->dccpd_type == DCCP_PKT_ACK)
return;
+ payload_size = skb->len - dccp_hdr(skb)->dccph_doff * 4;
Should't we use (skb->len - d
On 11/24/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
[CCID 3]: Avoid congestion control on zero-sized data packets
This resolves an `XXX' in ccid3_hc_tx_send_packet().
The function is only called on Data and DataAck packets and
returns a negative result on zero-sized messages. This is a reason
On 11/24/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
[CCID 3]: Remove redundant statements in ccid3_hc_tx_packet_sent
Thanks, looks good, applied.
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On 11/24/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
[CCID 3]: Resolve small FIXME
This considers the case - ACK received while no packet has been sent
so far. Resolved by printing a (rate-limited) warning message.
Further removes an unnecessary BUG_ON in ccid3_hc_tx_packet_recv,
received fee
On 11/24/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
[CCID 3]: Consolidate timer resets
The specification in [RFC 3448, 4.4, step (3)] is impossible to
implement: when no feedback has been received, the value of RTT
is undefined as per [RFC 3448, 4.2]. Hence we can not set the
timeout value to
On 11/24/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
[CCID 3] Consistently update t_nom, t_ipi, t_delta
This patch
* consolidates updating of parameters (t_nom, t_ipi, t_delta) which
need to be updated at the same time, since they are inter-dependent
* removes two inline functions which
On 11/24/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
[CCID 3] Consolidate handling of t_RTO
This patch
* removes setting t_RTO in ccid3_hc_tx_init (per [RFC 3448, 4.2], t_RTO is
undefined until feedback has been received);
* makes some trivial changes (updates of comments);
* performs a
On 11/24/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
[NET]: Add documentation for TFRC structures
This adds documentation for the TFRC structure fields.
Signed-off-by: Gerrit Renker <[EMAIL PROTECTED]>
Thanks, applied.
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe dc
On 11/24/06, Gerrit Renker <[EMAIL PROTECTED]> wrote:
[DCCP]: Simplify dccp_rcv_state_process
This patch does not change the algorithm, it just simplifies control flow a bit.
The main changes are:
* cleanup after dccp_rcv_request_sent_state_process is now done within that
function,
not in
1 - 100 of 719 matches
Mail list logo
