Re: [deal.II] Doubt in collect_periodic_faces() documentation

2021-03-31 Thread Wolfgang Bangerth
Thank you for the links. I noticed that the documentation of collect_periodic_faces()

Re: [deal.II] Doubt in collect_periodic_faces() documentation

2021-03-31 Thread vachanpo...@gmail.com
Dr. Wolfgang and Dr. Jean-Paul, Thank you for the links. I noticed that the documentation of collect_periodic_faces() has already been fixed. I have created pr11990

Re: [deal.II] Doubt in collect_periodic_faces() documentation

2021-03-30 Thread Jean-Paul Pelteret
Hi Vachan, To supplement the link that Wolfgang shared, there’s also a detailed step-by-step guide for contributing patches to the library that can be found on our Wiki page: https://github.com/dealii/dealii/wiki/Contributing Looking

Re: [deal.II] Doubt in collect_periodic_faces() documentation

2021-03-30 Thread Wolfgang Bangerth
On 3/30/21 11:20 AM, vachanpo...@gmail.com wrote: I would like to. However, I do not know how to write patches. Nor have I any experience with using github collaboratively; I have only used it for my personal repos. I would love to contribute if the experts can provide a little guidance. I

Re: [deal.II] Doubt in collect_periodic_faces() documentation

2021-03-30 Thread vachanpo...@gmail.com
Prof. Bangerth I would like to. However, I do not know how to write patches. Nor have I any experience with using github collaboratively; I have only used it for my personal repos. I would love to contribute if the experts can provide a little guidance. I have also noticed a small mistake in

Re: [deal.II] Doubt in collect_periodic_faces() documentation

2021-03-29 Thread Wolfgang Bangerth
On 3/29/21 6:04 PM, Daniel Arndt wrote: "dimension" actually doesn't appear in the function signature at all so it seems reasonable to just replace it with "direction" in its documentation. Vachan, I think you now understand what the documentation *wants* to say. Would you like to write a

Re: [deal.II] Doubt in collect_periodic_faces() documentation

2021-03-29 Thread Daniel Arndt
Vachan, "dimension" actually doesn't appear in the function signature at all so it seems reasonable to just replace it with "direction" in its documentation. Best, Daniel Am Sa., 27. März 2021 um 00:00 Uhr schrieb vachanpo...@gmail.com < vachanpotluri1...@gmail.com>: > Dr. Arndt, > > Thank you

Re: [deal.II] Doubt in collect_periodic_faces() documentation

2021-03-26 Thread vachanpo...@gmail.com
Dr. Arndt, Thank you for the clarification. But then isn't dimension redundant here? If I understand correctly, using direction would also give the same face indices. How are direction and dimension different here? On Friday, March 26, 2021 at 6:54:20 PM UTC+5:30 d.arnd...@gmail.com wrote: >

Re: [deal.II] Doubt in collect_periodic_faces() documentation

2021-03-26 Thread Daniel Arndt
Vachan, `dimension` is understood in the sense of dimension in which to apply periodicity: x-direction (0) means identifying faces with id 0 and 1, y-direction (1) means identifying faces with id 2 and 3, z-direction (2) means identifying faces with id 4 and 5, Best, Daniel Am Fr., 26. März

[deal.II] Doubt in collect_periodic_faces() documentation

2021-03-26 Thread vachanpo...@gmail.com
Hi all, The documentation of collect_periodic_faces() reads Instead of defining a 'first' and 'second' boundary with the help of two boundary_ids this function defines a 'left' boundary