Re: Really enable -fstack-clash-protection on armhf/armel?

2024-02-14 Thread Emanuele Rocca
Hi, On 2023-11-25 12:37, Wookey wrote: > For debian we'll keep an eye on it, do a belated rebuild to see how > much of a problem we really have, and then decide if we should revert > it too until some stuff if fixed. I now finally have some data to share. In total, out of the whole Debian

Re: Really enable -fstack-clash-protection on armhf/armel?

2024-01-08 Thread Julian Andres Klode
On Thu, Nov 23, 2023 at 10:45:33AM +0100, Matthias Klose wrote: > Hi, > > it looks like enabling this flag on armel/armhf is a little bit premature. > > Apparently it's not completely supported upstream, and might cause > regressions, according to >

Re: Really enable -fstack-clash-protection on armhf/armel?

2023-12-03 Thread Mate Kukri
I believe the most obvious issues we were having was the gsasl tests indirectly triggered by gnutls28 the unrar-free tests triggered by libarchive. Both of which do include valgrind use. In addition to flag being obviously incompatible with valgrind, it also caused issues with gdb for me,

Re: Really enable -fstack-clash-protection on armhf/armel?

2023-12-03 Thread Mate Kukri
Hello, Another Canonicaler chiming in, I was also involved with debugging this problem in Ubuntu. I believe the most obvious issues we were having was the gsasl tests indirectly triggered by gnutls28, and the unrar-free tests triggered by libarchive. Both of which do include valgrind use.

Re: Really enable -fstack-clash-protection on armhf/armel?

2023-11-30 Thread Emanuele Rocca
Hi, On 2023-11-24 10:50, Matthias Klose wrote: > A major problem will be valgrind stopping to work, causing issues in the > test suites of other packages. > > Also after rebuilding libxml2, libarchive, gnutls28, libselinux without this > flag on armhf, issues go away again. FTR there is no

Re: Really enable -fstack-clash-protection on armhf/armel?

2023-11-29 Thread Emanuele Rocca
Hi Matthias, On 2023-11-24 10:50, Matthias Klose wrote: > On 24.11.23 07:19, Emanuele Rocca wrote: > > In case there are any bugs, which is of course possible, please file > > them and add debian-arm@ to X-Debbugs-CC. > > No, I will not do that. Sorry, but the task of the porters it NOT to put

Re: Really enable -fstack-clash-protection on armhf/armel?

2023-11-27 Thread Moritz Muehlenhoff
On Fri, Nov 24, 2023 at 01:34:21AM +0100, Guillem Jover wrote: > > Is that a feature that the Debian ARM32 porters and the security team really > > want to support actively, despite the missing upstream support? > > According to https://bugs.debian.org/918914#73 there were no pending > toolchain

Re: Really enable -fstack-clash-protection on armhf/armel?

2023-11-24 Thread Wookey
On 2023-11-24 01:34 +0100, Guillem Jover wrote: > On Thu, 2023-11-23 at 10:45:33 +0100, Matthias Klose wrote: > > it looks like enabling this flag on armel/armhf is a little bit premature. > > In Ubuntu, people tracked down segfaults due to this change in at least > > valgrind and gnutls, maybe

Re: Really enable -fstack-clash-protection on armhf/armel?

2023-11-24 Thread Adrien Nader
Hi, Short introduction: I work at Canonical in the Foundations team and made changes in gnutls which is one of the packages that first encountered/caused issues which then started blocking various migrations and changes. On Fri, Nov 24, 2023, Matthias Klose wrote: > On 24.11.23 07:19, Emanuele

Re: Really enable -fstack-clash-protection on armhf/armel?

2023-11-24 Thread Florian Weimer
* Emanuele Rocca: > Hello! > > On 2023-11-24 01:34, Guillem Jover wrote: >> According to https://bugs.debian.org/918914#73 there were no pending >> toolchain issues related to this. > > That is correct. The GCC maintainers at Arm confirm that > stack-clash-protection is supported on 32 bit too.

Re: Really enable -fstack-clash-protection on armhf/armel?

2023-11-24 Thread Matthias Klose
On 24.11.23 07:19, Emanuele Rocca wrote: Hello! On 2023-11-24 01:34, Guillem Jover wrote: According to https://bugs.debian.org/918914#73 there were no pending toolchain issues related to this. That is correct. The GCC maintainers at Arm confirm that stack-clash-protection is supported on 32

Re: Really enable -fstack-clash-protection on armhf/armel?

2023-11-23 Thread Emanuele Rocca
Hello! On 2023-11-24 01:34, Guillem Jover wrote: > According to https://bugs.debian.org/918914#73 there were no pending > toolchain issues related to this. That is correct. The GCC maintainers at Arm confirm that stack-clash-protection is supported on 32 bit too. In case there are any bugs,

Re: Really enable -fstack-clash-protection on armhf/armel?

2023-11-23 Thread Guillem Jover
Hi! On Thu, 2023-11-23 at 10:45:33 +0100, Matthias Klose wrote: > it looks like enabling this flag on armel/armhf is a little bit premature. > > Apparently it's not completely supported upstream, and might cause > regressions, according to > https://bugzilla.redhat.com/show_bug.cgi?id=1522678 I

Really enable -fstack-clash-protection on armhf/armel?

2023-11-23 Thread Matthias Klose
Hi, it looks like enabling this flag on armel/armhf is a little bit premature. Apparently it's not completely supported upstream, and might cause regressions, according to https://bugzilla.redhat.com/show_bug.cgi?id=1522678 Is that a feature that the Debian ARM32 porters and the security

Re: Bug#1054583: dpkg-dev: really enable -fstack-clash-protection on armhf/armel

2023-10-28 Thread Wookey
On 2023-10-27 14:29 +0100, Steve McIntyre wrote: > > Are either of those ports (armeb/arm64ilp32) actually useful / alive > at this point? No, but if someone did try to build a package for those it would be incorrect for dpkg to enable these flags. The chances of anyone actually doing that are

Re: Bug#1054583: dpkg-dev: really enable -fstack-clash-protection on armhf/armel

2023-10-27 Thread Lennart Sorensen
On Fri, Oct 27, 2023 at 02:29:30PM +0100, Steve McIntyre wrote: > Are either of those ports (armeb/arm64ilp32) actually useful / alive > at this point? Not that I have seen. I didn't think anything other than the IXP ever really used big endian and that's a long time ago. arm64ilp32 seems to

Re: Bug#1054583: dpkg-dev: really enable -fstack-clash-protection on armhf/armel

2023-10-27 Thread Steve McIntyre
On Fri, Oct 27, 2023 at 03:23:10PM +0200, Emanuele Rocca wrote: >Hi Guillem, > >On 2023-10-27 04:33, Guillem Jover wrote: >> Checking now again, I realize Wookey mentioned enabling this for the 3 >> arm arches (those would be arm64, armhf and armel), so the patch I >> provided would match that.

Re: Bug#1054583: dpkg-dev: really enable -fstack-clash-protection on armhf/armel

2023-10-27 Thread Emanuele Rocca
Hi Guillem, On 2023-10-27 04:33, Guillem Jover wrote: > Checking now again, I realize Wookey mentioned enabling this for the 3 > arm arches (those would be arm64, armhf and armel), so the patch I > provided would match that. But I was wondering now what about armeb and > arm64ilp32? I mean, I

Re: Bug#1054583: dpkg-dev: really enable -fstack-clash-protection on armhf/armel

2023-10-26 Thread Guillem Jover
Hi! On Thu, 2023-10-26 at 12:55:32 +0200, Guillem Jover wrote: > On Thu, 2023-10-26 at 11:40:53 +0200, Emanuele Rocca wrote: > > Package: dpkg-dev > > Version: 1.22.0 > > Severity: normal > > -fstack-clash-protection is supposed to be enabled by default on amd64, > > arm64, armhf, and armel