Processed: Re: Bug#1036321: rootskel-gtk: Include metadata about the banner

[Debian Bug Tracking System]

Processing control commands:

> tag -1 patch pending
Bug #1036321 [rootskel-gtk] rootskel-gtk: Include metadata about the banner
Added tag(s) patch and pending.

-- 
1036321: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1036321
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems

Bug#1036321: rootskel-gtk: Include metadata about the banner

[Cyril Brulebois]

Control: tag -1 patch pending

Hi,

Cyril Brulebois  (2023-05-19):
> Maybe something like logo_debian.properties (or whatever name) with:
> 
> labelPosition=right
> bannerExpands=right

I settled for a logo_installer.ini (logo_debian.ini for us, plus a
symlink via the Makefile, as it is done for the logo files themselves):

[banner]
# supported values: left, right
label-position = right
# supported values: left, right, both
expand-direction = both

See: https://salsa.debian.org/installer-team/rootskel-gtk/-/commit/306e00e96b

I'm not entirely the current expand-direction is the best for Bookworm:
 - Setting it to “right” would accentuate the strange rendering on the
   right (since repeating the last 1-px column hadn't been anticipated).
 - Setting it to “both” pushes “debian 12” towards the center without
   really centering it, so it could be considered less appealing than
   keeping in on the left.

> and having cdebconf-gtk deal with default settings (e.g. right for
> both). I'm not yet sure about whether it would make sense to support
> bannerExpands=both (probably doesn't cost much more, but would that
> look OK?).

cdebconf-gtk now defaults to right and both (respectively). This is
totally arbitrary, and as noted in the changelog: the theme should
provide an up-to-date metadata file so that we never have to touch
cdebconf's code (or default banner settings) again.

> I'm tempted to try and get that squeezed in finally (#745359 was
> almost 10 years ago, and the scaling trick was better than nothing,
> but clearly not ideal); we can always refine the format later on.

I'd call that mergeable at it is. I've pushed the cdebconf side directly
to master. Since rootskel-gtk's master branch contains old changes that
have never been uploaded to the archive, and since I don't feel like
taking responsibility for them at this stage, I've forked a bookworm
branch from the last tag, and plan on uploading to unstable from it.

Aurélien, please work within that branch if you have a chance to look
into #1036315 and #1036317. Feel free to tweak logo_installer.ini, I'm
happy to let you pick whatever you feel is best!


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Bug#1036321: rootskel-gtk: Include metadata about the banner

[Cyril Brulebois]

Package: rootskel-gtk
Version: 12.0.1
Severity: normal

Hi,

Until now, we've always been favoring one side of the banner, and that's
been encoded in cdebconf-gtk: starting the installer in “Rescue” will
result in a (translated) label being printed on top of the banner,
either on the left or on the right. That's currently hardcoded in
cdebconf-gtk and that needs to be adjusted depending on where the Debian
name, logo, version number etc. end up for a given banner.

It would probably make sense to have a small metadata file that could be
picked up by cdebconf-gtk.

Maybe something like logo_debian.properties (or whatever name) with:

labelPosition=right
bannerExpands=right

and having cdebconf-gtk deal with default settings (e.g. right for
both). I'm not yet sure about whether it would make sense to support
bannerExpands=both (probably doesn't cost much more, but would that look
OK?).

I'm tempted to try and get that squeezed in finally (#745359 was almost
10 years ago, and the scaling trick was better than nothing, but clearly
not ideal); we can always refine the format later on.


Cheers,
-- 
Cyril Brulebois (k...@debian.org)
D-I release manager -- Release team member -- Freelance Consultant