Bug#823133: marked as done (subversion FTBFS on Alpha: misaligned strings in the test suite)

2018-04-18 Thread Debian Bug Tracking System 
Your message dated Wed, 18 Apr 2018 16:51:37 +
with message-id 
and subject line Bug#823133: fixed in subversion 1.10.0-1
has caused the Debian Bug report #823133,
regarding subversion FTBFS on Alpha: misaligned strings in the test suite
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
823133: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823133
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: subversion
Version: 1.9.4-1
Severity: important
Justification: fails to build from source (but built in the past)
Tags: patch
User: debian-al...@lists.debian.org
Usertags: alpha

subversion FTBFS on Alpha due to a test suite failure [1]:

START: utf-test
PASS:  lt-utf-test 1: test is_valid/last_valid
PASS:  lt-utf-test 2: test last_valid/last_valid2
PASS:  lt-utf-test 3: test svn_utf_cstring_to_utf8_ex2
PASS:  lt-utf-test 4: test svn_utf_cstring_from_utf8_ex2
PASS:  lt-utf-test 5: test svn_utf__normcmp
PASS:  lt-utf-test 6: test svn_utf__glob
PASS:  lt-utf-test 7: test svn_utf__fuzzy_escape
PASS:  lt-utf-test 8: test svn_utf__is_normalized
svn_tests: E235000: In file 
'/«PKGBUILDDIR»/subversion/tests/libsvn_subr/utf-test.c' line 807: assertion 
failed (0 == strcmp(result->data, tc->result))
FAIL:  lt-utf-test 9: test svn_utf__utf{16,32}_to_utf8
END: utf-test
ELAPSED: utf-test 0:00:00.603655

This failure occurs because the test suite allocates char aligned
strings in function test_utf_conversions() of file
subversion/tests/libsvn_subr/utf-test.c and passes those strings
to functions svn_utf__utf16_to_utf8() and svn_utf__utf32_to_utf8()
which are defined (in file subversion/libsvn_subr/utf.c) to take
apr_uint32_t * and apr_uint16_t * args respectively.  On
architectures with strict alignment requirements this is undefined
behaviour.  On Alpha, gcc likes to add bugs..., I mean, _optimise_
code, when the args are declared to be aligned by using a particular
CPU load instruction that neither traps nor gives correct results
if the args are not actually aligned.

I attach a patch that aligns the test strings in utf-test.c to be
aligned to apr_uint32_t (i.e. 32-bit alignment).  With that patch
subversion builds successfully to completion on Alpha.

Cheers
Michael.

[1] 
https://buildd.debian.org/status/fetch.php?pkg=subversion=alpha=1.9.4-1=1461928473
Index: subversion-1.9.4/subversion/tests/libsvn_subr/utf-test.c
===
--- subversion-1.9.4.orig/subversion/tests/libsvn_subr/utf-test.c   
2016-05-01 21:05:58.763536825 +1200
+++ subversion-1.9.4/subversion/tests/libsvn_subr/utf-test.c2016-05-01 
21:05:58.755722518 +1200
@@ -745,7 +745,7 @@
   {
 svn_boolean_t sixteenbit;
 svn_boolean_t bigendian;
-const char *source;
+const _Alignas(apr_int32_t) char *source;
 const char *result;
   } tests[] = {
 
--- End Message ---
--- Begin Message ---
Source: subversion
Source-Version: 1.10.0-1

We believe that the bug you reported is fixed in the latest version of
subversion, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 823...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
James McCoy  (supplier of updated subversion package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Format: 1.8
Date: Wed, 18 Apr 2018 12:29:55 -0400
Source: subversion
Binary: subversion libsvn1 libsvn-dev libsvn-doc libapache2-mod-svn 
python-subversion subversion-tools libsvn-java libsvn-perl ruby-svn
Architecture: source
Version: 1.10.0-1
Distribution: unstable
Urgency: medium
Maintainer: James McCoy 
Changed-By: James McCoy 
Description:
 libapache2-mod-svn - Apache Subversion server modules for Apache httpd
 libsvn-dev - Development files for Apache Subversion libraries
 libsvn-doc - Developer documentation for libsvn
 libsvn-java - Java bindings for Apache Subversion
 libsvn-perl - Perl bindings for Apache Subversion
 libsvn1- Shared libraries used by Apache Subversion
 python-subversion - Python bindings for Apache Subversion
 ruby-svn   - Ruby bindings for

Bug#823133: marked as done (subversion FTBFS on Alpha: misaligned strings in the test suite)

2018-04-07 Thread Debian Bug Tracking System 
Your message dated Sat, 07 Apr 2018 15:26:08 +
with message-id 
and subject line Bug#823133: fixed in subversion 1.10.0~rc2-1
has caused the Debian Bug report #823133,
regarding subversion FTBFS on Alpha: misaligned strings in the test suite
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
823133: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=823133
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: subversion
Version: 1.9.4-1
Severity: important
Justification: fails to build from source (but built in the past)
Tags: patch
User: debian-al...@lists.debian.org
Usertags: alpha

subversion FTBFS on Alpha due to a test suite failure [1]:

START: utf-test
PASS:  lt-utf-test 1: test is_valid/last_valid
PASS:  lt-utf-test 2: test last_valid/last_valid2
PASS:  lt-utf-test 3: test svn_utf_cstring_to_utf8_ex2
PASS:  lt-utf-test 4: test svn_utf_cstring_from_utf8_ex2
PASS:  lt-utf-test 5: test svn_utf__normcmp
PASS:  lt-utf-test 6: test svn_utf__glob
PASS:  lt-utf-test 7: test svn_utf__fuzzy_escape
PASS:  lt-utf-test 8: test svn_utf__is_normalized
svn_tests: E235000: In file 
'/«PKGBUILDDIR»/subversion/tests/libsvn_subr/utf-test.c' line 807: assertion 
failed (0 == strcmp(result->data, tc->result))
FAIL:  lt-utf-test 9: test svn_utf__utf{16,32}_to_utf8
END: utf-test
ELAPSED: utf-test 0:00:00.603655

This failure occurs because the test suite allocates char aligned
strings in function test_utf_conversions() of file
subversion/tests/libsvn_subr/utf-test.c and passes those strings
to functions svn_utf__utf16_to_utf8() and svn_utf__utf32_to_utf8()
which are defined (in file subversion/libsvn_subr/utf.c) to take
apr_uint32_t * and apr_uint16_t * args respectively.  On
architectures with strict alignment requirements this is undefined
behaviour.  On Alpha, gcc likes to add bugs..., I mean, _optimise_
code, when the args are declared to be aligned by using a particular
CPU load instruction that neither traps nor gives correct results
if the args are not actually aligned.

I attach a patch that aligns the test strings in utf-test.c to be
aligned to apr_uint32_t (i.e. 32-bit alignment).  With that patch
subversion builds successfully to completion on Alpha.

Cheers
Michael.

[1] 
https://buildd.debian.org/status/fetch.php?pkg=subversion=alpha=1.9.4-1=1461928473
Index: subversion-1.9.4/subversion/tests/libsvn_subr/utf-test.c
===
--- subversion-1.9.4.orig/subversion/tests/libsvn_subr/utf-test.c   
2016-05-01 21:05:58.763536825 +1200
+++ subversion-1.9.4/subversion/tests/libsvn_subr/utf-test.c2016-05-01 
21:05:58.755722518 +1200
@@ -745,7 +745,7 @@
   {
 svn_boolean_t sixteenbit;
 svn_boolean_t bigendian;
-const char *source;
+const _Alignas(apr_int32_t) char *source;
 const char *result;
   } tests[] = {
 
--- End Message ---
--- Begin Message ---
Source: subversion
Source-Version: 1.10.0~rc2-1

We believe that the bug you reported is fixed in the latest version of
subversion, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 823...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
James McCoy  (supplier of updated subversion package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Format: 1.8
Date: Sat, 07 Apr 2018 11:09:43 -0400
Source: subversion
Binary: subversion libsvn1 libsvn-dev libsvn-doc libapache2-mod-svn 
python-subversion subversion-tools libsvn-java libsvn-perl ruby-svn
Architecture: source
Version: 1.10.0~rc2-1
Distribution: experimental
Urgency: medium
Maintainer: James McCoy 
Changed-By: James McCoy 
Description:
 libapache2-mod-svn - Apache Subversion server modules for Apache httpd
 libsvn-dev - Development files for Apache Subversion libraries
 libsvn-doc - Developer documentation for libsvn
 libsvn-java - Java bindings for Apache Subversion
 libsvn-perl - Perl bindings for Apache Subversion
 libsvn1- Shared libraries used by Apache Subversion
 python-subversion - Python bindings for Apache Subversion
 ruby-svn   - Ruby