Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-19 Thread Jamie Zawinski
> According to upstream, this code is intended to handle errors in > async operations: gdk_x11_display_error_trap_pop_internal() uses > XNextRequest() to get a sequence number for the next X11 request, and > then _gdk_x11_display_error_event() treats sequence numbers between the > start sequence nu

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-19 Thread Jamie Zawinski
> I'm not an expert on the finer points of the X11 protocol, so I'm not sure > what this implies. Are you saying that this is (likely to be) the root > cause of the user-visible bug here (xscreensaver-settings not starting), Yes. GTK calls XSetInputFocus (for some unknown reason) and attempts to

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-19 Thread Tormod Volden
On Sun, Feb 19, 2023 at 5:22 PM Simon McVittie wrote: > It's not clear to me whether this is an xscreensaver issue or a GTK > issue, so for now I'm marking it to appear in both packages' bug pages. > If this is a GTK issue, then it's way outside my X11 knowledge, so someone > with a deeper understa

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-19 Thread Simon McVittie
Control: forwarded -1 https://gitlab.gnome.org/GNOME/gtk/-/issues/5607 Control: reassign -1 xscreensaver,libgtk-3-0 Control: found -1 xscreensaver/6.06+dfsg1-2 Control: found -1 libgtk-3-0/3.24.36-3 It's not clear to me whether this is an xscreensaver issue or a GTK issue, so for now I'm marking i

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-19 Thread Simon McVittie
On Wed, 08 Feb 2023 at 15:31:49 -0800, H. S. Teoh wrote: > Since upgrading to 6.06+dfsg1-2, I have been unable to run > xscreensaver-settings or xscreensaver-demo. On Fri, 10 Feb 2023 at 09:05:45 +0100, Tormod Volden wrote: > On Fri, Feb 10, 2023 at 8:54 AM Marco wrote: > > > Marco, which window m

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-19 Thread Tormod Volden
On Fri, Feb 10, 2023 at 9:58 PM Tormod Volden wrote: > > reassign 1030909 gtk+3.0 3.24.36-3 > affects 1030909 xscreensaver 6.06+dfsg1-2 > thanks > > OK, let's see if the gtk package maintainers can comment on this. I am afraid this is not reaching the attention of the gtk packagers or is not gett

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-12 Thread H. S. Teoh
On Fri, Feb 10, 2023 at 08:58:41AM +0100, Tormod Volden wrote: > On Fri, Feb 10, 2023 at 1:18 AM H. S. Teoh wrote: > > > xscreensaver-settings: 16:11:29: xscreensaver-gl-visual did not report a GL > > visual! > > Segmentation fault > > --snip--- > > > >

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-11 Thread Tormod Volden
For completeness, here is the backtrace at breakpoint on XSetInputFocus, on Debian unstable with debug symbols (before launching gdb, export DEBUGINFOD_URLS="https://debuginfod.debian.net"; ). (gdb) bt full #0 XSetInputFocus (dpy=0x555fda90, focus=focus@entry=41943047, revert_to=revert_to@ent

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-11 Thread Jamie Zawinski
You may want to report a second bug against GTK, that calling XSynchronize (dpy, True) does not work -- it appears that GTK or GDK are setting that to false at some time later. Proof: Add this to, e.g., update_subproc_timer and run with --debug: XSetWindowBackgroundPixmap (s->dpy, 0, 0); A sec

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Tormod Volden
reassign 1030909 gtk+3.0 3.24.36-3 affects 1030909 xscreensaver 6.06+dfsg1-2 thanks OK, let's see if the gtk package maintainers can comment on this.

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Jamie Zawinski
I meant to say: 1: every call to *XSetErrorHandler* has XSync before it, or 2: every *non-blocking* X11 call inside gdk_x11_display_error_trap_push has XSync before it.

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Jamie Zawinski
See also https://github.com/mirror/libX11/blob/master/src/ErrHndlr.c#L38 -- Jamie Zawinski • jwz.org • dnalounge.com

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Jamie Zawinski
On Feb 10, 2023, at 5:29 AM, Tormod Volden wrote: > > Here is the code around that XSetInputFocus(): > https://salsa.debian.org/gnome-team/gtk3/-/blob/debian/master/gdk/x11/gdkdisplay-x11.c#L1473 Tl;dr -- it looks like GDK is attempting to call XSetInputFocus and ignore errors from it, but it i

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Tormod Volden
Here is the code around that XSetInputFocus(): https://salsa.debian.org/gnome-team/gtk3/-/blob/debian/master/gdk/x11/gdkdisplay-x11.c#L1473

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Tormod Volden
And this is the XSetInputFocus call sending the offending request (on the same system). (gdb) bt #0 0x76cfb350 in XSetInputFocus () at /lib/x86_64-linux-gnu/libX11.so.6 #1 0x77eec2c1 in _gdk_wm_protocols_filter (xev=0x7fffd8e0, event=, data=) at ../../../../../gdk/x11/gdkdisp

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Tormod Volden
> FWIW, there is a GDK_SYNCHRONIZE environment variable that makes GDK > call XSynchronize some places. This the X error backtrace with GDK_SYNCHRONIZE set. Note this is not on Debian unstable and I couldn't install libX11 debug symbols. (gdb) bt #0 x_error (dpy=0x77e56460, error=0x7fffd

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Tormod Volden
> > You'll need to run with -sync for backtraces of X errors to make any sense. > > (Seeing XInternAtom in the stack is always an indication that the backtrace > > is bogus.) > > I have indeed tried -sync and --sync but it is not recognized by > xscreensaver-settings. How do I enable it? FWIW, t

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Jamie Zawinski
On Feb 10, 2023, at 1:50 AM, Tormod Volden wrote: > > Wait, this was different: What is the X error if you let that continue? -- Jamie Zawinski • jwz.org • dnalounge.com

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Jamie Zawinski
> Neither of those changed the backtrace. Hmm. Try setting breakpoints in xscreensaver_app_new, xscreensaver_app_class_init, xscreensaver_app_open, xscreensaver_app_activate, xscreensaver_app_startup, xscreensaver_dialog_init, and xscreensaver_dialog_realize and let's see whether any of those a

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Tormod Volden
Wait, this was different: (gdb) bt full #0 x_error (dpy=0x77e56460, error=0x7fffd610) at demo-Gtk.c:4253 #1 0x76d03734 in _XError () at /lib/x86_64-linux-gnu/libX11.so.6 #2 0x76d00107 in () at /lib/x86_64-linux-gnu/libX11.so.6 #3 0x76d001a5 in () at /lib/x86_6

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Tormod Volden
On Fri, Feb 10, 2023 at 10:29 AM Jamie Zawinski wrote: > > Ugh. Try adding XSynchronize (s->dpy, True); to xscreensaver_window_realize > around line 4958, just after s->dpy = gdk_x11_get_default_xdisplay(); > > It's possible that that won't be early enough to catch it... If not, maybe > this in x

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Jamie Zawinski
Ugh. Try adding XSynchronize (s->dpy, True); to xscreensaver_window_realize around line 4958, just after s->dpy = gdk_x11_get_default_xdisplay(); It's possible that that won't be early enough to catch it... If not, maybe this in xscreensaver_window_init -- XSynchronize (gdk_x11_get_default_xdis

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Jamie Zawinski
You'll need to run with -sync for backtraces of X errors to make any sense. (Seeing XInternAtom in the stack is always an indication that the backtrace is bogus.) xscreensaver-settings doesn't do anything with focus, though, so this is still confusing. -- Jamie Zawinski • jwz.org • dnalounge

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Tormod Volden
On Fri, Feb 10, 2023 at 10:08 AM Jamie Zawinski wrote: > > You'll need to run with -sync for backtraces of X errors to make any sense. > (Seeing XInternAtom in the stack is always an indication that the backtrace > is bogus.) I have indeed tried -sync and --sync but it is not recognized by xscre

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Tormod Volden
On Fri, Feb 10, 2023 at 9:10 AM Marco wrote: > > What is the difference in the behaviour of the according to X? > Is it a fault of mwm or XScreensaver? I think XScreensaver must wait and ensure the windows is mapped and viewable before sending the X_SetInputFocus request to it. Whether the fix sho

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Marco
Am 10.02.2023 schrieb Tormod Volden : > On Fri, Feb 10, 2023 at 8:54 AM Marco wrote: > > > Marco, which window manager are you using? > > > > mwm (motif window manager), on both machines. > > I can reproduce the issue after installing mwm. (Normally I use the > Marco window manager :) ) What

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Tormod Volden
On Fri, Feb 10, 2023 at 8:54 AM Marco wrote: > > Marco, which window manager are you using? > > mwm (motif window manager), on both machines. I can reproduce the issue after installing mwm. (Normally I use the Marco window manager :) ) Tormod

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-10 Thread Tormod Volden
On Fri, Feb 10, 2023 at 1:18 AM H. S. Teoh wrote: > xscreensaver-settings: 16:11:29: xscreensaver-gl-visual did not report a GL > visual! > Segmentation fault > --snip--- > > Apparently there *is* a segfault, even though it doesn't appear that way > whe

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-09 Thread Marco
Am 09.02.2023 schrieb Tormod Volden : > From searching about failing X_SetInputFocus requests, one common > cause is that the window hasn't been mapped by the window manager yet. > I notice that Teoh is using the ratpoison window manager. > > Marco, which window manager are you using? mwm (motif

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-09 Thread H. S. Teoh
On Thu, Feb 09, 2023 at 11:16:15AM +0100, Tormod Volden wrote: > On Thu, Feb 9, 2023 at 10:20 AM Tormod Volden wrote: > > Would it be possible for you to build the upstream sources, without > > optimization, and try it out? You shouldn't need to install any of > > it, just run driver/xscreensaver-s

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-09 Thread H. S. Teoh
On Thu, Feb 09, 2023 at 08:57:22PM +0100, Tormod Volden wrote: > > Since upgrading to 6.06+dfsg1-2, I have been unable to run > > xscreensaver-settings or xscreensaver-demo. The main xscreensaver > > >From which version did you upgrade? 5.45+dfsg1-2 T -- Written on the window of a clothing s

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-09 Thread Tormod Volden
>From searching about failing X_SetInputFocus requests, one common cause is that the window hasn't been mapped by the window manager yet. I notice that Teoh is using the ratpoison window manager. Marco, which window manager are you using?

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-09 Thread Tormod Volden
On Thu, Feb 9, 2023 at 10:20 AM Tormod Volden wrote: > Would it be possible for you to build the upstream sources, without > optimization, and try it out? You shouldn't need to install any of it, > just run driver/xscreensaver-settings --debug from the build tree. And > also rename your ~/.xscreens

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-09 Thread Tormod Volden
Hi, thanks for your report. Thanks also for checking for similar existing bugs. I believe it is the same issue as in #1030659 but for now it is better to track the reports separately. I was thinking that if it was a real issue there must be more reports coming. I am not able to reproduce this mysel

Bug#1030909: Unable to run xscreensaver-demo or xscreensaver-settings

2023-02-08 Thread H. S. Teoh
Package: xscreensaver Version: 6.06+dfsg1-2 Severity: important Since upgrading to 6.06+dfsg1-2, I have been unable to run xscreensaver-settings or xscreensaver-demo. The main xscreensaver binary still runs and works correctly; however, I can no longer configure which screensavers show up except