Michael Banck [EMAIL PROTECTED] writes:
On Tue, Mar 28, 2006 at 08:55:14PM +0100, Roger Leigh wrote:
+$main::force_build_source = 0;
If I understand correctly, that configure value determines whether the
.orig.tar.gz tarball will be included in the source package, *if* a
source package is
On Wed, Mar 29, 2006 at 09:27:14AM +0100, Roger Leigh wrote:
Michael Banck [EMAIL PROTECTED] writes:
This is only cosmetic if users don't get in contact with it, but as far
as I can tell, you could add this to you ~/.sbuildrc in order to make
sure -sa is passed to dpkg-source always? In
Michael Banck wrote:
Is there a use-case for this (always including the .orig when telling
sbuild to build source as well, no matter what revision)?
Yes, the use case I have is that we are created a derived distribution
from Debian. The first revision of the package that we put into our
Matt Brown [EMAIL PROTECTED] writes:
Michael Banck wrote:
If so, it should maybe be made an official config option perhaps.
This is clearly not useful for buildds (at least the official
ones), so this is our decision I guess.
Whether that option is on the command line or in the
On Wed, Mar 29, 2006 at 01:01:12PM +0100, Roger Leigh wrote:
The attached patch makes this a config option as well. Is this OK to
apply?
Looks good to me.
thanks,
Michael
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Are there any objections to applying the last patch?
http://bugs.debian.org/cgi-bin/bugreport.cgi/sbuild-include-source.diff?bug=318030;msg=55;att=1
For consistency with the other sbuild options, I think --force-source
or --force-orig-source would be better than the proposed
The attached patch is a slightly modified and tested version of Matt's
patch from 2005-07-13. This adds a --force-orig-source option.
Is this OK, or are there any further changes needed?
Regards,
Roger
--
Roger Leigh
Printing on GNU/Linux? http://gutenprint.sourceforge.net/
Roger Leigh wrote:
Are there any objections to applying the last patch?
http://bugs.debian.org/cgi-bin/bugreport.cgi/sbuild-include-source.diff?bug=318030;msg=55;att=1
It is fine with me.
It would have been nice if you kept the patch small and contained to the
source build change rather
tags 318030 + fixed-upstream pending
thanks
Matt Brown [EMAIL PROTECTED] writes:
Roger Leigh wrote:
Are there any objections to applying the last patch?
http://bugs.debian.org/cgi-bin/bugreport.cgi/sbuild-include-source.diff?bug=318030;msg=55;att=1
It is fine with me.
Super, thanks for
Roger Leigh wrote:
Super, thanks for the quick response. I did change the option to
--force-orig-source; is this OK with you?
Yes, I'd much rather have the option available than worry about what it
is called.
This will be available with the next upload, unless you would like
anything
On Tue, Mar 28, 2006 at 08:55:14PM +0100, Roger Leigh wrote:
+$main::force_build_source = 0;
If I understand correctly, that configure value determines whether the
.orig.tar.gz tarball will be included in the source package, *if* a
source package is built.
If so, I think this variable is badly
On Wed, Jul 13, 2005 at 11:51:50AM +1200, Matt Brown wrote:
When run with the -s option sbuild does not pass the -sa option to
dpkg-buildpackage. This results in the .orig.tar.gz file not being
included in the upload.
Well, only for revisions 1, right? At least, this is the case here.
Which
On Wed, 2005-07-13 at 14:01 +0200, Michael Banck wrote:
Well, only for revisions 1, right? At least, this is the case here.
Which is what I would expect. Or maybe I misunderstood your concern.
It is expected behaviour for a standard build, but not expected
behaviour for a include full
On Thu, Jul 14, 2005 at 12:59:37AM +1200, Matt Brown wrote:
On Wed, 2005-07-13 at 14:01 +0200, Michael Banck wrote:
Well, only for revisions 1, right? At least, this is the case here.
Which is what I would expect. Or maybe I misunderstood your concern.
It is expected behaviour for a
On Thu, Jul 14, 2005 at 12:59:37AM +1200, Matt Brown wrote:
On Wed, 2005-07-13 at 14:01 +0200, Michael Banck wrote:
Well, only for revisions 1, right? At least, this is the case here.
Which is what I would expect. Or maybe I misunderstood your concern.
It is expected behaviour for a
On Wed, Jul 13, 2005 at 03:27:47PM +0200, Michael Banck wrote:
I guess having (another, *sigh*) configuration option here would be
feasable, but I maintain the default should stay as it is. Feel free to
send a patch for that.
Maybe the others have a different opinion on this.
Oh well,
On Wed, Jul 13, 2005 at 03:41:00PM +0200, Francesco P. Lovergine wrote:
I would instead add one more dpkg-buildpackage related option
configuration var for that, such as --force-original and
$force_original = 1.
Let's keep the current default, ok?
Also, mabye $force_orig maybe better, I
On Wed, Jul 13, 2005 at 04:06:22PM +0200, Michael Banck wrote:
On Wed, Jul 13, 2005 at 03:41:00PM +0200, Francesco P. Lovergine wrote:
I would instead add one more dpkg-buildpackage related option
configuration var for that, such as --force-original and
$force_original = 1.
Let's keep
On Wed, 2005-07-13 at 15:27 +0200, Michael Banck wrote:
Where do you have that quote include full source build from? In the
manpage I have, it is:
-s,--source
Also build source package, i.e. use dpkg-buildpackage
without -B. This also switches on
On Thu, Jul 14, 2005 at 08:54:14AM +1200, Matt Brown wrote:
OK. I'm happy to do this if the patch has a chance of being accepted.
It definetely would.
Would -S be an acceptable choice for this option with a description
along the lines of force build of full source package.
-S is used be
On Wed, 2005-07-13 at 23:24 +0200, Michael Banck wrote:
-S is used be dpkg-buildpackage to do just what we have now: Include the
.orig.tar.gz when necessary, so I think it would be bad to use that.
We suggested --force-source-orig, maybe --include-source-orig would be
alright as well
Package: sbuild
Version: 0.35
Severity: normal
Tags: patch
When run with the -s option sbuild does not pass the -sa option to
dpkg-buildpackage. This results in the .orig.tar.gz file not being
included in the upload. From my understanding of the intent of -s this
is incorrect. -s is intented to
22 matches
Mail list logo
