Bug#353169: libupnp: Fixed length buffer for UPNP Action URLs breaks applications

2008-06-19 Thread Nick Leverton
My port of the patch to 1.6 proved buggy (causing bug #482737) so I've unapplied it, though it's still in the source package. libupnp3 version 1.6.6-1 is in the NEW queue now. Nick -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#353169: libupnp: Fixed length buffer for UPNP Action URLs breaks applications

2008-04-10 Thread Marcelo Jimenez
Hi, I am one of the maintainers of upstream libupnp. My remarks on this discussion: - You seem to be using a quite old version of the library, probably pre-1.4.x code, 1.2.x I would say. - libupnp is not C++, it is plain C, so the patch is correct in the use of malloc/free instead of

Bug#353169: libupnp: Fixed length buffer for UPNP Action URLs breaks applications

2008-04-04 Thread Arthur Taylor
Hi Nick, Thanks for getting back. We used that patch here for a while so it was sound against v1.2.1, but we have since embarked on a rewrite (because that seemed easier than trying to weed out all the fixed-length buffers and possible other liabilities). The rewrite is in a different

Bug#353169: libupnp: Fixed length buffer for UPNP Action URLs breaks applications

2008-04-03 Thread Nick Leverton
Thanks for the patch, Arthur, and sorry you had to wait so long. As new maintainer of libupnp I'm currently updating your patch to apply to pupnp 1.6.5. This being a C++ package, ideally I'd have liked to see a fix which made use of new/delete and object destructors to release memory, rather

Bug#353169: libupnp: Fixed length buffer for UPNP Action URLs breaks applications

2006-02-19 Thread Steve McIntyre
On Fri, Feb 17, 2006 at 01:11:20PM +, Arthur Taylor wrote: Please find attached a patch which goes some way to fixing this issue. I've only tested it in my current configuration, so I don't know how this impacts the webserver. I've had to introduce two new functions to free structures that

Bug#353169: libupnp: Fixed length buffer for UPNP Action URLs breaks applications

2006-02-17 Thread Arthur Taylor
Please find attached a patch which goes some way to fixing this issue. I've only tested it in my current configuration, so I don't know how this impacts the webserver. I've had to introduce two new functions to free structures that may be returned by the framework. Not sure how necessary they

Bug#353169: libupnp: Fixed length buffer for UPNP Action URLs breaks applications

2006-02-16 Thread Arthur Taylor
Package: libupnp Severity: important When using the UpnpSendActionAsync method (and possibly other Async methods), the SDK stores the URL for the action in a struct UpnpNonblockParam. This has a fixed length array for storing the action URL of 100 characters. Some UPNP servers routinely generate