Bug#643960: Broken log rotation

2011-12-22 Thread Richard Kettlewell
On 01/10/2011 09:24, Richard Kettlewell wrote: Package: inn2 Version: 2.5.2+20110413-1+b1 I have the following in my news.daily report: /usr/lib/news/bin/scanlogs: line 135: /var/log/news/news.crit: Permission denied /usr/lib/news/bin/scanlogs: line 135: /var/log/news/news.err: Permission

Bug#643960: Broken log rotation

2011-10-02 Thread Julien ÉLIE
Hi Russ, In the Debian package, would it be possible to use norotate as argument for news.daily (in sample inn2 crontab) and provide a logrotate entry for standard Debian logrotate program? I do not think so, since the two actions need to be coordinated. Could news.daily do its analysis on

Bug#643960: Broken log rotation

2011-10-02 Thread Russ Allbery
Julien ÉLIE jul...@trigofacile.com writes: I have not thoroughly looked at the code but I do not see why news.daily/scanlogs could not use .0 versions. Yet, are we sure that logrotate will always generate these files? (If a user changes the configuration of logrotate, it could break log

Bug#643960: Broken log rotation

2011-10-02 Thread Marco d'Itri
On Oct 02, Russ Allbery r...@debian.org wrote: assumptions about log rotation and go with that. As long as there's a comment somewhere in the inn2 configuration file telling people what to do if they want to change it, I think this is okay. The problem is that somebody may change the

Bug#643960: Broken log rotation

2011-10-02 Thread Julien ÉLIE
Hi Marco, assumptions about log rotation and go with that. As long as there's a comment somewhere in the inn2 configuration file telling people what to do if they want to change it, I think this is okay. The problem is that somebody may change the logrotate configuration (e.g. moving it after

Bug#643960: Broken log rotation

2011-10-01 Thread Richard Kettlewell
Package: inn2 Version: 2.5.2+20110413-1+b1 I have the following in my news.daily report: /usr/lib/news/bin/scanlogs: line 135: /var/log/news/news.crit: Permission denied /usr/lib/news/bin/scanlogs: line 135: /var/log/news/news.err: Permission denied /usr/lib/news/bin/scanlogs: line 135:

Bug#643960: Broken log rotation

2011-10-01 Thread Marco d'Itri
On Oct 01, Richard Kettlewell r...@greenend.org.uk wrote: -rw-r--r-- 1 syslog adm 0 May 15 04:15 /var/log/news/news.crit -rw-r--r-- 1 syslog adm1059 Aug 20 13:20 /var/log/news/news.err -rw-r--r-- 1 syslog adm 6399076 Oct 1 09:10 /var/log/news/news.notice This is enforced by the

Bug#643960: Broken log rotation

2011-10-01 Thread Julien ÉLIE
Hi Marco and Richard, This would be broken even if the cat didn't fail due to the file permissions - if a message is logged after the copy but before the cat then it will be lost. Better would be to rename the file aside, create a new one and signal syslogd to make it re-open it - except that

Bug#643960: Broken log rotation

2011-10-01 Thread Richard Kettlewell
On 01/10/2011 09:30, Marco d'Itri wrote: On Oct 01, Richard Kettlewellr...@greenend.org.uk wrote: -rw-r--r-- 1 syslog adm 0 May 15 04:15 /var/log/news/news.crit -rw-r--r-- 1 syslog adm1059 Aug 20 13:20 /var/log/news/news.err -rw-r--r-- 1 syslog adm 6399076 Oct 1 09:10

Bug#643960: Broken log rotation

2011-10-01 Thread Marco d'Itri
On Oct 01, Julien ÉLIE jul...@trigofacile.com wrote: In the Debian package, would it be possible to use norotate as argument for news.daily (in sample inn2 crontab) and provide a logrotate entry for standard Debian logrotate program? I do not think so, since the two actions need to be

Bug#643960: Broken log rotation

2011-10-01 Thread Russ Allbery
m...@linux.it (Marco d'Itri) writes: On Oct 01, Julien ÉLIE jul...@trigofacile.com wrote: In the Debian package, would it be possible to use norotate as argument for news.daily (in sample inn2 crontab) and provide a logrotate entry for standard Debian logrotate program? I do not think so,