X-Debbugs-Cc: eddy.petri...@gmail.com
Package: laptop-mode-tools
Version: 1.61-2
Followup-For: Bug #673818
I was looking over the fix for this bug, but it seems to me the fix changes the
behaviour of laptop-mode.
Previously the /usr/sbin/laptop_mode script looked for files with the .conf
package laptop-mode-tools
tags 673818 patch
thanks
Sorry, I quoted an incomplete patch. Correct patch attached.
BTW, there is an inconsistent usage of tabs and spaces for indentation
in the script, you might want to fix that, too.
2013/8/11 Eddy Petrișor eddy.petri...@gmail.com:
X-Debbugs-Cc:
On Sunday 11 August 2013 03:04 PM, Eddy Petrișor wrote:
--- laptop_mode.sid 2013-08-11 12:30:23.0 +0300
+++ laptop_mode 2013-08-11 12:28:10.0 +0300
@@ -234,7 +234,7 @@
test -d /etc/laptop-mode/conf.d/board-specific
CONF_DIR=$CONF_DIR
2013/8/11 Ritesh Raj Sarraf r...@researchut.com:
This is already fixes in my upstream branch. It will be part of the next
release.
BTW, won't just *.conf solve the problem.
Yes, I realised just after sending the mail I quoted the wrong patch. I
sent the correct patch in a follow up email:
On Sunday 11 August 2013 05:37 PM, Eddy Petrișor wrote:
The fix in the repo still has the original problem, because if the
/etc/laptop-mode/conf.d or /etc/laptop-mode/conf.d/board-specific
directories exists, but contains no .conf files, the script will
generate the ugly warning initially
2013/8/11 Ritesh Raj Sarraf r...@researchut.com
On Sunday 11 August 2013 05:37 PM, Eddy Petrișor wrote:
The fix in the repo still has the original problem, because if the
/etc/laptop-mode/conf.d or /etc/laptop-mode/conf.d/board-specific
directories exists, but contains no .conf files, the
On Sunday 11 August 2013 06:25 PM, Eddy Petrișor wrote:
You failed to reproduce the else branch in your test. The attached
test script displays the issue:
heidi:/home/eddy/usr/src/bugs/673818# mkdir
/etc/laptop-mode/conf.d/board-specific
heidi:/home/eddy/usr/src/bugs/673818# ls
7 matches
Mail list logo
