Bug#693817: Bugs in GooString::insert() leading to unterminated strings

2012-11-27 Thread Wolfram Gloger
Pino Toscano p...@debian.org writes: The char variant is perfectly fine. Um, yes. I noticed 5 minutes after submitting. Just a case of defensive programming on my side. No change required here. The loop in the char* version was wrong though, as you also noticed, but I proposed a better

Bug#693817: Bugs in GooString::insert() leading to unterminated strings

2012-11-27 Thread Pino Toscano
Hi, Alle martedì 27 novembre 2012, Wolfram Gloger ha scritto: The loop in the char* version was wrong though, as you also noticed, but I proposed a better fix upstream, and it was integrated. + resize(length + lengthA); +- for (j = prevLen; j = i; --j) +-s[j+lengthA] = s[j]; ++

Bug#693817: Bugs in GooString::insert() leading to unterminated strings

2012-11-26 Thread Pino Toscano
Hi, thanks for your report. Alle martedì 20 novembre 2012, Wolfram Gloger ha scritto: GooString::insert(int i, char c) GooString::insert(int i, const char* s) as exported by libpoppler are both buggy. They both cause the resulting strings to be not properly 0-terminated, breaking

Bug#693817: Bugs in GooString::insert() leading to unterminated strings

2012-11-20 Thread Wolfram Gloger
Package: poppler Version: 0.20.5-1 Severity: important Tags: patch GooString::insert(int i, char c) GooString::insert(int i, const char* s) as exported by libpoppler are both buggy. They both cause the resulting strings to be not properly 0-terminated, breaking GooString::getCString(). This