Bug#828833: python3-magic: magic file type double encoded

2016-06-29 Thread Orestis Ioannou
Hey So i took some time to investigate this. Here are my findings: On Wed, 29 Jun 2016 14:09:05 +0200 Christoph Biedl wrote: > Orestis Ioannou wrote... > > > So many tests failed with this stacktrace http://paste.debian.net/770211/ > > What I'd really like to

Bug#828833: python3-magic: magic file type double encoded

2016-06-29 Thread Christoph Biedl
Orestis Ioannou wrote... > So many tests failed with this stacktrace http://paste.debian.net/770211/ What I'd really like to see is the actual code and the circumstances that triggered the stacktrace, probably a certain file. Still I failed to create that, and this is important to fix the issue.

Bug#828833: python3-magic: magic file type double encoded

2016-06-29 Thread Christoph Biedl
Mattia Rizzolo wrote... > Can I ask you to quickly upload the fix as soon as there is a working > py2/py3 patch? Will do as soon as I'm confident there's a fix that does not create new hazzle, read: I still wasn't able to reproduce the original regression when using python2 (PR/511). As there's

Bug#828833: python3-magic: magic file type double encoded

2016-06-29 Thread Orestis Ioannou
On Wed, 29 Jun 2016 01:28:29 +0200 Christoph Biedl wrote: > > > The reason i proposed the patch was that the testsuit of Debsources > > (www.sources.debian.net) was reaching the str(r, 'utf-8'). Here's a log > > of the incident

Bug#828833: python3-magic: magic file type double encoded

2016-06-28 Thread Mattia Rizzolo
Hi Christoph, On Tue, Jun 28, 2016 at 11:28:30PM +0200, Christoph Biedl wrote: > > It looks like upstream just commited the same fix: > > https://github.com/file/file/commit/73e043d2a986234b187a00ed0c8d1f7bf83df372 > > Great. I'll collect some more stuff that needs attention, shouldn't > take

Bug#828833: python3-magic: magic file type double encoded

2016-06-28 Thread Christoph Biedl
Iago wrote... > The reason i proposed the patch was that the testsuit of Debsources > (www.sources.debian.net) was reaching the str(r, 'utf-8'). Here's a log > of the incident https://travis-ci.org/Debian/debsources/builds/102972221 Can you reduce that to a reproducer? Also, travis-ci is down

Bug#828833: python3-magic: magic file type double encoded

2016-06-28 Thread Iago
Hello, Thanks for including me in the loop On Tue, 28 Jun 2016 19:48:08 +0200 Reiner Herrmann wrote: > On Tue, Jun 28, 2016 at 11:42:35AM +0200, Christoph Biedl wrote: > > Still, even after applying your patch a test script works when > > using python2.7, and now I'm

Bug#828833: python3-magic: magic file type double encoded

2016-06-28 Thread Christoph Biedl
tags 828833 pending thanks Reiner Herrmann wrote... > It looks like upstream just commited the same fix: > https://github.com/file/file/commit/73e043d2a986234b187a00ed0c8d1f7bf83df372 Great. I'll collect some more stuff that needs attention, shouldn't take longer than a few days. Christoph

Bug#828833: python3-magic: magic file type double encoded

2016-06-28 Thread Reiner Herrmann
On Tue, Jun 28, 2016 at 11:42:35AM +0200, Christoph Biedl wrote: > Still, even after applying your patch a test script works when > using python2.7, and now I'm confused. Since my python knowledge is > rather limited, could you please check for both versions, too - and > perhaps shed some light on

Bug#828833: python3-magic: magic file type double encoded

2016-06-28 Thread Reiner Herrmann
[ adding Orestis to CC, who submitted the patch in file's #511 ] On Tue, Jun 28, 2016 at 11:42:35AM +0200, Christoph Biedl wrote: > > since python3-magic 1:5.28-1 the file type detection is broken. > > Instead of returning a string whih contains the magic, it returns > > double encoded bytes: >

Bug#828833: python3-magic: magic file type double encoded

2016-06-28 Thread Christoph Biedl
tags 828833 confirmed thanks Reiner Herrmann wrote... > since python3-magic 1:5.28-1 the file type detection is broken. > Instead of returning a string whih contains the magic, it returns > double encoded bytes: (...) > b"b'gzip compressed data, max compression, from Unix'" Thanks for catching,

Bug#828833: python3-magic: magic file type double encoded

2016-06-28 Thread Reiner Herrmann
Package: python3-magic Version: 1:5.28-1 Hi, since python3-magic 1:5.28-1 the file type detection is broken. Instead of returning a string whih contains the magic, it returns double encoded bytes: >>> import magic >>> path = "/usr/share/doc/gdb/refcard.ps.gz" >>> x = magic.open(magic.NONE) >>>