Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2017-01-03 Thread Christian Ehrhardt
On Wed, Dec 21, 2016 at 11:22 AM, Yves-Alexis Perez wrote: > > b7754fe changelog: d/rules: Make override_dh_strip a nop > > I don't think this one is ok. Stripping the binaries is a Debian Policy > *should*. > > > > The (to be enabled in a later commit in this series) plugin >

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2017-01-03 Thread Christian Ehrhardt
On Wed, Dec 21, 2016 at 11:29 AM, Yves-Alexis Perez wrote: > We did enable REDUCED_KEYLENGTH at one point on !linux and !x86, but it > still > wasn't enough, so we completely disabled the test suite on !x86. I'd rather > not disable more of the test suite, to be honest. >

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-21 Thread Yves-Alexis Perez
On Wed, 2016-12-21 at 10:34 +0100, Christian Ehrhardt wrote: > Commits: > 514dc31 * Add updated logcheck rules to match recent strongswan output > ab32a3f changelog: Add updated logcheck rules to match recent strongswan > output Thanks, applied. Regards, -- Yves-Alexis signature.asc

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-21 Thread Yves-Alexis Perez
On Wed, 2016-12-21 at 10:33 +0100, Christian Ehrhardt wrote: > Commits: > 6bf2bf5 * Add basic DEP8 tests > 6f408a9 changelog: Add basic DEP8 tests > > As basic CI dep8 based autopkgtests provide a very useful level of automated > sanity checks to become part of debci at https://ci.debian.net/. >

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-21 Thread Yves-Alexis Perez
On Wed, 2016-12-21 at 10:33 +0100, Christian Ehrhardt wrote: > Commits: > 59e9a0b * add and install apparmor profiles > 3d124a4 changelog: Add and install strongswan apparmor profiles > > Make the usage of strongswan even more secure by providing an apparmor > profile > for it. Thanks! I've

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-21 Thread Yves-Alexis Perez
On Wed, 2016-12-21 at 10:32 +0100, Christian Ehrhardt wrote: > Background to explain the reasoning behind the change 3/7: > > Commits: > 0af16a2 * d/rules: Set minimal TESTS_REDUCED_KEYLENGTHS > e024f7e changelog: d/rules: Set minimal TESTS_REDUCED_KEYLENGTHS to avoid > hanging builds > > There

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-21 Thread Yves-Alexis Perez
On Wed, 2016-12-21 at 10:32 +0100, Christian Ehrhardt wrote: > Background to explain the reasoning behind the change 2/7: > > Commits: > 944a3c7 * d/rules: Make override_dh_strip a nop. > b7754fe changelog: d/rules: Make override_dh_strip a nop I don't think this one is ok. Stripping the

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-21 Thread Yves-Alexis Perez
On Wed, 2016-12-21 at 10:32 +0100, Christian Ehrhardt wrote: > Commits: > 0733afe * d/rules: Reorganize to ease maintenance > be360c3 changelog: d/rules: Reorganize to ease maintenance > 45adecc * d/control: Wrap and sort to ease maintenance > 00bcdba changelog: d/control: Wrap and sort to ease

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-21 Thread Christian Ehrhardt
Background to explain the reasoning behind the change 7/7: Commits: 0271917 * Enable more features to to cover more use-cases bd04b06 changelog: Enable more features to to cover more use-cases Note: Many of those changes are so correlated that this is a one big change for now. If needed and ok

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-21 Thread Christian Ehrhardt
Background to explain the reasoning behind the change 5/7: Commits: 6bf2bf5 * Add basic DEP8 tests 6f408a9 changelog: Add basic DEP8 tests As basic CI dep8 based autopkgtests provide a very useful level of automated sanity checks to become part of debci at https://ci.debian.net/. See

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-21 Thread Christian Ehrhardt
Background to explain the reasoning behind the change 6/7: Commits: 514dc31 * Add updated logcheck rules to match recent strongswan output ab32a3f changelog: Add updated logcheck rules to match recent strongswan output When using logcheck with strongswan as of today there are a lot of unknown

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-21 Thread Christian Ehrhardt
I hope that these more detailed explanations help to clarify the reasoning. I'm likely away for the rest of the Year soon, but please let me know what might still be missing (or on what particular point you'd like to discuss some bits). I really want to work with you to get us in sync as much as

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-21 Thread Christian Ehrhardt
Background to explain the reasoning behind the change 4/7: Commits: 59e9a0b * add and install apparmor profiles 3d124a4 changelog: Add and install strongswan apparmor profiles Make the usage of strongswan even more secure by providing an apparmor profile for it. This change add the necessary

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-21 Thread Christian Ehrhardt
Background to explain the reasoning behind the change 3/7: Commits: 0af16a2 * d/rules: Set minimal TESTS_REDUCED_KEYLENGTHS e024f7e changelog: d/rules: Set minimal TESTS_REDUCED_KEYLENGTHS to avoid hanging builds There were several cases where low entropy build environments stalled. This was up

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-21 Thread Christian Ehrhardt
Background to explain the reasoning behind the change 2/7: Commits: 944a3c7 * d/rules: Make override_dh_strip a nop. b7754fe changelog: d/rules: Make override_dh_strip a nop The (to be enabled in a later commit in this series) plugin "integrity-test" provides a useful extra feature for the

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-21 Thread Christian Ehrhardt
Background to explain the reasoning behind the change 1/7: Commits: 0733afe * d/rules: Reorganize to ease maintenance be360c3 changelog: d/rules: Reorganize to ease maintenance 45adecc * d/control: Wrap and sort to ease maintenance 00bcdba changelog: d/control: Wrap and sort to ease maintenance

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-20 Thread Christian Ehrhardt
On Tue, Dec 20, 2016 at 5:21 PM, Yves-Alexis Perez wrote: > I hope it's clearer. Yeah that is good, I'll prep something and reply to this bug with mails one-by-one once I'm ready. I might update the branch I had linked if I happen to improve the changelog and or other

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-20 Thread Christian Ehrhardt
On Tue, Dec 20, 2016 at 4:32 PM, Yves-Alexis Perez wrote: > Thanks for the bug report. Could you document here the various changes you > make and justify somehow the reason? Some are a bit documented in the > changelog, but that's not the case for everything. > Hi, thank you

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-20 Thread Yves-Alexis Perez
On Tue, 2016-12-20 at 17:15 +0100, Christian Ehrhardt wrote: > #3 - something else > - I tried to group commits by topic, especially the mass enablement would > otherwise get issues as interim commits won't build correctly > - yet if you want me to split them up tell me and I'd try to do so. > -

Bug#848890: [Pkg-swan-devel] Bug#848890: Revisiting "Ubuntu strongSwan changes"

2016-12-20 Thread Yves-Alexis Perez
On Tue, 2016-12-20 at 16:14 +0100, Christian Ehrhardt wrote: > > If there are discussions please reply here and I hope we can hopefully sort > it out. Thanks for the bug report. Could you document here the various changes you make and justify somehow the reason? Some are a bit documented in the